In D46055#1050502, @jrm wrote:

In D46055#1050309, @rnagy wrote:

I'd rather much prefer third_party/nasm/BUILD.gn to be fixed.

I can rework the regex and restore patch-third__party_nasm_BUILD.gn, but it seems unnecessary. Could you elaborate on why it's still useful? We are testing for something with a certain answer because all our systems have supported mempcpy() since 13.1. Moreover, all our other bundled nasm (multimedia/ringrtc, devel/electron*, www/qt6-webengine) have now removed the patch. It would be nice to have all these ports consistent.

Also you are not adding HAVE_MEMPCPY , you are removing it.

The unpatched third_party/nasm/config/config-linux.h has #define HAVE_MEMPCPY 1. I'm removing a part of our patch that removed #define HAVE_MEMPCPY 1, i.e., restoring upstream's default of including #define HAVE_MEMPCPY 1.

I'd rather much prefer third_party/nasm/BUILD.gn to be fixed. Also you are not adding HAVE_MEMPCPY , you are removing it.