Page MenuHomeFreeBSD

rajfbsd_gmail.com (Rajesh Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2018, 8:57 AM (64 w, 6 d)

Recent Activity

Jul 9 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

Ok. I will create another review. Thanks for your time and immediate response.

Jul 9 2019, 1:33 PM
rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

Thanks @mav for reviewing and pushing the patch upstream. I verified it to work properly. I have some more minor changes to this Driver (basically to add support for another PCI Device ID). Shall I submit the additional patch here itself? or should I open another review for the same?

Jul 9 2019, 1:23 PM

Apr 15 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

Is there anything else needed here? or can this be taken upstream?

Apr 15 2019, 6:00 AM

Mar 11 2019

Herald added a reviewer for D18774: Add AMD NTB Hardware Driver for AMD SoC: Core Team.

@mav, Did you get a chance to look at this?

Mar 11 2019, 11:27 AM

Feb 25 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

@mav: Sorry to disturb you on this again. But, please have a look at this when you get a chance and let me know if there any comments to address here.

Feb 25 2019, 5:38 AM

Feb 18 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

@mav, Any more comments on this patch?

Feb 18 2019, 8:47 AM

Feb 11 2019

rajfbsd_gmail.com updated the diff for D18774: Add AMD NTB Hardware Driver for AMD SoC.

Made necessary changes as per the previous discussion. Attached V6 patch.

Feb 11 2019, 9:22 AM

Feb 8 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

@mav: I checked about that alignment requirements. Seems, the alignment should be on-par to the bar size (and not a fixed value) and the granularity range what I mentioned earlier for LUT based addressing (which is not implemented here). So, I need to change the alignment equal to the bar size. Do you have any comments on the previous discussed changes?

Feb 8 2019, 7:21 AM

Feb 5 2019

rajfbsd_gmail.com added inline comments to D18774: Add AMD NTB Hardware Driver for AMD SoC.
Feb 5 2019, 10:30 AM

Feb 4 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

No new patch attached, but looking for few clarification on your previous comments.

Feb 4 2019, 12:34 PM

Feb 1 2019

rajfbsd_gmail.com updated the diff for D18774: Add AMD NTB Hardware Driver for AMD SoC.

Addressed comment from @mav regarding the alignment and explained the reason for those checks for xlat and limit registers.

Feb 1 2019, 1:54 PM
rajfbsd_gmail.com added inline comments to D18774: Add AMD NTB Hardware Driver for AMD SoC.
Feb 1 2019, 1:52 PM

Jan 29 2019

rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

Any more comments on this patch?

Jan 29 2019, 10:13 AM

Jan 23 2019

rajfbsd_gmail.com added inline comments to D18774: Add AMD NTB Hardware Driver for AMD SoC.
Jan 23 2019, 9:03 AM

Jan 21 2019

rajfbsd_gmail.com updated the diff for D18774: Add AMD NTB Hardware Driver for AMD SoC.

Submitting V4 patch, addressing comment from @imp

Jan 21 2019, 5:28 PM
rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.
In D18774#403351, @imp wrote:

I just made a pass through for anything that caught my eye, and found a couple. I have not reviewed it to see if it matches the hardware spec for what it's trying to control.

Jan 21 2019, 5:27 PM

Jan 18 2019

rajfbsd_gmail.com updated the diff for D18774: Add AMD NTB Hardware Driver for AMD SoC.

Addressed commented from @imp and @mav and submitted V3 patch. Also, added amd_ntb_mw_set_wc routine.

Jan 18 2019, 2:17 PM
rajfbsd_gmail.com added inline comments to D18774: Add AMD NTB Hardware Driver for AMD SoC.
Jan 18 2019, 2:16 PM

Jan 9 2019

rajfbsd_gmail.com updated the diff for D18774: Add AMD NTB Hardware Driver for AMD SoC.

V2 patch addressing the previous comments from cem.

Jan 9 2019, 2:28 PM
rajfbsd_gmail.com added a comment to D18774: Add AMD NTB Hardware Driver for AMD SoC.

Hi cem,

Jan 9 2019, 2:27 PM

Jan 7 2019

rajfbsd_gmail.com created D18774: Add AMD NTB Hardware Driver for AMD SoC.
Jan 7 2019, 4:46 PM

Nov 5 2018

rajfbsd_gmail.com added a comment to D17381: Backport of rs338074 for stable/11 branch.

Thanks Macy.

Nov 5 2018, 6:19 AM

Oct 30 2018

rajfbsd_gmail.com added a comment to D17381: Backport of rs338074 for stable/11 branch.

Hi Macy,

Oct 30 2018, 8:15 AM

Oct 22 2018

rajfbsd_gmail.com added a comment to D17381: Backport of rs338074 for stable/11 branch.

Hi Macy/Warner,

Oct 22 2018, 10:44 AM

Oct 16 2018

rajfbsd_gmail.com updated the diff for D17381: Backport of rs338074 for stable/11 branch.

make tinderbox reported some failure with arm architecture. Fixed that.

Oct 16 2018, 3:56 AM

Oct 13 2018

rajfbsd_gmail.com updated the diff for D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Oleksandr,

Oct 13 2018, 6:25 PM

Oct 8 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Sorry for delays with answers

To be honest, the current code freeze seems quite... flexible. As in, there's certainly some new stuff coming in, and from my understanding adding a new driver (as opposed to modifying something that's already there) is rather unlikely to break something. Maybe just send an email to re@ and see what they say?

Yes, and IMHO this flexibility is not a very good thing (speaking from personal experience as a part-time RE at $WORK). I don't want to submit more new feature changes to re@ that is strictly necessary and so far I can't find pro arguments for this driver. As far as I understand this driver is going to be used as a building block for other components that are going to use it either as a control method for peripherals or as an interrupt source. If I am wrong and there are readily available immediate use cases, for instance, AMD-based embedded platforms where GPIO can be used from the userland or AMD-based laptops where gpioctl can be used directly to enable certain functionality that is otherwise unavailable I'll bring the patch up to re@ for the consideration. Otherwise, I'd rather wait for the code thaw and submit it to -HEAD with further MFCs to -12 and -11, it will be available in 12.1 in a year or so.
Rajesh, if you're familiar with the solutions available on the market could you share such use cases so I could argue for the inclusion of the driver?
Thanks

Oct 8 2018, 5:13 PM
rajfbsd_gmail.com updated the diff for D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Oleksandr,

Oct 8 2018, 4:58 PM

Oct 2 2018

rajfbsd_gmail.com created D17381: Backport of rs338074 for stable/11 branch.
Oct 2 2018, 2:29 PM

Oct 1 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Oleksandr,

Oct 1 2018, 6:29 PM

Sep 21 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Olexsandr,

Sep 21 2018, 10:52 AM
rajfbsd_gmail.com updated the diff for D16865: Add ACPI GPIO Controller driver for AMD Platforms.
  1. Added the static keywords to those mentioned structures in H file, as the intent is code readability
  2. Cleared the unwanted whitespaces/tabs and followed style(9) format for indentation in both C and H file.
Sep 21 2018, 10:49 AM
rajfbsd_gmail.com added a comment to D17189: Enable sdhci ACPI driver for AMD eMMC 5.0 controller.

Hi Oleksandr,

Sep 21 2018, 7:07 AM

Sep 18 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Thanks for taking time to review the first patch and clarifying on the release process.

Sep 18 2018, 1:35 PM
rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Gonzo,

Sep 18 2018, 1:33 PM
rajfbsd_gmail.com updated the diff for D16865: Add ACPI GPIO Controller driver for AMD Platforms.
  1. Removed static keywords from pin grouping definitions in H file.
  2. Moved static struct "resource_spec" to C file.
  3. Removed unwanted static declaration of probe, attach and detach in H file.
  4. Removed redundant file in C file
Sep 18 2018, 1:28 PM

Sep 17 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Gonzo,

Sep 17 2018, 10:38 AM
rajfbsd_gmail.com created D17189: Enable sdhci ACPI driver for AMD eMMC 5.0 controller.
Sep 17 2018, 10:35 AM

Sep 3 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Thank you Gonzo.

Sep 3 2018, 1:21 PM

Aug 30 2018

rajfbsd_gmail.com added a comment to D16865: Add ACPI GPIO Controller driver for AMD Platforms.

Hi Gonzo, Did you get a chance to look at this?

Aug 30 2018, 2:17 PM

Aug 24 2018

rajfbsd_gmail.com added a reviewer for D16865: Add ACPI GPIO Controller driver for AMD Platforms: gonzo.
Aug 24 2018, 5:57 AM

Aug 23 2018

rajfbsd_gmail.com created D16865: Add ACPI GPIO Controller driver for AMD Platforms.
Aug 23 2018, 1:10 PM

Aug 15 2018

rajfbsd_gmail.com created D16720: Designware I2C: Fix IO Timeout issue with I2C controller in AMD platforms.
Aug 15 2018, 1:01 PM

Aug 11 2018

rajfbsd_gmail.com created D16670: Designware I2C: Add ACPI Device HID for AMD platforms.
Aug 11 2018, 9:06 AM

Jul 30 2018

rajfbsd_gmail.com added inline comments to D16432: Use ACPI to probe serial devices & workaround limitations in acpi support.
Jul 30 2018, 9:02 AM

Jul 25 2018

rajfbsd_gmail.com added inline comments to D16432: Use ACPI to probe serial devices & workaround limitations in acpi support.
Jul 25 2018, 1:07 PM