Page MenuHomeFreeBSD

pawel.biernacki-gmail.com (Paweł Biernacki)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2015, 9:11 PM (226 w, 7 h)

Recent Activity

Mar 17 2019

pawel.biernacki-gmail.com added a comment to D19488: Enhance IPv6 autoconf startup scripts.

I confirm that it works.

Mar 17 2019, 1:10 AM

Mar 16 2019

pawel.biernacki-gmail.com added a comment to D19488: Enhance IPv6 autoconf startup scripts.
% cat /etc/rc.conf
clear_tmp_enable="YES"
syslogd_flags="-ss"
sendmail_enable="NONE"
hostname="devel2"
ifconfig_vtnet0="DHCP"
sshd_enable="YES"
ntpd_enable="YES"
dumpdev="AUTO"
zfs_enable="YES"
Mar 16 2019, 4:10 PM
pawel.biernacki-gmail.com added a comment to D19488: Enhance IPv6 autoconf startup scripts.

This breaks ifconfig_DEFAULT="DHCP" somehow. It works with either SYNCDHCP or this commit reverted.

Mar 16 2019, 1:27 PM

Sep 25 2018

pawel.biernacki-gmail.com updated the diff for D17282: new syscall: __sysctlbyname.

Update diff with minor fixes.

Sep 25 2018, 1:43 PM
pawel.biernacki-gmail.com added inline comments to D17282: new syscall: __sysctlbyname.
Sep 25 2018, 1:41 PM

Sep 22 2018

pawel.biernacki-gmail.com updated the diff for D17282: new syscall: __sysctlbyname.
Sep 22 2018, 3:52 AM
pawel.biernacki-gmail.com created D17282: new syscall: __sysctlbyname.
Sep 22 2018, 3:43 AM

Dec 23 2017

pawel.biernacki-gmail.com updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Man: start a sentence from new line.

Dec 23 2017, 7:15 PM · tests
pawel.biernacki-gmail.com updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Add CAVEATS section to the man page to point out the rounding issue with too short buffers.

Dec 23 2017, 6:09 PM · tests
pawel.biernacki-gmail.com added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#284349, @kib wrote:

In one branch of the snprintf() use, we add divisor / 2 and remainder * 10, not remainder. Does this case need to be handled differently ?

Dec 23 2017, 6:07 PM · tests

Dec 22 2017

pawel.biernacki-gmail.com updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:37 PM · tests
pawel.biernacki-gmail.com updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:30 PM · tests
pawel.biernacki-gmail.com updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:08 PM · tests

Dec 21 2017

pawel.biernacki-gmail.com added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Dec 21 2017, 10:07 PM · tests
pawel.biernacki-gmail.com updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Address @cem comments about style(9).

Dec 21 2017, 10:06 PM · tests
pawel.biernacki-gmail.com added a reviewer for D13578: humanize_number(3): fix edge case for rounding 999.5+: robak.
Dec 21 2017, 9:39 PM · tests
pawel.biernacki-gmail.com created D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 21 2017, 9:30 PM · tests

Dec 1 2017

pawel.biernacki-gmail.com added a comment to D13228: vmstat: fix style(9) violations and bump WARNS.

I'm fine with it. I've one question about what is the correct way of sorting local variables? style(9) use two different versions (or I'm reading it wrong):

int
main(int argc, char *argv[])
{
        char *ep;
        long num;
        int ch;
Dec 1 2017, 6:32 PM

Nov 29 2017

pawel.biernacki-gmail.com updated the summary of D13228: vmstat: fix style(9) violations and bump WARNS.
Nov 29 2017, 5:45 PM
pawel.biernacki-gmail.com updated the diff for D13228: vmstat: fix style(9) violations and bump WARNS.

Address @kib comments. Also more and more style(9) cleanup like moving variables from body to top of the functions, removing unneeded empty lines, PRIu64 changed to %ju with uintmax_t cast, sorting, etc...

Nov 29 2017, 4:21 PM
pawel.biernacki-gmail.com added inline comments to D13228: vmstat: fix style(9) violations and bump WARNS.
Nov 29 2017, 4:18 PM

Nov 24 2017

pawel.biernacki-gmail.com created D13228: vmstat: fix style(9) violations and bump WARNS.
Nov 24 2017, 4:08 PM

Nov 23 2017

pawel.biernacki-gmail.com added a comment to D13199: vmstat: use 64-bit counters from struct vmtotal.

vmstat(1) is full of style(9) violations, mostly related to libxo integration. I'd like to clean this in a separate patch.

Nov 23 2017, 4:36 PM
pawel.biernacki-gmail.com updated the diff for D13199: vmstat: use 64-bit counters from struct vmtotal.

Move uintmax_t cast to vmstat_pgtok macro.

Nov 23 2017, 4:30 PM
pawel.biernacki-gmail.com updated the diff for D13199: vmstat: use 64-bit counters from struct vmtotal.

Change u_int64_t to uint64_t in prthuman() and all invocations.

Nov 23 2017, 12:56 PM

Nov 22 2017

pawel.biernacki-gmail.com updated the summary of D13199: vmstat: use 64-bit counters from struct vmtotal.
Nov 22 2017, 11:25 PM
pawel.biernacki-gmail.com added inline comments to D13199: vmstat: use 64-bit counters from struct vmtotal.
Nov 22 2017, 10:47 PM
pawel.biernacki-gmail.com created D13199: vmstat: use 64-bit counters from struct vmtotal.
Nov 22 2017, 10:46 PM

Nov 21 2017

pawel.biernacki-gmail.com updated the summary of D13105: systat: use and correctly display 64bit counters.
Nov 21 2017, 11:43 AM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.

s/divider/divisor/

Nov 21 2017, 10:38 AM
pawel.biernacki-gmail.com updated the summary of D13105: systat: use and correctly display 64bit counters.
Nov 21 2017, 10:33 AM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.

Rename real_putuint64() to do_putuint64(), style(9) fixes.

Nov 21 2017, 10:33 AM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.

No need to use 64 bit arithmetics for namei cache.

Nov 21 2017, 2:36 AM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.

Use correctly generated diff.

Nov 21 2017, 12:36 AM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.

Split printing integer values to putint() and putuint64() functions, calling the actual implementation with parameter selecting using SI or IEC divisor. Update all memory related values to use putuint64().

Nov 21 2017, 12:33 AM

Nov 17 2017

pawel.biernacki-gmail.com added a comment to D13105: systat: use and correctly display 64bit counters.
In D13105#273075, @kib wrote:

Address @kib comments:

  • Drop 1000 as a divider and stick to expected 1024.

So we have two uses of putint(). One is for (possibly very large) VM counters, and others for (usually not too large) event counts e.g. syscall/intr and so on.
Should the new function used only for 'large' counters, leaving old display algorithm around for slow counters ? This question jibes with the note that changed function should be called putuint64.

Nov 17 2017, 6:01 PM

Nov 16 2017

pawel.biernacki-gmail.com added inline comments to D13105: systat: use and correctly display 64bit counters.
Nov 16 2017, 10:17 PM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.

Address @kib comments:

Nov 16 2017, 10:16 PM

Nov 15 2017

pawel.biernacki-gmail.com added inline comments to D13105: systat: use and correctly display 64bit counters.
Nov 15 2017, 7:19 PM
pawel.biernacki-gmail.com added inline comments to D13105: systat: use and correctly display 64bit counters.
Nov 15 2017, 7:18 PM
pawel.biernacki-gmail.com updated the diff for D13105: systat: use and correctly display 64bit counters.
  • Update with long diff.
  • Use correct formatting for uint64_t in snprintf.
Nov 15 2017, 7:16 PM
pawel.biernacki-gmail.com added a comment to D13105: systat: use and correctly display 64bit counters.

Sorry, uploaded the short patch. Will upload long one with fixes.

Nov 15 2017, 5:06 PM
pawel.biernacki-gmail.com created D13105: systat: use and correctly display 64bit counters.
Nov 15 2017, 4:18 PM

Nov 14 2017

pawel.biernacki-gmail.com updated the diff for D13018: vmtotal: extend counters to match reality.

Fix the alignment issue by introducing spare filed of 3x16 bit ints.

Nov 14 2017, 8:23 PM
pawel.biernacki-gmail.com added a comment to D13018: vmtotal: extend counters to match reality.

Reordering didn't really helped. There is 5 16-bit fields that seems to be aligned on amd64 leaving 3x16bit hole which is only 1x16bit on i386.
Any ideas how to fix it? Enforce struct alignment to 8 bytes? Add an extra 32bit field as a spare?

Nov 14 2017, 7:53 PM
pawel.biernacki-gmail.com updated the diff for D13018: vmtotal: extend counters to match reality.

Address the style(9) comments. Also there is no need to call sysctl_handle_opaque in the last return as all we do now is returning fully populated struct. SYSCTL_OUT is enough.

Nov 14 2017, 2:59 PM
pawel.biernacki-gmail.com updated the diff for D13018: vmtotal: extend counters to match reality.

Address @kib comments:

Nov 14 2017, 1:10 PM

Nov 13 2017

pawel.biernacki-gmail.com added inline comments to D13018: vmtotal: extend counters to match reality.
Nov 13 2017, 11:55 PM
pawel.biernacki-gmail.com updated the diff for D13018: vmtotal: extend counters to match reality.
  • Extend all counters to uint64_t.
  • Introduce new P_OSREL_VMTOTAL64 define to mark extension of the struct vmtotal.
  • Provide sysctl(8) compatibility.
  • Bump FreeBSD_version.
Nov 13 2017, 11:53 PM

Nov 9 2017

pawel.biernacki-gmail.com added a comment to D13018: vmtotal: extend counters to match reality.

From what I see, sysctl(8) first calls sysctl(3) to get the size of vmtotal. As defined in

SYSCTL_PROC(_vm, VM_TOTAL, vmtotal, CTLTYPE_OPAQUE|CTLFLAG_RD|CTLFLAG_MPSAFE,
    0, sizeof(struct vmtotal), vmtotal, "S,vmtotal", 
    "System virtual memory statistics");

it'll return the size of the current vmtotal. It later compares it with the compile time size of struct vmtotal and report mismatch.

Nov 9 2017, 6:27 PM
pawel.biernacki-gmail.com created D13018: vmtotal: extend counters to match reality.
Nov 9 2017, 2:50 PM
pawel.biernacki-gmail.com added inline comments to D12985: bhyve: don't try to capsicumise after failed open.
Nov 9 2017, 2:33 PM · bhyve

Nov 7 2017

pawel.biernacki-gmail.com updated the summary of D12985: bhyve: don't try to capsicumise after failed open.
Nov 7 2017, 11:56 PM · bhyve
pawel.biernacki-gmail.com created D12985: bhyve: don't try to capsicumise after failed open.
Nov 7 2017, 11:22 PM · bhyve
pawel.biernacki-gmail.com added inline comments to D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 9:17 PM
pawel.biernacki-gmail.com updated the test plan for D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 3:51 PM
pawel.biernacki-gmail.com updated the diff for D12972: sysctl_kern_proc_umask: fast path when operating on curproc.

Address @mjg comments and remove extra FILEDESC locks.

Nov 7 2017, 3:51 PM
pawel.biernacki-gmail.com updated the test plan for D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 3:51 PM
pawel.biernacki-gmail.com updated the summary of D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 3:51 PM
pawel.biernacki-gmail.com created D12972: sysctl_kern_proc_umask: fast path when operating on curproc.
Nov 7 2017, 3:51 PM

Nov 3 2017

pawel.biernacki-gmail.com updated the diff for D12929: pget: don't acquire allproc_lock when operating on curproc.

Roll back to the original version and optimise only for the pid == curproc->p_pid case.

Nov 3 2017, 4:07 PM
pawel.biernacki-gmail.com added a comment to D12929: pget: don't acquire allproc_lock when operating on curproc.

Shouldn't then CPUCLOCK_WHICH_PID case in kern_clock_getcpuclockid2 be amended?

Nov 3 2017, 2:49 PM
pawel.biernacki-gmail.com added a comment to D12929: pget: don't acquire allproc_lock when operating on curproc.

I'll check pfind and create new review if needed.

Nov 3 2017, 2:05 PM
pawel.biernacki-gmail.com updated the diff for D12929: pget: don't acquire allproc_lock when operating on curproc.

Address @kib comment and check for tid too.

Nov 3 2017, 2:02 PM
pawel.biernacki-gmail.com created D12929: pget: don't acquire allproc_lock when operating on curproc.
Nov 3 2017, 1:40 PM

Oct 31 2017

pawel.biernacki-gmail.com added a comment to D9649: Enable VNET operations for ifconfig and route.

OK, let me take a look at creating some in-kernel interface for this.

Oct 31 2017, 11:36 AM · network
pawel.biernacki-gmail.com added a comment to D9649: Enable VNET operations for ifconfig and route.

I don't know if I understand. jexec uses exactly the same syscall, jail_attach to achieve the same effect. Putting ifconfig and route inside a jail allows even more actions to be taken by the in-jail admin.
Also, there is no obvious other way to achieve this with current API.
I see two other options: additional API to manage jails and vnet without attaching process to the jail, or finding a way to avoid duplicated interface names but adding some sort of unique id(?).

Oct 31 2017, 11:19 AM · network

Oct 28 2017

pawel.biernacki-gmail.com updated the diff for D9649: Enable VNET operations for ifconfig and route.

Address comments and sync with r325058.

Oct 28 2017, 7:32 PM · network

Feb 17 2017

pawel.biernacki-gmail.com updated the diff for D9649: Enable VNET operations for ifconfig and route.

Even better grammar!

Feb 17 2017, 9:44 PM · network
pawel.biernacki-gmail.com updated the diff for D9649: Enable VNET operations for ifconfig and route.

Use proper diff.

Feb 17 2017, 8:29 PM · network
pawel.biernacki-gmail.com updated the diff for D9649: Enable VNET operations for ifconfig and route.

man fixes: improve poor grammar, bump date, start sentences from new line.

Feb 17 2017, 8:25 PM · network
pawel.biernacki-gmail.com updated the test plan for D9649: Enable VNET operations for ifconfig and route.
Feb 17 2017, 1:08 PM · network
pawel.biernacki-gmail.com updated the test plan for D9649: Enable VNET operations for ifconfig and route.
Feb 17 2017, 1:08 PM · network
pawel.biernacki-gmail.com updated the test plan for D9649: Enable VNET operations for ifconfig and route.
Feb 17 2017, 1:05 PM · network
pawel.biernacki-gmail.com retitled D9649: Enable VNET operations for ifconfig and route from to Enable VNET operations for ifconfig and route.
Feb 17 2017, 12:55 PM · network

Feb 14 2017

pawel.biernacki-gmail.com added a comment to D8290: Capsicumise bhyve.

As I wrote in a mail to @jhb - the idea is worth considering. I'd like to gather some feedback from broader audience as the code is in base now and start a new review with some ideas about polishing / improvements to the code.

Feb 14 2017, 5:07 PM
pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Remove extra ENOSYS check and notification about lack of Capsicum support in the kernel.

Feb 14 2017, 1:20 PM
pawel.biernacki-gmail.com added a comment to D8290: Capsicumise bhyve.

@grehan capsicum @emaste Guys, can this be reviewed and accepted once again so it could be safely committed?

Feb 14 2017, 12:55 PM

Feb 13 2017

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Remove now empty #ifdef.

Feb 13 2017, 1:40 PM
pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

@grehan Thank you for your help and the review.

Feb 13 2017, 1:26 PM

Feb 8 2017

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Address @grehan comments:

  • use bcopy instead of memcpy to be consistent with the rest of the code,
  • use cap_ioctl_t instead of unsigned long,
  • style(9) fixes.
Feb 8 2017, 9:31 AM

Feb 4 2017

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Drop executable permission in mmap.

Feb 4 2017, 11:42 AM
pawel.biernacki-gmail.com added inline comments to D8290: Capsicumise bhyve.
Feb 4 2017, 11:39 AM

Feb 1 2017

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Allow pci_e82545 descriptor to be used by mevent.

Feb 1 2017, 10:59 PM

Jan 30 2017

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Allow fsync(2) in block devices.

Jan 30 2017, 9:43 AM

Jan 10 2017

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.
  • Address @grehan comments
  • Sync with r311881
  • Small style fixes
Jan 10 2017, 8:48 PM

Dec 15 2016

pawel.biernacki-gmail.com added inline comments to D8290: Capsicumise bhyve.
Dec 15 2016, 11:31 PM

Dec 14 2016

pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.
  • Address @grehan comments and move table with VM_ ioctls to a separate function in libvmmapi
  • Style fixes here and there
  • Sync with r310050
Dec 14 2016, 12:03 PM

Dec 12 2016

pawel.biernacki-gmail.com added a comment to D8290: Capsicumise bhyve.

@lattera-gmail.com Thank you for the tests! I'd also want to appeal to anyone else who can help testing it in any configuration.

Dec 12 2016, 5:11 PM

Dec 10 2016

pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.

Fix regression when stdin/out/err fds are are overridden by shell.
Found by Kyua tests.

Dec 10 2016, 2:57 PM · capsicum
pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Wops, wrong differential, sorry.

Dec 10 2016, 2:56 PM
pawel.biernacki-gmail.com removed a reviewer for D8290: Capsicumise bhyve: ngie.
Dec 10 2016, 2:54 PM
pawel.biernacki-gmail.com updated the diff for D8290: Capsicumise bhyve.

Fix regression when stdin/out/err fds are are overridden by shell.
Found by Kyua tests.

Dec 10 2016, 2:53 PM

Dec 7 2016

pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.

Update diff with one that survived building head@r309672:

  1. buildword && buildkernel on FreeBSD 10.3-R i386
  2. universe on FreeBSD 11.0-R amd64
Dec 7 2016, 10:52 PM · capsicum

Dec 6 2016

pawel.biernacki-gmail.com added a comment to D8543: Capsicumise dd.

Since dd was removed from bootstrap in 309412, can this be recommitted?

Dec 6 2016, 6:41 PM · capsicum

Dec 2 2016

pawel.biernacki-gmail.com added a comment to D8290: Capsicumise bhyve.

Ping after two weeks of silence.

Dec 2 2016, 10:32 AM

Nov 21 2016

pawel.biernacki-gmail.com added a comment to D8543: Capsicumise dd.

As I see libcapsicum is header only https://svnweb.freebsd.org/base/head/lib/libcapsicum/Makefile?revision=306726&view=markup.
The breakage was obviously caused by lack of that header in installed system older than 12-C.

Nov 21 2016, 8:34 PM · capsicum
pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.

Make it compile on older releases as dd is part of bootstrap and pre 12-C don't have capsicum_helpers.h installed.

Nov 21 2016, 12:06 PM · capsicum

Nov 18 2016

pawel.biernacki-gmail.com added a comment to D8290: Capsicumise bhyve.

Does VNC disconnect/reconnect work ? (I'll try and test this out)

Nov 18 2016, 8:08 PM
pawel.biernacki-gmail.com updated the diff for D8543: Capsicumise dd.
  • be more consistent with lowercase in err().
Nov 18 2016, 7:38 PM · capsicum