Page MenuHomeFreeBSD

pauamma (Pau Amma)
User

Projects

User Details

User Since
Dec 1 2019, 8:31 PM (141 w, 3 d)

I wandered into FreeBSD/390 in early December 2011 and offered to help. Shortly thereafter, I suffered a severe brain crash and had to run away from it for my own sanity (or what was left of it), then the project was abandoned. Fast forward 8 years, and I'm a FreeBSD user again. Another 3 years, and I maintain a port, contribute bug reports, content, and reviews to documentation and manual pages, help a bit with IRC-based user support on occasion, and now learning the ropes of being a committer.

Core features: Muslim, autist, left libertarian, emotional abuse survivor, former nicotine addict, former jerk.

Beliefs (partial list): Black Lives Matter, Trans Women Are Women, people have worth just because they exist, Covid-19 is here to stay and still deadly.

Prone to: punning, instafilking in various languages, foodporning, advocating for accessibility and inclusivity, sleeping in 3-5 hour chunks, strictly enforcing my clearly stated boundaries against violators.

Pronouns: he/him/his (or singular they/them/their/theirs) for English, il (or iel/ielle) for French, or siya/niya/kaniya (please no sila/nila/kanila) if you ever have cause to discuss or mention me in Tagalog.

Alignment: Chaotic Punny, Useful Descriptivist, Nominative-Accusative, and or Austronesian.

Schiller Pastiche
Against ambiguity, the words themselves contend in vain.

Obligatory Kipling Pastiche
'Ah!' said the Elder Committer. 'Now I know who has been playing with the Tree;' and he called out, 'What are you doing, Pau Amma?'

And Pau Amma, deep down below, answered, 'Once a day and once a night I pull then rebase my branch. Once a day and once a night I commit. Leave me alone.'

Recent Activity

Yesterday

pauamma accepted D36210: rc: add a manual entry for ${name}_setup.

English LGTM and the addition of ${name}_setup looks consistent with https://reviews.freebsd.org/D36006 to my untrained eye. I can't say whether the change to ${name}_prepend is correct.

Wed, Aug 17, 7:34 AM · rc

Tue, Aug 16

pauamma accepted D27318: freebsd-version(1): present -v option, to print verbose output.
Tue, Aug 16, 1:08 AM
pauamma added inline comments to D27318: freebsd-version(1): present -v option, to print verbose output.
Tue, Aug 16, 1:05 AM
pauamma accepted D36205: kqueue: retire knlist_init_rw_reader().
Tue, Aug 16, 12:36 AM

Sat, Aug 13

pauamma added a comment to D27318: freebsd-version(1): present -v option, to print verbose output.

thanks for accepting this revision @pauamma
we shall just get an OK from @gbe and/or @kevans and this is good to be committed. right?

Sat, Aug 13, 3:08 AM

Fri, Aug 12

pauamma accepted D36090: Porter Handbook: Update documentation on porting Haskell programs..

LGTM.

Gleb please, would you hold a couple of days until @pauamma reviews this again or we call a timeout?

Thanks!

Fri, Aug 12, 7:50 PM
pauamma accepted D36140: ipfw: make it possible to specify MTU for "unreach needfrag" action.

Manual page change LGTM. Can't say beyond that.

Fri, Aug 12, 7:20 PM
pauamma accepted D27318: freebsd-version(1): present -v option, to print verbose output.
Fri, Aug 12, 1:13 PM
pauamma added a comment to D27318: freebsd-version(1): present -v option, to print verbose output.
In D27318#821022, @pi wrote:

See also PR#265789, it would help if

freebsd-version -rku and -kru did not print the same regardless of the sequence of CLI arguments.

So if some patch for that would be added to this review, that would be very helpful.

Fri, Aug 12, 1:08 PM

Wed, Aug 10

pauamma requested changes to D27318: freebsd-version(1): present -v option, to print verbose output.

Getting closer.

Wed, Aug 10, 8:58 PM
pauamma requested changes to D36090: Porter Handbook: Update documentation on porting Haskell programs..

A bunch of small nits. I'd also like someone who understands haskell porting to review for accuracy.

Wed, Aug 10, 4:55 PM
pauamma added inline comments to D36090: Porter Handbook: Update documentation on porting Haskell programs..
Wed, Aug 10, 6:57 AM

Tue, Aug 9

pauamma requested changes to D27318: freebsd-version(1): present -v option, to print verbose output.
In D27318#819456, @gbe wrote:

Is there anything specific that would block a commit?

I would've quite liked to see at least my later two comments addressed

Tue, Aug 9, 5:36 PM

Mon, Aug 8

pauamma removed a reviewer for D36076: src.conf: Introduce WITHOUT_MACHDEP knob.: manpages.
Mon, Aug 8, 4:36 PM
pauamma accepted D33400: kqueue: add knlist_init_sx() for shared/exclusive locks.

Assuming consistent with source.

Mon, Aug 8, 10:04 AM

Sat, Aug 6

pauamma added a comment to D30376: Add support for sleepable EPOCH(9) type, based on prior work in the LinuxKPI..

Misspelling can be fixed on commit if nothing else requires a rereview. Everything else is beyond me.

Sat, Aug 6, 10:11 AM
pauamma accepted D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..

The English in the manual page change LGTM. I can't attest to consistency with the rest.

Sat, Aug 6, 10:00 AM

Fri, Aug 5

pauamma added a comment to D36048: Update HISTORY and AUTHORS sections for cut(1) and paste(1).

++

Fri, Aug 5, 11:50 AM
pauamma added inline comments to D22012: Import dhcpcd(8) into FreeBSD base..
Fri, Aug 5, 10:05 AM
pauamma accepted D35588: bsdinstall: allow setting the root password via env variables.
Fri, Aug 5, 9:41 AM

Thu, Aug 4

pauamma requested changes to D36037: clock_gettime: Minor clarification.
Thu, Aug 4, 12:49 AM

Wed, Aug 3

pauamma accepted D36013: status/report-2022-04-2022-06: Add report.

Minor nit, can be fixed while committing. (Matching pull request to change the boilerplate in tools/ coming soon to a GitHub repo near you.)

Wed, Aug 3, 12:46 AM

Mon, Aug 1

pauamma accepted D36004: tcp.4: Add missing sysctls, other fixes.
Mon, Aug 1, 2:24 PM
pauamma accepted D36003: inet.4 icmp.4 udp.4: Add missing sysctls, other fixes.
Mon, Aug 1, 2:17 PM
pauamma accepted D35983: Support vt(4) console screen rotation for panels mounted at non-native orientations..

English LGTM. Can't vouch for consistency with source code or correctness of that.

Mon, Aug 1, 8:47 AM
pauamma added inline comments to D36003: inet.4 icmp.4 udp.4: Add missing sysctls, other fixes.
Mon, Aug 1, 2:55 AM
pauamma requested changes to D36004: tcp.4: Add missing sysctls, other fixes.
Mon, Aug 1, 1:23 AM

Sun, Jul 31

pauamma requested changes to D36003: inet.4 icmp.4 udp.4: Add missing sysctls, other fixes.
Sun, Jul 31, 11:08 PM
pauamma requested changes to D35986: committers-guide: add a bit about partial cloning.

For the next round, please include the whole file(s) as explained in https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface. This lets reviewers make edit suggestions directly instead of laboriously explaining them.

Sun, Jul 31, 8:53 PM
pauamma added a comment to D35979: Remove minigzip from the base system..

LGTM once https://reviews.freebsd.org/D36000 is MFC'd.

Sun, Jul 31, 1:24 PM
pauamma accepted D36000: Deprecate minigzip(1) in preparation of removing it from base system..

Minor wording tweak, so no need for another review round if nothing else needs it.

Sun, Jul 31, 1:20 PM

Sat, Jul 30

pauamma requested changes to D35983: Support vt(4) console screen rotation for panels mounted at non-native orientations..
Sat, Jul 30, 12:59 AM
pauamma added a comment to D35980: Add support for _CR3 critical standby (S3) threshold..

Manual page English LGTM, but holding back until someone approves the design and implementation.

Sat, Jul 30, 12:48 AM
pauamma requested changes to D35979: Remove minigzip from the base system..

Can we add a note to minigzip.1 (and MFC it) first, mentioning that it is removed from 14.x and to use gzip instead?

Sat, Jul 30, 12:36 AM

Fri, Jul 29

pauamma accepted D35912: stand: Add driver interface docs.

Minor enough to fix when committing.

Fri, Jul 29, 11:41 PM
pauamma added inline comments to D35756: pkg: Add limited --debug/-d support.
Fri, Jul 29, 11:08 PM
pauamma added inline comments to D35960: style: Allow C++ comments.
Fri, Jul 29, 10:38 PM
pauamma accepted D35909: sockets: implement MSG_TRUNC recv/recvmsg flag.
Fri, Jul 29, 10:22 PM

Thu, Jul 28

pauamma accepted D35966: date: refer to tzdata as a 'distribution' rather than 'package'.
Thu, Jul 28, 2:22 PM

Wed, Jul 27

pauamma added a comment to D35966: date: refer to tzdata as a 'distribution' rather than 'package'.

I agree "package" is unclear, but I have mixed feelings about "distribution". "tzdata data" read weirdly to me, so what about "information"?

Wed, Jul 27, 11:38 PM
pauamma accepted D35945: Style(9): Strengthen statements about not using K&R function definitions.

Looks clear and grammatical to me.

Wed, Jul 27, 10:48 PM
pauamma added inline comments to D35960: style: Allow C++ comments.
Wed, Jul 27, 6:51 PM
pauamma added inline comments to D35890: ip6(4): document IP_ORIGDSTADDR.
Wed, Jul 27, 6:41 PM
pauamma added a comment to D35959: style: Tighten up one use of 'may'.

Worth adding a short description of must/should/may/should not/must not a la RFC2119?

Wed, Jul 27, 2:23 PM
pauamma added inline comments to D35945: Style(9): Strengthen statements about not using K&R function definitions.
Wed, Jul 27, 9:44 AM

Tue, Jul 26

pauamma requested changes to D24415: Add rcvar to rc.d/utx.
Tue, Jul 26, 11:19 PM · rc
pauamma requested changes to D35912: stand: Add driver interface docs.
Tue, Jul 26, 10:20 PM
pauamma accepted D35909: sockets: implement MSG_TRUNC recv/recvmsg flag.

Both are minor and can be changed on commit. (And as always, I can't review the C source.)

Tue, Jul 26, 10:12 PM
pauamma added a comment to D33400: kqueue: add knlist_init_sx() for shared/exclusive locks.

Manual page LGTM, but holding approval until someone/somegroup is added for kernel code review.

Tue, Jul 26, 7:43 PM
pauamma requested changes to D35890: ip6(4): document IP_ORIGDSTADDR.
Tue, Jul 26, 7:15 PM
pauamma added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Hey guys, is there anything here that I still need to do?

Tue, Jul 26, 6:26 PM
pauamma accepted D21011: Functional implementation of Accurate ECN in FreeBSD.

This takes care of all my manual page edits as far as I can tell.

Tue, Jul 26, 11:10 AM
pauamma accepted D32669: Add pmc.dmc-620(3) man page..

English LGTM as long as the content matches reality.

Tue, Jul 26, 3:45 AM

Sat, Jul 23

pauamma accepted D35817: qat: Rename to qat_c2xxx and remove support for modern chipsets.

Manual page change English looks good to me and its content is consistent with change summary.

Sat, Jul 23, 8:02 AM
pauamma added a comment to D24208: Porter's handbook 5.4.3: clarify group in GH_TUPLE.

Can you convert it to AsciiDoc? https://docs.freebsd.org/en/books/fdp-primer/asciidoctor-primer/ and https://docs.freebsd.org/en/books/fdp-primer/rosetta/, and I can help if needed.

Sat, Jul 23, 2:22 AM
pauamma added a comment to D35819: Upgrade ports intalling section.

I'm getting an error message:

Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261852). Can you make sure your file ends in a newline and reupload?

Sat, Jul 23, 12:47 AM
pauamma added inline comments to D35823: Upgrade FreeBSD features page.
Sat, Jul 23, 12:32 AM
pauamma accepted D35857: etcupdate: Add a -N flag to perform a NO_ROOT build.

Unless something else needs revisions, fine with me to bump Dd at commit.

Sat, Jul 23, 12:19 AM
pauamma accepted D35854: etcupdate: Add a -m flag to change the make binary that's run.

Manual page English LGTM.

Sat, Jul 23, 12:15 AM
pauamma accepted D35533: crypto: Provide a routine to reset cryptops after EAGAIN.

One minor nit that can be fixed at commit.

Sat, Jul 23, 12:08 AM

Fri, Jul 22

pauamma added inline comments to D35588: bsdinstall: allow setting the root password via env variables.
Fri, Jul 22, 10:12 PM
pauamma requested changes to D32669: Add pmc.dmc-620(3) man page..
Fri, Jul 22, 11:11 AM
pauamma added a member for Doc Committers: pauamma.
Fri, Jul 22, 3:46 AM
bofh renamed pauamma from pauamma_gundo.com to pauamma.
Fri, Jul 22, 3:08 AM
pauamma updated pauamma.
Fri, Jul 22, 2:06 AM

Wed, Jul 20

pauamma committed rGe5d24f634e81: Update share/misc/committers-*.dot comments for git. (authored by pauamma).
Update share/misc/committers-*.dot comments for git.
Wed, Jul 20, 10:56 PM
pauamma closed D35803: Update share/misc/committers-*.dot comments for git..
Wed, Jul 20, 10:55 PM
pauamma committed rG102f31bf36ed: New committer (doc): Pau Amma (authored by pauamma).
New committer (doc): Pau Amma
Wed, Jul 20, 4:21 AM
pauamma closed D35768: New committer (doc): Pau Amma.
Wed, Jul 20, 4:21 AM

Jul 19 2022

pauamma requested changes to D35588: bsdinstall: allow setting the root password via env variables.
Jul 19 2022, 4:00 AM
pauamma added a comment to D35588: bsdinstall: allow setting the root password via env variables.
In D35588#813713, @0mp wrote:

LGTM, thanks!

One last nit that you may want to change is to use printf instead of echo. echo may behave in an undesired way if the root password is starting with a dash for example.

Jul 19 2022, 3:54 AM

Jul 18 2022

pauamma added a comment to D35803: Update share/misc/committers-*.dot comments for git..
In D35803#813728, @gjb wrote:

Doc committers can commit to all three repositories for doc-related items, so no explicit permission is necessary unless you are under mentorship.

Jul 18 2022, 9:27 PM
pauamma added a comment to D35768: New committer (doc): Pau Amma.

Is mentor approval from before I split off the bits unrelated to onboarding enough for me to proceed with the actual commit?

Jul 18 2022, 4:30 PM
pauamma updated the summary of D35768: New committer (doc): Pau Amma.
Jul 18 2022, 12:56 AM
pauamma added a comment to D35838: New Account Creation Procedure: correct two links.
In D35838#813568, @pauamma_gundo.com wrote:

May want to add docs as a group reviewer?

docs as a subscriber, thanks.

(I guess that strictly speaking, it should be Glen and/or Sergio, as mentors, to accept, for as long as I'm their mentee.)

Jul 18 2022, 12:42 AM

Jul 17 2022

pauamma added a comment to D35838: New Account Creation Procedure: correct two links.

May want to add docs as a group reviewer?

Jul 17 2022, 10:56 PM
pauamma requested changes to D35817: qat: Rename to qat_c2xxx and remove support for modern chipsets.

<grimace>

I don't like the idea of removing an existing manpage from an existing driver, just on general principles. Can you keep it and rename it appropriately instead?

Jul 17 2022, 9:40 PM
pauamma added inline comments to D35823: Upgrade FreeBSD features page.
Jul 17 2022, 4:25 PM
pauamma added inline comments to D35823: Upgrade FreeBSD features page.
Jul 17 2022, 12:10 PM

Jul 16 2022

pauamma added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 16 2022, 3:32 AM
pauamma added a comment to D35803: Update share/misc/committers-*.dot comments for git..

So, assuming this is the final round of reviewing, how does doc committing work for src files that aren't manual pages? Am I allowed (and able) to commit with a src committer's approval, or do I have to ask one to commit for me?

Jul 16 2022, 2:49 AM
pauamma updated the diff for D35803: Update share/misc/committers-*.dot comments for git..
  • Tweak wording as lwhsu and jhb suggested.
Jul 16 2022, 2:44 AM

Jul 15 2022

pauamma added inline comments to D35819: Upgrade ports intalling section.
Jul 15 2022, 9:02 PM
pauamma requested changes to D35823: Upgrade FreeBSD features page.

Can you use https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface (if not using Arcanist) to upload the whole file for the next round of reviewing? I think that's why I can't suggest edits in Phabricator.

Jul 15 2022, 8:37 PM
pauamma added a comment to D35817: qat: Rename to qat_c2xxx and remove support for modern chipsets.

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

Jul 15 2022, 5:34 PM
pauamma requested changes to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 15 2022, 7:52 AM
pauamma accepted D35371: mac: add new mac_ddb(4) policy.

Manual page changes are in good English but most of what they say is beyond me.

Jul 15 2022, 12:31 AM

Jul 13 2022

pauamma requested changes to D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).
Jul 13 2022, 10:14 PM
pauamma accepted D35774: kdump: Advance kdump timestamp resolution..
Jul 13 2022, 8:10 PM
pauamma added a comment to D35772: beep(1): Add support for rendering text and numbers as audio..

Can you test this updated patch, now with full UTF-8 support.

Jul 13 2022, 7:59 PM
pauamma updated the diff for D35768: New committer (doc): Pau Amma.
Split off git log changes at lwhsu's suggestion.
Jul 13 2022, 1:53 PM
pauamma added a comment to D35768: New committer (doc): Pau Amma.

VCS change split off to https://reviews.freebsd.org/D35803. New patch here in a bit.

Jul 13 2022, 11:35 AM
pauamma requested review of D35803: Update share/misc/committers-*.dot comments for git..
Jul 13 2022, 11:32 AM

Jul 11 2022

pauamma accepted D35741: IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8.

Manual page LGTM.

Jul 11 2022, 6:29 PM
pauamma requested changes to D35775: kdump: Sort options in alphabetical order..

May as well copyedit option description while there.

Jul 11 2022, 6:14 PM
pauamma requested changes to D35774: kdump: Advance kdump timestamp resolution..

Also: in last sentence of summary, "earch" should be "each".

Jul 11 2022, 6:11 PM
pauamma added a comment to D35741: IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8.
In D35741#811738, @imp wrote:
In D35741#811730, @pauamma_gundo.com wrote:

I dimly remember reading, 25-30 years ago, that some low-stratum NTP servers used 127.0.1.0/24 for their atomic clocks, but that's admittedly a corner case even if they use(d) FreeBSD.

Close. ntp never used 127.x addresses to talk to each other. For a while, though, stratum 1 clocks used that as the reference for different types of time source in a 4-byte field that often would also have the IP address of the upstream for stratum 2 and greater clocks. That was changed in the last 90s / early 2000s though I believe.

Jul 11 2022, 5:57 PM
pauamma added a comment to D35772: beep(1): Add support for rendering text and numbers as audio..

Would it work if the intermediate format was UTF-8, but all characters would be output as 16-bit unicode?

Jul 11 2022, 5:14 PM
pauamma added inline comments to D35741: IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8.
Jul 11 2022, 3:01 PM
pauamma added a comment to D35741: IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8.
In D35741#811409, @bz wrote:

I think the only real issue I can quickly think is that in the past FreeBSD users have used addressed out of 127/8 for adding a loopback IP to classic IP-jails based on certain schemes.

Jul 11 2022, 2:57 PM