Page MenuHomeFreeBSD

oleg_mamontov.net (Oleg A. Mamontov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2023, 8:48 PM (61 w, 5 d)

Recent Activity

Jul 31 2023

oleg_mamontov.net updated the diff for D39868: [NEW PORT] www/angie: patch also includes new related ports for dynamic modules.

Hi
Please find my comments below in-line:

Jul 31 2023, 3:18 PM

Jun 7 2023

oleg_mamontov.net updated the diff for D39868: [NEW PORT] www/angie: patch also includes new related ports for dynamic modules.

Thank you for suggestion.
I've re-worked patch with MASTERDIR approach and shortened the patch to only angie and angie-module-geoip2 ports for ease of review process. If we can agree on this method, I'm ready to introduce all the others.
Thank you in advance!

Jun 7 2023, 8:44 PM

Jun 6 2023

oleg_mamontov.net added a comment to D39868: [NEW PORT] www/angie: patch also includes new related ports for dynamic modules.

Sorry for the delay, this time from my side.
From the Porters Handbook it seems that MASTERDIR is recommended for building slightly different versions of packages but in this particular case we have a bunch of almost independent ports that still share a significant amount of parts.
I see many similar approaches in the tree, please take a look at www/twiki* for example.
In my opinion this seems more natural and convenient than using MASTERDIR for this use case.
Please let me know what do you think? If you are still sure that MASTERDIR is the only possible viable solution, I'll take this approach.

Jun 6 2023, 9:23 AM

Apr 28 2023

oleg_mamontov.net requested review of D39868: [NEW PORT] www/angie: patch also includes new related ports for dynamic modules.
Apr 28 2023, 1:40 PM