- User Since
- Feb 26 2021, 3:47 PM (118 w, 6 d)
Tue, Jun 6
Mon, Jun 5
Wed, May 31
Good patch this time...
Yes, of course...
Clearer commit message's headling
Original commit, with message untweaked by arc
Tue, May 30
Apr 26 2023
Move a comment
Apr 25 2023
FWIW, I've checked these filesystems as well and I concur. I've also tested the patch with a parallel buildkernel and several find processes repeatedly cating files in /usr/obj without problems.
Apr 24 2023
Now just contains the changes to vn_dir_next_dirent().
Further diff simplification
Keep just the move and rename. Next commits to be added as child revisions.
Apr 22 2023
I've also changed a bit the initial diff so as to minimize differences (order of declarations).
Keep just the get_next_dirent() => vfs_next_dirent() refactoring
Apr 21 2023
Jan 19 2023
I attached a diff to smr.9 only applying to your latest revision:.
Thanks. I have two further nitpicks. Otherwise, LGTM.
To ease things, I've uploaded a new diff for the whole review that includes proposed changes:.
Dec 2 2022
Oct 18 2022
May 5 2021
Apr 22 2021
In particular, POSIX allows an implementation to define any feature test macro they wish. There is no need that they are standardized.
This is exactly what we're doing here. We're just choosing to follow the glibc practice as prior art.
Please see my latest comment in bug #255290.
Mar 11 2021
Mar 5 2021
So, to recap:
- NORUNTIME is a file independent from any ports' files listing ports that cannot be runtime
dependencies (to any other ports) after some specific date.
- The modifications in do-depends.sh ensure that the dependency step will fail when depending on
forbidden ports. So port building will simply hard fail when it's the case.
- The modifications of bsd.port.mk will set DEPRECATED and EXPIRATION_DATE (as explained above)
according to forbidden runtime dependencies. AFAIK, this is an advisory mechanism only.
Set DEPRECATED and EXPIRATION_DATE if appropriate
Fix awk expression to exclude comment lines
Date is expiration date, regexp support removal, read NORUNTIME only once
Mar 2 2021
about the format, why adding a pattern matching? exact match should be enough I think and would simplify the script