Page MenuHomeFreeBSD

olce.freebsd_certner.fr (Olivier Certner)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2021, 3:47 PM (118 w, 6 d)

Recent Activity

Tue, Jun 6

olce.freebsd_certner.fr added inline comments to D40428: opencrypto: Handle end-of-cursor conditions in crypto_cursor_segment().
Tue, Jun 6, 2:40 PM
olce.freebsd_certner.fr added reviewers for D40352: setusercontext(): Set priority from '~/.login_conf' as well: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:29 AM
olce.freebsd_certner.fr added reviewers for D40351: setusercontext(): Apply user login context only on process' euid being set: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:28 AM
olce.freebsd_certner.fr added reviewers for D40350: setusercontext(): Move priority setting in new setclasspriority(): kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:28 AM
olce.freebsd_certner.fr added reviewers for D40349: setusercontext(): Only set priority if explicit in the login class specification: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:27 AM
olce.freebsd_certner.fr added reviewers for D40347: login.conf(5): Default values under "Default", elaborate on absence of such: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:26 AM
olce.freebsd_certner.fr added reviewers for D40346: setlogincontext(): Re-format to comply to style(9): kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:03 AM
olce.freebsd_certner.fr added reviewers for D40345: login.conf(5): umask has no default value: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:02 AM
olce.freebsd_certner.fr added reviewers for D40344: setusercontext(): umask: Set it only once (in the common case): kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:02 AM
olce.freebsd_certner.fr added reviewers for D40342: login_cap.c: Don't set errno to ERANGE on memory allocation failure: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 8:01 AM
olce.freebsd_certner.fr added reviewers for D40339: setusercontext(): Fix gap when setting a realtime-class priority: kib, mjg, yuripv, kevans, des.
Tue, Jun 6, 7:59 AM

Mon, Jun 5

olce.freebsd_certner.fr added a watcher for Contributor Reviews (src): olce.freebsd_certner.fr.
Mon, Jun 5, 4:26 PM
olce.freebsd_certner.fr added a watcher for vbox: olce.freebsd_certner.fr.
Mon, Jun 5, 4:24 PM

Wed, May 31

olce.freebsd_certner.fr updated the diff for D40352: setusercontext(): Set priority from '~/.login_conf' as well.

Good patch this time...

Wed, May 31, 4:53 PM
olce.freebsd_certner.fr updated the diff for D40352: setusercontext(): Set priority from '~/.login_conf' as well.

Yes, of course...

Wed, May 31, 4:52 PM
olce.freebsd_certner.fr updated the diff for D40351: setusercontext(): Apply user login context only on process' euid being set.

Clearer commit message's headling

Wed, May 31, 4:06 PM
olce.freebsd_certner.fr requested review of D40352: setusercontext(): Set priority from '~/.login_conf' as well.
Wed, May 31, 3:18 PM
olce.freebsd_certner.fr requested review of D40351: setusercontext(): Apply user login context only on process' euid being set.
Wed, May 31, 3:18 PM
olce.freebsd_certner.fr requested review of D40350: setusercontext(): Move priority setting in new setclasspriority().
Wed, May 31, 3:18 PM
olce.freebsd_certner.fr requested review of D40349: setusercontext(): Only set priority if explicit in the login class specification.
Wed, May 31, 3:18 PM
olce.freebsd_certner.fr updated the diff for D40339: setusercontext(): Fix gap when setting a realtime-class priority.

Original commit, with message untweaked by arc

Wed, May 31, 3:10 PM
olce.freebsd_certner.fr requested review of D40347: login.conf(5): Default values under "Default", elaborate on absence of such.
Wed, May 31, 2:35 PM
olce.freebsd_certner.fr requested review of D40346: setlogincontext(): Re-format to comply to style(9).
Wed, May 31, 2:34 PM
olce.freebsd_certner.fr requested review of D40345: login.conf(5): umask has no default value.
Wed, May 31, 2:31 PM
olce.freebsd_certner.fr requested review of D40344: setusercontext(): umask: Set it only once (in the common case).
Wed, May 31, 2:30 PM
olce.freebsd_certner.fr requested review of D40342: login_cap.c: Don't set errno to ERANGE on memory allocation failure.
Wed, May 31, 8:58 AM

Tue, May 30

olce.freebsd_certner.fr requested review of D40339: setusercontext(): Fix gap when setting a realtime-class priority.
Tue, May 30, 5:48 PM

Apr 26 2023

olce.freebsd_certner.fr updated the diff for D39775: vfs: Fix "emptydir" mount option.

Move a comment

Apr 26 2023, 1:43 PM
olce.freebsd_certner.fr updated the diff for D39775: vfs: Fix "emptydir" mount option.

Comments addressed.

Apr 26 2023, 1:40 PM
olce.freebsd_certner.fr updated the diff for D39764: vfs: Simplify and harden vn_dir_next_dirent().

Comments addressed.

Apr 26 2023, 1:39 PM

Apr 25 2023

olce.freebsd_certner.fr added a comment to D39784: VOP_CLOSE(): MNTK_EXTENDED_SHARED filesystems do not need excl lock.

FWIW, I've checked these filesystems as well and I concur. I've also tested the patch with a parallel buildkernel and several find processes repeatedly cating files in /usr/obj without problems.

Apr 25 2023, 2:17 PM
olce.freebsd_certner.fr updated the diff for D39775: vfs: Fix "emptydir" mount option.

Comments addressed.

Apr 25 2023, 10:10 AM
olce.freebsd_certner.fr added inline comments to D39764: vfs: Simplify and harden vn_dir_next_dirent().
Apr 25 2023, 10:07 AM
olce.freebsd_certner.fr updated the diff for D39764: vfs: Simplify and harden vn_dir_next_dirent().

Comments addressed.

Apr 25 2023, 10:06 AM

Apr 24 2023

olce.freebsd_certner.fr requested review of D39775: vfs: Fix "emptydir" mount option.
Apr 24 2023, 9:09 AM
olce.freebsd_certner.fr updated the diff for D39764: vfs: Simplify and harden vn_dir_next_dirent().

Now just contains the changes to vn_dir_next_dirent().

Apr 24 2023, 9:07 AM
olce.freebsd_certner.fr updated the diff for D39755: vfs: Export get_next_dirent() as vn_dir_next_dirent().

Further diff simplification

Apr 24 2023, 9:04 AM
olce.freebsd_certner.fr updated the diff for D39755: vfs: Export get_next_dirent() as vn_dir_next_dirent().

Keep just the move and rename. Next commits to be added as child revisions.

Apr 24 2023, 8:49 AM

Apr 22 2023

olce.freebsd_certner.fr requested review of D39764: vfs: Simplify and harden vn_dir_next_dirent().
Apr 22 2023, 9:28 PM
olce.freebsd_certner.fr updated the diff for D39755: vfs: Export get_next_dirent() as vn_dir_next_dirent().

Change summary

Apr 22 2023, 9:23 PM
olce.freebsd_certner.fr added a comment to D39755: vfs: Export get_next_dirent() as vn_dir_next_dirent().

I've also changed a bit the initial diff so as to minimize differences (order of declarations).

Apr 22 2023, 4:35 PM
olce.freebsd_certner.fr updated the diff for D39755: vfs: Export get_next_dirent() as vn_dir_next_dirent().

Keep just the get_next_dirent() => vfs_next_dirent() refactoring

Apr 22 2023, 4:28 PM

Apr 21 2023

olce.freebsd_certner.fr requested review of D39755: vfs: Export get_next_dirent() as vn_dir_next_dirent().
Apr 21 2023, 9:14 PM

Jan 19 2023

olce.freebsd_certner.fr accepted D38108: man9: Add an smr(9) manual page.
Jan 19 2023, 4:56 PM
olce.freebsd_certner.fr attached a referenced file: F55028602: share_man_man9_smr.9.diff.
Jan 19 2023, 3:52 PM
olce.freebsd_certner.fr added a comment to D38108: man9: Add an smr(9) manual page.

I attached a diff to smr.9 only applying to your latest revision:

.

Jan 19 2023, 3:52 PM
olce.freebsd_certner.fr added a comment to D38108: man9: Add an smr(9) manual page.

Thanks. I have two further nitpicks. Otherwise, LGTM.

Jan 19 2023, 3:48 PM
olce.freebsd_certner.fr attached a referenced file: F55016095: D38108-oc.diff.
Jan 19 2023, 10:19 AM
olce.freebsd_certner.fr added a comment to D38108: man9: Add an smr(9) manual page.

To ease things, I've uploaded a new diff for the whole review that includes proposed changes:

.

Jan 19 2023, 10:19 AM
olce.freebsd_certner.fr added a comment to D38108: man9: Add an smr(9) manual page.

Hi Mark,

Jan 19 2023, 9:16 AM

Dec 2 2022

olce.freebsd_certner.fr abandoned D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.
Dec 2 2022, 9:01 AM

Oct 18 2022

olce.freebsd_certner.fr added a comment to D36950: disable sendmail with variables specified in rc.sendmail(8).

At this point in time, it might be easier to revert d87e0e8e230495df3be59a8a5c173aafc83bc450 😓

Oct 18 2022, 10:32 AM

May 5 2021

olce.freebsd_certner.fr added a comment to D29902: headers: Implement _ISOC11_SOURCES macro when __POSIX_C_SOURCE defined.
In D29902#676065, @imp wrote:

After consulting with the OpenBSD folk and not hearing from Wollman,
I've reconsidered. I have become convinced that the OpenBSD and glibc
practice is the best way to resolve the ambiguity.

May 5 2021, 9:58 AM

Apr 22 2021

olce.freebsd_certner.fr added inline comments to D29902: headers: Implement _ISOC11_SOURCES macro when __POSIX_C_SOURCE defined.
Apr 22 2021, 4:04 PM
olce.freebsd_certner.fr added a comment to D29902: headers: Implement _ISOC11_SOURCES macro when __POSIX_C_SOURCE defined.

In particular, POSIX allows an implementation to define any feature test macro they wish. There is no need that they are standardized.

This is exactly what we're doing here. We're just choosing to follow the glibc practice as prior art.

Apr 22 2021, 3:57 PM
olce.freebsd_certner.fr added inline comments to D29902: headers: Implement _ISOC11_SOURCES macro when __POSIX_C_SOURCE defined.
Apr 22 2021, 8:24 AM
olce.freebsd_certner.fr added a comment to D29902: headers: Implement _ISOC11_SOURCES macro when __POSIX_C_SOURCE defined.

Please see my latest comment in bug #255290.

Apr 22 2021, 8:22 AM

Mar 11 2021

olce.freebsd_certner.fr added a comment to D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.
In D28946#653518, @bapt wrote:

So as we have discussed on irc, while I do like the proprosal here, I wonder if it will be very useful and I am more and more thinking we should just rely on RESTRICTED for that, meaning the packages will not be distributed, and only people who knows how to use the ports can install them. It also means than anything that just build depends on python2 stuff will still be built on the packages and distributed.

Mar 11 2021, 9:38 AM

Mar 5 2021

olce.freebsd_certner.fr added a comment to D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.

So, to recap:

  1. NORUNTIME is a file independent from any ports' files listing ports that cannot be runtime

dependencies (to any other ports) after some specific date.

  1. The modifications in do-depends.sh ensure that the dependency step will fail when depending on

forbidden ports. So port building will simply hard fail when it's the case.

  1. The modifications of bsd.port.mk will set DEPRECATED and EXPIRATION_DATE (as explained above)

according to forbidden runtime dependencies. AFAIK, this is an advisory mechanism only.

Mar 5 2021, 4:12 PM
olce.freebsd_certner.fr updated the diff for D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.

Set DEPRECATED and EXPIRATION_DATE if appropriate

Mar 5 2021, 3:56 PM
olce.freebsd_certner.fr updated the diff for D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.

Fix awk expression to exclude comment lines

Mar 5 2021, 3:39 PM
olce.freebsd_certner.fr updated the diff for D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.

Date is expiration date, regexp support removal, read NORUNTIME only once

Mar 5 2021, 11:44 AM

Mar 2 2021

olce.freebsd_certner.fr added a comment to D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports.

about the format, why adding a pattern matching? exact match should be enough I think and would simplify the script

Mar 2 2021, 5:10 PM

Feb 26 2021

olce.freebsd_certner.fr published D28946: Ports infra: Support for forbidding non-runtime dependencies on specific ports for review.
Feb 26 2021, 6:38 PM