Good patch this time...

Yes, of course...

Clearer commit message's headling

Original commit, with message untweaked by arc

Move a comment

Comments addressed.

Comments addressed.

FWIW, I've checked these filesystems as well and I concur. I've also tested the patch with a parallel buildkernel and several find processes repeatedly cating files in /usr/obj without problems.

Comments addressed.

Comments addressed.

Now just contains the changes to vn_dir_next_dirent().

Further diff simplification

Keep just the move and rename. Next commits to be added as child revisions.

Change summary

I've also changed a bit the initial diff so as to minimize differences (order of declarations).

Keep just the get_next_dirent() => vfs_next_dirent() refactoring

I attached a diff to smr.9 only applying to your latest revision:

Thanks. I have two further nitpicks. Otherwise, LGTM.

To ease things, I've uploaded a new diff for the whole review that includes proposed changes:

Hi Mark,

In D36950#839671, @jlduran_gmail.com wrote:

At this point in time, it might be easier to revert d87e0e8e230495df3be59a8a5c173aafc83bc450 😓

In D29902#676065, @imp wrote:

After consulting with the OpenBSD folk and not hearing from Wollman,
I've reconsidered. I have become convinced that the OpenBSD and glibc
practice is the best way to resolve the ambiguity.

In particular, POSIX allows an implementation to define any feature test macro they wish. There is no need that they are standardized.

This is exactly what we're doing here. We're just choosing to follow the glibc practice as prior art.

Please see my latest comment in bug #255290.

In D28946#653518, @bapt wrote:

So as we have discussed on irc, while I do like the proprosal here, I wonder if it will be very useful and I am more and more thinking we should just rely on RESTRICTED for that, meaning the packages will not be distributed, and only people who knows how to use the ports can install them. It also means than anything that just build depends on python2 stuff will still be built on the packages and distributed.

So, to recap:

1. NORUNTIME is a file independent from any ports' files listing ports that cannot be runtime

dependencies (to any other ports) after some specific date.

2. The modifications in do-depends.sh ensure that the dependency step will fail when depending on

forbidden ports. So port building will simply hard fail when it's the case.

3. The modifications of bsd.port.mk will set DEPRECATED and EXPIRATION_DATE (as explained above)

according to forbidden runtime dependencies. AFAIK, this is an advisory mechanism only.

Set DEPRECATED and EXPIRATION_DATE if appropriate

Fix awk expression to exclude comment lines

Date is expiration date, regexp support removal, read NORUNTIME only once

about the format, why adding a pattern matching? exact match should be enough I think and would simplify the script