Page MenuHomeFreeBSD

nonesuch_longcount.org (Mark Saad)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2018, 4:04 AM (18 w, 3 d)

Recent Activity

Sep 25 2018

nonesuch_longcount.org added a comment to D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.

Kristof

I want to stop this patch. I can not find any way to make it trigger. I feel that this condition was added to openbsd only to deal with a potential edge case . I can not find any way to make it trigger.
Sep 25 2018, 3:53 PM

Aug 30 2018

nonesuch_longcount.org added a comment to D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.

All

After reviewing the original OpenBSD version and talking to one of the authors of the change . I better understand what is going on here.
Aug 30 2018, 9:26 PM
nonesuch_longcount.org added a comment to D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.
Aug 30 2018, 3:06 PM

Aug 10 2018

nonesuch_longcount.org accepted D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.
Aug 10 2018, 5:36 PM
nonesuch_longcount.org added inline comments to D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.
Aug 10 2018, 5:35 PM
nonesuch_longcount.org updated the diff for D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.

This diff removed the extraneous comments and simplified the flowid assignment with use of M_HASHTYPE_OPAQUE_HASH

Aug 10 2018, 5:35 PM

Aug 7 2018

nonesuch_longcount.org added a comment to D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.

The 10-STABLE series of mbuf.h does not define a M_HASHTYPE_OPAQUE_HASH just a M_HASHTYPE_OPAQUE . Should I change the patch to work with 10 and make a new for 11 and on where opaque_hash exists ?
Here is a patch updated for the comments above that uses M_HASHTYPE_OPAQUE in place of M_HASHTYPE_OPAQUE_HASH ?

Aug 7 2018, 12:46 PM
nonesuch_longcount.org added a comment to D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.

Kristof , I am going to retest using the simplified patch. Do I need to resubmit it in this form ?

Aug 7 2018, 12:24 PM
nonesuch_longcount.org created D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD.
Aug 7 2018, 4:17 AM