Page MenuHomeFreeBSD

noah.bergbauer_tum.de (Noah Bergbauer)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 17 2019, 7:42 PM (176 w, 3 d)

Recent Activity

May 31 2020

noah.bergbauer_tum.de added a comment to D24988: Improve D23300.

Also, there is a reason msbuild is to not be used for any reason: it not only does but will break. msbuild has never been tested beyond "yes, everything went terribly." It has never been in CI and will never be in CI, either. All CI and unit testing is done with monolite. msbuild is just a thing that exists.

May 31 2020, 9:34 AM

May 30 2020

noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Switch to ONLY_FOR_ARCHS as requested

May 30 2020, 10:15 AM

May 29 2020

noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Fix portlint issues for lang/mono

May 29 2020, 6:02 PM
noah.bergbauer_tum.de added a comment to D24988: Improve D23300.

Do the same for lang/mono please.

May 29 2020, 5:23 PM
noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Fix portlint issues

May 29 2020, 1:57 PM

May 27 2020

noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Implement changes requested in review

May 27 2020, 4:08 PM
noah.bergbauer_tum.de added inline comments to D24988: Improve D23300.
May 27 2020, 2:51 PM

May 25 2020

noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Add msbuild patch

May 25 2020, 1:00 PM

May 24 2020

noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Update pkg-plist.powerpc as requested

May 24 2020, 9:59 PM
noah.bergbauer_tum.de added a comment to D24988: Improve D23300.

By the way, this breaks the devel/msbuild port, because the old msbuild version is not compatible with the newer compiler version. Given that it relies on pulling a plethora of binary dependencies from nuget anyways, there is arguably little point in having it actually compile msbuild. On Arch Linux there is a package that simply pulls in http://download.mono-project.com/repo/ubuntu/pool/main/m/msbuild/msbuild_16.5+xamarinxplat.2020.02.20.11.54-0xamarin2+ubuntu2004b1_all.deb (ubuntu package provided by the mono project). This runs just fine on FreeBSD with only two changes:

May 24 2020, 8:45 PM
noah.bergbauer_tum.de updated the diff for D24988: Improve D23300.

Actually update to the corret btls patch

May 24 2020, 8:32 PM
noah.bergbauer_tum.de requested review of D24988: Improve D23300.
May 24 2020, 8:12 PM

May 1 2019

noah.bergbauer_tum.de added a comment to D19227: geom: add feature: gconcat online append.

What is the status of this? Do you need me to split the changes? Would I need to create an entirely separate phabricator diff then?

May 1 2019, 12:30 PM

Mar 2 2019

noah.bergbauer_tum.de added inline comments to D19227: geom: add feature: gconcat online append.
Mar 2 2019, 12:04 PM
noah.bergbauer_tum.de updated the diff for D19227: geom: add feature: gconcat online append.

Feel free to break the change into multiple patches. The change to use a TAILQ could certainly be committed on its own as a "no functional change" diff.

Mar 2 2019, 12:04 PM

Feb 22 2019

noah.bergbauer_tum.de added inline comments to D19227: geom: add feature: gconcat online append.
Feb 22 2019, 1:10 AM
noah.bergbauer_tum.de updated the diff for D19227: geom: add feature: gconcat online append.

You're right, this should be a linked list. The only reason I went with the reallocation approach is that I wanted to touch as little code as possible to avoid new bugs. What I have now is a compromise: it leaves the old logic (allocate all list elements at creation, some of them are just invalid) untouched but it's still a list so append doesn't have to reallocate and fix pointers. I chose a TAILQ because the code assumes that the list is ordered so append has to insert at the tail.

Feb 22 2019, 1:08 AM

Feb 20 2019

noah.bergbauer_tum.de added inline comments to D19227: geom: add feature: gconcat online append.
Feb 20 2019, 9:01 AM

Feb 17 2019

noah.bergbauer_tum.de created D19227: geom: add feature: gconcat online append.
Feb 17 2019, 7:49 PM