User Details
- User Since
- Jul 5 2018, 7:23 PM (299 w, 18 h)
Aug 17 2018
- Addressed style(9) violations
- Moved percent busy color thresholds to #define per imp@
Aug 16 2018
I've made a few improvements based upon reviewer's feedback:
- Add microseconds to timestamp, fix lines longer than 80 chars, and update date in man page
- Update date in man page and remove unnecessary section about timestamp granularity, now that more timestamp granularity has been added
Jul 6 2018
Sure. I have no problem with that. How would you feel if I omit factional seconds if -I is >=1s, though?
- The existing logic is fairly ugly. It would be great to do a clean up pass. In particular I think all of the PRINTMSGs could be reduced to a few loops, if you define a format string array and an enabled array.
Agree this shouldn't be too hard to clean up a bit. I can work on this a bit while I'm on the road for the next few weeks. This should address the only inline comment that is not style-related as well.
- What happens if a new device arrives or one goes away while gstat -C is running?
I didn't try to be more or less clever than existing -b/-B modes. I actually can't remember the behavior of devices actually attaching or detaching, but if you specify the -a flag, devices will come and go from the CSV output, just as with the existing output modes. Actually, -a with -C will cause samples to be skipped entirely if there is no activity on the system.
Jul 5 2018
Attempting to fix mangled diff using arcanist