Page MenuHomeFreeBSD

nick_princi.pe (Nick Principe)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 5 2018, 7:23 PM (299 w, 18 h)

Recent Activity

Aug 17 2018

nick_princi.pe added inline comments to D16151: Add CSV output to gstat via -C flag.
Aug 17 2018, 1:01 AM
nick_princi.pe updated the diff for D16151: Add CSV output to gstat via -C flag.
  • Addressed style(9) violations
  • Moved percent busy color thresholds to #define per imp@
Aug 17 2018, 12:55 AM

Aug 16 2018

nick_princi.pe updated the diff for D16151: Add CSV output to gstat via -C flag.

I've made a few improvements based upon reviewer's feedback:

  • Add microseconds to timestamp, fix lines longer than 80 chars, and update date in man page
  • Update date in man page and remove unnecessary section about timestamp granularity, now that more timestamp granularity has been added
Aug 16 2018, 10:48 PM

Jul 6 2018

nick_princi.pe added a comment to D16151: Add CSV output to gstat via -C flag.

This change looks good. But I have a few overall concerns:

  • ISO-8601 allows fractional seconds, at least according to Wikipedia. That would improve -C's accuracy and usefulness.

Sure. I have no problem with that. How would you feel if I omit factional seconds if -I is >=1s, though?

  • The existing logic is fairly ugly. It would be great to do a clean up pass. In particular I think all of the PRINTMSGs could be reduced to a few loops, if you define a format string array and an enabled array.

Agree this shouldn't be too hard to clean up a bit. I can work on this a bit while I'm on the road for the next few weeks. This should address the only inline comment that is not style-related as well.

  • What happens if a new device arrives or one goes away while gstat -C is running?

I didn't try to be more or less clever than existing -b/-B modes. I actually can't remember the behavior of devices actually attaching or detaching, but if you specify the -a flag, devices will come and go from the CSV output, just as with the existing output modes. Actually, -a with -C will cause samples to be skipped entirely if there is no activity on the system.

Jul 6 2018, 4:40 PM

Jul 5 2018

nick_princi.pe added a comment to D16151: Add CSV output to gstat via -C flag.

I don't know what you did, but somehow you created this review as a bare diff without any context information. Did you upload the raw diff into reviews.freebsd.org or something? If you use the php5-arcanist command line tool instead, the review will include unchanged portions of the file. It's much easier to review that way.

Jul 5 2018, 10:25 PM
nick_princi.pe updated the diff for D16151: Add CSV output to gstat via -C flag.

Attempting to fix mangled diff using arcanist

Jul 5 2018, 10:22 PM
nick_princi.pe created D16151: Add CSV output to gstat via -C flag.
Jul 5 2018, 7:57 PM