Page MenuHomeFreeBSD

nick.hibma_gmail.com (Nick Hibma)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2015, 8:16 AM (436 w, 4 d)

Recent Activity

Mar 4 2021

nick.hibma_gmail.com added a comment to D29054: tests/sys/netgraph/ng_macfilter_test: Fix invalid TAP output.

is incorrect. It should be $(($TSTNR + 1)).

Mar 4 2021, 10:07 AM

Dec 13 2020

nick.hibma_gmail.com committed R9:04308caa4800: Added my name to the list of developers in the handbook (authored by nick.hibma_gmail.com).
Added my name to the list of developers in the handbook
Dec 13 2020, 8:00 PM
nick.hibma_gmail.com committed R9:78787eddc4fe: The underscore in n_hibma seems to break sgml, any idea how I can get (authored by nick.hibma_gmail.com).
The underscore in n_hibma seems to break sgml, any idea how I can get
Dec 13 2020, 8:00 PM
nick.hibma_gmail.com committed R9:e85972a0b2da: Added again my name to the hall of fame (authored by nick.hibma_gmail.com).
Added again my name to the hall of fame
Dec 13 2020, 8:00 PM

Nov 30 2020

nick.hibma_gmail.com updated the diff for D27268: New netgraph node: macfilter.

Final update incorporating all the changes.

Nov 30 2020, 11:19 AM

Nov 19 2020

nick.hibma_gmail.com updated the diff for D27268: New netgraph node: macfilter.

Change test to TAP and add to system tests (lwhsu).

Nov 19 2020, 2:10 PM

Nov 18 2020

nick.hibma_gmail.com added a comment to D27268: New netgraph node: macfilter.
In D27268#608971, @lutz_donnerhacke.de wrote:

Thank you for the work. In principle the functionality can be emulated by ng_bpf as well, but this kind of node is easier to use.

I'm curios about two things:

  • The only selecting criteria is the source mac, isn't it? Would it be difficult to match either by src or dst?
  • There is a static array of NG_MACFILTER_UPPER_NUM entries to remember the hooks for the node. Usually such limitations cause trouble in the medium time frame, so I'd ask you to think about getting rid of this array and use the hook traversal functions from the netgraph framework instead.

For the fine details, I'll need some more time. But at the first glance it looks very good. (Especially the test case.)

Nov 18 2020, 10:53 PM
nick.hibma_gmail.com updated the diff for D27268: New netgraph node: macfilter.

Implement suggested changes:

Nov 18 2020, 10:45 PM
nick.hibma_gmail.com added a comment to D27268: New netgraph node: macfilter.

Thanks. Removed all other checks as well as they are not being triggered either.
Nick Hibma
nick@van-laarhoven.org

Nov 18 2020, 10:00 PM
nick.hibma_gmail.com added a comment to D27268: New netgraph node: macfilter.

Who would be able to help me get that sorted out? The script as-is is starting to get convoluted.

Nov 18 2020, 9:53 PM
nick.hibma_gmail.com updated the diff for D27268: New netgraph node: macfilter.

Comment and copyright fixes (afedorov).

Nov 18 2020, 4:32 PM
nick.hibma_gmail.com updated the diff for D27268: New netgraph node: macfilter.

Remove unrelated change from this changeset.

Nov 18 2020, 3:24 PM
nick.hibma_gmail.com updated the diff for D27268: New netgraph node: macfilter.

Fixed all mandoc lint errors (bcr)

Nov 18 2020, 3:19 PM
nick.hibma_gmail.com requested review of D27268: New netgraph node: macfilter.
Nov 18 2020, 2:41 PM

Mar 5 2020

nick.hibma_gmail.com added a comment to D23972: change divert socket to use a sockaddr_div struct.

Thanks for reviewing.

Mar 5 2020, 9:49 PM
nick.hibma_gmail.com created D23972: change divert socket to use a sockaddr_div struct.
Mar 5 2020, 4:28 PM

Oct 3 2019

nick.hibma_gmail.com added a comment to D21886: Add USB support for location based device unit numbers.

There is people who expect the first serial device they plug-in to be ttyU0 (me for example) and there are people who would prefer the unit number to stay the same independent of the order the devices are detected (me as well).

Oct 3 2019, 7:27 PM

Dec 7 2015

nick.hibma_gmail.com accepted D4414: Set %esp correctly in the extended TSS..

This has been confirmed to fix our problem in VB VM as well as on an ALIX board.

Dec 7 2015, 10:22 AM