Page MenuHomeFreeBSD

neel_neelc.org (Neel Chauhan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2019, 2:36 PM (51 w, 6 d)

Recent Activity

Sun, Jul 12

neel_neelc.org requested review of D25637: Remove net.inet6.ip6.deembed_scopeid sysctl and assume the behavior of net.inet6.ip6.deembed_scopeid=1.
Sun, Jul 12, 6:27 PM

Fri, Jul 10

neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 5:09 PM · network
neel_neelc.org added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

This patch DOES reduce CPU usage, but not by 50%:

Fri, Jul 10, 5:09 PM · network
neel_neelc.org added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

The test output was a speedtest.net on a system behind IPFW NAT, but I looked at my test firewall box and realized the patch didn't apply.

Fri, Jul 10, 4:35 PM · network
neel_neelc.org updated the diff for D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Sure, fixed it.

Fri, Jul 10, 3:03 PM · network
neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 2:17 AM · network
neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 2:14 AM · network
neel_neelc.org updated the diff for D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Let's also do alias_proxy.c.

Fri, Jul 10, 12:42 AM · network
neel_neelc.org requested review of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Fri, Jul 10, 12:13 AM · network

Thu, Jul 9

neel_neelc.org updated the diff for D25595: In alter_nhop_from_info(), only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Good catch, reverting to my old diff.

Thu, Jul 9, 5:59 PM · network
neel_neelc.org updated the diff for D25595: In alter_nhop_from_info(), only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Thanks for the suggestion.

Thu, Jul 9, 4:11 PM · network

Wed, Jul 8

neel_neelc.org requested review of D25595: In alter_nhop_from_info(), only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Wed, Jul 8, 9:18 PM · network

Tue, Jul 7

neel_neelc.org updated subscribers of D25546: Transition from rtrequest1_fib() to rib_action().
Tue, Jul 7, 4:19 AM · network

Mon, Jul 6

neel_neelc.org updated the diff for D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Stop using memcpy here, instead use void pointers.

Mon, Jul 6, 10:11 PM · network
neel_neelc.org added a comment to D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Can you please explain, what the problem is?
Replacing a "struct assignment" by "memcpy" throws away several compile time checks while increasing the susceptibility to manual error.

Mon, Jul 6, 9:53 PM · network
neel_neelc.org updated the diff for D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Mon, Jul 6, 3:51 AM · network

Sat, Jul 4

neel_neelc.org added a project to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat: network.
Sat, Jul 4, 6:30 PM · network
neel_neelc.org added a project to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias: network.
Sat, Jul 4, 6:29 PM · network
neel_neelc.org added a comment to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.

Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.

Sat, Jul 4, 5:55 PM · network
neel_neelc.org added a comment to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.

Here, added the testing section.

Sat, Jul 4, 2:46 PM · network
neel_neelc.org updated the test plan for D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.
Sat, Jul 4, 2:46 PM · network

Fri, Jul 3

neel_neelc.org abandoned D25553: nfs: Unbreak build post-r362903.
Fri, Jul 3, 6:43 PM
neel_neelc.org updated the summary of D25553: nfs: Unbreak build post-r362903.
Fri, Jul 3, 2:42 AM
neel_neelc.org requested review of D25553: nfs: Unbreak build post-r362903.
Fri, Jul 3, 2:40 AM

Thu, Jul 2

neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Well, fixed the panics (which happened on BOOT on the first patch).

Thu, Jul 2, 5:34 AM · network
neel_neelc.org added a comment to D25546: Transition from rtrequest1_fib() to rib_action().

This patch currently panics and needs revision

Thu, Jul 2, 5:15 AM · network
neel_neelc.org requested review of D25546: Transition from rtrequest1_fib() to rib_action().
Thu, Jul 2, 4:43 AM · network

Mon, Jun 29

neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Made the changes.

Mon, Jun 29, 10:32 AM · network

Sun, Jun 28

neel_neelc.org added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

The Kyua log of my failing test is here: https://gist.github.com/neelchauhan/9e1ea12e0872f097294dc1f162b1a513

Sun, Jun 28, 8:00 PM
neel_neelc.org added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Unfortunately, I was unable to get test cases working. For some reason ICMP does not work in Kyua VNET jails. This is also why the other IPv6 forward/redirect tests fail as well.

Sun, Jun 28, 3:21 AM

Sat, Jun 27

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

This patch makes corrections to the man page and variable naming as mentioned by melifaro@ and 0mp@.

Sat, Jun 27, 8:45 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sorry for the delay.

Sat, Jun 27, 5:29 PM
neel_neelc.org added a reviewer for D25481: Fix build on 13-CURRENT post-r362666 (nvpair.c to bsd_nvpair.c rename).: imp.
Sat, Jun 27, 1:48 AM
neel_neelc.org requested review of D25481: Fix build on 13-CURRENT post-r362666 (nvpair.c to bsd_nvpair.c rename)..
Sat, Jun 27, 1:37 AM

Thu, Jun 25

neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jun 25, 10:35 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jun 25, 10:28 PM · network
neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Here's an updated diff.

Thu, Jun 25, 10:27 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jun 25, 10:26 PM · network
neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Good catch on the tidbits, here's an revised patch.

Thu, Jun 25, 4:12 PM · transport, network
neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Here, revised patch. Hope it is okay.

Thu, Jun 25, 3:24 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jun 25, 3:23 PM · network
neel_neelc.org requested review of D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Thu, Jun 25, 3:56 AM · network

Wed, Jun 24

neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Made the corrections.

Wed, Jun 24, 5:54 PM · transport, network
neel_neelc.org closed D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Wed, Jun 24, 4:58 PM · network
neel_neelc.org reclaimed D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Wed, Jun 24, 4:58 PM · network
neel_neelc.org abandoned D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.
Wed, Jun 24, 3:21 PM · network
neel_neelc.org reclaimed D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".
Wed, Jun 24, 3:02 PM · transport, network
neel_neelc.org abandoned D21923: netinet: In multicast/broadcast udp(6)_input(), compare the IP details after we lock inp as well.
Wed, Jun 24, 2:34 PM
neel_neelc.org abandoned D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".
Wed, Jun 24, 2:26 PM · transport, network
neel_neelc.org abandoned D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Wed, Jun 24, 2:26 PM · network
neel_neelc.org abandoned D24192: ipfw: add dst-mac/src-mac shorthands to do filtering based on source/destination MAC.
Wed, Jun 24, 2:23 PM · network
neel_neelc.org abandoned D22915: ipfw: Handle count > 1 in commit_rules().
Wed, Jun 24, 2:23 PM · network

Tue, Jun 23

neel_neelc.org added a project to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command: transport.
Tue, Jun 23, 8:47 PM · transport, network
neel_neelc.org added a project to D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6": transport.
Tue, Jun 23, 8:46 PM · transport, network
neel_neelc.org updated the diff for D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.

Done.

Tue, Jun 23, 3:04 PM · network
neel_neelc.org added a comment to D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.

Good catch.

Tue, Jun 23, 2:29 PM · network
neel_neelc.org updated the diff for D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.
Tue, Jun 23, 2:29 PM · network
neel_neelc.org updated the diff for D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.

I have a new patch making net.iflib.tx_update_freq a sysctl. I attempted to net.iflib.tx_update_freq=32 from 16 (without rebooting!) and it worked.

Tue, Jun 23, 4:57 AM · network
neel_neelc.org requested review of D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.
Tue, Jun 23, 3:26 AM · network
neel_neelc.org requested review of D25076: netinet6: Remove erroneous periods in scope6.c.
Tue, Jun 23, 3:25 AM · network
neel_neelc.org requested review of D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Tue, Jun 23, 3:22 AM · network
neel_neelc.org requested review of D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..
Tue, Jun 23, 3:21 AM · network
neel_neelc.org requested review of D24937: Add tunable net.iflib.tx_update_freq to set transmit descriptor update frequency.
Tue, Jun 23, 3:21 AM · network
neel_neelc.org updated the diff for D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().

Thanks for the suggestions. I have made the requested changes here.

Tue, Jun 23, 3:16 AM
neel_neelc.org requested review of D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().
Tue, Jun 23, 3:16 AM

Jun 9 2020

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sure, added the man pages.

Jun 9 2020, 5:21 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Yeah, the scopes. In the else{} statement we get and check the scopes, but not in the new ones I made. I moved in6_splitscope() earlier so my new statements can use it also.

Jun 9 2020, 4:14 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Good catch! Try this patch with the added "hlim = in6_selecthlim(NULL, ifp);".

Jun 9 2020, 2:51 PM

Jun 7 2020

neel_neelc.org added a comment to D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".

I'm not a committer (I'm also not neel@), could someone please commit this?

Jun 7 2020, 11:54 PM · transport, network
neel_neelc.org added a comment to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

I'm not a committer (I'm also not neel@), could someone please commit this?

Jun 7 2020, 11:53 PM · transport, network
neel_neelc.org retitled D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls from Introduce net.inet6.icmp6.reply_from_interface and \"net.inet.icmp.reply_src" sysctls to Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.
Jun 7 2020, 11:09 PM
neel_neelc.org requested review of D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.
Jun 7 2020, 11:06 PM

Jun 1 2020

neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

Should I sequence the key into "symmetrical RSS" where the first 32 bits == the next 32 bits, and all subsequent 16 bits chunks are equal?. Or is it something else?

Jun 1 2020, 6:00 PM · csprng, network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..
In D24989#552576, @avg wrote:

I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?

Jun 1 2020, 4:29 PM · csprng, network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

I believe Linux just uses random keys:

Jun 1 2020, 4:27 PM · csprng, network

May 31 2020

neel_neelc.org added a comment to D24991: netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware.

Sorry for the delay, I filled in the testing section.

May 31 2020, 10:03 PM · network
neel_neelc.org updated the test plan for D24991: netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware.
May 31 2020, 10:03 PM · network
neel_neelc.org abandoned D25076: netinet6: Remove erroneous periods in scope6.c.
May 31 2020, 9:34 PM · network

May 30 2020

neel_neelc.org updated the diff for D24989: netinet: Generate a random RSS key on boot..

@cem thanks for the comments.

May 30 2020, 9:55 PM · csprng, network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

@kevans thanks for the suggestion, I added csprng to this thread.

May 30 2020, 8:53 PM · csprng, network
neel_neelc.org added a reviewer for D24989: netinet: Generate a random RSS key on boot.: csprng.
May 30 2020, 8:53 PM · csprng, network
neel_neelc.org added inline comments to D24989: netinet: Generate a random RSS key on boot..
May 30 2020, 8:04 PM · csprng, network
neel_neelc.org added a project to D25076: netinet6: Remove erroneous periods in scope6.c: network.
May 30 2020, 7:52 PM · network

May 24 2020

neel_neelc.org requested review of D24991: netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware.
May 24 2020, 11:27 PM · network
neel_neelc.org added a comment to D24989: netinet: Generate a random RSS key on boot..

Sure.

May 24 2020, 9:31 PM · csprng, network
neel_neelc.org requested review of D24989: netinet: Generate a random RSS key on boot..
May 24 2020, 8:58 PM · csprng, network

May 13 2020

neel_neelc.org added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

In this patch, "me4" is IPv4-only and "me" is dual-stack. It uses kernel opcodes, however.

Please go read my comment #1. I'll review this if I get time, but this is what is needed as far as opcodes to make me4 and me6 different

May 13 2020, 1:27 AM · network
neel_neelc.org updated the diff for D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

In this patch, "me4" is IPv4-only and "me" is dual-stack. It uses kernel opcodes, however.

May 13 2020, 12:06 AM · network
neel_neelc.org added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

What I meant is that "me4" also takes action on IPv6, it does not "block" it. The "block" means I tested with "deny".

May 13 2020, 12:05 AM · network

May 12 2020

neel_neelc.org added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Note: I did some testing and the patch does not work as intended. "me4" also blocks IPv6, so I'm rewriting it.

May 12 2020, 7:06 PM · network
neel_neelc.org updated the diff for D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Thanks for the suggestions, Lutz. I also removed an unneeded variable.

May 12 2020, 6:32 PM · network
neel_neelc.org updated the diff for D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Accidentally included a file from another patch. Sorry.

May 12 2020, 3:40 AM · network
neel_neelc.org updated the diff for D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

The fill_ip6() code is now in D24403,

May 12 2020, 3:33 AM · network

May 6 2020

neel_neelc.org abandoned D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

I will close this revision as the code being modified will get refactored out.

May 6 2020, 3:45 PM · network
neel_neelc.org updated the diff for D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

Makes complete sense, I didn't realize how complex my code has become.

May 6 2020, 12:57 AM · network

May 5 2020

neel_neelc.org updated the diff for D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

I have a revised patch which removes code duplication (as suggested by Lutz Donnerhacke).

May 5 2020, 8:43 PM · network
neel_neelc.org added a comment to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

Sure, fine with me.

May 5 2020, 4:18 AM · network

May 1 2020

neel_neelc.org added reviewers for D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6(): emaste, rgrimes.
May 1 2020, 6:39 PM

Apr 28 2020

neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Here, I resolve two of three of rgrimes' suggestions.

Apr 28 2020, 4:16 AM · transport, network
neel_neelc.org added a reviewer for D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst().: rgrimes.
Apr 28 2020, 1:06 AM · network