Page MenuHomeFreeBSD

neel_neelc.org (Neel Chauhan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2019, 2:36 PM (71 w, 2 d)

Recent Activity

Thu, Nov 12

neel_neelc.org updated the diff for D27112: WIP: Remove scope embedding in the lle/lltable code.

melifaro@ gave an explanation/clarification that this is much larger than originally anticipated. This patch is still a WIP, the RTAX_DST/RTAX_GATEWAY parts in rib_action() still needs to be done.

Thu, Nov 12, 3:44 AM

Wed, Nov 11

neel_neelc.org added a comment to D27112: WIP: Remove scope embedding in the lle/lltable code.

I do not see any mention of scopes in nhop_ctl (from your email), very less scope embedding. May I please know where the nexthop scope embedding code is located?

Wed, Nov 11, 5:37 AM
neel_neelc.org updated the diff for D27112: WIP: Remove scope embedding in the lle/lltable code.

Here's revision 2.

Wed, Nov 11, 5:11 AM

Sun, Nov 8

neel_neelc.org abandoned D27137: malloc: Allow falling back to legacy magic number on platforms which require it.

This might have been an issue with the VirtualBox kernel module. Closing.

Sun, Nov 8, 5:50 AM
neel_neelc.org added a comment to D27137: malloc: Allow falling back to legacy magic number on platforms which require it.

Panic screenshot: https://imgur.com/a/3dVHlwy

Sun, Nov 8, 5:40 AM
neel_neelc.org requested review of D27137: malloc: Allow falling back to legacy magic number on platforms which require it.
Sun, Nov 8, 5:39 AM

Fri, Nov 6

neel_neelc.org requested review of D27112: WIP: Remove scope embedding in the lle/lltable code.
Fri, Nov 6, 3:42 AM

Oct 16 2020

neel_neelc.org updated the diff for D26755: Add hash table lookup for IPv6 raw sockets..

Don't invent my own IPv6 hash when one already exists.

Oct 16 2020, 9:44 PM
neel_neelc.org updated the diff for D26755: Add hash table lookup for IPv6 raw sockets..

Made the changes, here.

Oct 16 2020, 9:16 PM
neel_neelc.org added inline comments to D26755: Add hash table lookup for IPv6 raw sockets..
Oct 16 2020, 8:53 PM

Oct 15 2020

neel_neelc.org updated the diff for D26755: Add hash table lookup for IPv6 raw sockets..

Sure, done. Thanks for the pointers, @bz and @melifaro!

Oct 15 2020, 3:15 AM

Oct 14 2020

neel_neelc.org added a comment to D26755: Add hash table lookup for IPv6 raw sockets..

The reason for doing this is that the performance of raw IPv6 sockets is improved, like it was for IPv4 here: https://svnweb.freebsd.org/base?view=revision&revision=180828

Oct 14 2020, 7:15 PM

Oct 13 2020

neel_neelc.org requested review of D26755: Add hash table lookup for IPv6 raw sockets..
Oct 13 2020, 1:50 AM

Oct 12 2020

neel_neelc.org abandoned D24989: netinet: Generate a random RSS key on boot..
Oct 12 2020, 10:40 PM · csprng, network
neel_neelc.org abandoned D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.
Oct 12 2020, 10:39 PM · network
neel_neelc.org abandoned D26745: use getaddrinfo() instead of gethostbyname() in sbin/routed/rtquery/rtquery.c.
Oct 12 2020, 10:39 PM
neel_neelc.org abandoned D26744: Use getaddrinfo() instead of gethostbyname() in sbin/ggate/shared/ggate.c.
Oct 12 2020, 10:38 PM

Oct 11 2020

neel_neelc.org abandoned D23794: nat64lsn: When allocating, check if we already allocated pg in nat64lsn_alloc_pg().
Oct 11 2020, 10:30 PM · network
neel_neelc.org requested review of D26745: use getaddrinfo() instead of gethostbyname() in sbin/routed/rtquery/rtquery.c.
Oct 11 2020, 10:29 PM
neel_neelc.org requested review of D26744: Use getaddrinfo() instead of gethostbyname() in sbin/ggate/shared/ggate.c.
Oct 11 2020, 10:15 PM

Sep 8 2020

neel_neelc.org requested review of D26359: emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and bridge mode..
Sep 8 2020, 3:31 PM · vbox

Aug 31 2020

neel_neelc.org requested review of D26249: style: Remove erroneous space in rtsock.c.
Aug 31 2020, 2:49 PM

Aug 25 2020

neel_neelc.org added a comment to D26183: ZFS: Unbreak the world build on CURRENT with the OpenZFS import.

Yes.

Aug 25 2020, 11:19 PM · ZFS
neel_neelc.org added a comment to D26183: ZFS: Unbreak the world build on CURRENT with the OpenZFS import.

This is the error I get without the patch:

Aug 25 2020, 7:27 PM · ZFS
neel_neelc.org added a comment to D26183: ZFS: Unbreak the world build on CURRENT with the OpenZFS import.

This patch fixes the build issue complaining about:

Aug 25 2020, 7:15 PM · ZFS
neel_neelc.org retitled D26183: ZFS: Unbreak the world build on CURRENT with the OpenZFS import from ZFS: Unbreak the lz4 build on CURRENT with the OpenZFS import to ZFS: Unbreak the world build on CURRENT with the OpenZFS import.
Aug 25 2020, 5:47 PM · ZFS
neel_neelc.org requested review of D26183: ZFS: Unbreak the world build on CURRENT with the OpenZFS import.
Aug 25 2020, 5:42 PM · ZFS
neel_neelc.org updated the diff for D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..

Thanks for the clarification.

Aug 25 2020, 4:27 PM · network
neel_neelc.org updated the diff for D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..

Good catch.

Aug 25 2020, 3:41 PM · network
neel_neelc.org added a comment to D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..

Thanks for approving this.

Aug 25 2020, 3:14 PM · network

Aug 20 2020

neel_neelc.org added a comment to D26126: style: Fix function spacing for for icmp6type_match() and flow6id_match() in ip_fw2.c.

Thanks for the approvals!

Aug 20 2020, 4:53 PM · network

Aug 19 2020

neel_neelc.org retitled D26126: style: Fix function spacing for for icmp6type_match() and flow6id_match() in ip_fw2.c from style: Fix function spacing in ip_fw2.c to style: Fix function spacing for for icmp6type_match() and flow6id_match() in ip_fw2.c.
Aug 19 2020, 11:00 PM · network
neel_neelc.org requested review of D26126: style: Fix function spacing for for icmp6type_match() and flow6id_match() in ip_fw2.c.
Aug 19 2020, 11:00 PM · network

Aug 9 2020

neel_neelc.org updated the diff for D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

Here's the updated diff.

Aug 9 2020, 8:49 PM · wireless
neel_neelc.org added a comment to D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

Sounds good, will post a patch shortly.

Aug 9 2020, 8:48 PM · wireless
neel_neelc.org updated subscribers of D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().
Aug 9 2020, 7:18 PM · wireless
neel_neelc.org added a comment to D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().

Keep in mind that should this patch get approved, someone other than me will need to commit this.

Aug 9 2020, 7:18 PM · wireless
neel_neelc.org requested review of D26018: Methodize the TX power limit retrival in ieee80211_ioctl_get80211().
Aug 9 2020, 7:17 PM · wireless

Jul 26 2020

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sorry for the delay, but I got passing tests! This patch includes them.

Jul 26 2020, 5:48 AM

Jul 25 2020

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

With errors upon running rc.d, I realized that we should only do this when modifying.

Jul 25 2020, 3:43 AM · network

Jul 20 2020

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 20 2020, 4:18 PM · network
neel_neelc.org added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 20 2020, 4:18 PM · network

Jul 19 2020

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

I added tests, they all pass.

Jul 19 2020, 8:59 PM · network
neel_neelc.org added a comment to D25630: [net0211] Add new capabilities; restrict what can be done in a jail..

I think this broke the build on r363327 with if_an.

Jul 19 2020, 5:20 PM
neel_neelc.org requested review of D25723: if_an: Unbreak build with PRIV_NET80211_MANAGE->PRIV_NET80211_VAP_MANAGE rename.
Jul 19 2020, 5:18 PM

Jul 17 2020

neel_neelc.org added inline comments to D25546: Transition from rtrequest1_fib() to rib_action().
Jul 17 2020, 8:29 PM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Made some suggested revisions.

Jul 17 2020, 8:28 PM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().
Jul 17 2020, 4:49 AM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().
Jul 17 2020, 4:45 AM · network
neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Remove all variations of rtrequest (rtrequest1_fib, rtrequest_fib, in6_rtrequest, rtrequest_fib) as well.

Jul 17 2020, 2:49 AM · network
neel_neelc.org added a comment to D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

ce(4) for PCI G.703/E1 card,
cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards,
and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore,
removed by emaste@ recently.

Both ce(4) and cp(4) are i386-only drivers at present.

Such synchronous lines are still in use (here):

  • G.703 is common in phone systems.
  • X.21 for leased lines (with old contracts),
  • E1/E3 for SDH (carrier grade) leases lines.
  • RS-232 is the ordinary serial port, the other RS- are industry specific serials (mainly other voltages)

But you are right: Do we really need a specialized PPP hardware support these days?
Do we really want to run a recent kernel on this antique hardware? It would be a sacrilege.

Normal PPP over serial lines (currently available) does work using ppp(4)

Jul 17 2020, 1:07 AM · network, transport

Jul 16 2020

neel_neelc.org abandoned D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Jul 16 2020, 2:23 AM · network, transport
neel_neelc.org added a comment to D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

In case anybody is wondering, the source of the commit is here: https://freshbsd.org/commit/netbsd/src/hRr2tvIj1vj7QI2C

Jul 16 2020, 2:12 AM · network, transport
neel_neelc.org requested review of D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Jul 16 2020, 2:12 AM · network, transport
neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Here's the updated code, reduced to a single bitwise operator.

Jul 16 2020, 1:39 AM · network
neel_neelc.org added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 16 2020, 1:37 AM · network

Jul 12 2020

neel_neelc.org requested review of D25637: Remove net.inet6.ip6.deembed_scopeid sysctl and assume the behavior of net.inet6.ip6.deembed_scopeid=1.
Jul 12 2020, 6:27 PM

Jul 10 2020

neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Jul 10 2020, 5:09 PM · network
neel_neelc.org added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

This patch DOES reduce CPU usage, but not by 50%:

Jul 10 2020, 5:09 PM · network
neel_neelc.org added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

The test output was a speedtest.net on a system behind IPFW NAT, but I looked at my test firewall box and realized the patch didn't apply.

Jul 10 2020, 4:35 PM · network
neel_neelc.org updated the diff for D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Sure, fixed it.

Jul 10 2020, 3:03 PM · network
neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Jul 10 2020, 2:17 AM · network
neel_neelc.org updated the summary of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Jul 10 2020, 2:14 AM · network
neel_neelc.org updated the diff for D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Let's also do alias_proxy.c.

Jul 10 2020, 12:42 AM · network
neel_neelc.org requested review of D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Jul 10 2020, 12:13 AM · network

Jul 9 2020

neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Good catch, reverting to my old diff.

Jul 9 2020, 5:59 PM · network
neel_neelc.org updated the diff for D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.

Thanks for the suggestion.

Jul 9 2020, 4:11 PM · network

Jul 8 2020

neel_neelc.org requested review of D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 8 2020, 9:18 PM · network

Jul 7 2020

neel_neelc.org updated subscribers of D25546: Transition from rtrequest1_fib() to rib_action().
Jul 7 2020, 4:19 AM · network

Jul 6 2020

neel_neelc.org updated the diff for D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Stop using memcpy here, instead use void pointers.

Jul 6 2020, 10:11 PM · network
neel_neelc.org added a comment to D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Can you please explain, what the problem is?
Replacing a "struct assignment" by "memcpy" throws away several compile time checks while increasing the susceptibility to manual error.

Jul 6 2020, 9:53 PM · network
neel_neelc.org updated the diff for D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Jul 6 2020, 3:51 AM · network

Jul 4 2020

neel_neelc.org added a project to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat: network.
Jul 4 2020, 6:30 PM · network
neel_neelc.org added a project to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias: network.
Jul 4 2020, 6:29 PM · network
neel_neelc.org added a comment to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.

Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.

Jul 4 2020, 5:55 PM · network
neel_neelc.org added a comment to D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.

Here, added the testing section.

Jul 4 2020, 2:46 PM · network
neel_neelc.org updated the test plan for D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.
Jul 4 2020, 2:46 PM · network

Jul 3 2020

neel_neelc.org abandoned D25553: nfs: Unbreak build post-r362903.
Jul 3 2020, 6:43 PM
neel_neelc.org updated the summary of D25553: nfs: Unbreak build post-r362903.
Jul 3 2020, 2:42 AM
neel_neelc.org requested review of D25553: nfs: Unbreak build post-r362903.
Jul 3 2020, 2:40 AM

Jul 2 2020

neel_neelc.org updated the diff for D25546: Transition from rtrequest1_fib() to rib_action().

Well, fixed the panics (which happened on BOOT on the first patch).

Jul 2 2020, 5:34 AM · network
neel_neelc.org added a comment to D25546: Transition from rtrequest1_fib() to rib_action().

This patch currently panics and needs revision

Jul 2 2020, 5:15 AM · network
neel_neelc.org requested review of D25546: Transition from rtrequest1_fib() to rib_action().
Jul 2 2020, 4:43 AM · network

Jun 29 2020

neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Made the changes.

Jun 29 2020, 10:32 AM · network

Jun 28 2020

neel_neelc.org added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

The Kyua log of my failing test is here: https://gist.github.com/neelchauhan/9e1ea12e0872f097294dc1f162b1a513

Jun 28 2020, 8:00 PM
neel_neelc.org added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Unfortunately, I was unable to get test cases working. For some reason ICMP does not work in Kyua VNET jails. This is also why the other IPv6 forward/redirect tests fail as well.

Jun 28 2020, 3:21 AM

Jun 27 2020

neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

This patch makes corrections to the man page and variable naming as mentioned by melifaro@ and 0mp@.

Jun 27 2020, 8:45 PM
neel_neelc.org updated the diff for D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

Sorry for the delay.

Jun 27 2020, 5:29 PM
neel_neelc.org added a reviewer for D25481: Fix build on 13-CURRENT post-r362666 (nvpair.c to bsd_nvpair.c rename).: imp.
Jun 27 2020, 1:48 AM
neel_neelc.org requested review of D25481: Fix build on 13-CURRENT post-r362666 (nvpair.c to bsd_nvpair.c rename)..
Jun 27 2020, 1:37 AM

Jun 25 2020

neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 10:35 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 10:28 PM · network
neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Here's an updated diff.

Jun 25 2020, 10:27 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 10:26 PM · network
neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Good catch on the tidbits, here's an revised patch.

Jun 25 2020, 4:12 PM · transport, network
neel_neelc.org updated the diff for D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.

Here, revised patch. Hope it is okay.

Jun 25 2020, 3:24 PM · network
neel_neelc.org added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 3:23 PM · network
neel_neelc.org requested review of D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 3:56 AM · network

Jun 24 2020

neel_neelc.org updated the diff for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Made the corrections.

Jun 24 2020, 5:54 PM · transport, network
neel_neelc.org closed D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.
Jun 24 2020, 4:58 PM · network