Page MenuHomeFreeBSD

neel_neelc.org (Neel Chauhan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2019, 2:36 PM (31 w, 6 d)

Recent Activity

Yesterday

neel_neelc.org updated the diff for D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.
Mon, Feb 24, 1:17 AM · network
neel_neelc.org updated the summary of D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.
Mon, Feb 24, 12:29 AM · network
neel_neelc.org updated the diff for D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.

Here, I use inet_pton and inet_ntop. I didn't know this was possible in the kernel, so that's why the first revision lacked this.

Mon, Feb 24, 12:28 AM · network

Sat, Feb 22

neel_neelc.org created D23794: nat64lsn: When allocating, check if we already allocated pg in nat64lsn_alloc_pg().
Sat, Feb 22, 7:48 PM · network
neel_neelc.org updated the diff for D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.

Remove testing printfs.

Sat, Feb 22, 4:27 AM · network
neel_neelc.org retitled D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing from DRAFT: ng_ksocket IPv6 address parsing and unparsing to DRAFT: ng_ksocket: IPv6 address parsing and unparsing.
Sat, Feb 22, 4:25 AM · network
neel_neelc.org created D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.
Sat, Feb 22, 4:23 AM · network

Wed, Feb 19

neel_neelc.org updated the diff for D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

I decided to use the existing function nat64_extract_ip4() to extract the IPv4 and removed my nat64_get_ip4().

Wed, Feb 19, 4:33 PM · network

Tue, Feb 18

neel_neelc.org updated the diff for D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.
Tue, Feb 18, 4:38 PM · network
neel_neelc.org updated the diff for D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.

Here, I also compare the destination addresses. Is this what you want?

Tue, Feb 18, 4:25 PM · network

Mon, Feb 17

neel_neelc.org created D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate.
Mon, Feb 17, 9:43 PM · network
neel_neelc.org accepted D23727: netgraph/ng_one2many: Clarification in comments about copy mode.

Looks good to me.

Mon, Feb 17, 5:39 PM
neel_neelc.org abandoned D23721: ng_one2many: Don't duplicate packets with m_dup() when receiving and re-transmitting.
Mon, Feb 17, 2:36 PM
neel_neelc.org added a comment to D23721: ng_one2many: Don't duplicate packets with m_dup() when receiving and re-transmitting.

I'll give up on this.

Mon, Feb 17, 2:36 PM
neel_neelc.org updated the diff for D23721: ng_one2many: Don't duplicate packets with m_dup() when receiving and re-transmitting.

You make a good point.

Mon, Feb 17, 3:13 AM

Sun, Feb 16

neel_neelc.org created D23721: ng_one2many: Don't duplicate packets with m_dup() when receiving and re-transmitting.
Sun, Feb 16, 9:52 PM
neel_neelc.org updated the diff for D23577: divert: Add socket options divert socket send and receive buffers.

Here, I switch to using socket options.

Sun, Feb 16, 5:29 AM

Thu, Feb 13

neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

Here, I made changes to the:

Thu, Feb 13, 4:42 PM
neel_neelc.org updated the diff for D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.

I added the explanation in the man page.

Thu, Feb 13, 4:09 AM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

Here, I switch to the range separated by a - (e.g. 2000-2999 instead of 2000 3000), where the upper number is also included. On lines 611 and 668 in alias_db.c I added a " + 1" in order to account for the new range allocation mechanism.

Thu, Feb 13, 12:10 AM

Wed, Feb 12

neel_neelc.org added a comment to D23577: divert: Add socket options divert socket send and receive buffers.

divert(4) sockets can be used not only with natd(8), so the changes looks reasonable for me.

divert sockets can be used with other software but present exactly same significant overhead.
Do you have an example when suggested change improves performance really?

Wed, Feb 12, 4:20 PM
neel_neelc.org added a comment to D23577: divert: Add socket options divert socket send and receive buffers.

Please describe use case for this change. Also, defauls are not 65536 but (65536 + 100).

Wed, Feb 12, 5:42 AM
neel_neelc.org updated the summary of D23577: divert: Add socket options divert socket send and receive buffers.
Wed, Feb 12, 5:27 AM
neel_neelc.org updated subscribers of D23577: divert: Add socket options divert socket send and receive buffers.
Wed, Feb 12, 4:10 AM

Tue, Feb 11

neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.

Thanks for your feedback.

Tue, Feb 11, 8:57 PM

Mon, Feb 10

neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.

Sure, done that.

Mon, Feb 10, 3:03 PM

Sun, Feb 9

neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

Using long for the port parsing sounds good. Port numbers obviously can't be negative, neither than overflowed ints.

Sun, Feb 9, 11:04 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

Good catch. Fixed it.

Sun, Feb 9, 7:22 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.
Sun, Feb 9, 7:09 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

(Hopefully) fixed the interval and port parsing.

Sun, Feb 9, 7:05 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

Here's my updated patch.

Sun, Feb 9, 5:49 PM
neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.

I'm going to revert to the code to the one without the struct nat_port_range since it caused more problems than it's worth, especially with #include statements.

Sun, Feb 9, 5:30 PM

Sat, Feb 8

neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

Made the change.

Sat, Feb 8, 11:58 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

I made the requested changes.

Sat, Feb 8, 11:40 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

In the test, incoming connections are now based on their port, each NAT host gets their own port range.

Sat, Feb 8, 7:48 PM
neel_neelc.org updated the test plan for D23450: libalias: Allow setting alias port ranges.
Sat, Feb 8, 7:30 PM
neel_neelc.org added a comment to D23448: ipfw: Add missing mention of RFC 6598/Carrier Grade NAT in ipfw_config_nat().

Sorry for the late response, but yes, it is to fully enable the functionality.

Sat, Feb 8, 7:28 PM
neel_neelc.org updated the test plan for D23577: divert: Add socket options divert socket send and receive buffers.
Sat, Feb 8, 5:54 AM
neel_neelc.org created D23577: divert: Add socket options divert socket send and receive buffers.
Sat, Feb 8, 5:52 AM

Fri, Feb 7

neel_neelc.org added inline comments to D23450: libalias: Allow setting alias port ranges.
Fri, Feb 7, 4:14 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.
Fri, Feb 7, 4:13 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.
Fri, Feb 7, 4:11 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

I added an TCP test.

Fri, Feb 7, 4:07 AM

Thu, Feb 6

neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.

What still needs to be done with one test (port range) is a TCP client/server. It may or may not pass.

Thu, Feb 6, 12:40 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.

I have added a test.

Thu, Feb 6, 12:02 AM

Tue, Feb 4

neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.

Thanks for clarifying. I'm still new to FreeBSD TCP/IP stack development.

Tue, Feb 4, 7:07 PM
neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.

Correct me, if I'm wrong, but how are packets dealiased if more than one instance is defined using this patch?

Tue, Feb 4, 4:36 PM
neel_neelc.org added a comment to D23450: libalias: Allow setting alias port ranges.
In D23450#515674, @pi wrote:

What happens, if some port mapping is defined unexpected source IPs are sent from behind the CGN ? Will this packet/port end up 'somewhere' in the reserved range or will it map somewhere outside of all reserved ranges ?

In fact, this change provides no guarantees. It just makes NAT try using random port from configured range when looking for unused alias port. If such random port occurs to be occupied, another completely random ports outside of the range will be tried instead.

Tue, Feb 4, 3:15 PM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.
Tue, Feb 4, 5:34 AM
neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.
Tue, Feb 4, 5:31 AM

Mon, Feb 3

neel_neelc.org updated the diff for D23477: netgraph: If queue is full, don't enqueue in ng_source_rcvdata().

Sure, done so.

Mon, Feb 3, 8:11 PM
neel_neelc.org updated the diff for D23477: netgraph: If queue is full, don't enqueue in ng_source_rcvdata().

Sure, removed the comment

Mon, Feb 3, 1:51 PM
neel_neelc.org created D23477: netgraph: If queue is full, don't enqueue in ng_source_rcvdata().
Mon, Feb 3, 4:40 AM
neel_neelc.org updated the summary of D23365: libalias: Use correct case for GetNewPort in debug message in alias_db.c.
Mon, Feb 3, 4:33 AM

Sun, Feb 2

neel_neelc.org updated the diff for D21812: ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4.
Sun, Feb 2, 12:30 AM
neel_neelc.org created D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.
Sun, Feb 2, 12:18 AM

Sat, Feb 1

neel_neelc.org updated the diff for D23450: libalias: Allow setting alias port ranges.
Sat, Feb 1, 3:33 AM
neel_neelc.org created D23450: libalias: Allow setting alias port ranges.
Sat, Feb 1, 3:31 AM
neel_neelc.org updated the summary of D23448: ipfw: Add missing mention of RFC 6598/Carrier Grade NAT in ipfw_config_nat().
Sat, Feb 1, 2:46 AM
neel_neelc.org created D23448: ipfw: Add missing mention of RFC 6598/Carrier Grade NAT in ipfw_config_nat().
Sat, Feb 1, 2:44 AM

Jan 25 2020

neel_neelc.org created D23365: libalias: Use correct case for GetNewPort in debug message in alias_db.c.
Jan 25 2020, 11:34 PM
neel_neelc.org created D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.
Jan 25 2020, 3:12 AM

Jan 23 2020

neel_neelc.org added a comment to D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.

After this is committed, I plan to write tests based upon D23316.

Jan 23 2020, 4:29 PM

Jan 22 2020

neel_neelc.org added a comment to D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.

Nevermind, I think I'll skip the tests if this can be committed anyways.

Jan 22 2020, 3:15 AM

Jan 21 2020

neel_neelc.org requested review of D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Jan 21 2020, 4:47 AM
neel_neelc.org accepted D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Jan 21 2020, 4:46 AM
neel_neelc.org updated the diff for D21812: ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4.
Jan 21 2020, 4:43 AM
neel_neelc.org updated the diff for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Jan 21 2020, 4:42 AM
neel_neelc.org updated the diff for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Jan 21 2020, 4:40 AM
neel_neelc.org updated the diff for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.

Oops.

Jan 21 2020, 4:40 AM
neel_neelc.org updated the diff for D21812: ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4.
Jan 21 2020, 4:38 AM
neel_neelc.org updated the test plan for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Jan 21 2020, 2:31 AM
neel_neelc.org updated the test plan for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Jan 21 2020, 2:06 AM
neel_neelc.org added a comment to D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.

LGTM. Thank you for submitting the patch!
Could you please update the testing section of the review to show the actual tests?

Jan 21 2020, 1:59 AM

Jan 9 2020

neel_neelc.org updated the summary of D22318: net80211: Move rate printing in amrr_node_stats() to a separate method.
Jan 9 2020, 7:00 PM

Dec 26 2019

neel_neelc.org created D22929: devel/libgtop: Fix build on 13-CURRENT >= 1300062.
Dec 26 2019, 9:46 PM · gnome

Dec 24 2019

neel_neelc.org created D22915: ipfw: Handle count > 1 in commit_rules().
Dec 24 2019, 1:05 AM

Dec 23 2019

neel_neelc.org retitled D21812: ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4 from ipfw(8): Check for IPv4 in add_src() and add_dat, don't assume !IPv6 is IPv4 to ipfw(8): When checking for IPv4 in add_src() and add_dat(), don't assume !IPv6 is IPv4.
Dec 23 2019, 11:52 PM

Dec 20 2019

neel_neelc.org updated the diff for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.

Fix the ipfw man page typo.

Dec 20 2019, 1:59 PM

Dec 19 2019

neel_neelc.org updated the diff for D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Dec 19 2019, 6:52 PM
neel_neelc.org created D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.
Dec 19 2019, 6:20 PM

Dec 18 2019

neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

@dougm I uploaded your patch to GNOME GitLab here: https://gitlab.gnome.org/GNOME/libgtop/merge_requests/13

Dec 18 2019, 2:15 PM
neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

I'll offer your patch to GNOME's GitLab, but will give you credit as well.

Dec 18 2019, 2:09 PM
neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

Sounds good, lets go with your patch then.

Dec 18 2019, 12:15 AM

Dec 17 2019

neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

@dougm Your patch surely does look cleaner than mine (I just needed something to unbreak the build), but are you sure it will work on 12.x and 11.x? If so, lets go with yours.

Dec 17 2019, 10:49 PM
neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

I integrated your changes. Would the updated Ports/GNOME changes work?

Dec 17 2019, 6:38 PM
neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

I sent an updated patch to the GNOME people here: https://gitlab.gnome.org/GNOME/libgtop/merge_requests/12

Dec 17 2019, 4:04 PM
neel_neelc.org added a comment to D21964: Make vm_map a threaded tree.

@dougm Thanks for letting me know. I am working on an updated libgtop patch and will post it here (and at GNOME).

Dec 17 2019, 3:14 PM

Dec 8 2019

neel_neelc.org updated the diff for D22662: ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required..

Fixed the comment. Sorry about that.

Dec 8 2019, 12:45 PM

Dec 4 2019

neel_neelc.org updated the diff for D22662: ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required..
Dec 4 2019, 10:24 PM
neel_neelc.org updated the diff for D22662: ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required..

Here are the comments. Sorry if they aren't perfect.

Dec 4 2019, 8:15 PM
neel_neelc.org updated the diff for D22662: ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required..
Dec 4 2019, 12:08 AM

Dec 3 2019

neel_neelc.org retitled D22662: ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required. from Don't rollback state in alloc_table_vidx() if atomicity is not required. to ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required..
Dec 3 2019, 11:28 PM
neel_neelc.org created D22662: ipfw: Don't rollback state in alloc_table_vidx() if atomicity is not required..
Dec 3 2019, 11:27 PM

Nov 18 2019

neel_neelc.org added a comment to D22390: netmap: Check if we already ran mmap before we attempt it.

I was just grepping through the source tree for TODO occurrences and make patches from them.

Nov 18 2019, 11:07 PM

Nov 17 2019

neel_neelc.org updated the diff for D22390: netmap: Check if we already ran mmap before we attempt it.

Completely makes sense. New diff incorporates your recommended changes.

Nov 17 2019, 4:39 PM

Nov 15 2019

neel_neelc.org created D22390: netmap: Check if we already ran mmap before we attempt it.
Nov 15 2019, 7:27 PM

Nov 11 2019

neel_neelc.org created D22318: net80211: Move rate printing in amrr_node_stats() to a separate method.
Nov 11 2019, 7:48 PM

Oct 19 2019

neel_neelc.org updated the diff for D21923: netinet: In multicast/broadcast udp(6)_input(), compare the IP details after we lock inp as well.

Fixed the issue with full context and paths.

Oct 19 2019, 2:41 PM

Oct 18 2019

neel_neelc.org added inline comments to D21923: netinet: In multicast/broadcast udp(6)_input(), compare the IP details after we lock inp as well.
Oct 18 2019, 3:59 PM