Page MenuHomeFreeBSD

mqudsi_neosmart.net (Mahmoud Al-Qudsi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 24 2019, 5:23 PM (270 w, 16 h)

Recent Activity

Feb 8 2024

mqudsi_neosmart.net added a comment to D33671: kldxref: report errors and handle cross-device renames.

Thanks for the info! I can confirm that the patch in question addresses both the basic case and where there are different mount points under the top-level modules directory, each containing additional kernel modules.

Feb 8 2024, 4:55 PM

Jul 2 2023

mqudsi_neosmart.net added a comment to D33671: kldxref: report errors and handle cross-device renames.

@emaste do you mind taking a look and seeing if there's anything else this needs?

Jul 2 2023, 5:38 PM

Jun 23 2023

mqudsi_neosmart.net updated the diff for D33671: kldxref: report errors and handle cross-device renames.

Fixed reversed src/dst names in warning message when rename fails and its not EXDEV.

Jun 23 2023, 3:13 PM
mqudsi_neosmart.net added a comment to D33671: kldxref: report errors and handle cross-device renames.

@jrtc27 is there anything else you would like for me to do here?

Jun 23 2023, 2:59 PM

May 24 2023

mqudsi_neosmart.net added a comment to D33671: kldxref: report errors and handle cross-device renames.

@jrtc27 is there anything else you would like for me to do here?

May 24 2023, 12:59 AM

Feb 6 2023

mqudsi_neosmart.net updated the diff for D33671: kldxref: report errors and handle cross-device renames.

The copyfile helper function has been converted to void so that there are no ignored return codes.

Feb 6 2023, 10:50 PM
mqudsi_neosmart.net added inline comments to D33671: kldxref: report errors and handle cross-device renames.
Feb 6 2023, 10:08 PM
mqudsi_neosmart.net added a comment to D33671: kldxref: report errors and handle cross-device renames.

@emaste @jrtc27 is there anything else you would like for me to do here? I've checked and the attached diff still appears to apply cleanly against main. I'm not sure which future releases you would like to target this against; it is a fairly innocuous bugfix and it's hard to see any negative fallout from applying it across the board but I defer to your wisdom.

Feb 6 2023, 9:50 PM

Jan 6 2022

mqudsi_neosmart.net updated the diff for D33671: kldxref: report errors and handle cross-device renames.
Jan 6 2022, 6:37 PM
mqudsi_neosmart.net added inline comments to D33671: kldxref: report errors and handle cross-device renames.
Jan 6 2022, 6:37 PM
mqudsi_neosmart.net updated the diff for D33671: kldxref: report errors and handle cross-device renames.

Updated to address code review issues.

Jan 6 2022, 6:20 PM
mqudsi_neosmart.net added inline comments to D33671: kldxref: report errors and handle cross-device renames.
Jan 6 2022, 6:00 PM
mqudsi_neosmart.net added inline comments to D33671: kldxref: report errors and handle cross-device renames.
Jan 6 2022, 5:47 PM
mqudsi_neosmart.net added a reviewer for D33671: kldxref: report errors and handle cross-device renames: jrtc27.
Jan 6 2022, 5:18 PM
mqudsi_neosmart.net updated the diff for D33671: kldxref: report errors and handle cross-device renames.

Update per style(9) and ensure handling of partial copy_file_range() calls.

Jan 6 2022, 5:17 PM

Dec 31 2021

mqudsi_neosmart.net updated the diff for D33671: kldxref: report errors and handle cross-device renames.

Use warn() not err() to continue if possible.

Dec 31 2021, 1:26 AM

Dec 27 2021

mqudsi_neosmart.net requested review of D33671: kldxref: report errors and handle cross-device renames.
Dec 27 2021, 6:58 PM

Nov 30 2019

mqudsi_neosmart.net updated subscribers of D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.
Nov 30 2019, 5:59 AM
mqudsi_neosmart.net added a comment to D18613: Add driver for the VMware Paravirtual SCSI (pvscsi) controller.

Hot-add of the controller works but is followed by a scheduled hot-remove. This affects other VM pci devices as well.

Nov 30 2019, 5:58 AM

Oct 16 2019

mqudsi_neosmart.net added a comment to D20499: Only respond to Attention Button if device is already plugged in.

This works for VMware ESXi as well, where network card add/remove is directly mapped to PCIe hotplug.

Oct 16 2019, 1:50 AM

Jan 28 2019

mqudsi_neosmart.net added a comment to D18943: Correct maximum zstd compression level in bsdtar(1).

Thanks for the review.

Jan 28 2019, 9:11 PM

Jan 24 2019

mqudsi_neosmart.net created D18943: Correct maximum zstd compression level in bsdtar(1).
Jan 24 2019, 6:22 PM