Page MenuHomeFreeBSD

lutz_donnerhacke.de (Lutz Donnerhacke)
User

Projects

User Details

User Since
Sep 26 2019, 9:24 AM (51 w, 1 d)

Recent Activity

Today

lutz_donnerhacke.de added a comment to D26449: Stage 2: Introduce scalable route multipath.

Heavy patch, looks promising overall.

Fri, Sep 18, 6:02 AM

Mon, Sep 14

lutz_donnerhacke.de added a comment to D26420: New netgraph nodetype: ng_antispoof.

Does this match your requirements?

Yes, it absolutely does. Thank you very much!

Mon, Sep 14, 6:55 PM · network
lutz_donnerhacke.de added a comment to D26420: New netgraph nodetype: ng_antispoof.

To be honest, I did not recognize ng_bpf would do that. I will reevaluate my requirements based on that.

Mon, Sep 14, 7:03 AM · network
lutz_donnerhacke.de added a comment to D26420: New netgraph nodetype: ng_antispoof.

I had another look into ng_bpf and I still do not understand how to express the required directionality in a tcpdump filter.

Mon, Sep 14, 6:53 AM · network

Sun, Sep 13

lutz_donnerhacke.de requested changes to D26420: New netgraph nodetype: ng_antispoof.

Can you please explain, what your node has in favor of ng_bpf (which is scripted with an arbitrary tcpdump expression)?
Currently I see a lot of parsing complexity moving into the kernel, which lacks a lot of expressiveness.

Sun, Sep 13, 1:31 PM · network

Thu, Sep 10

lutz_donnerhacke.de added a comment to D26358: ipfw: fix compatibility with frag and older rule sets.
In D26358#586750, @ae wrote:

I think this patch is too complicated. Can you properly test this patch instead? https://people.freebsd.org/~ae/ipfw_frag.diff

Thu, Sep 10, 10:23 AM

Fri, Sep 4

lutz_donnerhacke.de accepted D26324: net: Mitigate vnet / epair cleanup races.
Fri, Sep 4, 4:00 PM

Aug 2 2020

lutz_donnerhacke.de accepted D25909: Fix handling of TTL/Hop Limit and TOS/Traffic Class in the TCP SYN Cache.
Aug 2 2020, 11:11 AM

Aug 1 2020

lutz_donnerhacke.de added inline comments to D25909: Fix handling of TTL/Hop Limit and TOS/Traffic Class in the TCP SYN Cache.
Aug 1 2020, 7:57 PM

Jul 30 2020

lutz_donnerhacke.de added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..
In D25873#573627, @np wrote:

Aren't we soon running out of flag bits in certain integer values?

Given that the inner flags mirror the outer ones, why not use a different variable inner_flags with the same set of flags?

That would work, but it would increase the size of struct mbuf.

Jul 30 2020, 8:17 PM
lutz_donnerhacke.de added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

Aren't we soon running out of flag bits in certain integer values?

Jul 30 2020, 12:47 PM

Jul 29 2020

lutz_donnerhacke.de added a comment to D25873: vxlan(4): Support for stateless NIC hardware offloads with VXLAN encapsulated traffic..

May you please consider splitting the patch into functional groups?

  • VXLAN HW capabilities
  • Spelling errors
  • Logic cleanup "xxx == 0" vs "!xxx"
  • style cleanup
Jul 29 2020, 9:33 AM

Jul 28 2020

lutz_donnerhacke.de accepted D25862: ng_iface(4): Remove unsupported protocols..

Thanks.

Jul 28 2020, 11:00 PM
lutz_donnerhacke.de added a comment to D25862: ng_iface(4): Remove unsupported protocols..

What's the reason behind this proposal?

Jul 28 2020, 8:32 PM
lutz_donnerhacke.de accepted D25789: NAT64: compute checksum for locally generated packets.
In D25789#572558, @2khramtsov_gmail.com wrote:

Improve test and do the same with kernel module as pf tests do.

Jul 28 2020, 12:34 PM
lutz_donnerhacke.de accepted D25788: ng_iface(4): Set the current VNET before calling netisr_dispatch()..

Thanks.

Jul 28 2020, 8:00 AM

Jul 27 2020

lutz_donnerhacke.de added inline comments to D25789: NAT64: compute checksum for locally generated packets.
Jul 27 2020, 6:07 PM

Jul 24 2020

lutz_donnerhacke.de added a comment to D22110: netgraph/ng_car: Add color marking code.

Ping

Jul 24 2020, 8:55 PM
lutz_donnerhacke.de updated the diff for D22140: netgraph/ng_tag: Variable length data can not be set for all length.

Revert errornous comparsion

Jul 24 2020, 8:53 PM
lutz_donnerhacke.de updated the diff for D22140: netgraph/ng_tag: Variable length data can not be set for all length.

Rebase to current

Jul 24 2020, 8:51 PM
lutz_donnerhacke.de accepted D25789: NAT64: compute checksum for locally generated packets.

Good work, thank you.
If possible convert your test into a real test file for regressions.

Jul 24 2020, 6:14 PM
lutz_donnerhacke.de added a comment to D25788: ng_iface(4): Set the current VNET before calling netisr_dispatch()..

In fact, for ng_iface it is possible for the node and ifnet VNETs to become out of sync: if I create two ng_iface interfaces and pass one into a jail, the node's VNET is not updated but the ifnet's VNET is updated.

Jul 24 2020, 6:04 PM
lutz_donnerhacke.de added a comment to D25788: ng_iface(4): Set the current VNET before calling netisr_dispatch()..

So - in order to handle this problem - the ng_iface node need to validate the incoming data messages and

  • supply the missing VNET information
  • overwrite(?) a wrong VNET information

Why is it not sufficient for ng_iface to simply set the current vnet in ng_iface_rcvdata()?

Jul 24 2020, 3:48 PM
lutz_donnerhacke.de requested changes to D25789: NAT64: compute checksum for locally generated packets.

Because the ABI break spans the kernel / userland barrier, the update procedure for the FreeBSD base system is harmed.
An old ipfw will send the old TOK_xxx values, which will be misinterpreted by a new kernel.
Please find a way to keep the old ipfw binary working during the upgrade.

Jul 24 2020, 8:15 AM
lutz_donnerhacke.de added a comment to D25789: NAT64: compute checksum for locally generated packets.

Thank you for your contribution, especially for using the documentation prefixes in your examples.
Because your test plan is so detailed, you may consider to write is as a regression test for constant revalidation.

Jul 24 2020, 8:09 AM
lutz_donnerhacke.de requested changes to D25788: ng_iface(4): Set the current VNET before calling netisr_dispatch()..

ng_tty is the wrong place for deciding this question. Almost any netgraph node is able to send data over a hook, most of them are VNET agnostic. The correct vnet depends on the context of the ng_iface node.

Jul 24 2020, 6:50 AM

Jul 20 2020

lutz_donnerhacke.de added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 20 2020, 7:45 AM · network

Jul 17 2020

lutz_donnerhacke.de added inline comments to D25546: Transition from rtrequest1_fib() to rib_action().
Jul 17 2020, 7:56 AM · network

Jul 16 2020

lutz_donnerhacke.de added a comment to D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

ce(4) for PCI G.703/E1 card,
cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards,
and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore,
removed by emaste@ recently.

Both ce(4) and cp(4) are i386-only drivers at present.

Jul 16 2020, 7:12 AM · network, transport
lutz_donnerhacke.de added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 16 2020, 6:14 AM · network

Jul 13 2020

lutz_donnerhacke.de added inline comments to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Jul 13 2020, 7:07 AM · network

Jul 11 2020

lutz_donnerhacke.de added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

I also have concerns over any performance claims, though I see the old code is probably at least sub optimal in that it often checks for UDP, then for TCP when the volume of traffic should almost always be mostly TCP.

Jul 11 2020, 9:03 PM · network

Jul 10 2020

lutz_donnerhacke.de added inline comments to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).
Jul 10 2020, 8:20 AM · network
lutz_donnerhacke.de added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

This will bring in a better coding style and improved readability.
But for the speed improvement, I'd like to see some evidence.

Jul 10 2020, 8:16 AM · network
lutz_donnerhacke.de added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 10 2020, 7:52 AM · network

Jul 9 2020

lutz_donnerhacke.de added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 9 2020, 7:43 AM · network

Jul 6 2020

lutz_donnerhacke.de added a comment to D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface.

May somebody with commit rights push this into the kernel and may have a kind look on my other open reviews ...

Jul 6 2020, 3:55 PM
lutz_donnerhacke.de added a comment to D23888: ipfw: Allow resolving of IPv6 DNS AAAA records in IPv6 table lookups.

Unbreak build on recent CURRENT by using memcpy.

Jul 6 2020, 5:56 AM · network

Jul 5 2020

lutz_donnerhacke.de added reviewers for D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface: network, melifaro.
Jul 5 2020, 12:45 PM
lutz_donnerhacke.de requested review of D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface.
Jul 5 2020, 12:43 PM

Jun 30 2020

lutz_donnerhacke.de added a comment to D25516: Allow some Bluetooth LE related HCI request by non-root user..

From the netgraph part, there is no objection.

Jun 30 2020, 8:45 AM

Jun 25 2020

lutz_donnerhacke.de added inline comments to D25445: Complete the fib<4|6>_lookup_nh_<basic|ext> -> fib<4|6>_lookup() transition.
Jun 25 2020, 3:49 PM · network
lutz_donnerhacke.de added inline comments to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.
Jun 25 2020, 6:38 AM · transport, network

Jun 23 2020

lutz_donnerhacke.de added a comment to D25075: netinet6: Don't calculate offset on ICMP6 NI query if the copied mbuf is null.

I'd suggest to stop processing at this place.

Jun 23 2020, 8:59 AM · network
lutz_donnerhacke.de accepted D25227: ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.

Good catch.

Jun 23 2020, 8:31 AM · network
lutz_donnerhacke.de added a comment to D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..

In RFC 6437 there is no rule, that flow labels are immutable for a given TCP session. It only notes in section 6.1, that changing the flow label within a TCP stream might be suspicious.
IPv6 flow labels are designed as QoS/routing indicators (like the DCSP field), which (in theory) might vary during the life time of the TCP session.

Jun 23 2020, 8:23 AM · network

Jun 9 2020

lutz_donnerhacke.de added a comment to D25181: Introduce net.inet6.icmp6.reply_from_interface and net.inet6.icmp6.reply_src sysctls.

May you be so kind as adding some lines into the man page, too?
Otherwise those are some more of the obscure sysctls, which are even not documented in the source code.

Jun 9 2020, 4:39 PM

Jun 2 2020

lutz_donnerhacke.de added a comment to D25029: Introduce ifconfig -a -[gG] groupname.

If I understand correctly

ifconfig -a -g lagg -G lagg*1

will match all lagg interfaces besides those ending in 1.

Jun 2 2020, 9:14 AM

May 30 2020

lutz_donnerhacke.de added a comment to D25029: Introduce ifconfig -a -[gG] groupname.
In D25029#551705, @ae wrote:

You can just use another option name to specify excludes.

Good point, -G would do it for negation.

May 30 2020, 5:31 PM

May 13 2020

lutz_donnerhacke.de accepted D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

In this patch, "me4" is IPv4-only and "me" is dual-stack. It uses kernel opcodes, however.

May 13 2020, 9:04 AM · network

May 12 2020

lutz_donnerhacke.de requested changes to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..
May 12 2020, 9:08 PM · network
lutz_donnerhacke.de added inline comments to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..
May 12 2020, 8:39 AM · network
lutz_donnerhacke.de added inline comments to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..
May 12 2020, 8:38 AM · network

May 9 2020

lutz_donnerhacke.de added a comment to D24781: Allow TCP to reuse local port with different destinations.

Can you point to existing implementations of this idea?
Several middle-ware boxes are prone to assumptions like one-port-one-connection.
I doubt, that this will work with i.e. restricted cone NAT (https://en.wikipedia.org/wiki/Network_address_translation)

May 9 2020, 9:14 PM

May 8 2020

lutz_donnerhacke.de added a comment to D24620: [bhyve] Add Netgraph network backend..

I'm still fine with the netgraph part.

May 8 2020, 5:43 PM

May 6 2020

lutz_donnerhacke.de added a comment to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.
In D24427#544221, @ae wrote:

JFYI, this code will be removed when refactoring to the epoch(9) will be finished.

May 6 2020, 7:34 AM · network
lutz_donnerhacke.de added a comment to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

"del" is a bad name for the running variable. I'd feel "prev" more appropriate.

May 6 2020, 7:33 AM · network
lutz_donnerhacke.de added inline comments to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.
May 6 2020, 7:13 AM · network

May 5 2020

lutz_donnerhacke.de added inline comments to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.
May 5 2020, 10:41 PM · network
lutz_donnerhacke.de requested changes to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.
May 5 2020, 7:08 AM · network

May 4 2020

lutz_donnerhacke.de accepted D24620: [bhyve] Add Netgraph network backend..

I assume, it is common practice to not explicitly assert(be != NULL) in each of the functions.

May 4 2020, 12:43 PM
lutz_donnerhacke.de added a comment to D24620: [bhyve] Add Netgraph network backend..

I tried the code generation with:

int testFP(int i) {
   return i*0.75;
}
May 4 2020, 12:02 PM
lutz_donnerhacke.de added a comment to D24620: [bhyve] Add Netgraph network backend..
In D24620#543377, @aleksandr.fedorov_itglobal.com wrote:
  • Change the "path" option to "relpath" to match the ngctl connect command.
May 4 2020, 11:15 AM

May 3 2020

lutz_donnerhacke.de accepted D24662: Simplify address parsing in DDB show route command..
May 3 2020, 12:45 AM

May 2 2020

lutz_donnerhacke.de added inline comments to D24662: Simplify address parsing in DDB show route command..
May 2 2020, 10:05 AM
lutz_donnerhacke.de added a comment to D24620: [bhyve] Add Netgraph network backend..

Your test defines a node named "vmbridge".

host# ngctl name ngeth0:ether vmbridge

and then referes to a node "vmbr"

host# sh vmrun.sh -c 4 -m 1024M -t netgraph:socket=vm0:path=vmbr:hook=vm0link:peerhook=link0 -d freebsd-0.img freebsd-0
May 2 2020, 9:59 AM

Apr 30 2020

lutz_donnerhacke.de added a comment to D24620: [bhyve] Add Netgraph network backend..
In D24620#542160, @aleksandr.fedorov_itglobal.com wrote:

If I understand correctly, you are adding code in the VM-setup (copied from ngctl) to create a ng_socket and connect it to a specified node (ng_bridge). Then you are using the data channel of the ng_socket to transmit Ethernet frames.

Yes. This is how bhyve network backends works. The guest OS sends / receives packets through the guest driver, bhyve processes them in user space and redirects them to the appropriate device using read / write / mmap system calls. Bhyve currently supports packet processing through /dev/tapX and /dev/netmap.

This review add support packet processing through ng_socket(4). I only know two useful ways to send/receive packets to/from the Netgraph network from the user space: ng_socket and ng_device (open /dev/ngdN and read/write).

Apr 30 2020, 4:44 PM

Apr 29 2020

lutz_donnerhacke.de added a comment to D24620: [bhyve] Add Netgraph network backend..

If I understand correctly, you are adding code in the VM-setup (copied from ngctl) to create a ng_socket and connect it to a specified node (ng_bridge). Then you are using the data channel of the ng_socket to transmit Ethernet frames.

Apr 29 2020, 5:59 PM
lutz_donnerhacke.de updated the diff for D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.

Fix issues in the code, i.e. bitfields are unsigned, spacing style, braces style.

Apr 29 2020, 3:06 PM
lutz_donnerhacke.de updated the diff for D23963: netgraph/ng_bridge: Introduce "uplink" ports without MAC learning.

Fix various man page issues.

Apr 29 2020, 3:02 PM

Apr 25 2020

lutz_donnerhacke.de accepted D24557: ng_eiface: fix kernel panic due to the racecondition in ng_eiface shutdown.
Apr 25 2020, 10:57 PM

Apr 23 2020

lutz_donnerhacke.de accepted D24524: libc: Shortcut if_indextoname() if index == 0.
Apr 23 2020, 10:57 AM

Apr 22 2020

lutz_donnerhacke.de added a comment to D24524: libc: Shortcut if_indextoname() if index == 0.

Is there really a typical use case for this call?

Apr 22 2020, 9:46 PM

Apr 16 2020

lutz_donnerhacke.de accepted D24447: pf: Do not allow negative ps_len in DIOCGETSTATES.
Apr 16 2020, 8:32 PM

Apr 14 2020

lutz_donnerhacke.de accepted D24403: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".
Apr 14 2020, 7:25 AM · transport, network

Apr 1 2020

lutz_donnerhacke.de accepted D24234: ipfw(8): Introduce src-ip4/dst-ip4 and src-ipv4/dst-ipv4 specifiers, make src-ip/dst-ip dual-stack.
Apr 1 2020, 7:58 AM · network

Mar 31 2020

lutz_donnerhacke.de accepted D24234: ipfw(8): Introduce src-ip4/dst-ip4 and src-ipv4/dst-ipv4 specifiers, make src-ip/dst-ip dual-stack.

What about src-ipv4? (for the sake of symmetry)
Somebody may think about "*ip" to accept both address families.

Mar 31 2020, 8:18 AM · network

Mar 26 2020

lutz_donnerhacke.de added inline comments to D24192: ipfw: add dst-mac/src-mac shorthands to do filtering based on source/destination MAC.
Mar 26 2020, 2:28 PM · network

Mar 25 2020

lutz_donnerhacke.de added a comment to D24179: ixl: Permit 802.1ad frames to pass though the chip.

Patch does work with 12-STABLE, too. (removing the NEEDGIANT flag)

Mar 25 2020, 9:31 AM

Mar 24 2020

lutz_donnerhacke.de updated the test plan for D24179: ixl: Permit 802.1ad frames to pass though the chip.
Mar 24 2020, 10:54 PM
lutz_donnerhacke.de added reviewers for D24179: ixl: Permit 802.1ad frames to pass though the chip: network, bz.
Mar 24 2020, 10:52 PM
lutz_donnerhacke.de created D24179: ixl: Permit 802.1ad frames to pass though the chip.
Mar 24 2020, 10:50 PM

Mar 21 2020

lutz_donnerhacke.de updated the diff for D21965: usr.sbin/ngctl: Generate more compact GraphWiz output.

Fixed spacing for "if (" statements.
Running the whole source through indent(1) would make a much larger patch.

Mar 21 2020, 8:27 PM

Mar 16 2020

lutz_donnerhacke.de added a comment to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

That would be my approach https://reviews.freebsd.org/differential/diff/69565/
I'd further eliminate the temporary storage "struct sockaddr_storage result", and copy directly from the gai result into the action (with memcpy).

Mar 16 2020, 10:46 AM · transport, network
lutz_donnerhacke.de requested changes to D23577: divert: Add socket options for divert socket's send and receive buffers.
Mar 16 2020, 9:40 AM
lutz_donnerhacke.de added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.

I tried to use the already existing socket infrastructure to change the socket buffer values ...

Mar 16 2020, 9:31 AM

Mar 14 2020

lutz_donnerhacke.de added inline comments to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..
Mar 14 2020, 9:39 PM · network

Mar 11 2020

lutz_donnerhacke.de added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Does this mean that for a current dual stack IPFW rule like:

allow tcp from any to me 443

It will only match for IPv4 packets, as "me" is only working with IPv4 addresses under the hood with the current behavior?
This is not the current behavior I'm observing since my web server answers IPv6 requests perfectly fine with my above rule.

Mar 11 2020, 7:50 PM · network
lutz_donnerhacke.de accepted D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Good catch.

Mar 11 2020, 1:28 PM · network

Mar 10 2020

lutz_donnerhacke.de added a comment to D23971: [bhyve][virtio-net] Add MTU advice support.

I have no idea why someone thinks a network device should have a minimum MTU of 1280, that is simply the IPv6 value, ethernet is very happy to transfer 64 byte packets. There should be some implementation detail of the in kernel vt driver that can at least go that small, and perhaps smaller as you do not have the collision detection minimum wire time that ethernet has(had).

Mar 10 2020, 7:41 PM
lutz_donnerhacke.de added a comment to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

How about detecting the port separator first? (i.e. repeatly call strpbrk)

Mar 10 2020, 7:57 AM · transport, network
lutz_donnerhacke.de added a comment to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

How about detecting the port separator first? (i.e. repeatly call strpbrk)
Then you can easily distinguish between the cases

  • starts with '[' -> numeric IPb6
  • contains ':' -> numeric IPv6
  • contains no letters -> numeric IPv4
  • use gai()
Mar 10 2020, 6:07 AM · transport, network

Mar 7 2020

lutz_donnerhacke.de added a comment to D21965: usr.sbin/ngctl: Generate more compact GraphWiz output.

Ping?

Mar 7 2020, 9:54 PM
lutz_donnerhacke.de added a comment to D22140: netgraph/ng_tag: Variable length data can not be set for all length.

Ping?

Mar 7 2020, 9:54 PM
lutz_donnerhacke.de added a comment to D21968: netgraph/ng_source: Allow ng_source to inject into any netgraph network.

Ping?

Mar 7 2020, 9:52 PM
lutz_donnerhacke.de added a comment to D23586: ipfw_nat: Perfomance of accessing multiple nat tables.

@melifaro Are your concerns resolved?

Mar 7 2020, 9:50 PM
lutz_donnerhacke.de added a comment to D23329: Make ICMP redirect processing depend on routing daemon.

@hrs Are your concerns resolved?

Mar 7 2020, 9:47 PM
lutz_donnerhacke.de added a reviewer for D23727: netgraph/ng_one2many: Clarification in comments about copy mode: network.
Mar 7 2020, 9:45 PM
lutz_donnerhacke.de added a comment to D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

@brueffer Are your concerns resolved?

Mar 7 2020, 9:44 PM
lutz_donnerhacke.de updated the diff for D22110: netgraph/ng_car: Add color marking code.

Widen the range of priority classes.

Mar 7 2020, 9:41 PM