Page MenuHomeFreeBSD

lutz_donnerhacke.de (Lutz Donnerhacke)
User

Projects

User Details

User Since
Sep 26 2019, 9:24 AM (16 w, 1 d)

Recent Activity

Wed, Jan 15

lutz_donnerhacke.de resigned from D23153: [netgraph/epoch] fix panic on usage of ipfw ng node.

Sorry, that's my failure. The patch is wrong though. We should run all netgraph in epoch.

Wed, Jan 15, 9:35 AM

Tue, Jan 14

lutz_donnerhacke.de added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

Sorry, I'm lost. What is the purpose of this flag?

Tue, Jan 14, 9:26 PM
lutz_donnerhacke.de accepted D23168: [netgraph/ng_eiface] Generate MAC address from the FreeBSD OUI range..

Because setting a MAC is still possible, the older scripts will not fail with this patch.

Tue, Jan 14, 9:17 PM
lutz_donnerhacke.de accepted D23153: [netgraph/epoch] fix panic on usage of ipfw ng node.

I'd prefer an accept from somebody more involved.

Tue, Jan 14, 9:15 PM

Mon, Jan 13

lutz_donnerhacke.de added a comment to D23153: [netgraph/epoch] fix panic on usage of ipfw ng node.

The structure of the whole function bugs me.
I'd expect a large switch(ip->ip_v) with thee cases: v4, v6 and default.
In each of the cases, I'd expect a

Mon, Jan 13, 9:40 PM
lutz_donnerhacke.de added a comment to D23091: netgraph/ng_nat: Prevent crash by malformated packets.

If there is no known case leading to a panic, we should not scare users with manual. It's still bad wording IMO. If there is known vector that may lead to panic, another checks should be added to make sure panic does not happen.

Mon, Jan 13, 3:38 PM
lutz_donnerhacke.de updated the diff for D23091: netgraph/ng_nat: Prevent crash by malformated packets.

Leave the man page untouched.

Mon, Jan 13, 3:37 PM
lutz_donnerhacke.de added a comment to D23091: netgraph/ng_nat: Prevent crash by malformated packets.

Add an explanation to the man page.

I don't think we should make a habit documenting kernel panics in NEGRAPH code. Such bugs must be fixed, not documented.

Mon, Jan 13, 11:56 AM
lutz_donnerhacke.de added inline comments to D23091: netgraph/ng_nat: Prevent crash by malformated packets.
Mon, Jan 13, 11:01 AM
lutz_donnerhacke.de updated the diff for D23091: netgraph/ng_nat: Prevent crash by malformated packets.

Add an explanation to the man page.

Mon, Jan 13, 10:59 AM

Fri, Jan 10

lutz_donnerhacke.de added inline comments to D23091: netgraph/ng_nat: Prevent crash by malformated packets.
Fri, Jan 10, 10:54 AM
lutz_donnerhacke.de updated the diff for D23091: netgraph/ng_nat: Prevent crash by malformated packets.

Fixed spacing style.

Fri, Jan 10, 10:53 AM

Thu, Jan 9

lutz_donnerhacke.de added inline comments to D23097: Revert VNET change and expand VNET structure..
Thu, Jan 9, 11:59 AM
lutz_donnerhacke.de created D23103: net/parpd: New version of software available.
Thu, Jan 9, 11:49 AM
lutz_donnerhacke.de updated the diff for D23091: netgraph/ng_nat: Prevent crash by malformated packets.

Checking available space before accessing it.

Thu, Jan 9, 8:06 AM

Wed, Jan 8

lutz_donnerhacke.de added a reviewer for D23091: netgraph/ng_nat: Prevent crash by malformated packets: network.
Wed, Jan 8, 5:39 PM
lutz_donnerhacke.de created D23091: netgraph/ng_nat: Prevent crash by malformated packets.
Wed, Jan 8, 5:38 PM

Sat, Jan 4

lutz_donnerhacke.de updated the diff for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

Run indent(1) on the source files.
Reduced comments from the boilerplate.
Changed hard coded ethertypes by global definitions introduced by D21846.

Sat, Jan 4, 9:09 PM
lutz_donnerhacke.de added a comment to D21961: netgraph/ng_bridge: Reestablish old ABI.

The diff https://reviews.freebsd.org/D21961?vs=63102&id=66348#toc does only contain two small lines.

Sat, Jan 4, 8:20 PM
lutz_donnerhacke.de updated the diff for D21961: netgraph/ng_bridge: Reestablish old ABI.

Changed back to a self contained handing of the old ABI calls.
Thank you @bz for the idea to check for errors.

Sat, Jan 4, 8:18 PM

Fri, Jan 3

lutz_donnerhacke.de updated the diff for D21961: netgraph/ng_bridge: Reestablish old ABI.

Allow common calls to the old ABI to fall though to the new one.
Fix generic error handling (go out on error).

Fri, Jan 3, 5:31 PM
lutz_donnerhacke.de updated the diff for D21961: netgraph/ng_bridge: Reestablish old ABI.

The old ABI is different from the new one.
Fall through to the new ABI was an early (but wrong idea)

Fri, Jan 3, 5:15 PM
lutz_donnerhacke.de accepted D22289: mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.
Fri, Jan 3, 12:08 PM
lutz_donnerhacke.de requested changes to D22289: mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.
Fri, Jan 3, 11:36 AM
lutz_donnerhacke.de added inline comments to D22289: mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.
Fri, Jan 3, 11:33 AM
lutz_donnerhacke.de added inline comments to D22289: mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.
Fri, Jan 3, 11:20 AM

Thu, Jan 2

lutz_donnerhacke.de accepted D22988: Bring back redirect route expiration..
Thu, Jan 2, 9:25 PM
lutz_donnerhacke.de added a comment to D22988: Bring back redirect route expiration..

If going this way, I'd be more thinking of having an rc.d script that would verify
the presence of an enabled routing daemon and rely on that to disable redirects.

Thu, Jan 2, 9:20 PM
lutz_donnerhacke.de added a comment to D22988: Bring back redirect route expiration..

Is it possible to default the "redirect" settings to an "automatic mode" where redirects are disabled if a certain, hardcoded size of the routing table is crossed?

Thu, Jan 2, 12:06 PM

Thu, Dec 26

lutz_donnerhacke.de added inline comments to D22110: netgraph/ng_car: Add color marking code.
Thu, Dec 26, 12:02 AM

Dec 11 2019

lutz_donnerhacke.de accepted D22737: pf: Make request_maxcount runtime adjustable.
Dec 11 2019, 8:26 AM
lutz_donnerhacke.de accepted D22733: pfctl: Warn users when they run into kernel limits.

Thank you.

Dec 11 2019, 8:08 AM

Dec 10 2019

lutz_donnerhacke.de added a comment to D22733: pfctl: Warn users when they run into kernel limits.
In D22733#497656, @kp wrote:

Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.

Good point. I'll see if I can improve the error message.

Dec 10 2019, 7:06 AM
lutz_donnerhacke.de added a comment to D22737: pf: Make request_maxcount runtime adjustable.

What happens, if the number is reduced below the number of currently existing tables?

Dec 10 2019, 7:01 AM

Dec 9 2019

lutz_donnerhacke.de added a comment to D22733: pfctl: Warn users when they run into kernel limits.

Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.

Dec 9 2019, 8:40 AM

Dec 4 2019

lutz_donnerhacke.de added a comment to D20468: Port if_vether from OpenBSD.

Speaking of locking, don't we need any in if_vether?

Likely, but I had failed to get anyone else to look at this and promptly lost interest because this isn't an area I work in often.

Dec 4 2019, 8:52 PM
lutz_donnerhacke.de added a comment to D20468: Port if_vether from OpenBSD.

It look like duplicate work compared to ng_eiface and ng_bridge.
What are the benefits of this interface over the ng ones?

Dec 4 2019, 8:33 PM
lutz_donnerhacke.de added a comment to D22447: Implement NDP resource limits..
In D22447#495146, @bz wrote:

Thanks a lot for the feedback. let me know what you think about the suggestion to move the basic functionality into llatbl?

Dec 4 2019, 6:39 AM

Dec 2 2019

lutz_donnerhacke.de added inline comments to D22447: Implement NDP resource limits..
Dec 2 2019, 8:58 PM

Nov 26 2019

lutz_donnerhacke.de added inline comments to D22447: Implement NDP resource limits..
Nov 26 2019, 9:22 PM

Nov 25 2019

lutz_donnerhacke.de added inline comments to D22447: Implement NDP resource limits..
Nov 25 2019, 10:36 PM

Nov 20 2019

lutz_donnerhacke.de added inline comments to D22447: Implement NDP resource limits..
Nov 20 2019, 10:05 PM
lutz_donnerhacke.de added inline comments to D22447: Implement NDP resource limits..
Nov 20 2019, 9:12 PM

Nov 19 2019

lutz_donnerhacke.de accepted D22267: Make sure the 'struct tcp_info' is stable.
Nov 19 2019, 9:45 PM
lutz_donnerhacke.de accepted D22267: Make sure the 'struct tcp_info' is stable.

Okay

Nov 19 2019, 7:06 AM

Nov 6 2019

lutz_donnerhacke.de added a comment to D22243: Schedule link address update when vlan's parent interface is changed.

Okay from me.
Now you need to find some of the senior developers to approve and commit it.

Nov 6 2019, 2:23 PM

Nov 5 2019

lutz_donnerhacke.de added a comment to D22243: Schedule link address update when vlan's parent interface is changed.

I just tried to avoid extra work (updating of each llentry), that can be done in case when interface has tens or hundreds of addresses.

Nov 5 2019, 8:37 PM
lutz_donnerhacke.de added a comment to D22243: Schedule link address update when vlan's parent interface is changed.

If copying the LL addr is happening every time a parent interface is added (bcopy) , why not schedule the update too unconditionally?
It will only happen on changing the parent interface anyway.

Nov 5 2019, 4:29 PM

Nov 2 2019

lutz_donnerhacke.de added inline comments to D22217: Fix iterating over BT LE responses.
Nov 2 2019, 4:05 PM

Oct 25 2019

lutz_donnerhacke.de added reviewers for D22140: netgraph/ng_tag: Variable length data can not be set for all length: julian, glebius, mav.
Oct 25 2019, 2:44 PM

Oct 24 2019

lutz_donnerhacke.de updated the summary of D22140: netgraph/ng_tag: Variable length data can not be set for all length.
Oct 24 2019, 2:04 PM
lutz_donnerhacke.de updated the summary of D22140: netgraph/ng_tag: Variable length data can not be set for all length.
Oct 24 2019, 2:03 PM
lutz_donnerhacke.de added inline comments to D22140: netgraph/ng_tag: Variable length data can not be set for all length.
Oct 24 2019, 11:34 AM
lutz_donnerhacke.de updated the summary of D22140: netgraph/ng_tag: Variable length data can not be set for all length.
Oct 24 2019, 11:34 AM
lutz_donnerhacke.de added a reviewer for D22140: netgraph/ng_tag: Variable length data can not be set for all length: network.
Oct 24 2019, 11:28 AM
lutz_donnerhacke.de created D22140: netgraph/ng_tag: Variable length data can not be set for all length.
Oct 24 2019, 11:27 AM
lutz_donnerhacke.de added inline comments to D20655: Make use of stats(3) in the TCP stack.
Oct 24 2019, 6:51 AM

Oct 22 2019

lutz_donnerhacke.de added a reviewer for D22110: netgraph/ng_car: Add color marking code: network.
Oct 22 2019, 3:22 PM
lutz_donnerhacke.de created D22110: netgraph/ng_car: Add color marking code.
Oct 22 2019, 3:21 PM

Oct 21 2019

lutz_donnerhacke.de added a comment to D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

Update inline notes.

Oct 21 2019, 8:05 AM
lutz_donnerhacke.de updated the diff for D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).

Fixed manpage bugs.

Oct 21 2019, 8:02 AM

Oct 18 2019

lutz_donnerhacke.de added a comment to D21923: netinet: In multicast/broadcast udp(6)_input(), compare the IP details after we lock inp as well.

The ip/uh data is fixed in this function, so only the inp structure might be modified.
My question is: How can the "ip/port" information of an pcb entry (inp) get changed?

Oct 18 2019, 9:53 PM
lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Update local working directory on my machine.

Oct 18 2019, 3:47 PM
lutz_donnerhacke.de updated the diff for D21965: usr.sbin/ngctl: Generate more compact GraphWiz output.

Change location of working directory locally at my machine.

Oct 18 2019, 3:41 PM
lutz_donnerhacke.de updated the diff for D21968: netgraph/ng_source: Allow ng_source to inject into any netgraph network.

Added documentation for the new behavior in the man page.

Oct 18 2019, 3:32 PM
lutz_donnerhacke.de updated the summary of D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
Oct 18 2019, 1:54 PM
lutz_donnerhacke.de updated the summary of D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
Oct 18 2019, 1:54 PM
lutz_donnerhacke.de created D22076: netgraph/ng_vlan_rotate: IEEE 802.1ad VLAN manipulation netgraph node type (new type).
Oct 18 2019, 1:50 PM
lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Added copyright for the man page author

Oct 18 2019, 12:20 PM
lutz_donnerhacke.de added a comment to D22067: netgraph/ng_pipe: Add missing man page.

One last question, is the copyright correct? If you just used a different manpage as a template but you wrote all the content, you should be the sole copyright holder here.

Oct 18 2019, 11:34 AM
lutz_donnerhacke.de added a comment to D22067: netgraph/ng_pipe: Add missing man page.

Please commit, if you have rights.

Oct 18 2019, 11:23 AM
lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Added Makefile reference in order to allow installing the man page.

Oct 18 2019, 11:20 AM
lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Further fix.

Oct 18 2019, 9:59 AM
lutz_donnerhacke.de added a comment to D22067: netgraph/ng_pipe: Add missing man page.

Mark errors fixed.

Oct 18 2019, 9:58 AM
lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Fixing spelling and more as pointed out by brueffer.

Oct 18 2019, 9:57 AM
lutz_donnerhacke.de added inline comments to D21923: netinet: In multicast/broadcast udp(6)_input(), compare the IP details after we lock inp as well.
Oct 18 2019, 9:17 AM

Oct 17 2019

lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Fix igor issues.

Oct 17 2019, 7:02 PM
lutz_donnerhacke.de updated the diff for D22067: netgraph/ng_pipe: Add missing man page.

Fixed "mandoc -Tlint" issues. Thank you for the hint.

Oct 17 2019, 6:48 PM
lutz_donnerhacke.de created D22067: netgraph/ng_pipe: Add missing man page.
Oct 17 2019, 4:40 PM

Oct 16 2019

lutz_donnerhacke.de added a reviewer for D21965: usr.sbin/ngctl: Generate more compact GraphWiz output: network.
Oct 16 2019, 9:47 PM

Oct 10 2019

lutz_donnerhacke.de added reviewers for D21968: netgraph/ng_source: Allow ng_source to inject into any netgraph network: linimon, koobs, network.
Oct 10 2019, 1:13 PM
lutz_donnerhacke.de created D21968: netgraph/ng_source: Allow ng_source to inject into any netgraph network.
Oct 10 2019, 1:11 PM
lutz_donnerhacke.de added a reviewer for D21965: usr.sbin/ngctl: Generate more compact GraphWiz output: linimon.
Oct 10 2019, 12:27 PM
lutz_donnerhacke.de created D21965: usr.sbin/ngctl: Generate more compact GraphWiz output.
Oct 10 2019, 12:21 PM
lutz_donnerhacke.de added a comment to D21961: netgraph/ng_bridge: Reestablish old ABI.

Don't let me stop you from committing it ...

Oct 10 2019, 9:11 AM
lutz_donnerhacke.de added a comment to D21961: netgraph/ng_bridge: Reestablish old ABI.

I wasn't saing you shoudl force yourself to do the test.. just whether it is theoretically possible,, anyhow I'm happy with the result. Don't let me stop you from committing it and I would say that the only case for keeping it in 13 is for the brief period while an upgrade is occurring. (for example I know people who have their interface connected into a bridge so that if the bridge wasn't configured correctly they'd be off the air.. It would basically be for compatibility up the 12 line rather than being needed in the 13 line.

Oct 10 2019, 8:56 AM
lutz_donnerhacke.de added a comment to D21961: netgraph/ng_bridge: Reestablish old ABI.

It should be backward compatible for 12 at least. Probably not needed for 13 but no harm in carrying it for one release.

Oct 10 2019, 8:32 AM
lutz_donnerhacke.de added a comment to D21961: netgraph/ng_bridge: Reestablish old ABI.

Can you use both binaries? e.g. a script uses one and manually you use a newer one?

Oct 10 2019, 8:17 AM

Oct 9 2019

lutz_donnerhacke.de added reviewers for D21961: netgraph/ng_bridge: Reestablish old ABI: network, julian.
Oct 9 2019, 9:38 PM
lutz_donnerhacke.de created D21961: netgraph/ng_bridge: Reestablish old ABI.
Oct 9 2019, 9:35 PM

Oct 1 2019

lutz_donnerhacke.de updated the diff for D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links.

Fix spelling and delayed allocation

Oct 1 2019, 8:15 AM

Sep 30 2019

lutz_donnerhacke.de added a comment to D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links.

What is the next step?
Should I replace the patch by a new one in order to correct the remaining issues?

Sep 30 2019, 11:34 PM
lutz_donnerhacke.de added a member for transport: lutz_donnerhacke.de.
Sep 30 2019, 7:35 AM
lutz_donnerhacke.de updated the summary of D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links.
Sep 30 2019, 7:06 AM
lutz_donnerhacke.de updated the test plan for D21846: Add 802.1Q ethertypes used in the wild.
Sep 30 2019, 7:03 AM
lutz_donnerhacke.de added a reviewer for D21846: Add 802.1Q ethertypes used in the wild: network.
Sep 30 2019, 7:01 AM
lutz_donnerhacke.de created D21846: Add 802.1Q ethertypes used in the wild.
Sep 30 2019, 7:00 AM

Sep 29 2019

lutz_donnerhacke.de added a reviewer for D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links: network.
Sep 29 2019, 9:44 PM

Sep 27 2019

lutz_donnerhacke.de added a member for network: lutz_donnerhacke.de.
Sep 27 2019, 9:17 PM
lutz_donnerhacke.de updated the test plan for D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links.
Sep 27 2019, 9:09 PM