- User Since
- Sep 26 2019, 9:24 AM (16 w, 1 d)
Wed, Jan 15
Tue, Jan 14
Sorry, I'm lost. What is the purpose of this flag?
Because setting a MAC is still possible, the older scripts will not fail with this patch.
I'd prefer an accept from somebody more involved.
Mon, Jan 13
The structure of the whole function bugs me.
I'd expect a large switch(ip->ip_v) with thee cases: v4, v6 and default.
In each of the cases, I'd expect a
Leave the man page untouched.
Add an explanation to the man page.
Fri, Jan 10
Fixed spacing style.
Thu, Jan 9
Checking available space before accessing it.
Wed, Jan 8
Sat, Jan 4
Run indent(1) on the source files.
Reduced comments from the boilerplate.
Changed hard coded ethertypes by global definitions introduced by D21846.
The diff https://reviews.freebsd.org/D21961?vs=63102&id=66348#toc does only contain two small lines.
Changed back to a self contained handing of the old ABI calls.
Thank you @bz for the idea to check for errors.
Fri, Jan 3
Allow common calls to the old ABI to fall though to the new one.
Fix generic error handling (go out on error).
The old ABI is different from the new one.
Fall through to the new ABI was an early (but wrong idea)
Thu, Jan 2
If going this way, I'd be more thinking of having an rc.d script that would verify
the presence of an enabled routing daemon and rely on that to disable redirects.
Is it possible to default the "redirect" settings to an "automatic mode" where redirects are disabled if a certain, hardcoded size of the routing table is crossed?
Thu, Dec 26
Dec 11 2019
Dec 10 2019
What happens, if the number is reduced below the number of currently existing tables?
Dec 9 2019
Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.
Dec 4 2019
It look like duplicate work compared to ng_eiface and ng_bridge.
What are the benefits of this interface over the ng ones?
Dec 2 2019
Nov 26 2019
Nov 25 2019
Nov 20 2019
Nov 19 2019
Nov 6 2019
Okay from me.
Now you need to find some of the senior developers to approve and commit it.
Nov 5 2019
I just tried to avoid extra work (updating of each llentry), that can be done in case when interface has tens or hundreds of addresses.
If copying the LL addr is happening every time a parent interface is added (bcopy) , why not schedule the update too unconditionally?
It will only happen on changing the parent interface anyway.
Nov 2 2019
Oct 25 2019
Oct 24 2019
Oct 22 2019
Oct 21 2019
Update inline notes.
Fixed manpage bugs.
Oct 18 2019
The ip/uh data is fixed in this function, so only the inp structure might be modified.
My question is: How can the "ip/port" information of an pcb entry (inp) get changed?
Update local working directory on my machine.
Change location of working directory locally at my machine.
Added documentation for the new behavior in the man page.
Added copyright for the man page author
Please commit, if you have rights.
Added Makefile reference in order to allow installing the man page.
Mark errors fixed.
Fixing spelling and more as pointed out by brueffer.
Oct 17 2019
Fix igor issues.
Fixed "mandoc -Tlint" issues. Thank you for the hint.
Oct 16 2019
Oct 10 2019
Oct 9 2019
Oct 1 2019
Fix spelling and delayed allocation
Sep 30 2019
What is the next step?
Should I replace the patch by a new one in order to correct the remaining issues?