Page MenuHomeFreeBSD

kristof (Kristof Provost)
User

Projects

User Details

User Since
Sep 28 2014, 7:22 PM (255 w, 15 h)

Recent Activity

Fri, Aug 16

D21276: Move pft_ping.py and sniffer.py to the common test directory is now accepted and ready to land.
Fri, Aug 16, 2:03 PM
kristof added a comment to D21276: Move pft_ping.py and sniffer.py to the common test directory.

This probably also wants this:

Fri, Aug 16, 9:29 AM

Thu, Aug 15

D21267: pf tests: Fix accidental duplication of content is now accepted and ready to land.
Thu, Aug 15, 11:24 AM

Wed, Aug 14

kristof accepted D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.
Wed, Aug 14, 12:21 PM

Mon, Aug 12

kristof added a comment to D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.

And this is wrong in firewall_init():

Mon, Aug 12, 2:41 PM

Sun, Aug 11

kristof added a comment to D21199: NAT basic test for pf, ipfw (both in-kernel and userspace) and ipf.

I seem to run into issues running the ipfw_basic test:

Sun, Aug 11, 5:01 PM

Wed, Jul 31

kristof added inline comments to D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Wed, Jul 31, 8:37 AM · GSoC Students

Mon, Jul 29

D21065: Pass/Block test for three firewalls (pf, ipfw, ipf) is now accepted and ready to land.

I think I'm happy with this.
I'll give Tom a bit of time to add any more remarks he might have, but I think we can commit this soon.

Mon, Jul 29, 8:39 PM · GSoC Students
kristof added a comment to D21100: riscv: Fix copyin/copyout.

Full context.

Mon, Jul 29, 1:57 PM
kristof added a comment to D21086: pf: Remove partial RFC2675 support.
In D21086#457948, @ae wrote:

Does this mean that you concluded in the IETF mailing list to drop this support?

Mon, Jul 29, 1:55 PM
kristof created D21100: riscv: Fix copyin/copyout.
Mon, Jul 29, 12:58 PM

Sun, Jul 28

kristof added a comment to D21086: pf: Remove partial RFC2675 support.

Remove more bits, as suggested by thj

Sun, Jul 28, 7:44 PM

Sat, Jul 27

kristof added inline comments to D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Sat, Jul 27, 8:52 PM · GSoC Students
kristof added a reviewer for D21086: pf: Remove partial RFC2675 support: thj.
Sat, Jul 27, 1:32 PM
kristof created D21086: pf: Remove partial RFC2675 support.
Sat, Jul 27, 1:32 PM

Fri, Jul 26

kristof added a comment to D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).

I'd want Tom to have a look too, but I think we're pretty close to something ready to commit.

Fri, Jul 26, 4:05 PM · GSoC Students
kristof added a comment to D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).

Also, I get 'install: /usr/tests/sys/netpfil/common/pass_block: No such file or directory' trying to install world.
This patch is missing this:

Fri, Jul 26, 11:34 AM · GSoC Students

Thu, Jul 25

kristof added inline comments to D21065: Pass/Block test for three firewalls (pf, ipfw, ipf).
Thu, Jul 25, 8:00 PM · GSoC Students

Jul 8 2019

kristof added a comment to D20868: epair: Fix shutdown race.

I think I now understand better how the problem happens. It's specific to epair.
It's indeed a race between if_vmove() moving the interface back into its original vnet, and the epair interface getting destroyed. Destruction of epairs is special, because we remove two interfaces at once.
See epair_clone_destroy(). There we if_detach() (through ether_ifdetach()) the other interface as well. If that interface has been moved out of the vnet by then the if_detach() will fail, but this does not return an error (if_detach_internal() does). So we end up freeing the ifp, while if_vmove() is reinserting it in another vnet, leading to the described panic.

Jul 8 2019, 3:27 PM

Jul 7 2019

kristof added a reviewer for D20868: epair: Fix shutdown race: mmacy.
Jul 7 2019, 5:18 PM
kristof added a comment to D20868: epair: Fix shutdown race.

Good point. While this does make things a lot better (as in, nearly perfectly reliable panic running the pf tests, to being able to loop the tests all night, when combined with D20869), I think you're right that the race is still there.

Jul 7 2019, 5:18 PM

Jul 6 2019

kristof added reviewers for D20869: vnet: Fix panic when shutting down jails and deleting interfaces simultaneously: bz, mmacy.
Jul 6 2019, 5:36 PM
kristof created D20869: vnet: Fix panic when shutting down jails and deleting interfaces simultaneously.
Jul 6 2019, 5:36 PM
kristof added a reviewer for D20868: epair: Fix shutdown race: bz.
Jul 6 2019, 5:35 PM
kristof created D20868: epair: Fix shutdown race.
Jul 6 2019, 5:35 PM

Jun 16 2019

kristof added a comment to D20568: Add a section to blacklistd to the PF chapter of the handbook.

Given that it's possible to use blacklistd with ipfw as well (at least, I believe it is), it should probably get its own chapter, with pf and ipfw subchapters.

Jun 16 2019, 2:35 PM

Jun 15 2019

kristof added a comment to D20616: Add a new external mbuf type that holds multiple unmapped pages..
In D20616#445627, @jhb wrote:

Is this routine used for transmit or only for receive? In the current patch, unmapped mbufs are only used for transmit. The comments in pf_check_proto_cksum imply it might only apply to receive in which case it should be fine as-is.

Jun 15 2019, 3:28 PM
kristof added inline comments to D20568: Add a section to blacklistd to the PF chapter of the handbook.
Jun 15 2019, 2:38 PM

Jun 12 2019

kristof added a comment to D20616: Add a new external mbuf type that holds multiple unmapped pages..
In D20616#445618, @jhb wrote:

What happens if a firewall is enabled and an unmapped mbuf is passed through pfil(9)?
I suspect that, if a pfil hook is hit, we'd also have to copy it in, just like when a checksum needs to be updated.

Only if the firewall needs to read/write actual packet data. Protocol headers (TCP, IP, etc.) are always stored in a normal mbuf at the start of a packet's mbuf chain. Unmapped mbufs only hold payload data that is stored in a socket buffer, so most of the filters I can think of off the top of my head as well as things like NAT should only operate on the normal mbuf holding the headers.

Okay, thanks. That should indeed just work. The 'pf_check_proto_cksum()' flow, assuming there's no hardware assist, might break. I suspect that hardware which uses unmapped mbufs is always going to have checksum offload, so that's probably not an issue either.

Jun 12 2019, 5:16 PM
kristof added a comment to D20616: Add a new external mbuf type that holds multiple unmapped pages..

What happens if a firewall is enabled and an unmapped mbuf is passed through pfil(9)?
I suspect that, if a pfil hook is hit, we'd also have to copy it in, just like when a checksum needs to be updated.

Jun 12 2019, 6:55 AM

May 15 2019

kristof added a comment to D20168: Start testing cloned interfaces.

There are sadly still a lot of panics triggered by these tests.

May 15 2019, 3:45 PM · network

May 6 2019

kristof added a comment to D20168: Start testing cloned interfaces.

That seems like a good idea. I'll try to bring it up during the BSDCan devsummit.

May 6 2019, 3:48 PM · network

Apr 18 2019

kristof added a comment to D19960: Remove support for RFC2675.

Burn it with fire! This code is not used, and pretty much can't be used, so let's get rid of it.

Apr 18 2019, 5:19 PM
kristof added a comment to D19957: devfs: Add 'devfsrules_vnet_jail'.

Rather annoyingly things like ezjail can't directly use the devfsrules_vnet_jail name. They must specify the number. See https://svnweb.freebsd.org/base/head/libexec/rc/rc.d/jail?view=markup#l238
I have no idea how to address that, but this at the very least will hint users in the direction of what they may want for vnet jails.

Apr 18 2019, 3:01 PM
kristof created D19957: devfs: Add 'devfsrules_vnet_jail'.
Apr 18 2019, 3:00 PM
kristof added a reviewer for D19838: Fix a memory leak in pw when invoked with -V or -R: bapt.

cc bapt who knows more about this code than I do.

Apr 18 2019, 11:02 AM
kristof accepted D19952: Add a bugs section to pflog man page.

LGTM. It may be useful to point at 122773 in the commit message for extra context.

Apr 18 2019, 10:42 AM
kristof added inline comments to D19939: Some cleanups for the PF chapter in the handbook.
Apr 18 2019, 10:29 AM

Apr 17 2019

kristof added a comment to D19838: Fix a memory leak in pw when invoked with -V or -R.

It's not clear to me how this leaks memory. Can you go into a bit more detail about how you found the memory leak, and the codepath it follows?

Apr 17 2019, 11:19 AM

Apr 9 2019

kristof accepted D19861: Update and clarify pflog man page.
Apr 9 2019, 12:32 PM

Mar 30 2019

kristof accepted D19757: if_bridge(4): Complete bpf auditing of local traffic over the bridge.
Mar 30 2019, 4:53 PM

Mar 23 2019

kristof accepted D19614: if_bridge(4): ensure all traffic passing over the bridge is accounted for.
Mar 23 2019, 12:27 PM

Mar 19 2019

kristof accepted D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.
Mar 19 2019, 7:34 AM

Mar 15 2019

kristof added a comment to D19586: if_bridge: Give bpf a shot at packets passed over the bridge.

I don't see any obvious problems, but I don't think I know this part of the code well enough to say for sure.

Mar 15 2019, 2:33 PM
kristof added a reviewer for D19586: if_bridge: Give bpf a shot at packets passed over the bridge: philip.
Mar 15 2019, 2:16 PM
kristof added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.
panic: Assertion in_epoch(net_epoch_preempt) failed at /usr/src/sys/netinet6/nd6_rtr.c:874
cpuid = 3
time = 1552657485
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0091c86300
vpanic() at vpanic+0x19d/frame 0xfffffe0091c86350
panic() at panic+0x43/frame 0xfffffe0091c863b0
defrouter_select_fib() at defrouter_select_fib+0x52a/frame 0xfffffe0091c86460
defrouter_del() at defrouter_del+0x15f/frame 0xfffffe0091c864a0
nd6_purge() at nd6_purge+0x1af/frame 0xfffffe0091c864f0
if_detach_internal() at if_detach_internal+0x7f6/frame 0xfffffe0091c86570
if_detach() at if_detach+0x3d/frame 0xfffffe0091c86590
epair_clone_destroy() at epair_clone_destroy+0x98/frame 0xfffffe0091c865e0
if_clone_destroyif() at if_clone_destroyif+0x175/frame 0xfffffe0091c86630
if_clone_destroy() at if_clone_destroy+0x205/frame 0xfffffe0091c86680
ifioctl() at ifioctl+0x3de/frame 0xfffffe0091c86750
kern_ioctl() at kern_ioctl+0x28a/frame 0xfffffe0091c867c0
sys_ioctl() at sys_ioctl+0x15d/frame 0xfffffe0091c86890
amd64_syscall() at amd64_syscall+0x276/frame 0xfffffe0091c869b0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe0091c869b0
--- syscall (54, FreeBSD ELF64, sys_ioctl), rip = 0x8004852ca, rsp = 0x7fffffffe228, rbp = 0x7fffffffe240 ---
KDB: enter: panic
[ thread pid 93197 tid 100466 ]
Stopped at      kdb_enter+0x3b: movq    $0,kdb_why
db>

During the sys/netinet/fibs_test:slaac_on_nondefault_fib6 test, I believe.

Mar 15 2019, 1:56 PM

Mar 14 2019

kristof accepted D19578: if_bridge(4): Fix module teardown .

Oh yes, of course.

Mar 14 2019, 6:00 PM
kristof added a comment to D19578: if_bridge(4): Fix module teardown .

Do we need to virtualise the bridge_rtnode_zone? Doesn't the cleanup call to bridge_rtflush() take care of all of the allocations already?

Mar 14 2019, 5:49 PM
kristof added a comment to D19578: if_bridge(4): Fix module teardown .

I'll try to take a more in-depth look later today.

Mar 14 2019, 6:34 AM

Mar 13 2019

kristof accepted D19573: ether: centralize fake hwaddr generation.

LGTM.

Mar 13 2019, 7:49 PM
kristof updated the diff for D19558: pf :Use counter(9) in pf tables..

Add comment

Mar 13 2019, 4:17 PM

Mar 12 2019

kristof updated the summary of D19558: pf :Use counter(9) in pf tables..
Mar 12 2019, 12:47 PM
kristof added a reviewer for D19558: pf :Use counter(9) in pf tables.: network.
Mar 12 2019, 12:46 PM
kristof created D19558: pf :Use counter(9) in pf tables..
Mar 12 2019, 12:45 PM
kristof accepted D19530: Followup to PR231977: Mention that /etc/pf.conf must be created first.
Mar 12 2019, 10:07 AM

Mar 8 2019

kristof added a comment to D19459: subversion: update commit message template to allow URLs in PR field.

@bdrewery and I both independently had the same idea. He mentioned it in D19426.

Ah, I hadn't looked at that review yet.

Mar 8 2019, 5:20 PM
kristof added a comment to D19459: subversion: update commit message template to allow URLs in PR field.

https://bugs.freebsd.org/12345 redirects to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=12345. Wouldn't the first form be better? It's shorter and likely easier to map to whatever bug tracker we might move to after bugzilla (if we ever do change). It also looks more like the phabricator links.

Mar 8 2019, 9:37 AM

Mar 5 2019

kristof updated the summary of D19248: tun: VIMAGE fix for if_tun cloner.
Mar 5 2019, 9:24 AM
kristof updated the diff for D19248: tun: VIMAGE fix for if_tun cloner.

'\0'

Mar 5 2019, 9:24 AM

Mar 4 2019

kristof added a comment to D19248: tun: VIMAGE fix for if_tun cloner.

If there are no objections I'm going to commit this soon.

Mar 4 2019, 6:34 PM

Feb 27 2019

kristof updated the diff for D19248: tun: VIMAGE fix for if_tun cloner.

Fix issues pointed out by hrs.

Feb 27 2019, 2:57 PM
kristof updated the diff for D19248: tun: VIMAGE fix for if_tun cloner.

Fix tun_clone_match() to not match on e.g. tunnel.

Feb 27 2019, 2:28 PM
kristof added inline comments to D19248: tun: VIMAGE fix for if_tun cloner.
Feb 27 2019, 1:50 PM
kristof added inline comments to D19248: tun: VIMAGE fix for if_tun cloner.
Feb 27 2019, 1:34 PM
kristof updated the diff for D19248: tun: VIMAGE fix for if_tun cloner.

Remove stray debug lines

Feb 27 2019, 9:52 AM
kristof updated the diff for D19248: tun: VIMAGE fix for if_tun cloner.

Ensure that unit numbers are system-unique.

Feb 27 2019, 9:37 AM

Feb 24 2019

kristof added a comment to D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

The pf bit is good.
Everything else looks good to me as well, modulo the remark karels had about the XXX comment.

Feb 24 2019, 8:25 PM

Feb 21 2019

kristof added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

New panic, I suspect while an interface is being moved into or out of a vnet jail.
The pf tests seem to trigger a lot of edge cases, so you may want to see if you can get them to run too. They don't need much setup (basically, pkg install scapy kyua, then kldload pfsync ; cd /usr/tests/sys/netpfil/pf ; sudo kyua test).

Feb 21 2019, 12:50 PM

Feb 20 2019

kristof added a comment to D19248: tun: VIMAGE fix for if_tun cloner.

Thanks. The original reporter of the bug discovered that too.

Feb 20 2019, 12:54 PM

Feb 19 2019

kristof added reviewers for D19248: tun: VIMAGE fix for if_tun cloner: network, bz.
Feb 19 2019, 6:28 PM
kristof created D19248: tun: VIMAGE fix for if_tun cloner.
Feb 19 2019, 6:27 PM

Feb 11 2019

kristof added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

This one boots, but panics when I kldload pfsync:

Feb 11 2019, 9:44 PM

Feb 10 2019

kristof accepted D19131: Decrease the time the kernel takes to install a new PF config with a large number of queues.
Feb 10 2019, 1:46 PM

Feb 9 2019

kristof added a comment to D19124: Fix HFSC configuration bug introduced in r343287.

I have no objections to the patch, but I don't know enough about HFSC to meaningfully review this, I'm afraid.

Feb 9 2019, 1:58 PM

Feb 8 2019

kristof added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

I'm pretty sure that ipv6_activate_all_interfaces="YES" in /etc/rc.conf is the trigger for the previous panic.
That also matches nicely with the backtrace. Presumably nd6_dad_timer() doesn't enter the NET_EPOCH.

Feb 8 2019, 3:15 PM
kristof added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

This panics my test vm:

Feb 8 2019, 10:43 AM

Feb 2 2019

kristof accepted D18924: bridge: Fix spurious warnings about capabilities.

LGTM

Feb 2 2019, 10:10 AM

Jan 29 2019

kristof added a comment to D18951: New pfil(9).

Did you happen to do any benchmarking on this? I'd have expected "Sync pfil hooks epoch(9)" to give us a (small) performance improvement, but my initial test shows a small reduction in forwarding performance (with pf loaded).

Jan 29 2019, 8:34 PM

Jan 28 2019

kristof accepted D19005: ifconfig: fix endianness bug displaying pfsync interfaces.
Jan 28 2019, 5:44 PM
kristof added inline comments to D19005: ifconfig: fix endianness bug displaying pfsync interfaces.
Jan 28 2019, 5:10 PM

Jan 25 2019

kristof added a comment to D18951: New pfil(9).

This panics during the netipsec and pf regression tests:

Jan 25 2019, 1:57 AM

Jan 24 2019

kristof accepted D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.

To be clear: I don't object to your change. It's just that ifconfig is a bit of a mess and any opportunity for cleanup is tempting. Especially if I don't have to do it.

Jan 24 2019, 9:04 AM
kristof added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:45 AM
kristof added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:31 AM
kristof added inline comments to D18919: In ifconfig(8), don't build, sort and search all system addresses when performing a non-status action on a single interface.
Jan 24 2019, 3:13 AM
kristof accepted D18918: Don't re-evaluate ALTQ kernel configuration due to events on non-ALTQ interfaces.
Jan 24 2019, 2:58 AM

Jan 21 2019

kristof added a reviewer for D18909: pfctl: Point users to net.pf.request_maxcount if large requests are rejected: network.
Jan 21 2019, 3:50 AM
kristof created D18909: pfctl: Point users to net.pf.request_maxcount if large requests are rejected.
Jan 21 2019, 3:50 AM

Jan 18 2019

kristof added a comment to D18882: Fix pfsync breaking carp.

Yeah, looking at my original commit I did manage to lose that flag. I’ve not tested yet, but this patch is almost certainly correct.

Jan 18 2019, 12:41 AM

Jan 15 2019

kristof added a comment to D18759: Improve pf.conf parsing speed for large numbers of queues.

Also, I’d really, really like some basic tests for altq. It should be reasonably straightforward to do something based on the existing pf tests. At least, if altq can work on top of epairs.

Jan 15 2019, 12:12 AM

Jan 12 2019

kristof accepted D18759: Improve pf.conf parsing speed for large numbers of queues.
Jan 12 2019, 5:55 AM

Jan 8 2019

kristof accepted D18779: Don't set if_linkmib for vlan(4)..

LGTM.

Jan 8 2019, 8:14 AM

Jan 7 2019

kristof added a comment to D18759: Improve pf.conf parsing speed for large numbers of queues.

I’ll try to review asap, but I’m on holiday wirh limited internet access right now.

Jan 7 2019, 9:05 PM

Dec 29 2018

kristof created D18679: libxo: Fix XML output if a container name is a number.
Dec 29 2018, 12:52 PM

Dec 8 2018

kristof created D18483: pf: Fix endless loop on NAT exhaustion with sticky-address.
Dec 8 2018, 3:07 PM

Dec 5 2018

kristof added a comment to D18373: pfsync: Performance improvement.
In D18373#392613, @eri wrote:

Not a blocker but:

  • It would also be nice to have measure if the other side can keep up with the blast of state updates now?
  • Even better, provide the same bucket mechanism on reception so it can be distributed on the various cores
Dec 5 2018, 7:35 PM
kristof added a comment to D18373: pfsync: Performance improvement.
In D18373#392610, @eri wrote:

Can you please measure the latency of syncing states with this change against previous latency?

Dec 5 2018, 7:25 PM

Dec 3 2018

kristof updated the diff for D18373: pfsync: Performance improvement.

Fix build with ! VIMAGE

Dec 3 2018, 11:04 AM
kristof updated the diff for D18373: pfsync: Performance improvement.

Address man page remark.

Dec 3 2018, 8:38 AM

Dec 2 2018

kristof updated the diff for D18373: pfsync: Performance improvement.

Minor improvements, style and such.
Small man page addition.

Dec 2 2018, 5:20 PM