Page MenuHomeFreeBSD

khng300_gmail.com (Ka Ho Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2018, 3:15 AM (124 w, 3 d)

Recent Activity

Yesterday

khng300_gmail.com requested review of D27003: Set PATH envvar after setting HOME..
Thu, Oct 29, 8:46 AM

Wed, Oct 28

khng300_gmail.com updated the diff for D26884: Add sndstat IOCTLs draft.
  • Cosmetic fixes
Wed, Oct 28, 11:57 AM
khng300_gmail.com updated the diff for D26884: Add sndstat IOCTLs draft.
  • Remove spurious SNDSTAT_UNLOCK() in sndstat_create_devs_nvlist()
Wed, Oct 28, 11:56 AM
khng300_gmail.com updated the diff for D26884: Add sndstat IOCTLs draft.
  • Remove spurious pf->lock unlock and replace with SNDSTAT_UNLOCK() 2
Wed, Oct 28, 11:53 AM
khng300_gmail.com updated the diff for D26884: Add sndstat IOCTLs draft.
  • Remove spurious pf->lock unlock and replace with SNDSTAT_UNLOCK()
Wed, Oct 28, 11:52 AM
khng300_gmail.com added a comment to D26884: Add sndstat IOCTLs draft.

What about providing the default sample bit depth used?

Wed, Oct 28, 9:10 AM
khng300_gmail.com updated the summary of D26884: Add sndstat IOCTLs draft.
Wed, Oct 28, 9:06 AM
khng300_gmail.com updated the diff for D26884: Add sndstat IOCTLs draft.
  • Add nameunit label to device items
Wed, Oct 28, 8:52 AM
khng300_gmail.com updated the diff for D26884: Add sndstat IOCTLs draft.
  • Address delphij's comments
Wed, Oct 28, 8:07 AM

Mon, Oct 26

khng300_gmail.com updated the diff for D26915: virtio_pci: Allow memory space for configuration.
  • Cosmetic fixes on vtpci_attach
Mon, Oct 26, 5:00 PM
khng300_gmail.com added inline comments to D26915: virtio_pci: Allow memory space for configuration.
Mon, Oct 26, 4:32 PM
khng300_gmail.com added a comment to D26884: Add sndstat IOCTLs draft.

Does things sound better if we create another label called nameunit to hold something like pcm0, while prepending /dev/ to existing devnode string, so that everytime user only need to directly use the devnode string to open the node without the hassle of snprintf?

Mon, Oct 26, 6:47 AM

Sat, Oct 24

khng300_gmail.com updated the diff for D26915: virtio_pci: Allow memory space for configuration.
  • Update the virtio-pci BAR0 detach path as well
Sat, Oct 24, 6:53 PM
khng300_gmail.com added reviewers for D26915: virtio_pci: Allow memory space for configuration: jhb, grehan.
Sat, Oct 24, 6:25 PM
khng300_gmail.com added a reviewer for D26915: virtio_pci: Allow memory space for configuration: cem.
Sat, Oct 24, 5:22 PM
khng300_gmail.com updated the diff for D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap.

Fix the differential

Sat, Oct 24, 4:58 PM
khng300_gmail.com requested review of D26933: virtio_pci: Use the table BAR and PBA BAR from MSI-X cap.
Sat, Oct 24, 4:22 PM

Fri, Oct 23

khng300_gmail.com requested review of D26915: virtio_pci: Allow memory space for configuration.
Fri, Oct 23, 9:31 AM
khng300_gmail.com added a comment to D26884: Add sndstat IOCTLs draft.

LGTM.
BTW, since I consider the API a draft, the API is subject to changes. :)

Fri, Oct 23, 6:01 AM

Thu, Oct 22

khng300_gmail.com added a comment to D26884: Add sndstat IOCTLs draft.

Do you have a patch for virtual_oss aswell?

Thu, Oct 22, 5:58 PM
khng300_gmail.com published D26884: Add sndstat IOCTLs draft for review.
Thu, Oct 22, 5:03 PM

Wed, Oct 14

khng300_gmail.com added a comment to D26209: GVT-d support for bhyve.

Updates:

Wed, Oct 14, 9:10 AM · bhyve

Sep 30 2020

khng300_gmail.com accepted D26599: gdb(4): Don't escape GDB special characters at application layer.

Tested. So far it runs well on my setup.

Sep 30 2020, 2:22 AM

Sep 27 2020

khng300_gmail.com added a comment to D26209: GVT-d support for bhyve.

I am curious is it possible you split out mmio remap handling to another differential review? This may make the mmio remap handling part quicker to be reviewed and merged.

Sep 27 2020, 4:40 AM · bhyve

Sep 25 2020

khng300_gmail.com added a comment to D26555: Add .clangd to .gitignore.

Seems not, although both are directories.

Sep 25 2020, 3:54 PM
khng300_gmail.com updated the diff for D26555: Add .clangd to .gitignore.
  • Add .ccls-cache to .gitignore
Sep 25 2020, 2:51 PM
khng300_gmail.com added a comment to D26555: Add .clangd to .gitignore.

Ideally everyone would keep that kind of stuff in their global gitignore (core.excludesfile) :)

but if we're going with this, please also add .ccls-cache/ from the sort-of more popular these days server ccls

Sep 25 2020, 2:51 PM
khng300_gmail.com requested review of D26555: Add .clangd to .gitignore.
Sep 25 2020, 10:51 AM
khng300_gmail.com added a comment to D26514: Add compile_commands*.json to .gitignore.
In D26514#590312, @cem wrote:

What drops this file? I don’t recognize it. No objection in principle.

Sep 25 2020, 10:04 AM

Sep 24 2020

khng300_gmail.com requested review of D26547: gecko: update OSS patches.
Sep 24 2020, 6:03 PM

Sep 22 2020

khng300_gmail.com added a comment to D26514: Add compile_commands*.json to .gitignore.

Just curious, what tool did you use to generate the compile commands database for FreeBSD? I have a vim linter plugin that is kind of useless for FreeBSD code without one.

Sep 22 2020, 5:13 AM

Sep 21 2020

khng300_gmail.com requested review of D26515: Update chinese/librime to 1.6.1.
Sep 21 2020, 5:43 PM
khng300_gmail.com requested review of D26514: Add compile_commands*.json to .gitignore.
Sep 21 2020, 4:23 PM

Sep 20 2020

khng300_gmail.com updated the summary of D26490: www/chromium: Make online detection always positive.
Sep 20 2020, 2:34 PM
khng300_gmail.com updated the summary of D26490: www/chromium: Make online detection always positive.
Sep 20 2020, 2:30 PM
khng300_gmail.com requested review of D26490: www/chromium: Make online detection always positive.
Sep 20 2020, 9:37 AM
khng300_gmail.com abandoned D24124: bhyve: implement NVMe flush command.

Abandoned as D24880 was landed

Sep 20 2020, 9:27 AM

Sep 14 2020

khng300_gmail.com updated the diff for D26419: New port: security/pam_pkcs11.
  • security/pam_pkcs11: Fix .example file paths in PAM_PKCS11_EXAMPLEDOCS
Sep 14 2020, 12:04 AM

Sep 13 2020

khng300_gmail.com updated the diff for D26419: New port: security/pam_pkcs11.
  • security/pam_pkcs11: Do path replacement of etc/*.example in post-patch target
Sep 13 2020, 11:54 PM
khng300_gmail.com updated the diff for D26419: New port: security/pam_pkcs11.
  • www/firefox: Some tailoring jobs
Sep 13 2020, 6:06 PM
khng300_gmail.com updated the diff for D26419: New port: security/pam_pkcs11.
  • www/firefox: Replace the occurrence of /usr/xxx with /usr/local/xxx for etc/*.example
Sep 13 2020, 5:57 PM
khng300_gmail.com updated the summary of D26419: New port: security/pam_pkcs11.
Sep 13 2020, 8:45 AM
khng300_gmail.com set the repository for D26419: New port: security/pam_pkcs11 to rP FreeBSD ports repository.
Sep 13 2020, 8:36 AM
khng300_gmail.com requested review of D26419: New port: security/pam_pkcs11.
Sep 13 2020, 8:33 AM

Sep 11 2020

khng300_gmail.com added a comment to D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.

Can you submit the change upstream? If you did rename the patch file after the bug.

Sep 11 2020, 7:03 PM
khng300_gmail.com updated the summary of D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.
Sep 11 2020, 7:00 PM
khng300_gmail.com updated the diff for D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.
  • sysutils/beats7: Update to 7.9.1
  • Update to the 20200906 snapshot of GCC 11.0.0.
  • Update to 1.1.0
  • Update to 1.0.7. This also fixes the -fno-common issue.
  • devel/intel-graphics-compiler: update to 1.0.4879
  • devel/gh: Update to 0.12.0
  • net-im/tut: Update to 0.0.17
  • New port: lang/hermes: JavaScript engine
  • Update to 6.4.167
  • - Update WWW
  • Update lang/erlang-runtime23 to version 23.0.4.
  • databases/pgrouting: Update to 3.1.0
  • editors/jucipp: Update to 1.6.1
  • Fix build on current.
  • graphics/gmt: Update to 6.1.1
  • - Reset MAINTAINER due to fatal bounces
  • devel/tortoisehg: Update to 5.5.1 and allow Python 3 by flavorizing the port. Switch to automatic plist.
  • devel/efl and x11-wm/enlightenment: Remove some files that I missed in the last update.
  • lang/intel-compute-runtime: update to 20.36.17813
  • devel/efl: Mark WAYLAND option BROKEN. Despite the code compiles, it is reported to fail on runtime.
  • math/pdal: Update to 2.2.0
  • Try to fix ports build.
  • Update to the 20200910 snapshot of GCC 8.4.1.
  • graphics/py-fiona: Update to 1.8.17
  • www/nextcloud: Update to 19.0.3
  • databases/virtualpg: Update to 2.0.0
  • www/firefox: Fix tab crashing when not using pulse-rust backend
Sep 11 2020, 6:57 PM

Sep 10 2020

khng300_gmail.com added a comment to D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.

Can you submit the change upstream? If you did rename the patch file after the bug.

I would try to seek feedback from upstream before moving in this direction.

Sep 10 2020, 7:25 AM

Sep 9 2020

khng300_gmail.com added a comment to D26209: GVT-d support for bhyve.

Notes on FreeBSD guests (may be updated):
This change also works with:

  • 13.0-CURRENT (20200903 snapshot) guest
Sep 9 2020, 6:30 PM · bhyve
khng300_gmail.com updated the diff for D26372: Remove manpage of vm_map_create(9) KPI.
  • Update ObseleteFiles for removal of vm_map_create(9)
Sep 9 2020, 1:05 PM
khng300_gmail.com requested review of D26372: Remove manpage of vm_map_create(9) KPI.
Sep 9 2020, 12:16 PM

Sep 8 2020

khng300_gmail.com added a comment to D26209: GVT-d support for bhyve.

Thank's for your feedback.

Yes, that's the expected behavior. As I mentioned in the Known Issues section, bhyve-edk2 is missing a working GOP driver. As a result, graphical output is visible after i915 driver is loaded and initialized.
If I boot into a shell instead of a desktop environment like GDM, I'll get access to a text console. However, the login prompt is the first graphical output that I get.

Sep 8 2020, 3:37 PM · bhyve
khng300_gmail.com added a comment to D26209: GVT-d support for bhyve.
Sep 8 2020, 12:02 PM · bhyve
khng300_gmail.com added a comment to D26209: GVT-d support for bhyve.

I back-ported this to my own khng300/freebsd@releng/12.1 and I also had a relatively successful GVT-d passthrough trial! However, was it expected when using this with Linux guest the console being blank? I only saw output right after I started GDM (in Wayland), without access to text console at all.

Sep 8 2020, 9:46 AM · bhyve

Sep 3 2020

khng300_gmail.com added a comment to D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.

Can you submit the change upstream? If you did rename the patch file after the bug.

Sep 3 2020, 6:52 PM
khng300_gmail.com updated the diff for D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.

Unregister as long as the stream ended peacefully

Sep 3 2020, 10:17 AM
khng300_gmail.com updated the diff for D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.
  • Unregister as long as the stream ended peacefully
Sep 3 2020, 10:15 AM
khng300_gmail.com added a comment to D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.

At the mean time, the offending code was introduced in bug1647717.

Sep 3 2020, 5:45 AM

Sep 2 2020

khng300_gmail.com updated the test plan for D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.
Sep 2 2020, 7:34 PM
khng300_gmail.com requested review of D26303: www/firefox: Fix tab crashing when not using pulse-rust backend.
Sep 2 2020, 7:32 PM

Jul 30 2020

khng300_gmail.com added a comment to D25097: multimedia/obs-studio: pull in upstream patches for oss-audio support.

Looks good, but won't that be a lot of patches?

And I see the OSS audio support could also be patched to use the new scaling function where it uses NSEC_PER_SEC .

Jul 30 2020, 6:21 PM

Mar 19 2020

khng300_gmail.com added inline comments to D21839: bhyve: implement NVMe deallocate command.
Mar 19 2020, 5:20 PM
khng300_gmail.com added inline comments to D21839: bhyve: implement NVMe deallocate command.
Mar 19 2020, 5:17 PM
khng300_gmail.com created D24124: bhyve: implement NVMe flush command.
Mar 19 2020, 4:59 PM

Feb 12 2020

khng300_gmail.com added inline comments to D23591: bhyve: use stream_read() to read 12 bytes of RFB client version.
Feb 12 2020, 8:53 AM

Feb 10 2020

khng300_gmail.com updated the diff for D23591: bhyve: use stream_read() to read 12 bytes of RFB client version.

Updating D23591: bhyve: use stream_read() to read 12 bytes of RFB client version

Feb 10 2020, 8:42 AM
khng300_gmail.com updated the diff for D23591: bhyve: use stream_read() to read 12 bytes of RFB client version.
  • bhyve: use stream_read() to read 12 bytes of RFB client version
Feb 10 2020, 8:39 AM

Feb 9 2020

khng300_gmail.com created D23591: bhyve: use stream_read() to read 12 bytes of RFB client version.
Feb 9 2020, 3:51 PM

Jul 8 2019

khng300_gmail.com added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

Opps careless mistakes.

Jul 8 2019, 6:16 PM
khng300_gmail.com added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

Update according to @jhb 's suggestions.

Jul 8 2019, 5:22 PM
khng300_gmail.com added a comment to D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..

Add comments in regards to SM961/PM961.

Jul 8 2019, 2:08 AM

Jul 7 2019

D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word. now requires review to proceed.

Add comments in regards to SM961/PM961

Jul 7 2019, 5:23 PM
khng300_gmail.com updated the summary of D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..
Jul 7 2019, 12:15 PM
khng300_gmail.com created D20873: Program the MSI-X vector control field for MSI-X table entries without loading the previous content of the vector control word..
Jul 7 2019, 12:04 PM

Jun 30 2019

khng300_gmail.com added a comment to D20809: Fix erroneously setting NVME_FEAT_NUMBER_OF_QUEUES one less than the actual number of IO queues.

It seems i get something wrong about the regarding nvme features. I have to look more carefully at it

Jun 30 2019, 5:23 AM
khng300_gmail.com created D20809: Fix erroneously setting NVME_FEAT_NUMBER_OF_QUEUES one less than the actual number of IO queues.
Jun 30 2019, 4:58 AM

Jun 28 2019

khng300_gmail.com added a comment to D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK.
  • Updated according to @mckusick 's suggestion
Jun 28 2019, 4:57 AM

Jun 19 2019

khng300_gmail.com added a comment to D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK.

Fix commit message

Jun 19 2019, 8:09 AM
khng300_gmail.com created D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK.
Jun 19 2019, 8:04 AM

Jul 3 2018

khng300_gmail.com updated the diff for D16105: vm_map.9: Update to match the struct layout in sys/vm/vm_map.h.

Now remove the two affected lines as they are implementation-specific. Instead
one should read vm_map_min.9 and vm_map_max.9.

Jul 3 2018, 3:18 PM
khng300_gmail.com added a comment to D16105: vm_map.9: Update to match the struct layout in sys/vm/vm_map.h.
In D16105#341436, @kib wrote:

This is wrong, it exposes an implementation detail which is really not relevant when _KBI wrappers are used.

These two lines should be removed, and vm_map_min(9)/vm_map_max(9) documented instead.

Jul 3 2018, 3:12 PM
khng300_gmail.com created D16105: vm_map.9: Update to match the struct layout in sys/vm/vm_map.h.
Jul 3 2018, 1:54 AM