kevin.bowling_kev009.com (Kevin Bowling)
User

Projects

User Details

User Since
Jun 6 2015, 10:46 PM (136 w, 5 d)

Recent Activity

Mon, Jan 15

kevin.bowling_kev009.com accepted D13885: ixgbe(4): Update shared code, add support for X552, fix bug.
Mon, Jan 15, 2:21 PM

Tue, Jan 9

kevin.bowling_kev009.com updated subscribers of D13660: e1000: Add support for Ice Lake and Cannon Lake.
Tue, Jan 9, 3:42 PM

Wed, Jan 3

kevin.bowling_kev009.com added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Wed, Jan 3, 9:15 AM

Thu, Dec 28

kevin.bowling_kev009.com updated the diff for D13660: e1000: Add support for Ice Lake and Cannon Lake.
Thu, Dec 28, 4:59 AM
kevin.bowling_kev009.com created D13660: e1000: Add support for Ice Lake and Cannon Lake.
Thu, Dec 28, 4:57 AM

Wed, Dec 27

kevin.bowling_kev009.com abandoned D13594: ipfw SCTP grew accidental dependency on full options SCTP stack.

Thanks, your changes worked

Wed, Dec 27, 9:03 AM

Sun, Dec 24

kevin.bowling_kev009.com added a watcher for Intel Networking: kevin.bowling_kev009.com.
Sun, Dec 24, 6:21 AM

Sat, Dec 23

kevin.bowling_kev009.com created D13594: ipfw SCTP grew accidental dependency on full options SCTP stack.
Sat, Dec 23, 3:22 AM

Nov 27 2017

kevin.bowling_kev009.com added a watcher for PowerPC: kevin.bowling_kev009.com.
Nov 27 2017, 11:35 PM
kevin.bowling_kev009.com added a watcher for NUMA: kevin.bowling_kev009.com.
Nov 27 2017, 11:34 PM

Nov 13 2017

kevin.bowling_kev009.com updated subscribers of D11727: ixgbe(4): Update HEAD to use iflib.

@oliver out of curiosity can you boot it with a KERNCONF with options MAXCPU=12

Nov 13 2017, 8:07 PM

Oct 26 2017

kevin.bowling_kev009.com accepted D12805: Avoid enabling MSI-X if MSI-X is disabled globally..
Oct 26 2017, 11:33 PM

Oct 8 2017

kevin.bowling_kev009.com added a comment to D12615: Mbuf external storage improvements..

It LGTM. I know sfbufs are quite different on i386, do you need anyone to do some basic tests there?

Oct 8 2017, 12:24 AM

Sep 26 2017

kevin.bowling_kev009.com added reviewers for D12501: count bytes in vn_sendfile when pru_send returns EAGAIN: jtl, glebius.
Sep 26 2017, 7:29 AM

Sep 25 2017

kevin.bowling_kev009.com added reviewers for D12492: Ensure strict error handling of tcp_usr_send: jtl, glebius, sbruno, rrs.
Sep 25 2017, 4:58 PM

Sep 21 2017

kevin.bowling_kev009.com added a comment to D12422: loader: support for mixed-endianness ELF/loader and POWER8.

Freenode #ppc64 if you want to go direct, a lot of the firmware and kernel team are there

Sep 21 2017, 9:49 AM
kevin.bowling_kev009.com added a comment to D12422: loader: support for mixed-endianness ELF/loader and POWER8.

I'm just relaying a conversation :)

Sep 21 2017, 9:30 AM
kevin.bowling_kev009.com added a comment to D12422: loader: support for mixed-endianness ELF/loader and POWER8.

Some advice from an IBM firmware team member:
‎[22:51] ‎<‎segher‎>‎ ah ok. some review... don't use endian-swapping macros; use a macro to do the actual memory accesses in the endian you want, instead
‎[22:52] ‎<‎segher‎>‎ and yup, very cool to see some other os on p8 :-)

Sep 21 2017, 7:46 AM

Sep 11 2017

kevin.bowling_kev009.com added a comment to D12295: Kill gets().

This is silly to bikeshed. 12.0 wont be released for at least a year and -CURRENT is for API breaks. Users can run the current -STABLE trees in a jail if they have any shitware they need to support for a long time. It's also trivial to maintain the patch in a corporate tree if needed, or a compat lib that doesn't live in src/.

Sep 11 2017, 11:15 PM

Sep 6 2017

kevin.bowling_kev009.com accepted D12235: iflib rollup patch..
Sep 6 2017, 5:52 AM

Sep 4 2017

kevin.bowling_kev009.com added a comment to D12137: Adaptively enable/disable entropy collection from packets.

And by that I mean we should use random_harvest_fast

Sep 4 2017, 10:56 PM
kevin.bowling_kev009.com added a comment to D12137: Adaptively enable/disable entropy collection from packets.

I prefer the solution in https://reviews.freebsd.org/D12132, and provide commentary in there as to why we shouldn't grow a wart in iflib for what I believe are misunderstandings on entropy collection that occurred when Fortuna went in.

Sep 4 2017, 10:48 PM
kevin.bowling_kev009.com added a comment to D12132: Avoid spinning in random_harvest_queue.

@markm are you able to provide guidance on this or may we proceed in running the performance issues to ground?

Sep 4 2017, 1:57 AM

Aug 29 2017

kevin.bowling_kev009.com added a comment to D12132: Avoid spinning in random_harvest_queue.

The random situation has been bugging me since Fortuna went in, the default mask is WAY too aggressive. Schneier himself says "Slowing down the prng by a perceptible factor to get a few bits more security is counterproductive" in his article describing it. I think the right choice is to always use random_harvest_fast in the network paths.

Aug 29 2017, 4:23 AM

Aug 28 2017

kevin.bowling_kev009.com added a reviewer for D12138: Add support for using ithread style dispatch for grouptaskqueue threads: gallatin.
Aug 28 2017, 7:03 AM
kevin.bowling_kev009.com added a reviewer for D12137: Adaptively enable/disable entropy collection from packets: gallatin.
Aug 28 2017, 6:58 AM
kevin.bowling_kev009.com added a reviewer for D12142: Don't start grouptaskqueue threads for unused grouptaskqueues: glebius.
Aug 28 2017, 6:57 AM

Aug 23 2017

kevin.bowling_kev009.com updated subscribers of D12101: swfw_sync DELAY -> sleep conversion.
Aug 23 2017, 8:46 PM · network

Aug 14 2017

kevin.bowling_kev009.com added a comment to D12003: Use counter(9) for PLPMTUD counters.

Noob question, should freebsdversion bump since this alters the ABI?

Aug 14 2017, 8:45 PM · transport
kevin.bowling_kev009.com updated the diff for D12003: Use counter(9) for PLPMTUD counters.

Use the libxo plurals and fix the pmtud-failed label

Aug 14 2017, 6:54 PM · transport
kevin.bowling_kev009.com updated the diff for D12003: Use counter(9) for PLPMTUD counters.
Aug 14 2017, 6:17 AM · transport

Aug 12 2017

kevin.bowling_kev009.com created D12003: Use counter(9) for PLPMTUD counters.
Aug 12 2017, 5:32 AM · transport

Aug 11 2017

kevin.bowling_kev009.com added reviewers for D11969: refactoring in support of *future* change to cope with slow configuration path on INTC and BRCM drivers: gallatin, jtl, scottl.
Aug 11 2017, 1:39 AM

Jul 27 2017

kevin.bowling_kev009.com added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Jul 27 2017, 5:36 PM

Jul 25 2017

kevin.bowling_kev009.com added a reviewer for D11727: ixgbe(4): Update HEAD to use iflib: kmacy.
Jul 25 2017, 8:16 PM
kevin.bowling_kev009.com added a comment to D11712: Drop ixgbe rx lock during TCP LRO.

To document my understanding.. this is safe because interrupts are disabled while handling rx, including passing work to the 'que_task' if processing limits are present.

Jul 25 2017, 7:30 AM · Intel Networking
kevin.bowling_kev009.com created D11724: Drop ixl rx lock during TCP LRO.
Jul 25 2017, 1:17 AM · Intel Networking

Jul 24 2017

kevin.bowling_kev009.com added a comment to D11711: Fix LOR in if_lagg.
In D11711#242651, @mav wrote:

It won't work this way, since lagg_port_destroy() in case of error require WLOCK to be locked. If go this way, it at least should be relocked before calling lagg_port_destroy().

Jul 24 2017, 9:24 PM
kevin.bowling_kev009.com updated the diff for D11711: Fix LOR in if_lagg.
Jul 24 2017, 9:24 PM
kevin.bowling_kev009.com added inline comments to D11712: Drop ixgbe rx lock during TCP LRO.
Jul 24 2017, 7:55 PM · Intel Networking
kevin.bowling_kev009.com created D11712: Drop ixgbe rx lock during TCP LRO.
Jul 24 2017, 7:39 AM · Intel Networking
kevin.bowling_kev009.com created D11711: Fix LOR in if_lagg.
Jul 24 2017, 7:30 AM

Jul 21 2017

kevin.bowling_kev009.com updated the summary of D11684: net-p2p/bitcoin{,-daemon,-utils} 0.14.2.
Jul 21 2017, 7:02 AM
kevin.bowling_kev009.com added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

@sepherosa_gmail.com does this look good to you now?

Jul 21 2017, 4:37 AM
kevin.bowling_kev009.com created D11684: net-p2p/bitcoin{,-daemon,-utils} 0.14.2.
Jul 21 2017, 1:48 AM

Jun 28 2017

kevin.bowling_kev009.com created D11387: Garbage collect kernel option TWA_FLASH_FIRMWARE.
Jun 28 2017, 4:31 AM

Jun 16 2017

kevin.bowling_kev009.com added inline comments to D11085: TCP Blackbox Recorder.
Jun 16 2017, 4:20 PM
kevin.bowling_kev009.com added inline comments to D11085: TCP Blackbox Recorder.
Jun 16 2017, 2:26 AM

Jun 12 2017

kevin.bowling_kev009.com added a reviewer for D11003: Load balance sockets with new SO_REUSEPORT_LB option: sepherosa_gmail.com.
Jun 12 2017, 4:12 PM

Jun 10 2017

kevin.bowling_kev009.com added a comment to D11105: Compile the default TCP stack as a module.

Ok, sounds like it's not the time to have that discussion since we don't yet really know how the other stacks will compose.

Jun 10 2017, 3:24 PM

Jun 9 2017

kevin.bowling_kev009.com added a comment to D11105: Compile the default TCP stack as a module.

Should tcp_default.c move under tcp_stacks/default.c?

Jun 9 2017, 5:51 PM

Jun 7 2017

kevin.bowling_kev009.com added a comment to D11083: cddl/lib/libzfs build warning fixes.

Sorry wrong repo in last comment, here's the one https://github.com/openzfs/openzfs

Jun 7 2017, 7:37 PM
kevin.bowling_kev009.com added a comment to D11083: cddl/lib/libzfs build warning fixes.

This will need to be a github pull request against https://github.com/illumos/illumos-gate

Jun 7 2017, 7:01 PM

May 31 2017

kevin.bowling_kev009.com updated subscribers of D11003: Load balance sockets with new SO_REUSEPORT_LB option.
May 31 2017, 10:28 AM

May 26 2017

D8556: Fix spurious retransmit recovery on low latency networks is now accepted and ready to land.

@kmacy is this still relevant?

May 26 2017, 7:57 AM · network

May 25 2017

kevin.bowling_kev009.com added a comment to D10556: Update cubic constants.

@lstewart our staff transport committer has moved on, would you be willing to commit this to HEAD for Matt?

May 25 2017, 11:47 PM · network

Apr 27 2017

kevin.bowling_kev009.com added a comment to D10435: x86: Add dynamic interrupt rebalancing.

I don't have the credibility to slow anything down, I'll table the broader discussion for BSDCan dev summit.

Apr 27 2017, 9:58 AM
kevin.bowling_kev009.com added a comment to D10435: x86: Add dynamic interrupt rebalancing.

I'm not sure I fully understand this, but my reading is that it moves intr threads that are typically round-robin distributed once during boot/attach around at runtime at 1Hz? I do have some concerns if that is the case, particularly for networking. We rely heavily on prefetching data, so intr movement and intr preemption are both bad IMO (but to what extent is actual research, and should include generic scheduling policy). An overarching concern of mine is keeping things (locks and data) vertically aligned on a core between layers.. from tx/rx intrs up through transport layer and application (via RSS). There are things in motion that seem to move away rather than toward that goal.

Apr 27 2017, 12:50 AM

Apr 5 2017

kevin.bowling_kev009.com updated subscribers of D9894: Honor net.inet.tcp.drop_synfin in other states than LISTEN.
Apr 5 2017, 9:26 AM

Mar 24 2017

kevin.bowling_kev009.com created D10126: em(4) em_print_debug_info crash.
Mar 24 2017, 8:37 AM
kevin.bowling_kev009.com updated subscribers of D9851: ixgbe(4): Update HEAD to 3.2.12-k.

I think this review supersedes D5213, if there are other diffs they should be added here. Matt approved the change proposed by @krzysztof.galazka_intel.com https://github.com/mattmacy/networking/pull/5

Mar 24 2017, 2:11 AM

Mar 23 2017

kevin.bowling_kev009.com added a comment to D9851: ixgbe(4): Update HEAD to 3.2.12-k.

I would like to see this integrated soon, @sbruno has gotten iflib.c leveled up to a good spot and we are running it in production for e1000. @jeffrey.e.pieper_intel.com are you ok with @cramerj_intel.com latest fixes?

Mar 23 2017, 10:27 PM

Mar 20 2017

kevin.bowling_kev009.com added a reviewer for D10052: sparc64 EARLY_AP_STARTUP: marius.
Mar 20 2017, 6:20 AM

Mar 19 2017

kevin.bowling_kev009.com added a comment to D10052: sparc64 EARLY_AP_STARTUP.

To clarify for @sbruno this isn't related to iflib or the issues we had there, just doing a thing while I'm in sparc64.

Mar 19 2017, 11:20 AM
kevin.bowling_kev009.com updated the test plan for D10052: sparc64 EARLY_AP_STARTUP.
Mar 19 2017, 11:19 AM
kevin.bowling_kev009.com created D10052: sparc64 EARLY_AP_STARTUP.
Mar 19 2017, 10:37 AM

Feb 24 2017

kevin.bowling_kev009.com added a comment to D4767: MFC the remainder of nv(9) and pci_iov(9) back to stable/10.

I think that is a good call, 10 is pretty long in the tooth these days.

Feb 24 2017, 7:16 AM

Jan 16 2017

kevin.bowling_kev009.com added a comment to D7848: rework libGL/libEGL/libGLESv2/nvidia-driver/xorg-server mess.

This needs to be resynced against ports updates. I can do so if desired.

Jan 16 2017, 1:41 AM

Jan 13 2017

kevin.bowling_kev009.com updated the diff for D9150: Add kevent EVFILT_EMPTY for notification when a client has received all data.

Use sbused accessor per BZ

Jan 13 2017, 7:26 PM

Jan 12 2017

kevin.bowling_kev009.com updated the diff for D9150: Add kevent EVFILT_EMPTY for notification when a client has received all data.

Updated to use sb_ccc. Add diff context

Jan 12 2017, 9:53 PM
kevin.bowling_kev009.com retitled D9150: Add kevent EVFILT_EMPTY for notification when a client has received all data from Add kevent EVFILT_EMPTY for socket empty notification to Add kevent EVFILT_EMPTY for notification when a client has received all data.
Jan 12 2017, 3:04 AM
kevin.bowling_kev009.com retitled D9150: Add kevent EVFILT_EMPTY for notification when a client has received all data from to Add kevent EVFILT_EMPTY for socket empty notification.
Jan 12 2017, 2:51 AM

Dec 9 2016

kevin.bowling_kev009.com updated subscribers of D8737: TSO handling in IPv6 when ip options are present..

I found Microsoft's docs quite good https://msdn.microsoft.com/en-us/windows/hardware/drivers/network/offloading-the-segmentation-of-large-tcp-packets.

Dec 9 2016, 12:03 AM

Nov 16 2016

kevin.bowling_kev009.com added a comment to D4810: Properly save the original MSS during blackhole detection.

Ping @jtl

Nov 16 2016, 5:19 AM

Oct 19 2016

kevin.bowling_kev009.com abandoned D4232: MFC SR-IOV to 10-STABLE.
Oct 19 2016, 11:00 PM
kevin.bowling_kev009.com added a comment to D5213: convert ixgbe to iflib.

Just to follow up publicly with my own testing results, we've addressed all known issues and the performance and queue distribution look very good on a production Internet facing system.

Oct 19 2016, 8:30 AM

Oct 12 2016

kevin.bowling_kev009.com added a reviewer for D8225: Let congestion control algorithms decide congestion window.: kmacy.
Oct 12 2016, 6:22 AM

Oct 10 2016

kevin.bowling_kev009.com added a comment to D7649: Fix bug where malloc(.., M_NOWAIT) return value is not checked.

Matt approved in LLNW IRC

Oct 10 2016, 9:25 PM

Oct 9 2016

kevin.bowling_kev009.com added a comment to D5213: convert ixgbe to iflib.

@sbruno I can't update the diff myself, can you please apply https://gist.github.com/kev009/4e464d396782c677ef5a6e7ff61bfc9b on top of the latest rev?

Oct 9 2016, 12:43 AM

Oct 8 2016

kevin.bowling_kev009.com retitled D8199: Remove extra space between point to point links and netmask in ifconfig output from to Remove extra space between point to point links and netmask in ifconfig output.
Oct 8 2016, 6:16 PM

Oct 6 2016

kevin.bowling_kev009.com added a comment to D5213: convert ixgbe to iflib.

This is a fresh clone...tried it twice w/ the same results.

Oct 6 2016, 9:22 PM
kevin.bowling_kev009.com updated D5213: convert ixgbe to iflib.
Oct 6 2016, 9:47 AM
kevin.bowling_kev009.com updated D5213: convert ixgbe to iflib.
Oct 6 2016, 9:47 AM

Oct 5 2016

kevin.bowling_kev009.com added a reviewer for D7821: Preserve ECN bits when merging frames in LRO: hiren.
Oct 5 2016, 9:23 AM

Oct 4 2016

kevin.bowling_kev009.com added a reviewer for D5213: convert ixgbe to iflib: gnn.
Oct 4 2016, 10:36 PM
kevin.bowling_kev009.com added a reviewer for D5334: Move netmap selinfo.h in to sensible location: gnn.
Oct 4 2016, 10:33 PM

Oct 3 2016

kevin.bowling_kev009.com added a comment to D8072: Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242..

As far as I can tell this is good. I have a box serving large volume of internet facing traffic with a data accept filter.

Oct 3 2016, 7:22 AM

Sep 29 2016

kevin.bowling_kev009.com added reviewers for D7986: Simplify cubic_ack_received: hiren, lstewart, gnn.
Sep 29 2016, 8:11 AM

Sep 23 2016

kevin.bowling_kev009.com added reviewers for D8021: Correctness fixes to Cubic : hiren, gnn.
Sep 23 2016, 11:38 PM

Sep 21 2016

kevin.bowling_kev009.com updated subscribers of D7016: Add CK.

@gnn I heard there was some news on the FF front, can we import this to vendor?

Sep 21 2016, 9:00 AM

Aug 31 2016

kevin.bowling_kev009.com added a comment to D7723: x11/nvidia-driver: Update to 367.44 (PR #212287).

LGTM

Aug 31 2016, 6:34 PM

Jul 14 2016

kevin.bowling_kev009.com updated subscribers of D7135: A problem with ASYNC drain.
Jul 14 2016, 5:26 PM

Jun 26 2016

kevin.bowling_kev009.com added a comment to D6967: Sync iwm against dfbsd .

I haven't looked at this patch in detail, but I thought I would point out the obvious, that manu's work changed some additional files required to update the firmware - as you alluded to in your original comment above:

Jun 26 2016, 10:58 PM
kevin.bowling_kev009.com added a reviewer for D6967: Sync iwm against dfbsd : manu.
Jun 26 2016, 9:17 PM
kevin.bowling_kev009.com updated the diff for D6967: Sync iwm against dfbsd .

Address Andriy's comment on accidentally removing rS299883.

Jun 26 2016, 8:57 PM
kevin.bowling_kev009.com added a comment to D6967: Sync iwm against dfbsd .

It seems to go through 2 watchdog resets on boot while scanning/associating, then is fairly reliable. I've now passed a few gigabytes over the 8260 w/o hiccups.

Jun 26 2016, 9:21 AM
kevin.bowling_kev009.com retitled D6967: Sync iwm against dfbsd from to Sync iwm against dfbsd .
Jun 26 2016, 6:10 AM

May 21 2016

kevin.bowling_kev009.com abandoned D4249: MFC libnv to 10-STABLE.
May 21 2016, 6:15 AM

May 20 2016

kevin.bowling_kev009.com added inline comments to D6472: Use optimised complexity safe sort routine instead of the kernel's qsort.
May 20 2016, 6:01 PM

Mar 27 2016

kevin.bowling_kev009.com accepted D5753: CAM: Add 4k quirks for Samsung PM851 SSD.
Mar 27 2016, 5:38 PM