Page MenuHomeFreeBSD

ing.castellanosdz_gmail.com (Luis Castellanos)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 10 2026, 5:11 AM (8 w, 6 d)

Recent Activity

Mon, Oct 5

ing.castellanosdz_gmail.com requested review of D60356: mlx4ib: Fix SRQ resource leak on mlx4_ib_create_srq() copyout failure.
Mon, Oct 5, 3:58 AM
ing.castellanosdz_gmail.com requested review of D60354: mlx4ib: Fix EQ resource leak on mlx4_ib_add() error path.
Mon, Oct 5, 3:55 AM

Sun, Sep 13

ing.castellanosdz_gmail.com updated the test plan for D59140: bpf: assert that calculated header length fits in sockaddr.
Sun, Sep 13, 2:48 PM
ing.castellanosdz_gmail.com updated the summary of D59140: bpf: assert that calculated header length fits in sockaddr.
Sun, Sep 13, 2:44 PM
ing.castellanosdz_gmail.com added a comment to D59140: bpf: assert that calculated header length fits in sockaddr.

Updated as suggested: replaced the sa_len check in individual drivers
with MPASS(hlen <= sizeof(sockp->sa_data)) in bpf_movein() before the
bcopy. Summary updated to reflect the evolution of the revision.

Sun, Sep 13, 2:25 PM
ing.castellanosdz_gmail.com updated the diff for D59140: bpf: assert that calculated header length fits in sockaddr.

Updated per glebius's suggestion: replaced the sa_len check in individual
drivers with a defensive assertion in bpf_movein() asserting
MPASS(hlen <= sizeof(sockp->sa_data)) before the bcopy. Original
attribution (missing sa_len initialization) was not sustained after review.

Sun, Sep 13, 2:23 PM

Sat, Sep 12

ing.castellanosdz_gmail.com added a comment to D59140: bpf: assert that calculated header length fits in sockaddr.

Thanks for the correction on DLT_NULL and for reviewing this carefully. You are right on both points.

Sat, Sep 12, 11:47 PM

Sep 11 2026

ing.castellanosdz_gmail.com added a comment to D59140: bpf: assert that calculated header length fits in sockaddr.

Thank you for the question, glebius.

Sep 11 2026, 2:52 PM
ing.castellanosdz_gmail.com updated the diff for D59140: bpf: assert that calculated header length fits in sockaddr.

Updating D59140: if_output: validate sa_len before reading sa_data for BPF address family

Rebased against stable/14 as of 2026-09-10. Line offsets updated for
if_tuntap.c (1455), if_me.c (544), if_gif.c (409), if_disc.c (181),
if_loop.c (229). Logic and fix unchanged from original D59140.

Sep 11 2026, 12:36 AM

Aug 24 2026

ing.castellanosdz_gmail.com requested review of D59140: bpf: assert that calculated header length fits in sockaddr.
Aug 24 2026, 6:38 AM

Aug 10 2026

ing.castellanosdz_gmail.com added a comment to D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.

Thank you for the review, kp.

Aug 10 2026, 1:03 PM
ing.castellanosdz_gmail.com updated the diff for D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.

Address reviewer feedback from kp

Aug 10 2026, 12:54 PM
ing.castellanosdz_gmail.com requested review of D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.
Aug 10 2026, 7:55 AM