Page MenuHomeFreeBSD

greg_unrelenting.technology (Greg V)
User

Projects

User Details

User Since
Dec 9 2017, 2:51 PM (174 w, 3 d)

Recent Activity

Mon, Apr 5

greg_unrelenting.technology added inline comments to D29479: x11: document the latest best advice about graphics.
Mon, Apr 5, 4:32 PM

Thu, Apr 1

greg_unrelenting.technology added a comment to D29534: spibus: add cs_delay ivar.
In D29534#662122, @manu wrote:

That doesn't seems to be specific to the Apple hardware but to the intel controller.

Thu, Apr 1, 4:12 PM
greg_unrelenting.technology requested review of D29534: spibus: add cs_delay ivar.
Thu, Apr 1, 1:42 PM
greg_unrelenting.technology accepted D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().

Builds fine for me

Thu, Apr 1, 1:33 PM
greg_unrelenting.technology abandoned D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
Thu, Apr 1, 1:33 PM
greg_unrelenting.technology updated the diff for D29276: smbios: support getting address from EFI.

oops, thought I did remove that include, but somehow didn't

Thu, Apr 1, 1:29 PM

Wed, Mar 31

greg_unrelenting.technology updated the diff for D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.

Oops, with git now, we don't need $FreeBSD$ in the Makefile either

Wed, Mar 31, 7:03 PM
greg_unrelenting.technology updated the diff for D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.
  • Use backlight(9) subsystem
  • Add SPDX tag
  • Some formatting changes
Wed, Mar 31, 7:02 PM
greg_unrelenting.technology updated the diff for D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.

Only include linker_set changes

Wed, Mar 31, 6:50 PM
greg_unrelenting.technology updated the diff for D29276: smbios: support getting address from EFI.
  • options EFIRT is not in MINIMAL, so now device smbios can't be either, so kldload smbios would be the way to go in MINIMAL
  • address feedback
Wed, Mar 31, 6:47 PM
greg_unrelenting.technology reclaimed D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.

Oops, the sets were not fixed

Wed, Mar 31, 6:25 PM

Tue, Mar 30

greg_unrelenting.technology abandoned D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.

libsa has been fixed by 59b2caef, dev/md by 69e18c9b7b12 (by just removing, heh)

Tue, Mar 30, 3:18 PM
greg_unrelenting.technology added a comment to D29020: efifb,vbefb: implement vd_fini.

ping

Tue, Mar 30, 1:30 PM

Fri, Mar 19

greg_unrelenting.technology added a comment to D29332: WIP to add sysutils/fwupd (if it runs well).
In D29332#656928, @jrm wrote:

WIP to add devel/libgusb, which is a dependency for sysutils/fwupd

Current blocker for this port is that it requires libusb1 >= 1.0.19, but reports that we have 1.0.13 on 12.2

Fri, Mar 19, 1:57 PM

Thu, Mar 18

greg_unrelenting.technology added a comment to D29323: Implement O_PATH.

+1 on the request from xdg-desktop-portal

Thu, Mar 18, 4:18 PM

Mon, Mar 15

greg_unrelenting.technology abandoned D29277: smbios: expose useful DMI information as sysctl and dmesg.

Most of that info is already available through kenv(1) and/or kenv(2):

Mon, Mar 15, 9:32 PM
greg_unrelenting.technology requested review of D29277: smbios: expose useful DMI information as sysctl and dmesg.
Mon, Mar 15, 9:16 PM
greg_unrelenting.technology added inline comments to D29276: smbios: support getting address from EFI.
Mon, Mar 15, 9:02 PM
greg_unrelenting.technology updated the diff for D29276: smbios: support getting address from EFI.

oops, forgot efi.h change

Mon, Mar 15, 9:02 PM
greg_unrelenting.technology added reviewers for D29270: ipmi,smbios: move smbios_walk_table to smbios.h: allanjude, rpokala.
Mon, Mar 15, 8:55 PM
greg_unrelenting.technology requested review of D29276: smbios: support getting address from EFI.
Mon, Mar 15, 8:53 PM
greg_unrelenting.technology requested review of D29270: ipmi,smbios: move smbios_walk_table to smbios.h.
Mon, Mar 15, 5:55 PM

Mar 14 2021

greg_unrelenting.technology updated the summary of D29249: intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point), apply child's mode/speed, cleanup.
Mar 14 2021, 8:51 PM
greg_unrelenting.technology updated the diff for D29249: intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point), apply child's mode/speed, cleanup.

argh, left another debug print :D

Mar 14 2021, 6:38 PM
greg_unrelenting.technology updated the diff for D29249: intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point), apply child's mode/speed, cleanup.

Also add suspend-resume support (need to backup/restore private registers, also reinitialize).

Mar 14 2021, 6:19 PM

Mar 13 2021

greg_unrelenting.technology added a comment to D29249: intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point), apply child's mode/speed, cleanup.

One interesting problem that I'm not sure how to properly solve: this device's description in ACPI (at least on Lynx/Wildcat) does have a _CID:

Mar 13 2021, 7:23 PM
greg_unrelenting.technology requested review of D29249: intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point), apply child's mode/speed, cleanup.
Mar 13 2021, 3:32 PM

Mar 10 2021

greg_unrelenting.technology added reviewers for D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12: emaste, manu.
Mar 10 2021, 10:10 PM
greg_unrelenting.technology added reviewers for D29157: kern.mk: use -Wno-error=.. instead of -Wno-error-.. to fix build with clang 12: emaste, manu.
Mar 10 2021, 10:09 PM

Mar 9 2021

greg_unrelenting.technology added inline comments to D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
Mar 9 2021, 7:53 PM
greg_unrelenting.technology updated the summary of D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
Mar 9 2021, 7:51 PM
greg_unrelenting.technology requested review of D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
Mar 9 2021, 7:50 PM
greg_unrelenting.technology requested review of D29158: Remove any -flto* flag, not just literal -flto.
Mar 9 2021, 7:47 PM
greg_unrelenting.technology requested review of D29157: kern.mk: use -Wno-error=.. instead of -Wno-error-.. to fix build with clang 12.
Mar 9 2021, 7:45 PM
greg_unrelenting.technology requested review of D29150: bsd.cpu.mk: add support for x86-64-v[234] levels as CPUTYPE.
Mar 9 2021, 5:39 PM
greg_unrelenting.technology updated the diff for D29020: efifb,vbefb: implement vd_fini.

Added vbefb (not tested)

Mar 9 2021, 12:35 PM

Mar 2 2021

greg_unrelenting.technology updated the summary of D29020: efifb,vbefb: implement vd_fini.
Mar 2 2021, 9:02 PM
greg_unrelenting.technology requested review of D29020: efifb,vbefb: implement vd_fini.
Mar 2 2021, 9:01 PM

Mar 1 2021

greg_unrelenting.technology added reviewers for D28995: hid: add opt_hid.h to modules that use HID_DEBUG: wulf, Contributor Reviews (base).
Mar 1 2021, 12:13 PM
greg_unrelenting.technology requested review of D28995: hid: add opt_hid.h to modules that use HID_DEBUG.
Mar 1 2021, 12:12 PM

Feb 25 2021

greg_unrelenting.technology updated the diff for D20974: Port sbsawdt (ARM SBSA generic watchdog) driver from NetBSD.

Remove __BIT NetBSD-ism, add sc_ to all sc fields

Feb 25 2021, 4:15 PM · arm64
greg_unrelenting.technology added inline comments to D20974: Port sbsawdt (ARM SBSA generic watchdog) driver from NetBSD.
Feb 25 2021, 4:08 PM · arm64

Feb 20 2021

greg_unrelenting.technology updated the diff for D26630: Update pygobject3.

Now 3.38.0.

Feb 20 2021, 11:43 AM

Feb 19 2021

greg_unrelenting.technology added a reviewer for D26630: Update pygobject3: tcberner.
Feb 19 2021, 11:37 AM
greg_unrelenting.technology updated subscribers of D26630: Update pygobject3.

@bapt @tcberner ping

Feb 19 2021, 11:37 AM

Feb 16 2021

greg_unrelenting.technology added reviewers for D20974: Port sbsawdt (ARM SBSA generic watchdog) driver from NetBSD: scottph, emaste, andrew.
Feb 16 2021, 7:31 PM · arm64
greg_unrelenting.technology added a comment to D28709: gicv3_its: Leave LPI interrupts enable during handling.

Are legacy interrupts supported on this platform?

Feb 16 2021, 7:07 PM
greg_unrelenting.technology added a reviewer for D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode: capsicum.
Feb 16 2021, 3:12 PM
greg_unrelenting.technology updated the summary of D28704: md: check uid when non-root users detach/resize the mds.
Feb 16 2021, 3:10 PM
greg_unrelenting.technology requested review of D28704: md: check uid when non-root users detach/resize the mds.
Feb 16 2021, 3:05 PM
greg_unrelenting.technology added reviewers for D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode: emaste, Contributor Reviews (base).
Feb 16 2021, 2:42 PM
greg_unrelenting.technology requested review of D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode.
Feb 16 2021, 2:41 PM

Feb 1 2021

greg_unrelenting.technology added a comment to D26836: linsysfs: add drm render node.

The only (non) issue I might have is that I don't understand what it does. You've said it fixes the CentOS 7 glxgears from ports on Radeon; the same glxgears worked for me last time I've checked, and one difference is that I'm using integrated Intel graphics.

Feb 1 2021, 2:51 PM
greg_unrelenting.technology added a reviewer for D26836: linsysfs: add drm render node: manu.
Feb 1 2021, 2:47 PM

Jan 29 2021

greg_unrelenting.technology added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Jan 29 2021, 12:01 PM

Jan 20 2021

greg_unrelenting.technology updated the diff for D24423: arm/pmu: add ACPI attachment, more FDT names.

Rebased, switched to MPIDR for cpuid finding

Jan 20 2021, 3:15 PM · arm64

Jan 10 2021

greg_unrelenting.technology added a comment to D28050: Implement enforcing write XOR execute mapping policy..

The code of the binary itself doesn't require X stack, but the attempt to map stack as X somehow comes from libthr anyway for no good reason.
Anyway I just made these stacks non-executable too in my tree, so this is just notes for upstream about what things conflict with W^X.

Jan 10 2021, 12:24 AM

Jan 9 2021

greg_unrelenting.technology added a comment to D28061: linuxkpi: add kernel_fpu_begin/kernel_fpu_end.

Done. It booted and I used it now for about 15 min. without any in the face issue.
Do you need any logs or sth. ?

Jan 9 2021, 4:35 PM · linuxkpi
greg_unrelenting.technology added a comment to D28061: linuxkpi: add kernel_fpu_begin/kernel_fpu_end.

How does the test plan look like ?

Jan 9 2021, 2:57 PM · linuxkpi
greg_unrelenting.technology requested review of D28061: linuxkpi: add kernel_fpu_begin/kernel_fpu_end.
Jan 9 2021, 1:52 PM · linuxkpi
greg_unrelenting.technology added a comment to D28050: Implement enforcing write XOR execute mapping policy..

Hm, ctfmerge hangs in cond_wait_common_thr_umtx_timedwait_uint_umtx_op_err
(I think this didn't happen with the previous W^X variant enabled but I'm not 100% sure)

Jan 9 2021, 1:38 PM

Jan 7 2021

greg_unrelenting.technology requested review of D28018: openzfs: attach pam_zfs_key to build.
Jan 7 2021, 11:20 AM · ZFS

Jan 6 2021

greg_unrelenting.technology added a comment to D28009: WIP: arm64: enable the ipmi module.

I wonder if there are machines that support any of the existing communication methods. eMAG would need acpi-i2c support…

Jan 6 2021, 10:45 PM

Jan 4 2021

greg_unrelenting.technology requested review of D27953: rtld: When relocating, map without PROT_EXEC.
Jan 4 2021, 5:45 PM
greg_unrelenting.technology updated the diff for D24933: implement W^X for mmap and mprotect.

Added flag check (NT_FREEBSD_FCTL_WXNEEDED)

Jan 4 2021, 5:03 PM
greg_unrelenting.technology commandeered D24933: implement W^X for mmap and mprotect.
Jan 4 2021, 5:02 PM

Jan 3 2021

greg_unrelenting.technology abandoned D27943: ccp: add new PCI ID for Zen 2/3.

or RDRAND

Jan 3 2021, 6:13 PM
greg_unrelenting.technology requested review of D27943: ccp: add new PCI ID for Zen 2/3.
Jan 3 2021, 5:04 PM

Dec 30 2020

greg_unrelenting.technology added a comment to D26836: linsysfs: add drm render node.

Ping?

Dec 30 2020, 12:33 AM

Dec 28 2020

greg_unrelenting.technology added inline comments to D27800: Man page for AMD 10GbE driver.
Dec 28 2020, 10:40 PM
greg_unrelenting.technology updated the diff for D26642: Add DTYPE/KF_TYPE and procstat support for dma-buf.
  • Rebase on top of landed eventfd :)
  • Remove padding fields
Dec 28 2020, 10:06 PM

Dec 25 2020

greg_unrelenting.technology accepted D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
In D26668#620034, @kib wrote:

Is this right, does Linux sources use e.g. EFD_NONBLOCK or O_NONBLOCK ?

Dec 25 2020, 8:21 PM · Linux Emulation

Dec 18 2020

greg_unrelenting.technology added inline comments to D27666: Enable ASLR by default for 64-bit executables..
Dec 18 2020, 4:37 PM · PowerPC, security, arm64

Dec 12 2020

greg_unrelenting.technology added a comment to D27420: loader: implement framebuffer console.

Notable side effect of setting kern.vt.fb.default_mode: switching from efifb to GPU fb does not increase resolution.
Fun effect with Radeon GPUs: a GOP mode with the wrong aspect ratio will be stretched, but GPU native framebuffer setting the same resolution via kern.vt.fb.default_mode will instead be pillarboxed :)

Dec 12 2020, 3:49 PM
greg_unrelenting.technology updated the diff for D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 12 2020, 12:18 PM

Dec 11 2020

greg_unrelenting.technology added inline comments to D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 11 2020, 6:22 PM
greg_unrelenting.technology added inline comments to D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 11 2020, 6:17 PM
greg_unrelenting.technology requested review of D27570: superio,wbwd: Add Nuvoton NCT6796.
Dec 11 2020, 1:29 PM

Dec 10 2020

greg_unrelenting.technology requested review of D27552: amdsmn,amdtemp: add support for Family 19h (Zen 3).
Dec 10 2020, 7:13 PM

Dec 5 2020

greg_unrelenting.technology updated the summary of D20830: audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations.
Dec 5 2020, 5:19 PM
greg_unrelenting.technology updated the summary of D20830: audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations.
Dec 5 2020, 5:15 PM
greg_unrelenting.technology added inline comments to D20830: audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations.
Dec 5 2020, 5:11 PM
greg_unrelenting.technology updated the diff for D20830: audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations.

oof. Hopefully this is good now, I haven't tested everything, but lots of things build fine without gtk2 now.

Dec 5 2020, 5:09 PM
greg_unrelenting.technology added a comment to D24917: Add ACPI attachment for the Vybrid VF610 I2C controller.

https://github.com/freebsd/freebsd/commit/36362eb0a0a1862a0898a6e17844a54f3f28f114 looks like extra code in the main driver itself was required for this hardware to work too, and we now have that

Dec 5 2020, 4:26 PM · arm64, ARM
greg_unrelenting.technology commandeered D20830: audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations.
Dec 5 2020, 12:34 PM
greg_unrelenting.technology added a comment to D20830: audio/libcanberra: add Mk/Uses/canberra.mk, modularize plugins/integrations.

Way too many things have :gtk2 here, no gtk3 apps should need it

Dec 5 2020, 12:52 AM

Nov 28 2020

greg_unrelenting.technology added inline comments to D26776: Skip make includes for (most) directories without includes.
Nov 28 2020, 5:05 PM
greg_unrelenting.technology added inline comments to D26776: Skip make includes for (most) directories without includes.
Nov 28 2020, 4:13 PM

Nov 21 2020

greg_unrelenting.technology added inline comments to D27239: WIP: New port: x11/kitty: Cross-platform, fast, featureful, GPU-based terminal emulator.
Nov 21 2020, 4:35 PM

Nov 17 2020

greg_unrelenting.technology added a comment to D23085: DRM: Add DRM core files and DRMKPI.

I suspect this would be much more acceptable if rather than "never using linuxkpi" and introducing some duplication, it would be something like a clearer separation of linuxkpi into "bottom layer linuxkpi" (that doesn't force "writing a linux driver" but provides functionality necessary for e.g. drm) and "top layer linuxkpi" (the stuff that makes linux drivers almost just compile). It's already somewhat like that – it is possible to just pick some headers from linuxkpi and use their functions in a native driver, and it doesn't force you to write a linux driver.

Nov 17 2020, 12:29 AM

Nov 11 2020

greg_unrelenting.technology updated the summary of D27180: uaudio: add sysctl hw.usb.uaudio.handle_hid to allow disabling HID volume keys support.
Nov 11 2020, 10:13 PM
greg_unrelenting.technology added inline comments to D27180: uaudio: add sysctl hw.usb.uaudio.handle_hid to allow disabling HID volume keys support.
Nov 11 2020, 9:04 PM
greg_unrelenting.technology requested review of D27180: uaudio: add sysctl hw.usb.uaudio.handle_hid to allow disabling HID volume keys support.
Nov 11 2020, 5:56 PM

Nov 10 2020

greg_unrelenting.technology requested review of D27158: Allow rtprio_thread to operate on threads of any process.
Nov 10 2020, 12:44 AM

Nov 9 2020

greg_unrelenting.technology retitled D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall from Add native system call for eventfd to Expose eventfd in the native API/ABI using a new __specialfd syscall.
Nov 9 2020, 4:41 PM · Linux Emulation
greg_unrelenting.technology added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Now named with the __ convention and using libc_private (didn't know about it).

Nov 9 2020, 4:40 PM · Linux Emulation
greg_unrelenting.technology updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.
Nov 9 2020, 4:38 PM · Linux Emulation

Nov 6 2020

greg_unrelenting.technology updated the diff for D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Added specialfd. Okay, that doesn't look too bad. I haven't tested intentionally causing problems from userspace, but other syscalls seem to be doing the same thing as here with user structs, I guess everything that could go wrong is handled inside copyin?

Nov 6 2020, 10:23 PM · Linux Emulation
greg_unrelenting.technology added a comment to D27113: Only try to retrieve UUID from SMBIOS on x86 machines.

Server-class arm64 machines also have SMBIOS data present. Maybe just condition the actual warning print to amd64 | i386 but try it everywhere?

Nov 6 2020, 4:28 PM
greg_unrelenting.technology added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Another thing. That syscall, would it have to be documented? Or would it be okay to pretend that we have the eventfd(2) "system call" when in reality it's a libc function calling into a private specialfd system call?

Nov 6 2020, 12:39 PM · Linux Emulation