Page MenuHomeFreeBSD

greg_unrelenting.technology (Greg V)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2017, 2:51 PM (79 w, 2 d)

Recent Activity

Mon, Jun 10

greg_unrelenting.technology created D20591: Make it obvious that SR-IOV VF creation fails because of the PCIe bus, not the device driver.
Mon, Jun 10, 7:12 PM · PCI

Tue, May 28

greg_unrelenting.technology added a comment to D20437: lang/zig-devel: new port.

Works fine on aarch64, please add it to the list

Tue, May 28, 8:59 PM

Mon, May 27

greg_unrelenting.technology updated the diff for D19896: Match PCI UART devices using PCI data from the ACPI SPCR table.

Rebased for rS348195 (D20357)

Mon, May 27, 10:32 AM · arm64

Wed, May 22

greg_unrelenting.technology accepted D20357: Use ACPI SPCR on x86.
Wed, May 22, 10:58 PM

Tue, May 21

greg_unrelenting.technology added a comment to D20327: Don't reset memory attributes when mapping physical addresses for ACPI..

I wonder if this is what we need on aarch64 for the Ampere eMAG server to not panic in ACPI: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237055#c40

Tue, May 21, 5:38 PM

May 14 2019

greg_unrelenting.technology added a comment to D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.

update: what's hanging is the WRITE4 for putting the PLL into normal mode!

May 14 2019, 8:30 PM · arm64
greg_unrelenting.technology added a comment to D20250: Build arm64 kernel with inline ffs, fls.

Kernel with this patch boots fine on Amazon EC2 (which btw you can use too, freebsd-snapshots posts have aarch64 AMIs)

May 14 2019, 9:54 AM

May 11 2019

greg_unrelenting.technology abandoned D19336: Enable SD/MMC (microSD and eMMC controllers) on the Rockchip RK3399 SoC.

new emmc patch is D20156

May 11 2019, 2:19 PM · arm64

May 8 2019

greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 11:48 AM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 11:47 AM · arm64, Contributor Reviews (base)

May 7 2019

greg_unrelenting.technology added inline comments to D20153: x11-drivers/xf86-video-vmware: Enable hardware accelerated graphics in VMware.
May 7 2019, 10:34 AM

May 3 2019

greg_unrelenting.technology added a comment to D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.
In D19335#433606, @manu wrote:
In D19335#433397, @manu wrote:

rebased, depends on D19986
not tested yet — for some reason my rockpro64 can't boot: clknode_register hangs when registering the first PLL on rk3399_cru0 :(

Could you test reverting r344626 ? ganbold@ have problem with this revision on the NanoPi T4. I personally don't have problems booting it (tried yesterday).

Mhm no, I've unplugged my eMMC module from my RockPro64 for a long time now so it's not that.
Could you try with the latest dtb ? It's installed now but on the wrong path until @kevans commit his fix. (so it's in /boot/dtb/ directly right now)

May 3 2019, 11:10 AM · arm64

May 1 2019

greg_unrelenting.technology added inline comments to D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.
May 1 2019, 7:33 PM · arm64
greg_unrelenting.technology updated the diff for D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.

rebased, depends on D19986

May 1 2019, 7:31 PM · arm64
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Added fdt detach corresponding to the current attach code (usb-phy)

May 1 2019, 4:58 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
May 1 2019, 4:56 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology accepted D20099: graphics/wayland: update to 1.17.0.

I don't think anyone really worked on the tests. I never tried to run them.

May 1 2019, 4:06 PM

Apr 25 2019

greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Done. btw, the original version was confirmed working on the Ampere system.

Apr 25 2019, 6:48 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Ah, yes. GregV would you rework it using that approach?

Apr 25 2019, 2:22 PM · arm64, Contributor Reviews (base)

Apr 21 2019

greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Done. Checked that mlx5ib loads.

Apr 21 2019, 3:28 PM · arm64, Contributor Reviews (base)

Apr 20 2019

greg_unrelenting.technology added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Apr 20 2019, 3:13 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology retitled D19987: Enable ioremap for aarch64 in the LinuxKPI from LinuxKPI: enable ioremap on AArch64 to Enable ioremap for aarch64 in the LinuxKPI.
Apr 20 2019, 3:04 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Sure, split to D19987

Apr 20 2019, 2:10 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19987: Enable ioremap for aarch64 in the LinuxKPI.
Apr 20 2019, 2:09 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19986: Add support for USB 3.0 XHCI via ACPI.
Apr 20 2019, 2:05 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19983: Enable Mellanox drivers on AArch64.
Apr 20 2019, 1:01 PM · arm64, Contributor Reviews (base)

Apr 19 2019

greg_unrelenting.technology added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

Update: the GPU hangs are *not* caused by IOMMU remapping. Possibly a bug in drm-v5.0… I'll try the updated version of this patch with stable drm later

Apr 19 2019, 3:51 PM

Apr 18 2019

greg_unrelenting.technology added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

Looks like a symptom of non-translatable physical address. I've encountered drivers which need additional work outside of the scope of this effort. Perhaps this is the case there as I can't any more cases in the Linux KPI where a physical address is substituted for a DMA one.
Also, I assume this is in remap mode. Does it work in identify map mode hw.busdma.default="bounce"? Unless there is an API which escaped, if it works in hw.dmar.enable="0" it's not a regression from before :-/

Apr 18 2019, 12:52 PM
greg_unrelenting.technology added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

Some more i915 GPU testing (w/o the latest update here): after using Firefox (opengl layers, xwayland) for some time, GPU resets start happening

Apr 18 2019, 9:29 AM

Apr 14 2019

greg_unrelenting.technology added a reviewer for D19896: Match PCI UART devices using PCI data from the ACPI SPCR table: Contributor Reviews (base).
Apr 14 2019, 10:22 PM · arm64
greg_unrelenting.technology updated subscribers of D19914: ACPI SPCR: handle BaudRate=0.
Apr 14 2019, 10:21 PM · arm64
greg_unrelenting.technology created D19914: ACPI SPCR: handle BaudRate=0.
Apr 14 2019, 10:21 PM · arm64
greg_unrelenting.technology added a comment to D19192: lang/elixir: update to 1.8.1 and use OTP-21 shim.

works very well, will this be committed soon?

Apr 14 2019, 3:57 PM

Apr 13 2019

greg_unrelenting.technology created D19897: Do not overwrite DISTNAME when USE_GITLAB=nodefault.
Apr 13 2019, 1:39 PM · Contributor Reviewers (ports)
greg_unrelenting.technology added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

Also tested on an AMD Ryzen + Vega system, no regressions. (No IOMMU there because no one wrote a dmar equivalent for AMD IOMMU…)

Apr 13 2019, 12:48 PM
greg_unrelenting.technology added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

Tested on my Haswell laptop with drm-v5.0, everything works (both with DMAR on and off), this line is new in dmesg:

Apr 13 2019, 12:40 PM
greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

okay, PCI is now https://reviews.freebsd.org/D19896

Apr 13 2019, 11:08 AM · arm64
greg_unrelenting.technology created D19896: Match PCI UART devices using PCI data from the ACPI SPCR table.
Apr 13 2019, 11:05 AM · arm64

Apr 10 2019

greg_unrelenting.technology added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 11:09 AM

Apr 6 2019

greg_unrelenting.technology added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

done

Apr 6 2019, 9:18 AM · arm64
greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Apr 6 2019, 9:17 AM · arm64

Apr 5 2019

greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

The quirk is a much more elegant way, thanks for the suggestion!

Apr 5 2019, 11:40 PM · arm64

Apr 2 2019

greg_unrelenting.technology abandoned D18372: Enable building if_ena on aarch64.

Landed as r345407.

Apr 2 2019, 5:51 PM · arm64
greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Apr 2 2019, 5:18 PM · arm64
greg_unrelenting.technology added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
In D19507#423995, @imp wrote:

I wouldn't be opposed to that either. I dislike special cases, but this may be a good case for an exception.

Apr 2 2019, 5:18 PM · arm64
greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Apr 2 2019, 5:12 PM · arm64

Apr 1 2019

greg_unrelenting.technology added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
In D19507#423825, @imp wrote:

IIRC, this violates the ACPI definition for these fields.

Apr 1 2019, 11:50 AM · arm64

Mar 31 2019

greg_unrelenting.technology added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Dammit. The Ampere eMAG (which uses the pl011 SBSR UART) represents *shiftp = 2; as

Mar 31 2019, 12:38 PM · arm64

Mar 22 2019

greg_unrelenting.technology added a comment to D19438: Revert revision 254095.
In D19438#416304, @ae wrote:

I have no objection. AFAIR, the main goal of this change was the adding ability to extend number of entries for some tables, that have very little number of partition entries, e.g. 1 or 2.
I think if you revert this change, then you will not able to add new partitions for these tables, even if there are enough space to keep them.

Mar 22 2019, 11:51 PM

Mar 20 2019

greg_unrelenting.technology updated the diff for D19657: Enable NVMe on aarch64.
Mar 20 2019, 10:15 PM · arm64
greg_unrelenting.technology added inline comments to D19657: Enable NVMe on aarch64.
Mar 20 2019, 8:47 PM · arm64
greg_unrelenting.technology added a comment to D19641: Add bus_release_resource() method to nexus on arm64.

I can confirm that mtu changes on ena work fine with this patch, nice

Mar 20 2019, 11:48 AM · arm64
greg_unrelenting.technology created D19657: Enable NVMe on aarch64.
Mar 20 2019, 11:01 AM · arm64

Mar 10 2019

greg_unrelenting.technology updated the diff for D18371: Allow building EC2 AMIs for arm64, use GPT/EFI in VM images consistently.
Mar 10 2019, 9:49 PM

Mar 9 2019

greg_unrelenting.technology abandoned D19502: Unbreak manual UART settings (hw.uart.console) on aarch64.

Merged into D19507

Mar 9 2019, 12:05 AM · arm64

Mar 8 2019

greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Mar 8 2019, 11:59 PM · arm64
greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Mar 8 2019, 11:58 PM · arm64
greg_unrelenting.technology added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

btw, would it be better to integrate all my uart patches into this, or post them separately?

Mar 8 2019, 5:49 PM · arm64
greg_unrelenting.technology added a comment to D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.

Could you use spcr->SerialPort.AccessWidth to find this? It's set to 1 in the copy of the spcr table I have indicating byte access.

Mar 8 2019, 2:56 PM · arm64
greg_unrelenting.technology updated the diff for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Mar 8 2019, 2:32 PM · arm64
greg_unrelenting.technology updated subscribers of D19502: Unbreak manual UART settings (hw.uart.console) on aarch64.
Mar 8 2019, 2:23 PM · arm64
greg_unrelenting.technology added a reviewer for D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART: andrew.
Mar 8 2019, 1:58 PM · arm64
greg_unrelenting.technology added a reviewer for D19502: Unbreak manual UART settings (hw.uart.console) on aarch64: andrew.
Mar 8 2019, 1:58 PM · arm64
greg_unrelenting.technology created D19507: Add quirk for ignoring SPCR AccessWidth values on the PL011 UART.
Mar 8 2019, 1:53 PM · arm64

Mar 7 2019

greg_unrelenting.technology created D19502: Unbreak manual UART settings (hw.uart.console) on aarch64.
Mar 7 2019, 8:54 PM · arm64

Feb 27 2019

greg_unrelenting.technology added a comment to D19330: Allow setting O_NONBLOCK on shm file descriptors.

I still think that the change should apply only to shm descriptors

Feb 27 2019, 6:54 PM
greg_unrelenting.technology updated the diff for D19330: Allow setting O_NONBLOCK on shm file descriptors.
Feb 27 2019, 6:47 PM
greg_unrelenting.technology added a comment to D19354: lang/rust: update to 1.33.0.

Greg, can you help fix stdsimd on aarch64?

Feb 27 2019, 6:35 PM
greg_unrelenting.technology added a comment to D19389: Split out the attachment from the generic-ehci driver.

I've noticed a generic-ehci driver in sys/mips/mediatek/mtk_ehci.c already (and tried on my RK3399, it does attach). That should probably be replaced by this. Does anyone test mediatek MIPS these days? :)

Feb 27 2019, 6:27 PM

Feb 25 2019

greg_unrelenting.technology added a comment to D19336: Enable SD/MMC (microSD and eMMC controllers) on the Rockchip RK3399 SoC.
In D19336#413879, @manu wrote:

I haven't looked at the arasan controller yet but I'm sure that if there is a different compatible it's because we need to do more work than just matching on the compatible.

Feb 25 2019, 8:12 PM · arm64
greg_unrelenting.technology added a comment to D19330: Allow setting O_NONBLOCK on shm file descriptors.

I don't really follow. For regular files, O_NONBLOCK means "don't block on open." vn_read() will translate O_NONBLOCK to IO_NDELAY, but most filesystems don't do anything with that. In the snippet you referenced, the code has a comment, "refuse to block when reading," but with this patch shm_read() will block anyway because uiomove_object_page() provides no mechanism for the caller to ask for non-blocking semantics. So either Linux ignores the O_NONBLOCK flag when reading from a shm object and the referenced comment is bogus, or Linux actually honours the flag, in which case this patch isn't sufficient. In the former case, the code should simply be eliminated rather than changing the kernel.

Feb 25 2019, 8:06 PM
greg_unrelenting.technology added a comment to D19330: Allow setting O_NONBLOCK on shm file descriptors.

What are the semantics on Linux? I can imagine O_NONBLOCK meaning "return EAGAIN if the page is swapped out," in which case this patch is not sufficient.

Feb 25 2019, 7:24 PM

Feb 24 2019

greg_unrelenting.technology created D19336: Enable SD/MMC (microSD and eMMC controllers) on the Rockchip RK3399 SoC.
Feb 24 2019, 10:37 PM · arm64
greg_unrelenting.technology created D19335: Add USB 3.0 support for Rockchip RK3328/RK3399 SoC.
Feb 24 2019, 9:48 PM · arm64
greg_unrelenting.technology created D19330: Allow setting O_NONBLOCK on shm file descriptors.
Feb 24 2019, 3:12 PM
greg_unrelenting.technology added a comment to D18694: evdev: add sysctls with device info.
In D18694#410790, @wulf wrote:

I hope you won't mind if I change sysctl name from "input_id" to "id" and disable exposure of optional properties like "uniq" and "phys" if they are not set. Just to be consistent with ioctl interface.

Feb 24 2019, 3:01 PM
greg_unrelenting.technology added a comment to D19068: devel/llvm70, devel/llvm80: fix libclangDoc.a installation, install clang-doc80.

ping @brooks

Feb 24 2019, 2:59 PM · Contributor Reviewers (ports)

Feb 17 2019

greg_unrelenting.technology added a comment to D18412: graphics/cairo: update to 1.16.0.

Works fine for me. x11-im/fractal update to 4.0.0 is waiting on this.

Feb 17 2019, 10:13 AM

Feb 10 2019

greg_unrelenting.technology updated the diff for D18694: evdev: add sysctls with device info.

added missing EVDEV_UNLOCK

Feb 10 2019, 3:37 PM

Feb 2 2019

greg_unrelenting.technology added a comment to D18694: evdev: add sysctls with device info.
In D18694#403804, @wulf wrote:

To handle native device creation one should listen for EVDEV devd events while to handle cuse devices CDEV devd events should be processed.
You can not just listen for CDEV devd events as there is a race window between cdev and sysctl creation.

Feb 2 2019, 10:12 PM
greg_unrelenting.technology updated the diff for D18694: evdev: add sysctls with device info.
Feb 2 2019, 10:08 PM
greg_unrelenting.technology created D19068: devel/llvm70, devel/llvm80: fix libclangDoc.a installation, install clang-doc80.
Feb 2 2019, 8:10 PM · Contributor Reviewers (ports)
greg_unrelenting.technology added a comment to D19061: lang/rust: add armv6 and armv7 targets.

Looks like powerpc64 is also here (but not the new aarch64 bootstraps)…

Feb 2 2019, 2:49 PM

Jan 12 2019

greg_unrelenting.technology added a comment to D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition.
Jan 12 2019, 1:58 PM

Jan 9 2019

greg_unrelenting.technology updated the diff for D18729: New port: sysutils/intel-undervolt: Intel CPU undervolting tool.

Updated with suggestions

Jan 9 2019, 7:33 PM

Jan 6 2019

greg_unrelenting.technology added a comment to D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition.

Tryign to ck-launch-session /usr/local/bin/startplasmacompositor leads to a segfault ck.

Jan 6 2019, 12:59 AM

Jan 5 2019

greg_unrelenting.technology updated the diff for D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition.

oh, it also didn't enable termios raw mode. That was causing Weston to crash when pressing Enter :D Fixed.

Jan 5 2019, 3:20 PM
greg_unrelenting.technology updated the diff for D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition.

+ fix re-plugging devices by checking if the found device is still alive

Jan 5 2019, 2:38 PM
greg_unrelenting.technology added a reviewer for D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition: gnome.
Jan 5 2019, 1:59 PM
greg_unrelenting.technology created D18754: sysutils/consolekit2: enable drm/evdev, fix drm device recognition.
Jan 5 2019, 1:55 PM

Jan 4 2019

greg_unrelenting.technology added inline comments to D18729: New port: sysutils/intel-undervolt: Intel CPU undervolting tool.
Jan 4 2019, 5:50 PM
greg_unrelenting.technology created P243 ikos patch-clang-workaround.
Jan 4 2019, 11:06 AM

Jan 3 2019

greg_unrelenting.technology created D18729: New port: sysutils/intel-undervolt: Intel CPU undervolting tool.
Jan 3 2019, 6:39 PM
greg_unrelenting.technology updated the summary of D18694: evdev: add sysctls with device info.
Jan 3 2019, 6:36 PM
greg_unrelenting.technology added a comment to D18728: Support MSG_DONTWAIT in sendmsg().

Updated style.

Jan 3 2019, 6:35 PM
greg_unrelenting.technology added a reviewer for D18728: Support MSG_DONTWAIT in sendmsg(): tuexen.
Jan 3 2019, 6:27 PM
greg_unrelenting.technology updated the diff for D18728: Support MSG_DONTWAIT in sendmsg().
Jan 3 2019, 6:25 PM
greg_unrelenting.technology updated the diff for D18728: Support MSG_DONTWAIT in sendmsg().

I think that's the right place in sctp. I'm not sure how to test it though, or the sdp thing…

Jan 3 2019, 6:07 PM
greg_unrelenting.technology added inline comments to D18728: Support MSG_DONTWAIT in sendmsg().
Jan 3 2019, 6:01 PM
greg_unrelenting.technology added a reviewer for D18728: Support MSG_DONTWAIT in sendmsg(): Contributor Reviews (base).
Jan 3 2019, 4:26 PM