Page MenuHomeFreeBSD

gbergling_gmail.com (Gordon Bergling)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 9 2019, 1:39 PM (39 w, 2 d)

Recent Activity

Wed, Apr 8

gbergling_gmail.com added a comment to D23905: smbfs(5): Add a basic man page.

Looks good apart from the missing comma.

Wed, Apr 8, 11:41 AM
gbergling_gmail.com updated the diff for D23905: smbfs(5): Add a basic man page.
  • Add mission common sign at the .Xr elements
Wed, Apr 8, 11:40 AM
gbergling_gmail.com added a comment to D23905: smbfs(5): Add a basic man page.
In D23905#535330, @bcr wrote:

Looks good. Did you run "mandoc -Tlint" and igor over it?

Wed, Apr 8, 10:37 AM
gbergling_gmail.com updated the diff for D23905: smbfs(5): Add a basic man page.

smbfs(5): Eliminate Whitespaces and Correct Xr Order

Wed, Apr 8, 10:34 AM
gbergling_gmail.com added a comment to D24150: Add a HISTORY section to domain(9).

Could somebody review this differential?

Wed, Apr 8, 9:50 AM
gbergling_gmail.com added a comment to D23905: smbfs(5): Add a basic man page.

Could somebody review this differential?

Wed, Apr 8, 9:49 AM

Sat, Apr 4

gbergling_gmail.com abandoned D23855: Add HISTORY section some manual pages.

Superseded by D24295

Sat, Apr 4, 6:52 PM
gbergling_gmail.com added a comment to D23714: Add a manual page for smbios(4).

Ping?

As far as I can tell, there are no outstanding reviews. Are you pinging for someone to commit it on your behalf?

Sat, Apr 4, 6:34 PM
gbergling_gmail.com updated the summary of D24295: Add HISTORY section to getc(3) and exit(3).
Sat, Apr 4, 10:16 AM
gbergling_gmail.com created D24295: Add HISTORY section to getc(3) and exit(3).
Sat, Apr 4, 10:13 AM
gbergling_gmail.com updated the diff for D23855: Add HISTORY section some manual pages.
  • rebase
  • Merge branch 'master' of /home/gbergling/sources/freebsd/src
Sat, Apr 4, 9:41 AM

Fri, Apr 3

gbergling_gmail.com added a comment to D23855: Add HISTORY section some manual pages.

Could someone take this one? sin(3), cos(3) and log(3) are already committed.

Sorry, I’ll review this night what’s left and make the committs

Fri, Apr 3, 4:22 PM
gbergling_gmail.com added a comment to D23714: Add a manual page for smbios(4).

Ping?

Fri, Apr 3, 3:53 PM
gbergling_gmail.com added a comment to D23855: Add HISTORY section some manual pages.

Could someone take this one? sin(3), cos(3) and log(3) are already committed.

Fri, Apr 3, 3:50 PM
gbergling_gmail.com added a comment to D23383: Update contrib/subversion to the latest LTS version (1.10.6).

Any update on this? I would think that the subversion sources could be integrated from this diff into the vendor repository. So it would be possible to go the specified way which is described in the developers handbook.

Fri, Apr 3, 2:23 PM
gbergling_gmail.com created D24271: Add HISTORY sections to build(7), crypto(7), ffs(7), growfs(7) and diskless(8).
Fri, Apr 3, 2:00 PM

Tue, Mar 31

gbergling_gmail.com created D24243: Add HISTORY sections to disk(9), driver(9) and epoch(9).
Tue, Mar 31, 8:13 PM

Sat, Mar 28

gbergling_gmail.com added a comment to D23833: Add HISTORY sections to ZFS and dtrace manpages.

@bcr @allanjude As far as I know, these manpages where converted to mdoc a while ago, so an easy upstream adaption isn't that this simple as it may seems. This was driving me towards a FreeBSD only HISTORY section for the manpages.

Sat, Mar 28, 7:12 PM

Sun, Mar 22

gbergling_gmail.com added a comment to D24147: Add HISTORY section to getc(3) man page.

as the author of the original PR, I try to clarify the sources in question. The newly introduces HISTORY section comes from OpenBSD, which originates from http://minnie.tuhs.org/cgi-bin/utree.pl. Jörg Schwarze did some research and pointed out that these functions actually predate 2BSD and the mentioned UNIX versions are the nearest version to match for the HISTORY section. However, if you think that this HISTORY section needs an update I am willing to refresh it.

Sun, Mar 22, 2:46 PM
gbergling_gmail.com created D24150: Add a HISTORY section to domain(9).
Sun, Mar 22, 1:23 PM

Fri, Mar 13

gbergling_gmail.com added a comment to D21752: Add STANDARDS section to the gre(4) manual page.

@0mp please have a look at the mentioned PR. I updated the Diff already at the End of November.

Fri, Mar 13, 3:10 PM

Mar 9 2020

gbergling_gmail.com accepted D23581: calendar(1): Updates and corrections for calendar files.

I made the requested changes for @imp and set this differential to accepted because of the acceptance from @imp and @pfg in the first place.

Mar 9 2020, 9:45 PM
gbergling_gmail.com added a comment to D23392: More Secure Permissions for /root.

PIng?

Mar 9 2020, 9:41 PM

Mar 6 2020

gbergling_gmail.com added a comment to D23581: calendar(1): Updates and corrections for calendar files.

@imp I added Millard Fillmore birthday to the respective calendar file. Lincoln's birthday was moved from history to the birthday file.

Mar 6 2020, 8:39 AM
gbergling_gmail.com updated the diff for D23581: calendar(1): Updates and corrections for calendar files.
  • Add back Millard Fillmore birthday
Mar 6 2020, 8:36 AM

Mar 1 2020

gbergling_gmail.com added a reviewer for D23905: smbfs(5): Add a basic man page: manpages.
Mar 1 2020, 11:12 AM
gbergling_gmail.com created D23905: smbfs(5): Add a basic man page.
Mar 1 2020, 11:12 AM

Feb 29 2020

gbergling_gmail.com created D23893: Sync vis(1) with NetBSD.
Feb 29 2020, 3:26 PM
gbergling_gmail.com created D23892: sort(1): Remove duplicate option check..
Feb 29 2020, 2:58 PM
gbergling_gmail.com created D23891: env(1): Match glibc getopt() semantics.
Feb 29 2020, 2:45 PM
gbergling_gmail.com updated the diff for D23880: libc/strptime(3): Handle ISO 8601 time zone formats in %z.
  • Fix parenthesis
Feb 29 2020, 11:44 AM

Feb 28 2020

gbergling_gmail.com added a reviewer for D23880: libc/strptime(3): Handle ISO 8601 time zone formats in %z: manpages.
Feb 28 2020, 6:06 PM
gbergling_gmail.com updated the diff for D23880: libc/strptime(3): Handle ISO 8601 time zone formats in %z.
  • Use one \t for the comments
Feb 28 2020, 6:05 PM
gbergling_gmail.com created D23880: libc/strptime(3): Handle ISO 8601 time zone formats in %z.
Feb 28 2020, 6:02 PM

Feb 27 2020

gbergling_gmail.com added a reviewer for D23855: Add HISTORY section some manual pages: manpages.
Feb 27 2020, 5:59 PM
gbergling_gmail.com created D23855: Add HISTORY section some manual pages.
Feb 27 2020, 5:58 PM

Feb 25 2020

gbergling_gmail.com added a comment to D23832: Add HISTORY sections to tree(3), stdarg(3) and sigevent(3).

@carlavilla this is a new differential / patch for new HISTORY sections.

Feb 25 2020, 6:32 PM
gbergling_gmail.com created D23833: Add HISTORY sections to ZFS and dtrace manpages.
Feb 25 2020, 2:53 PM
gbergling_gmail.com created D23832: Add HISTORY sections to tree(3), stdarg(3) and sigevent(3).
Feb 25 2020, 1:34 PM

Feb 18 2020

gbergling_gmail.com accepted D23714: Add a manual page for smbios(4).

I removed the "All Rights Reserved." as suggested by rpokala@.

Feb 18 2020, 7:01 AM
gbergling_gmail.com updated the diff for D23714: Add a manual page for smbios(4).
  • Address Feedback by rpokala@
Feb 18 2020, 6:59 AM

Feb 16 2020

gbergling_gmail.com added a comment to D23714: Add a manual page for smbios(4).

Thanks for the comments, I updated the diff accordingly.

Feb 16 2020, 2:58 PM
gbergling_gmail.com updated the diff for D23714: Add a manual page for smbios(4).
Address feedback by brueffer@
Feb 16 2020, 2:55 PM
gbergling_gmail.com updated the summary of D23716: arc4random(3): Expand the SEE ALSO section.
Feb 16 2020, 2:19 PM
gbergling_gmail.com created D23716: arc4random(3): Expand the SEE ALSO section.
Feb 16 2020, 2:16 PM
gbergling_gmail.com abandoned D23453: Correct some typos in sourcesfiles.

Already committed...

Feb 16 2020, 12:02 PM
gbergling_gmail.com updated the summary of D23714: Add a manual page for smbios(4).
Feb 16 2020, 11:09 AM
gbergling_gmail.com created D23714: Add a manual page for smbios(4).
Feb 16 2020, 11:03 AM

Feb 15 2020

gbergling_gmail.com added a comment to D23693: Add some HISTORY sections to manpages.
In D23693#520205, @bcr wrote:

Looks good. Can one of my mentees take care of committing it, including an MFC?

Feb 15 2020, 10:23 AM
gbergling_gmail.com created D23693: Add some HISTORY sections to manpages.
Feb 15 2020, 10:14 AM

Feb 8 2020

gbergling_gmail.com added a comment to D23392: More Secure Permissions for /root.

Any update on this topic?

Feb 8 2020, 3:02 PM
gbergling_gmail.com created D23581: calendar(1): Updates and corrections for calendar files.
Feb 8 2020, 11:21 AM

Feb 7 2020

gbergling_gmail.com retitled D23572: Update OpenBSM constants with recent additions by Apple from Update OpenBSM constantes with recent additions by Apple to Update OpenBSM constants with recent additions by Apple.
Feb 7 2020, 4:06 PM
gbergling_gmail.com created D23572: Update OpenBSM constants with recent additions by Apple.
Feb 7 2020, 4:05 PM
gbergling_gmail.com added a comment to D23383: Update contrib/subversion to the latest LTS version (1.10.6).

So, I just finished the testplan. A freshly -CURRENT from yesterday with the D23383 applied resulted in the following svnlite and the checkouts of head, ports and docs where successful. The tinderbox build was failing due to an "arm LINT-V7 kernel failed" error, but the "make universe" target was successful. I would think that the testplan was passed.

Thanks. As described in src/Makefile, the universe target will not error out when there is error immediately. I don't think the armv7 LINT failure is caused by svn update, but please check if there is any other bug in that. This is another thing, though. But please be sure to check all the buildworld targets fine on all architectures. If you could check running this on some non-x86 arches, it will be great.
For merging this to the tree, it would take some extra work at the committer side. We don't directly import contributed software to the contrib/ director, but put to vendor branch first and then merge, as https://www.freebsd.org/doc/en_US.ISO8859-1/books/developers-handbook/policies-contributed.html describes. It takes some time to take care these things. If you happen to have more time, please help me check if there is anything we should do with the local modification. Thank you.

Feb 7 2020, 9:43 AM
gbergling_gmail.com updated the diff for D23453: Correct some typos in sourcesfiles.
  • Delete sys/sparc64/sparc64/intr_machdep.c
Feb 7 2020, 9:10 AM
gbergling_gmail.com updated the diff for D23453: Correct some typos in sourcesfiles.
  • Rebase to r357644
Feb 7 2020, 8:47 AM
gbergling_gmail.com added a comment to D23383: Update contrib/subversion to the latest LTS version (1.10.6).

So, I just finished the testplan. A freshly -CURRENT from yesterday with the D23383 applied resulted in the following svnlite and the checkouts of head, ports and docs where successful. The tinderbox build was failing due to an "arm LINT-V7 kernel failed" error, but the "make universe" target was successful. I would think that the testplan was passed.

Feb 7 2020, 8:06 AM

Feb 4 2020

gbergling_gmail.com added a comment to D23383: Update contrib/subversion to the latest LTS version (1.10.6).

Not as far as I know. I tested a "make buildworld" on amd64 and a local invocation of the freshly compiled svnlite, which worked. I also tested a crossbuild for arm64.

Is there a suggested check/test list for updating the svn(lite) in base?

Ok this reminds me that I think this kinds of change needs a make tinderbox build to check all the architecture are fine.
Also, the main task of svnlite is for getting the latest freebsd source code (and ports and docs), could you do some checkout and update tests? And verify the things like $FreeBSD$ tag is expanded correctly?
Thanks for working on this!

Feb 4 2020, 7:24 PM
gbergling_gmail.com updated the test plan for D23383: Update contrib/subversion to the latest LTS version (1.10.6).
Feb 4 2020, 7:23 PM
gbergling_gmail.com added a comment to D23383: Update contrib/subversion to the latest LTS version (1.10.6).

Not as far as I know. I tested a "make buildworld" on amd64 and a local invocation of the freshly compiled svnlite, which worked. I also tested a crossbuild for arm64.

Feb 4 2020, 4:32 PM

Feb 3 2020

gbergling_gmail.com updated the diff for D23392: More Secure Permissions for /root.
  • Fix whitespace identation
Feb 3 2020, 6:47 AM

Feb 1 2020

gbergling_gmail.com added reviewers for D23453: Correct some typos in sourcesfiles: emaste, lwhsu.
Feb 1 2020, 3:17 PM
gbergling_gmail.com created D23453: Correct some typos in sourcesfiles.
Feb 1 2020, 3:16 PM
gbergling_gmail.com created D23452: Correct Netflix Copyright Statements.
Feb 1 2020, 2:39 PM
gbergling_gmail.com retitled D23392: More Secure Permissions for /root from More Secure Permissions for /root and /etc/sysctl.conf to More Secure Permissions for /root.
Feb 1 2020, 11:36 AM
gbergling_gmail.com updated the diff for D23392: More Secure Permissions for /root.
  • Update /root permissions to 0750
  • Revert sysctl.conf permissions changes
Feb 1 2020, 11:36 AM

Jan 28 2020

gbergling_gmail.com added reviewers for D23392: More Secure Permissions for /root: emaste, lwhsu.
Jan 28 2020, 9:27 AM
gbergling_gmail.com created D23392: More Secure Permissions for /root.
Jan 28 2020, 9:26 AM

Jan 27 2020

gbergling_gmail.com removed a reviewer for D23383: Update contrib/subversion to the latest LTS version (1.10.6): Core Team.
Jan 27 2020, 7:11 PM
gbergling_gmail.com added reviewers for D23383: Update contrib/subversion to the latest LTS version (1.10.6): emaste, lwhsu.
Jan 27 2020, 7:08 PM
gbergling_gmail.com created D23383: Update contrib/subversion to the latest LTS version (1.10.6).
Jan 27 2020, 6:50 PM