User Details
- User Since
- Jun 6 2021, 5:11 PM (49 w, 5 d)
Jan 17 2022
Please consider removing the ONLY_FOR_ARCHS line when updating this port. I have managed to successfully compile the port for armv7 at least.
Nov 30 2021
Nov 29 2021
I would prefer shorter names. signed_extend32 is really unwieldy. Also, the name does not really explain that the operation is really about extracting from bitfields.
Nov 11 2021
As discussed on IRC, I propose that such a helper should have three arguments:
Nov 3 2021
LGTM. Once this is committed, I'll go ahead and report our patches up stream.
Oct 3 2021
Note that there's no OpenMP with clang on armv7. It's a bit weird to take this out because now way more ports will fail to build on armv7. Would have been better to make compiler:openmp only chose gcc on architectures where LLVM doesn't implement OpenMP.
Sep 29 2021
Sep 17 2021
As already discussed, I have not asked for a STATIC option to be added not have I asked for the test suite to be disabled. In fact, I do not wish to maintain these changes. Please remove them as already discussed on IRC.
Sep 2 2021
Commit message could use an explicit reference to dummy message catalogues being added and a link to the announce file (changelog).
Aug 24 2021
Looks good to me.
@lbartoletti USE_GITHUB does not seem possible: this is an autotools project and the release tarballs have pre-generated autotools files that aren't in the repository. I've previously been told off for using USE_GITHUB and regenerating the configure script in such a case.
Aug 19 2021
After private discussion with @tcberner, how about
I have intentionally chosen this COMMENT to highlight that this is not an ordinary backup program, but rather performs some RAID-like functionality.
Jul 14 2021
Patch successfully on arm64 13.0 RELEASE. Applying it makes armv7 Go binaries work.
Jul 1 2021
devel/schilybase: refactor bootstrap smake logic
Jun 30 2021
Rebase onto current main branch as requested by otis.
Jun 22 2021
Address all feedback by otis, implementing the changes he suggested.
- MOVED: fix wrong port name in sysutils/sformat entry
- devel/schilybase: unsilence post-extract commands
Jun 21 2021
Will fix the MOVED issue shortly. Please let me know if you still want the silencing to be taken out, given that it seems to be recommended by the Porter's handbook and is general practice in many other ports.
sysutils/schilyutils: rename bin/compare to bin/scompare
Jun 19 2021
Add forgotten USE_LDCONFIG
Mark items addressed by Diff 90898 as done.
Jun 14 2021
address code review feedback by mat
Jun 13 2021
archivers/star: simplify Makefile
Jun 9 2021
sysutils/sformat: obsolete; subsumed under sysutils/schilyutils
Jun 8 2021
Jun 7 2021
archivers/star: do not install an mt binary