Page MenuHomeFreeBSD

fel1x.mintchoco.development_gmail.com (Minsoo Choo)
Minsoo

Projects

User Details

User Since
May 6 2021, 12:00 AM (81 w, 4 d)

Recent Activity

Wed, Nov 2

fel1x.mintchoco.development_gmail.com updated the diff for D37143: Update doc repo build method on macOS.
Wed, Nov 2, 8:03 PM · docs

Tue, Nov 1

fel1x.mintchoco.development_gmail.com updated fel1x.mintchoco.development_gmail.com.
Tue, Nov 1, 11:20 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Tue, Nov 1, 11:10 PM
fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Tue, Nov 1, 11:09 PM

Mon, Oct 31

fel1x.mintchoco.development_gmail.com added a comment to D34385: Update Apple descriptions in the handbook..

@fel1x, are the name and email on your Phabricator profile the ones you want recorded as the author of this patch? If now, what do you want to be recorded as?

Mon, Oct 31, 7:09 PM

Sun, Oct 30

fel1x.mintchoco.development_gmail.com changed the repository for D34747: ls(1): Add -g, -n, and -o options for POSIX standard from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Sun, Oct 30, 3:30 AM
fel1x.mintchoco.development_gmail.com updated the diff for D37208: Specify TrueNAS Core and TrueNas Enterprise.
Sun, Oct 30, 3:29 AM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37208: Specify TrueNAS Core and TrueNas Enterprise.
Sun, Oct 30, 3:21 AM · docs

Sat, Oct 29

fel1x.mintchoco.development_gmail.com updated the diff for D37208: Specify TrueNAS Core and TrueNas Enterprise.
Sat, Oct 29, 10:19 PM · docs
fel1x.mintchoco.development_gmail.com abandoned D37207: Fixing the definition of the term "committer".
Sat, Oct 29, 9:53 PM · docs
fel1x.mintchoco.development_gmail.com added a comment to D37207: Fixing the definition of the term "committer".

This was a suggestion from other revision and I separated the issue to this. I agree with you that this is not a good idea. Closing this revision

Sat, Oct 29, 9:53 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37202: Modify http links to use https.
Sat, Oct 29, 3:21 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37202: Modify http links to use https.
Sat, Oct 29, 3:11 PM · docs
fel1x.mintchoco.development_gmail.com requested review of D37208: Specify TrueNAS Core and TrueNas Enterprise.
Sat, Oct 29, 3:11 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37202: Modify http links to use https.
Sat, Oct 29, 3:05 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37207: Fixing the definition of the term "committer".
Sat, Oct 29, 3:05 PM · docs
fel1x.mintchoco.development_gmail.com requested review of D37207: Fixing the definition of the term "committer".
Sat, Oct 29, 3:04 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37202: Modify http links to use https.
Sat, Oct 29, 2:54 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37202: Modify http links to use https.
Sat, Oct 29, 2:52 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37202: Modify http links to use https.
Sat, Oct 29, 2:47 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37202: Modify http links to use https.
Sat, Oct 29, 2:43 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37202: Modify http links to use https.
Sat, Oct 29, 2:41 PM · docs
fel1x.mintchoco.development_gmail.com added a comment to D37143: Update doc repo build method on macOS.

On macOS and Linux (I used Kali Linux), GEM_PATH is not /bin folder.

Sat, Oct 29, 12:58 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37143: Update doc repo build method on macOS.
Sat, Oct 29, 12:52 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37143: Update doc repo build method on macOS.
Sat, Oct 29, 12:47 PM · docs
fel1x.mintchoco.development_gmail.com retitled D34385: Update Apple descriptions in the handbook. from Update names of Apple products in the introduction chapter of FreeBSD Handbook. to Update Apple descriptions in the handbook..
Sat, Oct 29, 2:02 AM
fel1x.mintchoco.development_gmail.com retitled D37202: Modify http links to use https from modify http links to use https to Modify http links to use https.
Sat, Oct 29, 2:01 AM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D34385: Update Apple descriptions in the handbook..

Separating this issue from HTTP issue

Sat, Oct 29, 2:00 AM

Oct 29 2022

fel1x.mintchoco.development_gmail.com added a comment to D34385: Update Apple descriptions in the handbook..

Changing HTTP links to HTTPS links is moved to here

Oct 29 2022, 1:59 AM
fel1x.mintchoco.development_gmail.com requested review of D37202: Modify http links to use https.
Oct 29 2022, 1:58 AM · docs
fel1x.mintchoco.development_gmail.com abandoned D34402: Website: Ports and Packages for Supported Releases Update.

The page has been updated by other person. Closing revision.

Oct 29 2022, 1:31 AM
fel1x.mintchoco.development_gmail.com updated the diff for D37143: Update doc repo build method on macOS.
Oct 29 2022, 1:22 AM · docs

Oct 28 2022

fel1x.mintchoco.development_gmail.com added inline comments to D37143: Update doc repo build method on macOS.
Oct 28 2022, 11:26 PM · docs
fel1x.mintchoco.development_gmail.com added a comment to D37143: Update doc repo build method on macOS.

I prefer the direction this is heading to!
There is one thing that bothers me with the current diff, but it can be easily solved: If I a person is a FreeBSD user and a Ruby developer, the GEM_PATH might be already defined (see other reserved names).
Let's try to tackle this from the end user's perspective:
FreeBSD:

$ bmake run

Linux:

$ bmake run LOCALBASE=/usr

macOS:

$ bmake run USE_RUBYGEMS=YES GEM_PATH=/usr/local/lib/ruby/gems/[ruby_version]

If the macOS user has already defined GEM_PATH, then the command would just be bmake run USE_RUBYGEMS=YES. USE_RUBYGEMS or something along those lines.
Then, a FreeBSD/Linux user, that is also a Ruby developer —and hates installing Ruby gems via package managers— now has the ability to USE_RUBYGEMS.
What do you think?

Oct 28 2022, 11:20 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37143: Update doc repo build method on macOS.
Oct 28 2022, 11:17 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37184: Update FreeBSD versions to 13.1 in handbook.
Oct 28 2022, 9:24 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37143: Update doc repo build method on macOS.
Oct 28 2022, 5:39 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37184: Update FreeBSD versions to 13.1 in handbook.
Oct 28 2022, 12:16 PM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37184: Update FreeBSD versions to 13.1 in handbook.
Oct 28 2022, 4:02 AM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37184: Update FreeBSD versions to 13.1 in handbook.
Oct 28 2022, 4:01 AM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37143: Update doc repo build method on macOS.
Oct 28 2022, 3:22 AM · docs
fel1x.mintchoco.development_gmail.com added a comment to D37143: Update doc repo build method on macOS.

I uploaded wrong diff file. I'll fix in a few minutes

Oct 28 2022, 3:20 AM · docs
fel1x.mintchoco.development_gmail.com updated the diff for D37143: Update doc repo build method on macOS.
Oct 28 2022, 3:19 AM · docs
fel1x.mintchoco.development_gmail.com updated the summary of D37184: Update FreeBSD versions to 13.1 in handbook.
Oct 28 2022, 1:00 AM · docs

Oct 27 2022

fel1x.mintchoco.development_gmail.com requested review of D37184: Update FreeBSD versions to 13.1 in handbook.
Oct 27 2022, 11:07 PM · docs
fel1x.mintchoco.development_gmail.com added a comment to D37143: Update doc repo build method on macOS.

I took a closer look at this, and I think one solution could be just to patch the Makekile in the documentation directory.

The problem is that the rouge binaries (rougify), installed by gem are in a different path. This predicament is not present on FreeBSD/Linux because you are instructed to install everything with a package manager, which installs all the binaries in the same place.

I have deployed a simple GitHub repo illustrating this issue. It patches the Makefile. You can verify in the artifacts for each run that the documentation builds successfully (it uploads a documentation.zip file containing the public directory).

In the meantime, perhaps a quick solution would be to define:

ROUGIFY_CMD?= ${LOCALBASE}/bin/rougify

So it can be overridden:

$ bmake run ROUGIFY_CMD=${GEM_PATH}/rougify

My main issue with this patch are the symlinks.

Oct 27 2022, 9:43 PM · docs
fel1x.mintchoco.development_gmail.com added inline comments to D37143: Update doc repo build method on macOS.
Oct 27 2022, 9:40 PM · docs
fel1x.mintchoco.development_gmail.com requested review of D37143: Update doc repo build method on macOS.
Oct 27 2022, 3:42 AM · docs

May 29 2022

fel1x.mintchoco.development_gmail.com added a comment to D34385: Update Apple descriptions in the handbook..

When can this be committed to the doc repository?

May 29 2022, 6:22 PM

May 26 2022

fel1x.mintchoco.development_gmail.com updated the diff for D34402: Website: Ports and Packages for Supported Releases Update.

Someone edited FreeBSD 12.3 information. Adding 13.1-Release

May 26 2022, 12:41 AM

Apr 18 2022

fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • print warning message to stderr
Apr 18 2022, 5:43 PM

Apr 15 2022

fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 15 2022, 1:44 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • better comment
Apr 15 2022, 12:22 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • fix spacing syntax
Apr 15 2022, 12:17 AM

Apr 12 2022

fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • change -o to -O in files in src tree
Apr 12 2022, 10:06 PM

Apr 10 2022

fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • present a deprecation message to -o option
Apr 10 2022, 12:23 AM
fel1x.mintchoco.development_gmail.com added a comment to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
In D34747#790015, @pauamma_gundo.com wrote:

As disgorged by grep -rH -E 'ls +-[a-zA-A0-9]*o' /usr/src, the following files in src also need changes:
/usr/src/share/skel/dot.shrc:alias ll='ls -laFo'
/usr/src/sys/contrib/zstd/tests/gzip/init.sh: perms=\ls -dgo "$d" 2>/dev/null\ &&
/usr/src/bin/ls/tests/ls_tests.sh: atf_set "descr" "Verify that the output from ls -o prints out the chflag values or '-' if none are set"
/usr/src/bin/ls/tests/ls_tests.sh: -s exit:0 ls -lo a.file
/usr/src/bin/ls/tests/ls_tests.sh: -s exit:0 ls -lo b.file
/usr/src/bin/chflags/chflags.1:You can use "ls -lo" to see the flags of existing files.

Nothing obvious in the ports tree, but that doesn't include actual source code, so I think an exp-run is in order. There's one ls -lo in the handbook (I haven't checked the rest of the doc tree). And of course, that doesn't and can't account for all the unported apps and homegrown ops or devops shell programs out there. With that in mind, I suggest a staged change instead, with introducing -O and adding a deprecation message to -o as the first stage.

Apr 10 2022, 12:15 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • change -o to -O in files in src tree
Apr 10 2022, 12:13 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • update ls man page
Apr 10 2022, 12:06 AM
fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 10 2022, 12:03 AM

Apr 9 2022

fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • make -O option work
Apr 9 2022, 6:26 PM
fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 9 2022, 12:02 PM
fel1x.mintchoco.development_gmail.com added a comment to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.

I found out that -O does not work even though I compiled and installed it, but I cannot find the cause.

Apr 9 2022, 12:00 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • add -O option for compatibility
Apr 9 2022, 11:58 AM
fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 9 2022, 11:58 AM
fel1x.mintchoco.development_gmail.com added a comment to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
In D34747#789446, @pauamma_gundo.com wrote:

Compatibility question: how, with that change, can I get output equivalent to current (or 12.x if it changed in 13.x) ls -ol?

This may be related to f_flags being declared and implicitly initialized to false but never set to a true value.

Apr 9 2022, 11:49 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • Comment consistency
Apr 9 2022, 11:43 AM

Apr 7 2022

fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 7 2022, 1:52 PM
fel1x.mintchoco.development_gmail.com changed the repository for D34747: ls(1): Add -g, -n, and -o options for POSIX standard from R9 FreeBSD doc repository to rG FreeBSD src repository.
Apr 7 2022, 1:51 PM
fel1x.mintchoco.development_gmail.com changed the repository for D34747: ls(1): Add -g, -n, and -o options for POSIX standard from rS FreeBSD src repository - subversion to R9 FreeBSD doc repository.
Apr 7 2022, 1:51 PM
fel1x.mintchoco.development_gmail.com updated the test plan for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 7 2022, 1:50 PM
fel1x.mintchoco.development_gmail.com updated the summary of D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 7 2022, 1:50 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • Update ls(1) man page
Apr 7 2022, 1:48 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • %*ju with both s_nlink and st_nlink
Apr 7 2022, 1:33 PM
fel1x.mintchoco.development_gmail.com added inline comments to D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 7 2022, 2:17 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • Changed description for new variables
Apr 7 2022, 2:16 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • Match if syntax
Apr 7 2022, 2:05 AM
fel1x.mintchoco.development_gmail.com updated the diff for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
  • delete line that is commented out
Apr 7 2022, 1:52 AM

Apr 4 2022

fel1x.mintchoco.development_gmail.com requested review of D34766: lio_listio(2): add __restrict keyword to third parameter struct sigvent *sig.
Apr 4 2022, 3:48 PM
fel1x.mintchoco.development_gmail.com retitled D34747: ls(1): Add -g, -n, and -o options for POSIX standard from ls(1): dd -g, -n, and -o options to ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 4 2022, 1:37 PM
fel1x.mintchoco.development_gmail.com retitled D34747: ls(1): Add -g, -n, and -o options for POSIX standard from add -g, -n, and -o options for ls to ls(1): dd -g, -n, and -o options.
Apr 4 2022, 1:37 PM

Apr 3 2022

fel1x.mintchoco.development_gmail.com added a comment to D34402: Website: Ports and Packages for Supported Releases Update.
In D34402#787758, @grahamperrin_gmail.com wrote:

Needs releng 13.1, I think …

Apr 3 2022, 6:33 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34385: Update Apple descriptions in the handbook..
Apr 3 2022, 1:24 AM
fel1x.mintchoco.development_gmail.com added inline comments to D34385: Update Apple descriptions in the handbook..
Apr 3 2022, 1:24 AM

Apr 2 2022

fel1x.mintchoco.development_gmail.com retitled D34385: Update Apple descriptions in the handbook. from Change trademarks of Apple products in the first chapter of FreeBSD Handbook. to Update names of Apple products in the introduction chapter of FreeBSD Handbook..
Apr 2 2022, 8:27 PM
fel1x.mintchoco.development_gmail.com updated the diff for D34385: Update Apple descriptions in the handbook..
Apr 2 2022, 8:03 PM
fel1x.mintchoco.development_gmail.com added a comment to D30176: Freebsd doc cross-platform build.

I just created another revision to handle the macOS addition.
It's here: https://reviews.freebsd.org/D34752
@fel1x.mintchoco.development_gmail.com if your ok with this new revision I'll commit it.
Are the instructions ok? I removed the brew installation command since the idea of this documentation it's to help the user to build the documentation in macOS not to install brew.

Apr 2 2022, 3:40 PM · docs
fel1x.mintchoco.development_gmail.com updated the summary of D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 2 2022, 11:30 AM
fel1x.mintchoco.development_gmail.com removed rS FreeBSD src repository - subversion as the repository for D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 2 2022, 11:26 AM
fel1x.mintchoco.development_gmail.com requested review of D34747: ls(1): Add -g, -n, and -o options for POSIX standard.
Apr 2 2022, 11:25 AM
fel1x.mintchoco.development_gmail.com added a member for Linux Emulation: fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:37 AM
fel1x.mintchoco.development_gmail.com removed a watcher for Linux Emulation: fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:37 AM
fel1x.mintchoco.development_gmail.com added a member for linuxkpi: fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:37 AM
fel1x.mintchoco.development_gmail.com removed a watcher for linuxkpi: fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:37 AM
fel1x.mintchoco.development_gmail.com removed a watcher for Contributor Reviews (base): fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:37 AM
fel1x.mintchoco.development_gmail.com added a member for Contributor Reviews (base): fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:37 AM
fel1x.mintchoco.development_gmail.com added a watcher for Contributor Reviews (base): fel1x.mintchoco.development_gmail.com.
Apr 2 2022, 1:36 AM

Apr 1 2022

fel1x.mintchoco.development_gmail.com added a watcher for linuxkpi: fel1x.mintchoco.development_gmail.com.
Apr 1 2022, 10:18 PM
fel1x.mintchoco.development_gmail.com added a watcher for Linux Emulation: fel1x.mintchoco.development_gmail.com.
Apr 1 2022, 10:18 PM

Mar 2 2022

fel1x.mintchoco.development_gmail.com added a comment to D34410: Delete 25th anniversary image from FreeBSD website.

Yeah, let's hold off on celebrating the 30th anniversary until it actually happens, shall we? :)

Also, I'd recommend not tagging the doceng team in every review you create, since that only adds to the mail they receive, and phabricator (or some of the FreeBSD infrastructure surrounding it, I forget) knows which files need to have approval by them before the file can be changed, so it will add the automatically if needed.

Mar 2 2022, 7:29 PM