- User Since
- Nov 1 2020, 1:24 PM (39 w, 1 d)
outid will be written in case of a non-null output node found only. This is how iort_pci_rc_map() used to work and I don't want my patch to change this behavior.
Shared parts of the iort_pci_rc_map() and iort_named_comp_map() were extracted into a separate iort_smmu_trymap() function.
Tue, Jul 27
@andrew It definitely won't be, but I wanted to have a separate function for named components from IORT table similar to one for PCI RC nodes. I'll probably extract the same parts of the both functions into a separate one.
You won't see "MSI allocated" in dmesg if you clone the repository or pull the latest changes now. Please, ping me and I'll explain how to test this patch.
Thu, Jul 22
Dec 2 2020
@mhorne Should I update a patch attached to the PR also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251053 ?
Unnecessary tests of the devtype argument have been removed from uart_cpu_getdev() in sys/dev/uart/uart_cpu_arm64.c and sys/dev/uart/uart_cpu_fdt.c. uart_cpu_fdt_probe() checks for console types it supports.
Dec 1 2020
Please, take a look at the updated patch.
I've tried to follow all of the comments during the review.
Nov 30 2020
Nov 25 2020
There's some information here if you haven't found it already: https://wiki.freebsd.org/Phabricator
No, I haven't seen it yet - thanks for sharing! What's a preferred way to create a revision: via command line or web interface?
Nov 24 2020
Would you be willing to create a new phabricator review for the change?
Nov 11 2020
I've re-worked this patch and opened a PR at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251053.