- User Since
- Aug 25 2018, 5:03 PM (126 w, 4 d)
Wed, Jan 13
Sat, Jan 9
Thanks for the review! I don't have a bit but I have updated the description with the PR number.
Thu, Dec 31
Remove unwanted whitespace line.
Remove files not intended to be added to the review.
Update with feedback from jhb.
Wed, Dec 30
Sep 21 2020
I think you are missing some files in this review that changed, probably got lost when updating the new manpage changes.
Aug 19 2020
Ah yes it makes perfect sense to not document removal of code in man pages. That would result in some big ones :-). Thanks!
Aug 18 2020
I tagged @manu and @avg as they seem to have touched acpi_video not so long ago.
acpi_video can attach before, but it just wont show brightness sysctls. (atleast on our laptops T490)
So in the end maybe a bug rather than intended behavior.
Aug 15 2020
Also remove cuseeme reference in the man page itself.
Jul 19 2020
As I am not a committer, could someone take care of the commit for me? Thanks!
Jul 10 2020
Hi all, any updates on this patch getting merged? Whats the blocking issue ATM?
Jun 16 2020
Committed in r539318, thanks @meta!
Jun 11 2020
May 22 2020
This landed in r533804, thanks Dan!
Yea NP, there are a lot of other “which”s that dont start on a new line, I could move those to get consitency?
Just for my understanding before I start making changes
May 21 2020
Hi all, I don't have a commit bit :-). Following the discussion above, could someone take care of the commit? I'll quickly follow up with a new review removing the .Tn's.
May 13 2020
I could definitely do that, @bcr do you think the .Tn is a blocker? Its already present in this man page at line 40.
May 7 2020
I think this is fine to commit now :-). If any other pointers come up on the mailing lists regarding this commit I'll make an additional review to tackle those.
May 5 2020
Thanks for committing this new port Gleb!
May 3 2020
For whatever my approval is worth :-)
Thanks for your work on this Dan! I left a rough review, although most of them are easily fixable. Looking good so far! Looking forward seeing this landed :-).
Apr 30 2020
Apr 27 2020
I have tested this patch, it builds fine in poudriere. I run time tested this on my server, for the moment still running smoothly.
Apr 25 2020
FYI, I don't have a bit. We can wait a bit longer though for other people to possibly chime in.
Apr 22 2020
Apr 8 2020
Update to 5.2
Apr 7 2020
Got committed in r54041 ...
Apr 6 2020
Apr 3 2020
How close are we to getting this committed? Are there still some open points or is it fine as is ATM?
Mar 30 2020
Mar 17 2020
Nice! Looking forward to this :-).
Mar 14 2020
Mar 12 2020
Mar 11 2020
Does this mean that for a current dual stack IPFW rule like:
Feb 11 2020
This diff should resolve the plist issue fully and much more correctly.
Feb 10 2020
Jan 31 2020
Fix typo pointed out by @bcr. Thanks for the review!
Jan 30 2020
Jan 27 2020
I have run time tested this patch with multimedia/emby-server for a few days now and it has worked fine. Build is clean on my system too (12-STABLE).
Jan 20 2020
Jan 13 2020
Oct 9 2019
Hi guys, any more pointers or feedback? Otherwise I think this might be ready to commit :-).
Sep 27 2019
firewall.rc is actually rc.firewall.
Sep 26 2019
This is an obvious no-op change and only documents what was lagging behind.
Could someone from @portmgr take a look at this if blanket approval is needed?
Address feedback from @bcr. Thanks for the review!
Sep 25 2019
Address feedback. Thanks for the review!
Sep 13 2019
Aug 21 2019
Thanks, I see what you mean now! :-) Let me see what I can cook up.
Thanks for the feedback Eugen, that will take a bit more time to restructure / add some of your comments.
Aug 17 2019
May 25 2019
Revert using GCC, it is not a requirement and works best with USE_GCC that defines a run-time dep on GCC which is a big nono.
May 21 2019
May 20 2019
May 19 2019
Can you make sure that it also works with the WITH_SVN build option? (That installs svnlite as svn)
Mar 23 2019
Just FYI, I am not a committer :)
Mar 21 2019
Thanks for the pointer, this diff was by no means limited to the IPv6 modules :)!
I added a switch for the pmod module in a similar fashion.
Feb 23 2019
Remove trailing slash in LIB_DEPENDS
Re-add X11 option as there is interest for this in the community and an extra option doesn't hurt anyway.
Also handy for people wanting to keep their system clean of X11 and extra libraries.
Feb 21 2019
- Upstream released Emby-server 188.8.131.52 so update to latest version
- Link ffmpeg with x265
- Remove X11 as option (as it defaulted to on anyway and USE_XORG=x11 is set)
Feb 15 2019
Remove unneeded += for configure args.
Feb 14 2019
Fix typo's in RC script.
Feb 12 2019
Remove unneeded use of tar:xz.