- User Since
- Aug 25 2018, 5:03 PM (147 w, 16 h)
Thu, Jun 10
Hi all, could this regain some traction?
The conflicting information between the handbook and the notes in UPDATING is confusing a few people on the forums etc.
Apr 23 2021
- Actually define runtime for python
- PDF default off as suggested
- Define python version and only for runtime.
- Order asciidoctor rundep alphabetically like the others
- Specify minimum version of po4a
Apr 22 2021
fold in feedback.
In general your comments are valid and will open different reviews for some of them. But I'd like to keep this one just simple to change the mergemaster commands to etcupdate.
No real change intended rebased to master.
Apr 8 2021
Hi @debdrup, as you landed my review for updating the handbook to reference etcupdate, do you mind taking this one too? Thanks
Mar 29 2021
Hi Crees good improvements! I only have one small remark inline.
Mar 26 2021
Done & thanks!
Change [source,bash] to [source,shell]
Rebase on top of master
Mar 23 2021
Mar 18 2021
@debdrup given I don't have a commit bit someone will have to do it in my place anyway :-).
I like your suggested approach, go ahead & thank you for getting this landed!
Mar 17 2021
Feb 24 2021
Feb 16 2021
Advise to always run the bootstrap procedure when switching from mergemaster(8).
Readd Created by Line.
Feb 15 2021
Authors: Yasuhiro Kimura, Dries Michiels :-)
New doctree builds fine with this port installed, yay!
Steal patch from PR 253518, keep the GIT option.
Bump port version.
I went ahead and removed one dependency at a time and tried building the old English docs.
I removed each dependency from the port that caused a failure with the old doc tree.
So dependencies that are required to build the old doc tree are now gone.
Feb 12 2021
Rebase on new documentation tree.
Fix some other typo's.
I have build tested it and looks good in the web browser.
- Fix typo agains => again
Rebase on new documentation. Not yet build tested.
Feb 7 2021
Rebase on new documentation
Jan 13 2021
Jan 9 2021
Thanks for the review! I don't have a bit but I have updated the description with the PR number.
Dec 31 2020
Remove unwanted whitespace line.
Remove files not intended to be added to the review.
Update with feedback from jhb.
Dec 30 2020
Sep 21 2020
I think you are missing some files in this review that changed, probably got lost when updating the new manpage changes.
Aug 19 2020
Ah yes it makes perfect sense to not document removal of code in man pages. That would result in some big ones :-). Thanks!
Aug 18 2020
I tagged @manu and @avg as they seem to have touched acpi_video not so long ago.
acpi_video can attach before, but it just wont show brightness sysctls. (atleast on our laptops T490)
So in the end maybe a bug rather than intended behavior.
Aug 15 2020
Also remove cuseeme reference in the man page itself.
Jul 19 2020
As I am not a committer, could someone take care of the commit for me? Thanks!
Jul 10 2020
Hi all, any updates on this patch getting merged? Whats the blocking issue ATM?
Jun 16 2020
Committed in r539318, thanks @meta!
Jun 11 2020
May 22 2020
This landed in r533804, thanks Dan!
Yea NP, there are a lot of other “which”s that dont start on a new line, I could move those to get consitency?
Just for my understanding before I start making changes
May 21 2020
Hi all, I don't have a commit bit :-). Following the discussion above, could someone take care of the commit? I'll quickly follow up with a new review removing the .Tn's.
May 13 2020
I could definitely do that, @bcr do you think the .Tn is a blocker? Its already present in this man page at line 40.
May 7 2020
I think this is fine to commit now :-). If any other pointers come up on the mailing lists regarding this commit I'll make an additional review to tackle those.
May 5 2020
Thanks for committing this new port Gleb!
May 3 2020
For whatever my approval is worth :-)
Thanks for your work on this Dan! I left a rough review, although most of them are easily fixable. Looking good so far! Looking forward seeing this landed :-).
Apr 30 2020
Apr 27 2020
I have tested this patch, it builds fine in poudriere. I run time tested this on my server, for the moment still running smoothly.
Apr 25 2020
FYI, I don't have a bit. We can wait a bit longer though for other people to possibly chime in.
Apr 22 2020
Apr 8 2020
Update to 5.2
Apr 7 2020
Got committed in r54041 ...
Apr 6 2020
Apr 3 2020
How close are we to getting this committed? Are there still some open points or is it fine as is ATM?
Mar 30 2020
Mar 17 2020
Nice! Looking forward to this :-).
Mar 14 2020
Mar 12 2020
Mar 11 2020
Does this mean that for a current dual stack IPFW rule like:
Feb 11 2020
This diff should resolve the plist issue fully and much more correctly.
Feb 10 2020
Jan 31 2020
Fix typo pointed out by @bcr. Thanks for the review!