Page MenuHomeFreeBSD

driesm.michiels_gmail.com (Dries Michiels)
Duffyx

Projects

User does not belong to any projects.

User Details

User Since
Aug 25 2018, 5:03 PM (147 w, 16 h)

Recent Activity

Thu, Jun 10

driesm.michiels_gmail.com added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).
In D28062#690276, @ceri wrote:

Change looks good, I think, but is there any reason not to renumber those "footnotes" at the same time so that they are vaguely in order and 2 and 7 aren't missing for no good reason?

Thu, Jun 10, 10:56 AM
driesm.michiels_gmail.com added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

Hi all, could this regain some traction?
The conflicting information between the handbook and the notes in UPDATING is confusing a few people on the forums etc.

Thu, Jun 10, 9:55 AM

Apr 23 2021

driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.
  • Actually define runtime for python
  • PDF default off as suggested
Apr 23 2021, 4:39 PM
driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.
  • Define python version and only for runtime.
  • Order asciidoctor rundep alphabetically like the others
  • Specify minimum version of po4a
Apr 23 2021, 4:37 PM

Apr 22 2021

driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.

fold in feedback.

Apr 22 2021, 7:25 PM
driesm.michiels_gmail.com requested review of D29934: Reorder commented steps in UPDATING following sequential order..
Apr 22 2021, 7:10 PM
driesm.michiels_gmail.com added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

In general your comments are valid and will open different reviews for some of them. But I'd like to keep this one just simple to change the mergemaster commands to etcupdate.

Apr 22 2021, 6:51 PM
driesm.michiels_gmail.com updated the diff for D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

No real change intended rebased to master.

Apr 22 2021, 6:46 PM

Apr 8 2021

driesm.michiels_gmail.com added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

Hi @debdrup, as you landed my review for updating the handbook to reference etcupdate, do you mind taking this one too? Thanks

Apr 8 2021, 7:19 PM
driesm.michiels_gmail.com added a reviewer for D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8): debdrup.
Apr 8 2021, 7:19 PM

Mar 29 2021

driesm.michiels_gmail.com added a comment to D29489: security/crowdsec: rc script improvements.

Hi Crees good improvements! I only have one small remark inline.

Mar 29 2021, 8:17 PM

Mar 26 2021

driesm.michiels_gmail.com added a comment to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

The only thing I'd note is that [source,bash] should be [source,shell].

Done & thanks!

Mar 26 2021, 8:31 PM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Change [source,bash] to [source,shell]

Mar 26 2021, 8:30 PM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Rebase on top of master

Mar 26 2021, 8:27 PM

Mar 23 2021

driesm.michiels_gmail.com planned changes to D28609: textproc/docproj: Add required dependencies of the new documentation tree.
Mar 23 2021, 7:05 PM
driesm.michiels_gmail.com added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.
In D28609#642417, @mat wrote:

Has all the docs tree been converted to the ascii thing?

I had a look the other day and it looked like most bits were still using docbook, so we probably need to keep the dependencies.

+1 just add the new dependencies here, as we have the legacy documentation,

Mar 23 2021, 7:04 PM

Mar 18 2021

driesm.michiels_gmail.com added a comment to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

@debdrup given I don't have a commit bit someone will have to do it in my place anyway :-).
I like your suggested approach, go ahead & thank you for getting this landed!

Mar 18 2021, 3:39 PM

Mar 17 2021

driesm.michiels_gmail.com added a reviewer for D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8): docs.
Mar 17 2021, 7:59 PM
driesm.michiels_gmail.com added a reviewer for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook: docs.
Mar 17 2021, 7:57 PM

Feb 24 2021

driesm.michiels_gmail.com added a comment to D26123: [handbook] Remove reference to cusueeme.

It's possible Phabricator mangled things.

What I wanted you to do was:
1: Change 'seem' to 'appear'
2: Put the full path to /etc/rc.conf (instead of just rc.conf).

Feb 24 2021, 6:56 PM
driesm.michiels_gmail.com added inline comments to D26123: [handbook] Remove reference to cusueeme.
Feb 24 2021, 6:22 PM

Feb 16 2021

driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Advise to always run the bootstrap procedure when switching from mergemaster(8).

Feb 16 2021, 9:15 PM
driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.

Readd Created by Line.
Remove PDF_DESC.

Feb 16 2021, 5:11 PM

Feb 15 2021

driesm.michiels_gmail.com added a comment to D28609: textproc/docproj: Add required dependencies of the new documentation tree.

Authors: Yasuhiro Kimura, Dries Michiels :-)
New doctree builds fine with this port installed, yay!

Feb 15 2021, 6:36 PM
driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.

Steal patch from PR 253518, keep the GIT option.

Feb 15 2021, 6:32 PM
driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.

Bump port version.

Feb 15 2021, 6:17 PM
driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.

I went ahead and removed one dependency at a time and tried building the old English docs.
I removed each dependency from the port that caused a failure with the old doc tree.
So dependencies that are required to build the old doc tree are now gone.

Feb 15 2021, 6:16 PM

Feb 12 2021

driesm.michiels_gmail.com added a reviewer for D26123: [handbook] Remove reference to cusueeme: 0mp.
Feb 12 2021, 1:53 PM
driesm.michiels_gmail.com updated the diff for D26123: [handbook] Remove reference to cusueeme.

Rebase on new documentation tree.

Feb 12 2021, 1:53 PM
driesm.michiels_gmail.com updated the diff for D28609: textproc/docproj: Add required dependencies of the new documentation tree.

Fix typo

Feb 12 2021, 1:47 PM
driesm.michiels_gmail.com retitled D28609: textproc/docproj: Add required dependencies of the new documentation tree from Add required dependencies of the new documentation tree to textproc/docproj: Add required dependencies of the new documentation tree.
Feb 12 2021, 1:45 PM
driesm.michiels_gmail.com requested review of D28609: textproc/docproj: Add required dependencies of the new documentation tree.
Feb 12 2021, 1:44 PM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Fix some other typo's.
I have build tested it and looks good in the web browser.

Feb 12 2021, 10:39 AM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
  • Fix typo agains => again
Feb 12 2021, 10:17 AM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Rebase on new documentation. Not yet build tested.

Feb 12 2021, 10:16 AM

Feb 7 2021

driesm.michiels_gmail.com updated the diff for D27845: Fix broken link for Stormshield..

Rebase on new documentation

Feb 7 2021, 7:32 PM

Jan 13 2021

driesm.michiels_gmail.com updated the diff for D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

Incorporate feedback.

Jan 13 2021, 8:21 PM
driesm.michiels_gmail.com added inline comments to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Jan 13 2021, 8:14 PM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Incorporate feedback.

Jan 13 2021, 8:08 PM

Jan 9 2021

driesm.michiels_gmail.com updated the summary of D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).
Jan 9 2021, 3:17 PM
driesm.michiels_gmail.com added a comment to D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).

Thanks for the review! I don't have a bit but I have updated the description with the PR number.

Jan 9 2021, 3:17 PM
driesm.michiels_gmail.com requested review of D28062: Change procedure in UPDATING to use etcupdate(8) over mergemaster(8).
Jan 9 2021, 1:58 PM

Dec 31 2020

driesm.michiels_gmail.com added inline comments to D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Dec 31 2020, 10:59 AM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Remove unwanted whitespace line.

Dec 31 2020, 10:55 AM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Remove files not intended to be added to the review.

Dec 31 2020, 10:51 AM
driesm.michiels_gmail.com updated the diff for D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.

Update with feedback from jhb.

Dec 31 2020, 10:43 AM

Dec 30 2020

driesm.michiels_gmail.com retitled D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook from Try to favor etcupdate(8) over mergemsater(8) in the handbook to Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Dec 30 2020, 3:36 PM
driesm.michiels_gmail.com retitled D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook from Try to favor etcupdate over mergemsater in the handbook to Try to favor etcupdate(8) over mergemsater(8) in the handbook.
Dec 30 2020, 3:35 PM
driesm.michiels_gmail.com requested review of D27848: Try to favor etcupdate(8) over mergemaster(8) in the handbook.
Dec 30 2020, 2:56 PM
driesm.michiels_gmail.com requested review of D27845: Fix broken link for Stormshield..
Dec 30 2020, 1:59 PM

Sep 21 2020

driesm.michiels_gmail.com added a comment to D26435: Add rtsx driver for Realtek SD card readers..

I think you are missing some files in this review that changed, probably got lost when updating the new manpage changes.

Sep 21 2020, 7:19 PM

Aug 19 2020

driesm.michiels_gmail.com requested review of D26123: [handbook] Remove reference to cusueeme.
Aug 19 2020, 5:53 PM
driesm.michiels_gmail.com updated the diff for D26075: ipfirewall(4): Mention Cuseeme support was removed from libalias.

Ah yes it makes perfect sense to not document removal of code in man pages. That would result in some big ones :-). Thanks!

Aug 19 2020, 5:46 PM

Aug 18 2020

driesm.michiels_gmail.com added a comment to D26073: acpi_video(4): mention that acpi_video should be loaded after any drm driver.

I tagged @manu and @avg as they seem to have touched acpi_video not so long ago.
acpi_video can attach before, but it just wont show brightness sysctls. (atleast on our laptops T490)
So in the end maybe a bug rather than intended behavior.

Aug 18 2020, 1:19 PM
driesm.michiels_gmail.com added reviewers for D26073: acpi_video(4): mention that acpi_video should be loaded after any drm driver: avg, manu.
Aug 18 2020, 1:16 PM
driesm.michiels_gmail.com retitled D26073: acpi_video(4): mention that acpi_video should be loaded after any drm driver from mention that acpi_video should be loaded after any drm driver to acpi_video(4): mention that acpi_video should be loaded after any drm driver.
Aug 18 2020, 10:14 AM
driesm.michiels_gmail.com retitled D26075: ipfirewall(4): Mention Cuseeme support was removed from libalias from Mention Cuseeme support was removed from libalias to ipfirewall(4): Mention Cuseeme support was removed from libalias.
Aug 18 2020, 10:13 AM

Aug 15 2020

driesm.michiels_gmail.com updated the diff for D26075: ipfirewall(4): Mention Cuseeme support was removed from libalias.

Also remove cuseeme reference in the man page itself.

Aug 15 2020, 7:46 AM
driesm.michiels_gmail.com requested review of D26075: ipfirewall(4): Mention Cuseeme support was removed from libalias.
Aug 15 2020, 7:44 AM
driesm.michiels_gmail.com requested review of D26073: acpi_video(4): mention that acpi_video should be loaded after any drm driver.
Aug 15 2020, 7:34 AM

Jul 19 2020

driesm.michiels_gmail.com added a comment to D24952: ipfirewall.4: restructure new line starts and remove .Tn.

As I am not a committer, could someone take care of the commit for me? Thanks!

Jul 19 2020, 4:09 PM

Jul 10 2020

driesm.michiels_gmail.com added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Hi all, any updates on this patch getting merged? Whats the blocking issue ATM?

Jul 10 2020, 9:19 AM

Jun 16 2020

driesm.michiels_gmail.com abandoned D25235: [NEW PORT]: net/librespeed-cli.

Committed in r539318, thanks @meta!

Jun 16 2020, 6:16 AM

Jun 11 2020

driesm.michiels_gmail.com updated the summary of D25235: [NEW PORT]: net/librespeed-cli.
Jun 11 2020, 5:38 PM
driesm.michiels_gmail.com updated the summary of D25235: [NEW PORT]: net/librespeed-cli.
Jun 11 2020, 3:37 PM
driesm.michiels_gmail.com added a reviewer for D25235: [NEW PORT]: net/librespeed-cli: Contributor Reviewers (ports).
Jun 11 2020, 3:36 PM
driesm.michiels_gmail.com requested review of D25235: [NEW PORT]: net/librespeed-cli.
Jun 11 2020, 3:36 PM

May 22 2020

driesm.michiels_gmail.com closed D24671: net-mgmt/librenms: add Dispatch Service option to.

This landed in r533804, thanks Dan!

May 22 2020, 4:15 PM
driesm.michiels_gmail.com updated the diff for D24952: ipfirewall.4: restructure new line starts and remove .Tn.

incorporate feedback

May 22 2020, 4:13 PM
driesm.michiels_gmail.com added a comment to D24952: ipfirewall.4: restructure new line starts and remove .Tn.

Yea NP, there are a lot of other “which”s that dont start on a new line, I could move those to get consitency?

May 22 2020, 3:45 PM
driesm.michiels_gmail.com planned changes to D24952: ipfirewall.4: restructure new line starts and remove .Tn.

Just for my understanding before I start making changes

May 22 2020, 3:23 PM
driesm.michiels_gmail.com updated the summary of D24952: ipfirewall.4: restructure new line starts and remove .Tn.
May 22 2020, 9:36 AM
driesm.michiels_gmail.com requested review of D24952: ipfirewall.4: restructure new line starts and remove .Tn.
May 22 2020, 9:35 AM

May 21 2020

driesm.michiels_gmail.com added a comment to D24541: Update ipfw(4) manpage with all kernel options.

Hi all, I don't have a commit bit :-). Following the discussion above, could someone take care of the commit? I'll quickly follow up with a new review removing the .Tn's.

May 21 2020, 2:23 PM

May 13 2020

driesm.michiels_gmail.com added a comment to D24541: Update ipfw(4) manpage with all kernel options.

I could definitely do that, @bcr do you think the .Tn is a blocker? Its already present in this man page at line 40.

May 13 2020, 8:19 AM

May 7 2020

driesm.michiels_gmail.com added a comment to D24541: Update ipfw(4) manpage with all kernel options.

I think this is fine to commit now :-). If any other pointers come up on the mailing lists regarding this commit I'll make an additional review to tackle those.

May 7 2020, 9:03 AM

May 5 2020

driesm.michiels_gmail.com added a comment to D23157: New Port www/librespeed Lightweight (self)hosted speedtest.

Thanks for committing this new port Gleb!

May 5 2020, 7:29 AM

May 3 2020

driesm.michiels_gmail.com accepted D24671: net-mgmt/librenms: add Dispatch Service option to.

For whatever my approval is worth :-)

May 3 2020, 6:44 PM
driesm.michiels_gmail.com added a comment to D24671: net-mgmt/librenms: add Dispatch Service option to.

Thanks for your work on this Dan! I left a rough review, although most of them are easily fixable. Looking good so far! Looking forward seeing this landed :-).

May 3 2020, 4:53 PM

Apr 30 2020

driesm.michiels_gmail.com added reviewers for D24541: Update ipfw(4) manpage with all kernel options: melifaro, ae.
Apr 30 2020, 9:11 AM

Apr 27 2020

driesm.michiels_gmail.com added a comment to D18995: net-p2p/transmission: Update to 3.00..

I have tested this patch, it builds fine in poudriere. I run time tested this on my server, for the moment still running smoothly.

Apr 27 2020, 8:58 AM

Apr 25 2020

driesm.michiels_gmail.com added a comment to D24541: Update ipfw(4) manpage with all kernel options.

FYI, I don't have a bit. We can wait a bit longer though for other people to possibly chime in.

Apr 25 2020, 4:49 PM

Apr 22 2020

driesm.michiels_gmail.com added a reviewer for D24541: Update ipfw(4) manpage with all kernel options: eugen_grosbein.net.
Apr 22 2020, 8:25 PM
driesm.michiels_gmail.com created D24541: Update ipfw(4) manpage with all kernel options.
Apr 22 2020, 8:22 PM

Apr 8 2020

driesm.michiels_gmail.com updated the diff for D23157: New Port www/librespeed Lightweight (self)hosted speedtest.

Update to 5.2

Apr 8 2020, 5:57 PM

Apr 7 2020

driesm.michiels_gmail.com abandoned D24309: [Handbook] Fix typo in in-kernel NAT chapter.

Got committed in r54041 ...

Apr 7 2020, 10:21 AM

Apr 6 2020

driesm.michiels_gmail.com updated the diff for D24309: [Handbook] Fix typo in in-kernel NAT chapter.

Fix reassmbling/s/reassembling
Fix reassamble/s/reassemble

Apr 6 2020, 1:06 PM
driesm.michiels_gmail.com created D24309: [Handbook] Fix typo in in-kernel NAT chapter.
Apr 6 2020, 12:35 PM

Apr 3 2020

driesm.michiels_gmail.com added a comment to D23300: lang/mono: take maintainership, update to 6.8.0.105.

How close are we to getting this committed? Are there still some open points or is it fine as is ATM?

Apr 3 2020, 9:04 AM · mono

Mar 30 2020

driesm.michiels_gmail.com created D24230: Relax existence check of ${LOCALBASE}/bin/kyua in Makefile.inc1.
Mar 30 2020, 7:47 PM

Mar 17 2020

driesm.michiels_gmail.com added inline comments to D24077: New driver pchtherm(4), PCH installed thermal sensor..
Mar 17 2020, 4:26 PM
driesm.michiels_gmail.com added a comment to D24077: New driver pchtherm(4), PCH installed thermal sensor..

Nice! Looking forward to this :-).

Mar 17 2020, 4:26 PM

Mar 14 2020

driesm.michiels_gmail.com added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Adding me4 as an explicit ipv4 keyword is a good idea.

Mar 14 2020, 6:21 PM · network

Mar 12 2020

driesm.michiels_gmail.com added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..
Mar 12 2020, 7:28 PM · network

Mar 11 2020

driesm.michiels_gmail.com added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

Does this mean that for a current dual stack IPFW rule like:

Mar 11 2020, 3:18 PM · network

Feb 11 2020

driesm.michiels_gmail.com added a comment to D23300: lang/mono: take maintainership, update to 6.8.0.105.

This diff should resolve the plist issue fully and much more correctly.

Feb 11 2020, 5:10 PM · mono

Feb 10 2020

driesm.michiels_gmail.com added a comment to D23300: lang/mono: take maintainership, update to 6.8.0.105.
  • Update to 6.8.0.105
  • Includes fix for powerpc64 building (patch has been upstreamed)
  • Includes @greg_unrelenting.technology 's patch partially; testing is required here. All of the Mono changes were already done upstream except for the boringssl portion. Some were done slightly differently (e.g. REDZONE is for all !APPLE) and revisions were necessary to boehm being deprecated/externalized.

The issue with MCS/CSC insta-crashing on qemu is a known issue due to qemu limitations and Roslyn behaviors, so if anyone knows how I can say "aarch64 as long as it's not qemu" that would be very helpful. Users on qemu should expect this port to NOT build, while users on native arm should have no issues.

Feb 10 2020, 7:09 PM · mono

Jan 31 2020

driesm.michiels_gmail.com updated the diff for D23426: Simplify IPFW in-kernel NAT section (handbook).

Fix typo pointed out by @bcr. Thanks for the review!

Jan 31 2020, 4:57 PM

Jan 30 2020

driesm.michiels_gmail.com updated the summary of D23426: Simplify IPFW in-kernel NAT section (handbook).
Jan 30 2020, 10:34 AM
driesm.michiels_gmail.com created D23426: Simplify IPFW in-kernel NAT section (handbook).
Jan 30 2020, 10:33 AM