Page MenuHomeFreeBSD

dougm_rice.edu (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (68 w, 4 d)

Recent Activity

Mon, Oct 22

dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Avoid function call in MERGE_NONE case.

Mon, Oct 22, 3:28 AM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Add missing max_free update to MERGE_NEXT case.

Mon, Oct 22, 3:24 AM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Add a KASSERT to vm_map_mergeable_neighbors. Exploit the fact that some adj_free field is 0 in vm_map_entry_unlink neighbor-merging to avoid some calculation.

Mon, Oct 22, 3:01 AM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Apply reviewer suggestions.

Mon, Oct 22, 12:03 AM

Sun, Oct 21

dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Fix cut-and-paste error. Drop prevsize. Reformat comment. Add merge parameter to vm_entry_map_delete, so that deleting a gap entry can happen without a call to vm_map_entry_resize_free.

Sun, Oct 21, 10:11 PM
dougm_rice.edu abandoned D17639: address late reviewer concerns about helper functions patch.

The concerns that this change would address will be addressed elsewhere.

Sun, Oct 21, 9:15 PM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Rename pesky 'neighbor' functions. Pass the unlink_merge_type to the function that disposes of things.

Sun, Oct 21, 8:38 PM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Address reviewer comments.

Sun, Oct 21, 8:21 PM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Rewrite to avoid changing start/end values before splaying, by adding an argument to unlink telling it which "neighbor", if any, that the unlinking item is being merged with.

Sun, Oct 21, 7:35 PM
dougm_rice.edu added reviewers for D17639: address late reviewer concerns about helper functions patch: kib, markj.
Sun, Oct 21, 7:20 PM
dougm_rice.edu updated the diff for D17639: address late reviewer concerns about helper functions patch.

Add 'simplify' to 'neighbor' function names.

Sun, Oct 21, 6:22 PM
dougm_rice.edu created D17639: address late reviewer concerns about helper functions patch.
Sun, Oct 21, 6:01 PM
dougm_rice.edu added inline comments to D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors.
Sun, Oct 21, 5:58 PM
dougm_rice.edu updated the diff for D17635: Avoid duplicate set_max_free after unlink.

Update the diff to match the updated title of this change.

Sun, Oct 21, 5:02 PM
dougm_rice.edu retitled D17635: Avoid duplicate set_max_free after unlink from Avoid duplicate set_max_free in merging with next neighbor to Avoid duplicate set_max_free after unlink.
Sun, Oct 21, 5:01 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Back-up to a version that worked once, and hope that it still does.

Sun, Oct 21, 9:07 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Fix a problem recently introduced that breaks an insert of a new last item.

Sun, Oct 21, 7:21 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Update to adjust to recent changes in adjacent code.

Sun, Oct 21, 4:58 AM
dougm_rice.edu created D17635: Avoid duplicate set_max_free after unlink.
Sun, Oct 21, 1:05 AM

Sat, Oct 20

dougm_rice.edu created D17622: Use adj_free field in vm_map_entry_t instead of computing e->next->start - e->end.
Sat, Oct 20, 10:28 AM

Thu, Oct 18

dougm_rice.edu updated the diff for D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors.

Accept reviewer style suggestions.

Thu, Oct 18, 7:39 PM
dougm_rice.edu updated the summary of D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors.
Thu, Oct 18, 3:38 PM
dougm_rice.edu added a reviewer for D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors: kib.
Thu, Oct 18, 3:37 PM
dougm_rice.edu created D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors.
Thu, Oct 18, 3:36 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Apply recommended style changes.

Thu, Oct 18, 3:27 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Fix CTR3 compilation error.

Thu, Oct 18, 3:20 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Drop unneeded argument to vm_map_entry_link. Drop unnecessary calls to vm_map_entry_resize_free from vm_map_simplify_entry, by setting start/end fields before removing neighbor. Reduce number of uses of 'prev' member when iterating through consecutive map entries.

Thu, Oct 18, 8:29 AM

Sep 17 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Thanks to Peter Holm for point out necessary changes to this patch on account of changes elsewhere. min_offset and max_offset fields have been renamed.

Sep 17 2018, 9:20 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

The patch hasn't changed since February, but some of the context around it has, so updating to deal with conflicts.

Sep 17 2018, 3:12 AM

Sep 6 2018

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

The only difference between this and what was posted in January is that that patch discarded code that has recently been found to be buggy, and this patch discards the fixed code.

Sep 6 2018, 12:25 PM

Sep 5 2018

dougm_rice.edu accepted D17020: Fix an edge case in the node count computation in blist_create()..
Sep 5 2018, 3:59 AM

Sep 4 2018

dougm_rice.edu added inline comments to D17020: Fix an edge case in the node count computation in blist_create()..
Sep 4 2018, 9:09 PM

Sep 1 2018

dougm_rice.edu updated the diff for D16901: Eliminate some needless attempts to merge buddies.

Add parens, as requested.

Sep 1 2018, 11:41 PM
dougm_rice.edu updated the diff for D16901: Eliminate some needless attempts to merge buddies.

Apply reviewer-recommended changes.

Sep 1 2018, 9:16 PM

Aug 25 2018

dougm_rice.edu created D16901: Eliminate some needless attempts to merge buddies.
Aug 25 2018, 5:50 PM

Aug 15 2018

dougm_rice.edu added inline comments to D13484: swapoff to release multiple swap blocks at a time.
Aug 15 2018, 7:47 AM
dougm_rice.edu abandoned D15703: Compute stats regarding error in pid calculations.
Aug 15 2018, 5:09 AM

Aug 5 2018

dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Alphabetically order variable definitions. Introduce standard whitespace before block comment.

Aug 5 2018, 11:39 PM
dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Replace another conditional freerange with a KASSERT, as instructed.

Aug 5 2018, 11:29 PM
dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Add KASSERT on swap_pager_meta_build return value. Use a 'continue' to allow a big indented block to be outdented.

Aug 5 2018, 7:48 PM
dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Accept a suggestion to remove an unnecessary conditional 'continue'.

Aug 5 2018, 6:44 PM
dougm_rice.edu added inline comments to D13707: Defer and aggregate swap_pager_meta_build frees.
Aug 5 2018, 6:42 PM

Jun 8 2018

dougm_rice.edu created D15703: Compute stats regarding error in pid calculations.
Jun 8 2018, 6:06 AM

Feb 6 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Rewrite the splay root-picking code a bit to eliminate a few redundant writes.

Feb 6 2018, 5:55 AM

Jan 29 2018

dougm_rice.edu added a comment to D13999: add map header sentinel to vm_map search tree.
In D13999#296096, @kib wrote:
In D13999#295780, @kib wrote:

Is there an assert somewhere that the map header is never returned by a lookup ?

Without this change, it is possible that vm_map_lookup_entry will return with *entry == &map->header, when the root is null or when a binary search is made for an address smaller than any in the tree. So there's no assertion to fail on that condition, and it would be incorrect to add one.

That will still be possible after this change, so that there's no cause to add an assertion.

Ok. I looked at the consumers, and either they explicitly check for the lookup address falling into the map range, or do found_entry->next if result is false.

I mean that with your previous and this changes, the header map entry looks more and more as the normal entry, which might make some futher code change erroneously fail to skip it. I want to have some protection and diagnostic for that error.

Jan 29 2018, 9:46 PM

Jan 28 2018

dougm_rice.edu added a comment to D13999: add map header sentinel to vm_map search tree.
In D13999#295780, @kib wrote:

Is there an assert somewhere that the map header is never returned by a lookup ?

Jan 28 2018, 10:50 AM

Jan 27 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Punctuate comments.

Jan 27 2018, 4:19 AM

Jan 26 2018

dougm_rice.edu added reviewers for D13999: add map header sentinel to vm_map search tree: kib, markj.
Jan 26 2018, 8:36 PM
dougm_rice.edu abandoned D14019: Don't splay on an out-of-range address.
Jan 26 2018, 8:31 PM
dougm_rice.edu abandoned D13398: Complete zig-zag splay, rather than zigging and looping again.
Jan 26 2018, 8:31 PM
dougm_rice.edu added a reviewer for D13999: add map header sentinel to vm_map search tree: alc.
Jan 26 2018, 3:54 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Endeavor to properly delete a tree node with no left child.

Jan 26 2018, 10:47 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Throw everything back in.

Jan 26 2018, 7:16 AM

Jan 25 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Null the children of the item being inserted.

Jan 25 2018, 9:07 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Fix function name.

Jan 25 2018, 8:37 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Missing *

Jan 25 2018, 6:57 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Let splay() do the insertion of a new node.

Jan 25 2018, 6:25 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Small changes to splay and unlink that I expect to break nothing.

Jan 25 2018, 4:49 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Back up to where I think things last worked, to start a search for where things broke again.

Jan 25 2018, 9:36 AM
dougm_rice.edu removed a reviewer for D13999: add map header sentinel to vm_map search tree: alc.
Jan 25 2018, 9:34 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Update a comment.

Jan 25 2018, 5:30 AM
dougm_rice.edu updated the summary of D13999: add map header sentinel to vm_map search tree.
Jan 25 2018, 5:28 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

The changed behavior of the splay function merits a renaming, to vm_map_splay from vm_map_entry_splay.

Jan 25 2018, 5:27 AM
dougm_rice.edu updated the summary of D13999: add map header sentinel to vm_map search tree.
Jan 25 2018, 4:05 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Reduce the size of the diff a bit.

Jan 25 2018, 3:06 AM

Jan 24 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Move all tree manipulation into the splay function, by passing a map argument instead of a pointer to root, and a supplementary argument to control whether an item is inserted, or deleted, or neither. Add a assertion on splay that the address is within map bounds.

Jan 24 2018, 11:23 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Perhaps I found a problem with linking a new entry at the beginning. Perhaps I fixed it.

Jan 24 2018, 8:54 AM

Jan 23 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Put everything back in, including a fix for the failure to initialize *entry on an out-of-bounds lookup, and await news.

Jan 23 2018, 9:33 PM
dougm_rice.edu updated the diff for D14019: Don't splay on an out-of-range address.

Returning early cannot mean leaving the *entry value uninitialized.

Jan 23 2018, 6:44 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Drop the early exit for out-of-range addresses, which leaves *entry uninitialized.

Jan 23 2018, 6:39 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Fix the broken binary search.

Jan 23 2018, 4:32 PM
dougm_rice.edu added a comment to D14019: Don't splay on an out-of-range address.

The map is not an argument to vm_map_entry_splay, so the range data is not available to form an assertion.

Jan 23 2018, 4:11 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Restore the modifications to the tree search, and restore the range check to lookup_entry, and wait to see if those changes can be blamed for what's wrong in the big patch.

Jan 23 2018, 9:50 AM
dougm_rice.edu added a comment to D14019: Don't splay on an out-of-range address.

The origin of this patch is that I am developing changes to vm_map_entry_splay that require the address to lie within the map range, and a Peter Holm test reveals that not to be the case in at least one instance:

Jan 23 2018, 4:36 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Throw out everything except the changes to the splay function, to see if a problem regarding rc scripts resides there.

Jan 23 2018, 3:47 AM

Jan 22 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Fix another error from rushed editting. I'm surprised that it compiled.

Jan 22 2018, 9:22 PM
dougm_rice.edu added reviewers for D14019: Don't splay on an out-of-range address: alc, markj, kib.
Jan 22 2018, 7:43 PM
dougm_rice.edu created D14019: Don't splay on an out-of-range address.
Jan 22 2018, 7:43 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Avoid duplicated comparisons in splay.

Jan 22 2018, 7:38 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Have lookup_entry check that address is within map range before splaying.

Jan 22 2018, 6:50 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Try again to fix the right-right problem, without compilation errors. Thanks again, Peter.

Jan 22 2018, 9:24 AM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Remember to compare to end before comparing to start in the case when the first splay step is to the right and we have to consider whether the next splay step is also to the right.

Jan 22 2018, 7:08 AM

Jan 21 2018

dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Provide more debug information when a splay assertion fails.

Jan 21 2018, 9:19 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Initialize map->header.max_free too.

Jan 21 2018, 8:27 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Initialize map->header.adj_free in _vm_map_init.

Jan 21 2018, 8:20 PM
dougm_rice.edu updated the diff for D13999: add map header sentinel to vm_map search tree.

Fix a compilation error that I'm embarrassed to have included in the previous version.

Jan 21 2018, 6:45 PM
dougm_rice.edu created D14005: initializing map->header.eflags allows skipping one loop test.
Jan 21 2018, 7:51 AM

Jan 20 2018

dougm_rice.edu created D13999: add map header sentinel to vm_map search tree.
Jan 20 2018, 7:09 PM
dougm_rice.edu updated the diff for D13735: Assign map->header values to avoid boundary checks.

Apply suggested changes to indentation.

Jan 20 2018, 9:25 AM
dougm_rice.edu added a comment to D13735: Assign map->header values to avoid boundary checks.

I have addressed the comments (made offline) from alc. He has stated that he has no objections to the resulting patch, but that I will have to rely on someone else to give it final approval and checkin. I'd appreciate that help from somebody, please.

Jan 20 2018, 3:46 AM
dougm_rice.edu updated the diff for D13735: Assign map->header values to avoid boundary checks.

Add a comment regarding the use of sentinel values.

Jan 20 2018, 3:44 AM

Jan 16 2018

dougm_rice.edu updated the diff for D13735: Assign map->header values to avoid boundary checks.

Make recommended formatting changes to a couple of loops.

Jan 16 2018, 6:02 PM
dougm_rice.edu added reviewers for D13735: Assign map->header values to avoid boundary checks: markj, kib.
Jan 16 2018, 3:37 AM

Jan 14 2018

dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Add recommended space to one comment.

Jan 14 2018, 5:37 PM

Jan 13 2018

dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Apply reviewer suggestions.

Jan 13 2018, 5:08 PM
dougm_rice.edu added a comment to D13735: Assign map->header values to avoid boundary checks.

Peter Holm, can you please stress test this patch at your convenience?

Jan 13 2018, 4:49 AM
dougm_rice.edu updated subscribers of D13735: Assign map->header values to avoid boundary checks.
Jan 13 2018, 4:48 AM
dougm_rice.edu added reviewers for D13707: Defer and aggregate swap_pager_meta_build frees: kib, markj.
Jan 13 2018, 4:46 AM

Jan 6 2018

dougm_rice.edu abandoned D12511: replace blist_fill with list_alloc_all.
Jan 6 2018, 7:42 PM
dougm_rice.edu removed a reviewer for D12511: replace blist_fill with list_alloc_all: alc.
Jan 6 2018, 7:40 PM