dougm_rice.edu (Doug Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 30 2017, 3:18 PM (28 w, 6 d)

Recent Activity

Tue, Jan 16

dougm_rice.edu updated the diff for D13735: Assign map->header values to avoid boundary checks.

Make recommended formatting changes to a couple of loops.

Tue, Jan 16, 6:02 PM
dougm_rice.edu added reviewers for D13735: Assign map->header values to avoid boundary checks: markj, kib.
Tue, Jan 16, 3:37 AM

Sun, Jan 14

dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Add recommended space to one comment.

Sun, Jan 14, 5:37 PM

Sat, Jan 13

dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Apply reviewer suggestions.

Sat, Jan 13, 5:08 PM
dougm_rice.edu added a comment to D13735: Assign map->header values to avoid boundary checks.

Peter Holm, can you please stress test this patch at your convenience?

Sat, Jan 13, 4:49 AM
dougm_rice.edu updated subscribers of D13735: Assign map->header values to avoid boundary checks.
Sat, Jan 13, 4:48 AM
dougm_rice.edu added reviewers for D13707: Defer and aggregate swap_pager_meta_build frees: kib, markj.
Sat, Jan 13, 4:46 AM

Sat, Jan 6

dougm_rice.edu abandoned D12511: replace blist_fill with list_alloc_all.
Sat, Jan 6, 7:42 PM
dougm_rice.edu removed a reviewer for D12511: replace blist_fill with list_alloc_all: alc.
Sat, Jan 6, 7:40 PM

Wed, Jan 3

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Rewrite a comment.

Wed, Jan 3, 10:52 PM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Adopt reviewer suggestions. Reduce the size of the diff by reformatting modified comments to have fewer lines changed.

Wed, Jan 3, 9:07 PM
dougm_rice.edu added inline comments to D12635: Allow allocations across meta boundaries.
Wed, Jan 3, 6:59 PM
dougm_rice.edu updated the diff for D13735: Assign map->header values to avoid boundary checks.

Eliminate unneeded &map->header checks in vm_mmap.c.

Wed, Jan 3, 2:48 AM

Tue, Jan 2

dougm_rice.edu updated the diff for D13735: Assign map->header values to avoid boundary checks.

Associate min_offset and max_offset with header.end and header.start, respectively.

Tue, Jan 2, 8:50 AM
dougm_rice.edu created D13735: Assign map->header values to avoid boundary checks.
Tue, Jan 2, 6:49 AM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Restore missing blist.h changes.

Tue, Jan 2, 5:48 AM

Mon, Jan 1

dougm_rice.edu added inline comments to D13398: Complete zig-zag splay, rather than zigging and looping again.
Mon, Jan 1, 7:17 PM
dougm_rice.edu added inline comments to D13398: Complete zig-zag splay, rather than zigging and looping again.
Mon, Jan 1, 7:01 PM
dougm_rice.edu updated the diff for D13398: Complete zig-zag splay, rather than zigging and looping again.

Fixup comments, and whitespace.

Mon, Jan 1, 6:33 PM

Sun, Dec 31

dougm_rice.edu updated the diff for D13398: Complete zig-zag splay, rather than zigging and looping again.

On a failed lookup, stop trying to avoid pulling both neighbors of the missing item to the top of the tree.

Sun, Dec 31, 8:40 PM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Apply suggested whitespace and commenting changes.

Sun, Dec 31, 5:11 AM
dougm_rice.edu updated the diff for D13707: Defer and aggregate swap_pager_meta_build frees.

Add missing declaration.

Sun, Dec 31, 5:05 AM
dougm_rice.edu created D13707: Defer and aggregate swap_pager_meta_build frees.
Sun, Dec 31, 5:03 AM
dougm_rice.edu updated the diff for D13290: allow frees to aggregate in swap_pager_copy.

Drop unwanted comment.

Sun, Dec 31, 3:36 AM
dougm_rice.edu updated the diff for D13290: allow frees to aggregate in swap_pager_copy.

Capitalize in a comment.

Sun, Dec 31, 1:02 AM
dougm_rice.edu updated the diff for D13290: allow frees to aggregate in swap_pager_copy.

Fix 'else' spacing.

Sun, Dec 31, 12:31 AM

Sat, Dec 30

dougm_rice.edu updated the diff for D13290: allow frees to aggregate in swap_pager_copy.

Adopt reviewer comments about comments.

Sat, Dec 30, 8:22 PM
dougm_rice.edu updated the diff for D13290: allow frees to aggregate in swap_pager_copy.

Adopt reviewer suggestions.

Sat, Dec 30, 4:46 PM
dougm_rice.edu added reviewers for D13290: allow frees to aggregate in swap_pager_copy: kib, markj.
Sat, Dec 30, 6:52 AM

Dec 10 2017

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Eliminate whitespace changes to comments that may have discouraged reviewers.

Dec 10 2017, 11:23 PM
dougm_rice.edu updated the diff for D13398: Complete zig-zag splay, rather than zigging and looping again.

Adding code to eliminate a redundant comparison.

Dec 10 2017, 10:59 PM

Dec 7 2017

dougm_rice.edu added inline comments to D13398: Complete zig-zag splay, rather than zigging and looping again.
Dec 7 2017, 6:26 PM

Dec 6 2017

dougm_rice.edu created D13398: Complete zig-zag splay, rather than zigging and looping again.
Dec 6 2017, 6:42 PM

Dec 2 2017

dougm_rice.edu abandoned D13347: change top-down splay.
Dec 2 2017, 11:05 PM
dougm_rice.edu added a comment to D13346: Handle address wrap errors in vm_map_find().
Dec 2 2017, 9:54 PM
dougm_rice.edu created D13347: change top-down splay.
Dec 2 2017, 9:53 PM
dougm_rice.edu added a comment to D13346: Handle address wrap errors in vm_map_find().
Dec 2 2017, 9:51 PM
dougm_rice.edu added a comment to D13346: Handle address wrap errors in vm_map_find().

If you are concerned about a search for a missing tree element flipping the top two tree nodes for no good reason, as for example when looking for 1 in the set (0 2) and flipping the tree back and forth between

Dec 2 2017, 9:50 PM

Dec 1 2017

dougm_rice.edu added a comment to D12635: Allow allocations across meta boundaries.

Would you please stress test this patch, Peter?

Dec 1 2017, 9:08 PM
dougm_rice.edu updated subscribers of D12635: Allow allocations across meta boundaries.
Dec 1 2017, 9:07 PM

Nov 29 2017

dougm_rice.edu added a reviewer for D13290: allow frees to aggregate in swap_pager_copy: alc.
Nov 29 2017, 8:41 AM
dougm_rice.edu created D13290: allow frees to aggregate in swap_pager_copy.
Nov 29 2017, 8:40 AM

Nov 26 2017

dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Add missing brace.

Nov 26 2017, 6:21 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Update an assertion.

Nov 26 2017, 6:13 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Drop 'empty' variable.

Nov 26 2017, 6:10 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Rename the new function, and reposition its declaration.

Nov 26 2017, 6:04 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Fold two lines into one, where de-indentation now allows it.

Nov 26 2017, 5:51 PM
dougm_rice.edu added inline comments to D12397: combine block frees in swap_pager_meta_frees.
Nov 26 2017, 5:24 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Add a function to test for empty block ranges, and use it to simplify code.

Nov 26 2017, 5:23 PM

Nov 25 2017

dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Fix prototype.

Nov 25 2017, 11:52 PM
dougm_rice.edu added inline comments to D12397: combine block frees in swap_pager_meta_frees.
Nov 25 2017, 9:20 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Avoid casting vm_pindex_t differences to ints before comparing them.

Nov 25 2017, 9:20 PM

Nov 17 2017

dougm_rice.edu updated the diff for D13074: Allow powers-of-two differences for free blocks in vm_phys buddy system allocator.
Nov 17 2017, 10:26 PM
dougm_rice.edu updated the diff for D13074: Allow powers-of-two differences for free blocks in vm_phys buddy system allocator.

Switch from using bitstring.h to bitset.h.

Nov 17 2017, 6:55 AM

Nov 13 2017

dougm_rice.edu created D13074: Allow powers-of-two differences for free blocks in vm_phys buddy system allocator.
Nov 13 2017, 9:22 PM
dougm_rice.edu added a comment to D12635: Allow allocations across meta boundaries.

Alan Cox has told me that this blank line, before the first executable statement of a function, and regardless of whether or not there are any variable declarations preceding it, is a required element of FreeBSD coding style. So, by applying your patch, I would be ensuring his disapproval. Unless he directs me otherwise, I can't reasonably incorporate your patch into mine.

Nov 13 2017, 9:53 AM

Oct 31 2017

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

With ample context.

Oct 31 2017, 3:24 PM

Oct 28 2017

dougm_rice.edu added inline comments to D12635: Allow allocations across meta boundaries.
Oct 28 2017, 6:28 PM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Replace imin with ummin.

Oct 28 2017, 6:27 PM

Oct 27 2017

dougm_rice.edu added reviewers for D12635: Allow allocations across meta boundaries: markj, kib.
Oct 27 2017, 7:29 PM

Oct 16 2017

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Don't print the all-used tree. With fill-column set to 80, reformat some comments. Update others to reflect the changes made in the substance of the patch.

Oct 16 2017, 2:59 AM

Oct 13 2017

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Include the avail count in the blist printout.

Oct 13 2017, 5:18 AM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Use a more appropriate constant in blist_alloc.

Oct 13 2017, 5:01 AM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Fix an avail update.

Oct 13 2017, 4:59 AM

Oct 12 2017

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Fix a typo in updating meta-node hint. Change nodes allocted so that when an alloc fails and the last block is free, there is always some meta node that can have its hint updated to count-1.

Oct 12 2017, 10:30 PM
dougm_rice.edu abandoned D12016: reduce computation in meta-function loops.
Oct 12 2017, 7:04 AM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Drop KERN_{SUCCESS,FAILURE}. Make META_RADIX match BMAP_RADIX.

Oct 12 2017, 2:13 AM

Oct 11 2017

dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

Correct calculation of number of nodes, to account for the extra zero node when blocks is a multiple of BLIST_BMAP_RADIX.

Oct 11 2017, 5:21 PM
dougm_rice.edu removed a reviewer for D12016: reduce computation in meta-function loops: alc.
Oct 11 2017, 3:38 PM
dougm_rice.edu updated the diff for D12635: Allow allocations across meta boundaries.

in blst_next_leaf_alloc, stop walking over meta-nodes as soon as one of them has an empty first child. That way, the extra empty meta node at the end of a 1024-block tree will stop a search for next leaf before we walk past allocated memory.

Oct 11 2017, 8:25 AM
dougm_rice.edu added a reviewer for D12635: Allow allocations across meta boundaries: alc.
Oct 11 2017, 5:58 AM
dougm_rice.edu created D12635: Allow allocations across meta boundaries.
Oct 11 2017, 5:56 AM

Oct 9 2017

dougm_rice.edu added a reviewer for D12627: clear allocated blist struct: kib.
Oct 9 2017, 10:00 AM
dougm_rice.edu created D12627: clear allocated blist struct.
Oct 9 2017, 9:59 AM

Oct 8 2017

dougm_rice.edu updated the diff for D12016: reduce computation in meta-function loops.

Update patch after an unrelated checkin.

Oct 8 2017, 10:26 PM
dougm_rice.edu updated the summary of D11968: Simplify blist initialization.
Oct 8 2017, 7:54 PM
dougm_rice.edu updated the summary of D11968: Simplify blist initialization.
Oct 8 2017, 7:53 PM
dougm_rice.edu updated the diff for D11968: Simplify blist initialization.

In blist_create, change some variable types from daddr_t to u_daddr_t where those variables could, when BLIST_META_RADIX and BLIST_BMAP_RADIX are reduced to 1, and blocks is near its maximum value, exceed the max value for the signed type.

Oct 8 2017, 5:36 PM
dougm_rice.edu updated the summary of D11968: Simplify blist initialization.
Oct 8 2017, 5:20 PM

Sep 26 2017

dougm_rice.edu updated the diff for D12511: replace blist_fill with list_alloc_all.

Correct update of swap_pager_avail.

Sep 26 2017, 11:06 PM
dougm_rice.edu updated the diff for D12511: replace blist_fill with list_alloc_all.

Add an alloc-all option to the test program.

Sep 26 2017, 10:24 PM
dougm_rice.edu added a reviewer for D12511: replace blist_fill with list_alloc_all: alc.
Sep 26 2017, 10:18 PM
dougm_rice.edu created D12511: replace blist_fill with list_alloc_all.
Sep 26 2017, 10:17 PM

Sep 21 2017

dougm_rice.edu updated the diff for D11968: Simplify blist initialization.

Eliminate blist_init, and set the root values and terminators in blist_create.

Sep 21 2017, 4:41 AM
dougm_rice.edu updated the summary of D11968: Simplify blist initialization.
Sep 21 2017, 4:38 AM

Sep 19 2017

dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Handle index - sb->p < 0.

Sep 19 2017, 8:08 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Tidy up.

Sep 19 2017, 6:22 AM

Sep 18 2017

dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

In swap_pager_meta_free, avoid iterations of the i loop that can only set 'empty' to false when 'empty' has already been made false.

Sep 18 2017, 1:30 AM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Undo the most recent update, as it had an unintended effect.

Sep 18 2017, 12:06 AM

Sep 17 2017

dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

In swap_pager_meta_free, shrink the upper and lower bounds on the i-loop, to omit iterations that just set empty to false, and instead set empty based on whether or not the loop range gets shrunk.

Sep 17 2017, 11:58 PM
dougm_rice.edu updated the diff for D12397: combine block frees in swap_pager_meta_frees.

Change swap_pager_freeswapspace npages params and args from int to daddr_t.

Sep 17 2017, 11:15 PM
dougm_rice.edu added a reviewer for D12397: combine block frees in swap_pager_meta_frees: alc.
Sep 17 2017, 4:25 AM
dougm_rice.edu created D12397: combine block frees in swap_pager_meta_frees.
Sep 17 2017, 4:24 AM

Sep 16 2017

dougm_rice.edu updated the diff for D12016: reduce computation in meta-function loops.

Resolve conflicts.

Sep 16 2017, 6:39 PM
dougm_rice.edu updated the diff for D11968: Simplify blist initialization.

Resolve a conflict introduced by another change to subr_blist.c.

Sep 16 2017, 6:29 PM

Sep 15 2017

dougm_rice.edu updated the diff for D11819: Allow blist allocations to span leaf boundaries, but not meta boundaries.

If a leaf allocation uses all the free block of the leaf, make sure that the hint is zeroed.

Sep 15 2017, 9:07 PM

Sep 14 2017

dougm_rice.edu updated the diff for D11819: Allow blist allocations to span leaf boundaries, but not meta boundaries.

Initialize bitmap in termintors to avoid leaf allocations to go past last available block.

Sep 14 2017, 6:33 PM

Sep 13 2017

dougm_rice.edu updated the diff for D11968: Simplify blist initialization.

Insert blank line.

Sep 13 2017, 5:33 PM
dougm_rice.edu updated the diff for D11968: Simplify blist initialization.

Fix a whitespace problem.

Sep 13 2017, 3:57 PM
dougm_rice.edu updated the diff for D11819: Allow blist allocations to span leaf boundaries, but not meta boundaries.

Update comments. Address style issues. Avoid initialization of 'n' in blst_leaf_free an blst_leaf_fill.

Sep 13 2017, 5:14 AM