Page MenuHomeFreeBSD

dg_syrec.org (Dmitri Goutnik)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2017, 2:22 PM (124 w, 3 d)

Recent Activity

Yesterday

dg_syrec.org added a comment to D20813: Mk/Uses/go.mk: Default to "." (the current package) instead of PORTNAME.
  1. If GO_PKGNAME=${PORTNAME} is almost always wrong then why are we setting it like that?
  2. Can you give some examples of ports where this would simplify things? I'm too lazy to figure out which ports this applies to by myself.
  3. It would be nice if @jlaffaye could sign off on the maintainership transfer.
Thu, Jul 18, 12:57 PM

Wed, Jul 17

dg_syrec.org added a comment to D20813: Mk/Uses/go.mk: Default to "." (the current package) instead of PORTNAME.

Any thoughts/feedback on this? Should I request an exp-run to get this moving forward?
Otherwise I believe this can be committed with maintainer timeout (17 days).

Wed, Jul 17, 12:38 PM

Fri, Jul 5

dg_syrec.org added a comment to D20813: Mk/Uses/go.mk: Default to "." (the current package) instead of PORTNAME.

Request maintainership.

Fri, Jul 5, 5:04 PM

Sun, Jun 30

dg_syrec.org added reviewers for D20813: Mk/Uses/go.mk: Default to "." (the current package) instead of PORTNAME: jlaffaye, swills, tobik.
Sun, Jun 30, 9:35 PM
dg_syrec.org created D20813: Mk/Uses/go.mk: Default to "." (the current package) instead of PORTNAME.
Sun, Jun 30, 9:34 PM

Wed, Jun 26

dg_syrec.org added a comment to D20746: Convert all Go ports to USES=go.

Remove unnecessary :no_targets (databases/cockroach, devel/gitlab-shell, sysutils/docker-freebsd)

Wed, Jun 26, 7:58 PM
dg_syrec.org added a comment to D20746: Convert all Go ports to USES=go.

Fix devel/grumpy RUN_DEPENDS; add missed ports:

Wed, Jun 26, 5:14 PM
dg_syrec.org added a comment to D20746: Convert all Go ports to USES=go.

The proposed change is deliberately minimal and only affects _DEPENDS/USES declarations, leaving all build/install targets in place (even if they are now redundant with USES=go).

After this review I hope we can eventually convert every port with custom build/install targets to USES=go

Wed, Jun 26, 1:16 PM
dg_syrec.org added a comment to D20746: Convert all Go ports to USES=go.

Rename build to no_targets, address tobik@ feedback.

Wed, Jun 26, 1:07 PM
dg_syrec.org retitled D20735: Mk/Uses/go.mk: Add no_targets and run args from Mk/Uses/go.mk: Add `build` and `run` args to Mk/Uses/go.mk: Add no_targets and run args.
Wed, Jun 26, 1:02 PM
dg_syrec.org added a comment to D20735: Mk/Uses/go.mk: Add no_targets and run args.

Rename build to no_targets.

Wed, Jun 26, 1:00 PM
dg_syrec.org retitled D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable from The porter's handbook Go chapter: document build/run args and GO_PORT variable to The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.
Wed, Jun 26, 12:31 PM
dg_syrec.org added a comment to D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.

Update based on mat@ comments.

Wed, Jun 26, 12:29 PM

Tue, Jun 25

dg_syrec.org added a comment to D20735: Mk/Uses/go.mk: Add no_targets and run args.

Another option is :env. imake.mk and pear.mk use it as an arg to not define targets.

Tue, Jun 25, 5:10 PM
dg_syrec.org added a comment to D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.

should not -> must not

Tue, Jun 25, 3:11 PM
dg_syrec.org added a comment to D20735: Mk/Uses/go.mk: Add no_targets and run args.
In D20735#448830, @mat wrote:

Also, I think :build is badly named, I would think it means "build with go" or as there is a "run" argument "do the same as run but at build-time, probably something to do with dependencies". But what it does is completely different than any other USES's :build argument, it removes targets, it should probably be named no_build or no_targets or dep_only.

Tue, Jun 25, 3:06 PM
dg_syrec.org added a comment to D20735: Mk/Uses/go.mk: Add no_targets and run args.
In D20735#448830, @mat wrote:

Is there any port that would USES=go:run ? Because there is none in the other review, and we really do not like to add code that is never used.

Tue, Jun 25, 3:02 PM
dg_syrec.org added a comment to D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.

Address tobik@ feedback.

Tue, Jun 25, 12:49 PM

Mon, Jun 24

dg_syrec.org added reviewers for D20746: Convert all Go ports to USES=go: portmgr, mat, swills, jlaffaye, tobik.
Mon, Jun 24, 5:52 PM
dg_syrec.org created D20746: Convert all Go ports to USES=go.
Mon, Jun 24, 5:51 PM
dg_syrec.org added reviewers for D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable: tobik, swills, jlaffaye.
Mon, Jun 24, 4:22 PM
dg_syrec.org created D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.
Mon, Jun 24, 4:21 PM
dg_syrec.org added reviewers for D20735: Mk/Uses/go.mk: Add no_targets and run args: mat, swills, jlaffaye, tobik.
Mon, Jun 24, 4:16 PM
dg_syrec.org created D20735: Mk/Uses/go.mk: Add no_targets and run args.
Mon, Jun 24, 4:15 PM

Jun 11 2019

dg_syrec.org retitled D20570: Mk/Uses/go.mk: Allow Go port selection with GO_PORT from Mk/bsd.default-versions.mk, Mk/Uses/go.mk: Add GO_DEFAULT version selection to Mk/Uses/go.mk: Allow Go port selection with GO_PORT.
Jun 11 2019, 12:32 PM
dg_syrec.org updated the diff for D20570: Mk/Uses/go.mk: Allow Go port selection with GO_PORT.

Do not set DEFAULT_VERSION to prevent users breaking their systems by setting go=go14,
add simple Go port selection with GO_PORT instead.

Jun 11 2019, 12:29 PM

Jun 10 2019

dg_syrec.org added a comment to D20570: Mk/Uses/go.mk: Allow Go port selection with GO_PORT.
In D20570#444928, @mat wrote:

Well, DEFAULT_VERSIONS is a user facing variable something users can set to choose the version they want to use. I have a feeling this is only for testing purposes, so it would probably be better to patch your local installation. Otherwise, people would end up setting go=go14 and complain things break.

Jun 10 2019, 1:31 PM

Jun 9 2019

dg_syrec.org added a comment to D20570: Mk/Uses/go.mk: Allow Go port selection with GO_PORT.

~120 ports unfortunately do not use USES=go and declare a build dependency on lang/go themselves. They should be updated to use GO_DEFAULT too.

Jun 9 2019, 5:33 PM
dg_syrec.org added reviewers for D20570: Mk/Uses/go.mk: Allow Go port selection with GO_PORT: mat, jlaffaye, swills, tobik.
Jun 9 2019, 2:52 PM
dg_syrec.org created D20570: Mk/Uses/go.mk: Allow Go port selection with GO_PORT.
Jun 9 2019, 2:51 PM

Apr 14 2019

dg_syrec.org added a comment to D19892: Mk/Uses/go.mk: Better ARM support.

LGTM, but do we know the reason why CGO is not enabled on arm by default by upstream ?

Apr 14 2019, 12:24 PM

Apr 12 2019

dg_syrec.org added a reviewer for D19892: Mk/Uses/go.mk: Better ARM support: tobik.
Apr 12 2019, 9:57 PM
dg_syrec.org added reviewers for D19892: Mk/Uses/go.mk: Better ARM support: jlaffaye, swills.
Apr 12 2019, 8:17 PM
dg_syrec.org created D19892: Mk/Uses/go.mk: Better ARM support.
Apr 12 2019, 8:16 PM

Apr 3 2019

dg_syrec.org added inline comments to D19812: Update USES=go docs for D19570.
Apr 3 2019, 3:45 PM
dg_syrec.org added reviewers for D19813: Update "Go Libraries" for D19570: swills, jlaffaye, tobik, 0mp.
Apr 3 2019, 2:20 PM
dg_syrec.org created D19813: Update "Go Libraries" for D19570.
Apr 3 2019, 2:19 PM
dg_syrec.org retitled D19812: Update USES=go docs for D19570 from Update USES=go docs for D19570 - Add modules argument description - Describe how GO_PKGNAME works in modules mode; add note about GO_PKGNAME/GH_SUBDIR relationship - Document GO_BUILDFLAGS to Update USES=go docs for D19570.
Apr 3 2019, 2:17 PM
dg_syrec.org created D19812: Update USES=go docs for D19570.
Apr 3 2019, 2:15 PM

Apr 2 2019

dg_syrec.org updated the diff for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.

Update file comments: add a short ARGS description; describe how variables work in modules mode; add a note about GO_PKGNAME/GH_SUBDIR relationship.

Apr 2 2019, 9:33 PM
dg_syrec.org added a comment to D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.

@tobik Thank you for the commits Tobias. mail/mailhog is unrelated to this review I added by mistake along with other build failures.

Apr 2 2019, 9:29 PM
dg_syrec.org added a reviewer for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support: mat.
Apr 2 2019, 7:45 PM
dg_syrec.org added a reviewer for D19803: Unbreak build with D19570: iscandr_gmail.com.
Apr 2 2019, 7:44 PM
dg_syrec.org added a reviewer for D19802: Unbreak build with D19570: iscandr_gmail.com.
Apr 2 2019, 7:43 PM
dg_syrec.org created D19803: Unbreak build with D19570.
Apr 2 2019, 7:42 PM
dg_syrec.org created D19802: Unbreak build with D19570.
Apr 2 2019, 7:40 PM
dg_syrec.org abandoned D19791: Unbreak build with D19570.

Thanks!

Apr 2 2019, 6:46 PM
dg_syrec.org added a reviewer for D19794: Unbreak build with D19570: ben.lavery_hashbang0.com.
Apr 2 2019, 1:29 PM
dg_syrec.org added a reviewer for D19795: Unbreak build with D19570: jhixson.
Apr 2 2019, 1:28 PM
dg_syrec.org added a reviewer for D19796: Unbreak build with D19570: sunpoet.
Apr 2 2019, 1:28 PM
dg_syrec.org added a comment to D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.

Build failures and fixes with ports r497574:

Apr 2 2019, 1:27 PM
dg_syrec.org created D19796: Unbreak build with D19570.
Apr 2 2019, 1:26 PM
dg_syrec.org created D19795: Unbreak build with D19570.
Apr 2 2019, 1:25 PM
dg_syrec.org created D19794: Unbreak build with D19570.
Apr 2 2019, 1:24 PM
dg_syrec.org created D19793: Unbreak build with D19570.
Apr 2 2019, 1:22 PM
dg_syrec.org created D19792: Unbreak build with D19570.
Apr 2 2019, 1:20 PM
dg_syrec.org added a reviewer for D19791: Unbreak build with D19570: danilo.
Apr 2 2019, 1:19 PM
dg_syrec.org created D19791: Unbreak build with D19570.
Apr 2 2019, 1:18 PM
dg_syrec.org added a reviewer for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support: tobik.
Apr 2 2019, 1:01 PM

Mar 30 2019

dg_syrec.org updated the diff for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.
  • Do not undef GH_SUBDIR
  • Put back GO_WRKDIR_BIN and GO_WRKDIR_SRC, they are used by many ports in build and install targets
  • Do not silence build
Mar 30 2019, 10:57 PM

Mar 27 2019

dg_syrec.org added inline comments to D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.
Mar 27 2019, 12:20 PM
dg_syrec.org added inline comments to D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.
Mar 27 2019, 12:18 PM
dg_syrec.org updated the diff for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.

Use PREFIX instead of LOCALBASE in do-install.

Mar 27 2019, 12:17 PM

Mar 26 2019

dg_syrec.org added a reviewer for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support: swills.
Mar 26 2019, 9:01 PM
dg_syrec.org updated the diff for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.

Make go.mk work with either GO_PKGNAME/GH_SUBDIR or both.

Mar 26 2019, 8:59 PM

Mar 14 2019

dg_syrec.org updated the summary of D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.
Mar 14 2019, 12:27 PM
dg_syrec.org removed a reviewer for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support: O5: Ports Framework. dg_syrec.org removed 1 blocking reviewer(s) for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support: portmgr.
Mar 14 2019, 12:25 PM

Mar 13 2019

dg_syrec.org added a reviewer for D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support: jlaffaye.
Mar 13 2019, 1:49 PM
dg_syrec.org created D19570: Mk/Uses/go.mk: Remove support for installing Go libs and sources; add initial modules support.
Mar 13 2019, 1:48 PM
dg_syrec.org added a comment to D19568: Deprecate Go library ports.

www/unit-go (osa@) probably should be deprecated too.

Mar 13 2019, 1:01 PM

Feb 20 2019

dg_syrec.org updated the diff for D19241: [new port] net/google-cloud-sdk-app-engine-go: Google Cloud SDK App Engine Go Extensions.

Add find-new-version target.

Feb 20 2019, 6:24 PM

Feb 19 2019

dg_syrec.org updated the diff for D19241: [new port] net/google-cloud-sdk-app-engine-go: Google Cloud SDK App Engine Go Extensions.

Remove stray GO386 evironment var

Feb 19 2019, 1:54 PM
dg_syrec.org updated the diff for D19241: [new port] net/google-cloud-sdk-app-engine-go: Google Cloud SDK App Engine Go Extensions.

Update DISTVERSION

Feb 19 2019, 2:31 AM
dg_syrec.org added a reviewer for D19241: [new port] net/google-cloud-sdk-app-engine-go: Google Cloud SDK App Engine Go Extensions: swills.
Feb 19 2019, 1:45 AM
dg_syrec.org updated the summary of D19241: [new port] net/google-cloud-sdk-app-engine-go: Google Cloud SDK App Engine Go Extensions.
Feb 19 2019, 1:26 AM
dg_syrec.org created D19241: [new port] net/google-cloud-sdk-app-engine-go: Google Cloud SDK App Engine Go Extensions.
Feb 19 2019, 12:37 AM

Oct 20 2018

dg_syrec.org accepted D17627: misc/nnn: Update to 2.0.
Oct 20 2018, 10:56 PM

Aug 20 2018

dg_syrec.org added a comment to D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.

After further discussion, port option seems like a best solution. Closing, sorry for the noise.

Aug 20 2018, 1:22 PM
dg_syrec.org added reviewers for D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support: eugen_grosbein.net, jlaffaye.
Aug 20 2018, 12:55 PM
dg_syrec.org updated the diff for D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.

Scope flavors to i386 arch.

Aug 20 2018, 12:53 PM
dg_syrec.org added a comment to D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.
In D16789#357744, @mat wrote:

The flavor does not make much sense.
First because it is only needed for i386 processors before pentium 4, so it only concerns on i386 architecture, so having a flavor on all other archs is bogus.

Aug 20 2018, 12:21 PM

Aug 18 2018

dg_syrec.org added a comment to D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.

The issue with SSE2 here is not related to C compiler flags or build environment. lang/go is self-hosting and doesn't use C compiler during build.

Aug 18 2018, 5:39 PM
dg_syrec.org retitled D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support from Flavorize; add -nosse2 flavor for older CPUs lacking SSE2 support to lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.
Aug 18 2018, 5:08 PM
dg_syrec.org updated the diff for D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.

lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support

Aug 18 2018, 5:07 PM
dg_syrec.org created D16789: lang/go: flavorize; add -nosse2 flavor for older i386 CPUs lacking SSE2 support.
Aug 18 2018, 2:09 PM

Jul 25 2018

dg_syrec.org created D16441: Expand initial GL_SUBDIR value so GL_ACCOUNT and GL_PROJECT can be safely used in it.
Jul 25 2018, 5:13 PM

Jul 24 2018

dg_syrec.org updated the diff for D16411: Update to 0.31, switch to the original torproject.org upstream, remove dependency on packaged Go libs.

Remove group for the default distfile, remove DISTNAMES.

Jul 24 2018, 1:30 PM

Jul 23 2018

dg_syrec.org created D16411: Update to 0.31, switch to the original torproject.org upstream, remove dependency on packaged Go libs.
Jul 23 2018, 10:21 PM

Jul 21 2018

dg_syrec.org added inline comments to D16384: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229928 Need portmgr@ approval for flavors..
Jul 21 2018, 9:41 PM

Feb 17 2018

dg_syrec.org added inline comments to D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.
Feb 17 2018, 4:37 AM

Feb 12 2018

dg_syrec.org added inline comments to D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.
Feb 12 2018, 10:19 PM
dg_syrec.org added inline comments to D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.
Feb 12 2018, 9:55 PM
dg_syrec.org updated the diff for D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.

Address review feedback.

Feb 12 2018, 9:45 PM
dg_syrec.org updated the diff for D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.

Simplify GOARCH and GO386 options.

Feb 12 2018, 3:34 PM
dg_syrec.org added inline comments to D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.
Feb 12 2018, 2:14 PM

Feb 11 2018

dg_syrec.org created D14321: New port: www/go-appengine-sdk: App Engine SDK for Go.
Feb 11 2018, 3:12 PM

Jan 15 2018

dg_syrec.org added inline comments to D13900: x11/wmutils-core: Set of window manipulation tools.
Jan 15 2018, 3:06 PM
dg_syrec.org updated the diff for D13900: x11/wmutils-core: Set of window manipulation tools.

Fix CONFLICTS.

Jan 15 2018, 3:05 PM

Jan 13 2018

dg_syrec.org created D13901: x11/wmutils-opt: Optional addons to wmutils.
Jan 13 2018, 4:48 PM
dg_syrec.org created D13900: x11/wmutils-core: Set of window manipulation tools.
Jan 13 2018, 4:46 PM