- User Since
- Jan 12 2018, 3:33 PM (57 w, 2 d)
This might be a dumb question, but does the process title change often enough that setproctitle_fast() added in rS335939 should be used?
Sun, Jan 27
Found two things which may need some TLC.
Jan 2 2019
Noticed only one thing, otherwise it looks good to me.
Dec 21 2018
Looks good to me.
Looks Good To Me!
Dec 20 2018
I had to double-check i.e vs. eg., and found that it scans, so it looks good to me.
Dec 11 2018
Nov 9 2018
Supply a patch that (should) work.
Turns out this revision didn't work, will update with a new diff that fixes it once I get the OK for the change.
They do, thank you. :)
Oct 29 2018
Applied the changes from rene@ after satisfying myself I understand why they were made.
Added entities properly, sorted alphabetically
Added forward slash on last variablelist tag.
I'm really not sure what I'm supposed to do about these entries (nor am I even sure where to add them), because upstream (linux drm/kms stack) doesn't seem to provide these man-pages and I'm not at all capable of writing them.
Oct 28 2018
Looks Good To Me!
Corrected which drivers work for what cards.
Oct 27 2018
Added amdgpu, and explain that radeonkms and amdgpu are in general used for older and newer graphcs respectively.
Oct 25 2018
Added missing semicolon.
Oct 24 2018
Fixed issues pointed out by bcr@
Remove exteneous article.
Avoid weasel words, in accordance with the documentation primer.
Oct 12 2018
For posterity's sake, the context of this review is a conversation on Twitter regarding the state of xattr/EA in FreeBSD for ZFS, with a special eye to multi-labels.
Oct 4 2018
Did you think about getting some reviewers attached for this, as well as fixing the various errors?
The reason I ask is because it doesn't seem like a bad change, but if it's going to go into the tree there's typically some sort of review process.
I shan't comment on it on the change itself, but have you considered getting some reviewers attached to this?
Changes to FreeBSD typically don't land automatically, and there usually has to be at least some sort of review process.