Page MenuHomeFreeBSD

chengc_netapp.com (Cheng Cui)
Research

Projects

User Details

User Since
Nov 23 2015, 12:29 AM (290 w, 4 d)

Recent Activity

Wed, May 26

chengc_netapp.com accepted D30470: tcp: Use local CC data only in correct context.

Looks good to me. Thanks for picking this up! :)

Wed, May 26, 2:58 PM

Feb 3 2021

chengc_netapp.com added a comment to D26807: move cwnd and ssthresh updates into individual congestion control module.

The above discussion about tcp_maxseg() has been closed in the subjected email thread: https://lists.freebsd.org/pipermail/freebsd-transport/2020-November/000355.html
No further action needed.

Feb 3 2021, 2:45 PM

Nov 19 2020

chengc_netapp.com added a comment to D27275: Create new CC module to track cubic RFC 8312bis changes.

Is the rfc8312bis draft publicly available? Where can I find it?

Nov 19 2020, 4:18 PM

Oct 15 2020

chengc_netapp.com requested review of D26808: TCP Cubic: improve reaction to (and rollback from) RTO.
Oct 15 2020, 8:54 PM
chengc_netapp.com requested review of D26807: move cwnd and ssthresh updates into individual congestion control module.
Oct 15 2020, 8:42 PM

Oct 8 2020

chengc_netapp.com requested changes to D26446: Stop sending tiny new data segments during SACK recovery.
Oct 8 2020, 3:13 PM

Aug 27 2020

chengc_netapp.com accepted D26181: cc_mod: remove unused CCF_DELACK definition.
Aug 27 2020, 1:29 PM

Aug 18 2020

chengc_netapp.com accepted D26060: TCP Cubic: Recalculate cubic cwnd for every ack..

Looks good. Thanks for picking this up.

Aug 18 2020, 7:05 PM
chengc_netapp.com added inline comments to D26060: TCP Cubic: Recalculate cubic cwnd for every ack..
Aug 18 2020, 6:51 PM
chengc_netapp.com added a comment to D26060: TCP Cubic: Recalculate cubic cwnd for every ack..

Verified this patch here:
https://github.com/ccui1000/freebsd-tcp/wiki/test-D26060

Aug 18 2020, 3:40 PM

Aug 14 2020

chengc_netapp.com requested changes to D26060: TCP Cubic: Recalculate cubic cwnd for every ack..
Aug 14 2020, 1:49 PM

Aug 7 2020

chengc_netapp.com accepted D25746: Address unintended jump of calculated cwnd when leaving slowstart.

Looks good. Thanks for picking this up.

Aug 7 2020, 1:58 PM

Jul 30 2020

chengc_netapp.com requested changes to D25746: Address unintended jump of calculated cwnd when leaving slowstart.

Tested with my results: https://github.com/ccui1000/freebsd-tcp/wiki/test-D25746

Jul 30 2020, 2:36 PM

Jul 20 2020

chengc_netapp.com accepted D25744: Add MODULE_VERSION to TCP loadable congestion control modules..
Jul 20 2020, 5:01 PM

Jul 7 2020

chengc_netapp.com added a member for transport: chengc_netapp.com.
Jul 7 2020, 1:54 PM

Jun 5 2020

chengc_netapp.com accepted D25065: Start cubic epoch after having been app-limited..

Good discovery. Thanks.

Jun 5 2020, 7:00 PM
chengc_netapp.com accepted D25133: Fix cubic RTO reaction.
Jun 5 2020, 4:28 PM
chengc_netapp.com accepted D23655: Cubic: prevent abrupt cwnd jumps after slow start.

I think this has a higher priority than D25133.

Jun 5 2020, 4:26 PM

May 12 2020

chengc_netapp.com accepted D24817: DCTCP: update alpha only once after loss recovery..

Looks good. Thanks for picking this up.

May 12 2020, 6:49 PM

Apr 21 2020

chengc_netapp.com accepted D24515: Prevent premature zeroing of a scaled receiver window.

Looks good. Thanks.

Apr 21 2020, 6:32 PM

Feb 24 2020

chengc_netapp.com added inline comments to D23353: ECN and CUBIC do not play well together in very congested networks.
Feb 24 2020, 6:33 PM

Feb 19 2020

chengc_netapp.com accepted D22438: Improve NewReno after_idle ssthresh per RFC2861 Sec.2.
Feb 19 2020, 6:40 PM

Feb 14 2020

chengc_netapp.com accepted D23687: Fix sporadic odd MSS values when TCP HostCache is not in use.

Even better. Tested on my side. Looks good.

Feb 14 2020, 9:05 PM
chengc_netapp.com accepted D23687: Fix sporadic odd MSS values when TCP HostCache is not in use.
Feb 14 2020, 3:24 PM

Jan 27 2020

chengc_netapp.com requested changes to D23160: Fixing RTO timer during SACK loss recovery.

Looks the persistent timer may be still alive. Suggest revise this change.

Jan 27 2020, 9:18 PM

Jan 21 2020

chengc_netapp.com accepted D23160: Fixing RTO timer during SACK loss recovery.

Tested in both bsd11 and bsd12. Without this fix, I can find a 2nd retransmission triggered by the persistent timer, not the RTO timer. But this means the persistent timer is still alive. Suggest revise this change.

Jan 21 2020, 8:21 PM
chengc_netapp.com accepted D23119: Send CWR whenever a ECN-enabled session runs into RTO.

Did not find any problem in bsd11.

Jan 21 2020, 7:21 PM
chengc_netapp.com accepted D23118: Fix IP ECN codepoint for SACK retransmissions (RFC3168).

Did not find any problem in bsd11.

Jan 21 2020, 7:18 PM
chengc_netapp.com accepted D22670: Send immediate ACK on receipt of CWR.

Did not find any problem.

Jan 21 2020, 7:16 PM

Jan 17 2020

chengc_netapp.com added a comment to D22670: Send immediate ACK on receipt of CWR.

I am testing this patch now. Will update from my side in one or two days.

Jan 17 2020, 2:12 PM

Dec 30 2019

chengc_netapp.com added a comment to D22644: Fix the CE reflector receiver state machine in DCTCP.

Also, you can remove the CCF_DELACK definition from cc.h.

Dec 30 2019, 5:04 PM

Dec 29 2019

chengc_netapp.com accepted D22644: Fix the CE reflector receiver state machine in DCTCP.
Dec 29 2019, 5:08 PM

Nov 18 2019

chengc_netapp.com accepted D22438: Improve NewReno after_idle ssthresh per RFC2861 Sec.2.
Nov 18 2019, 7:10 PM
chengc_netapp.com accepted D21798: Restrict cwnd growth on app-limited flows.
Nov 18 2019, 7:07 PM

Oct 25 2019

chengc_netapp.com requested changes to D21798: Restrict cwnd growth on app-limited flows.
Oct 25 2019, 2:47 PM

Aug 27 2019

chengc_netapp.com added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Aug 27 2019, 2:51 PM

Aug 20 2019

chengc_netapp.com added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Aug 20 2019, 4:01 PM

Aug 7 2019

chengc_netapp.com added inline comments to D19047: TCP Dynamic Burst Limit.
Aug 7 2019, 6:52 PM
chengc_netapp.com added a comment to D19047: TCP Dynamic Burst Limit.

I believe rS87145 was submitted because of some unexpected DelayedACK
implementation, or it might be just the DelayedACK was expecting two full MSS
(instead of two segments that updated later) in FreeBSD 4.2/4.3 in 2001.

Aug 7 2019, 2:36 PM

Jul 26 2019

chengc_netapp.com added a comment to D19118: Add Boundary and Overflow checks in Cubic formulas.

I prefer D18982 to be submitted. If D18982 is submitted, we don't need this patch as D18982 covers everything here.

Jul 26 2019, 3:06 PM

Jun 11 2019

chengc_netapp.com requested changes to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Jun 11 2019, 9:07 PM

Mar 25 2019

chengc_netapp.com accepted D18954: Implement Cubic-specific After-Idle reaction.

Looks good to me. Will let @lstewart make the final decision.

Mar 25 2019, 8:30 PM

Feb 5 2019

chengc_netapp.com added inline comments to D18954: Implement Cubic-specific After-Idle reaction.
Feb 5 2019, 8:16 PM

Jan 31 2019

chengc_netapp.com accepted D17614: RFC6582 - prevent cwnd to collapse down to 1 mss after exiting recovery.

Looks good. I think Richard can update more that we recently tested this patch.

Jan 31 2019, 4:59 PM · transport

Jan 29 2019

chengc_netapp.com accepted D18897: Add a simple port filter to SIFTR.

Looks good. Thanks.

Jan 29 2019, 9:11 PM

Jan 28 2019

chengc_netapp.com added inline comments to D18897: Add a simple port filter to SIFTR.
Jan 28 2019, 2:37 PM

Jan 25 2019

chengc_netapp.com added inline comments to D18954: Implement Cubic-specific After-Idle reaction.
Jan 25 2019, 3:30 PM

Jan 18 2019

chengc_netapp.com accepted D18885: Make SIFTR work again.

Looks good to me. If the summary can also be updated to represent the new context, that will be better. Thanks.

Jan 18 2019, 8:15 PM
chengc_netapp.com added inline comments to D18885: Make SIFTR work again.
Jan 18 2019, 2:17 PM

Jan 15 2019

chengc_netapp.com added a comment to D17614: RFC6582 - prevent cwnd to collapse down to 1 mss after exiting recovery.

I have been testing this patch against a stable/11 build. Over a 1Gb/s link with emulated 40ms RTT and (10^-4) loss rate, I use iperf from a FreeBSD node to send traffic to a 4.15.0-39-generic Ubuntu16.04 client.

Jan 15 2019, 8:54 PM · transport

Jan 2 2019

chengc_netapp.com updated chengc_netapp.com.
Jan 2 2019, 3:14 PM
chengc_netapp.com added a comment to D17614: RFC6582 - prevent cwnd to collapse down to 1 mss after exiting recovery.

Thanks for the review request.
I will test this patch in Emulab.net before I give more feedback.

Jan 2 2019, 3:04 PM · transport