Page MenuHomeFreeBSD

c.koehne_beckhoff.com (Corvin Köhne)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2020, 6:07 AM (89 w, 3 d)

Recent Activity

Tue, May 3

c.koehne_beckhoff.com requested review of D35114: bsdinstall/script: umount before zpool export.
Tue, May 3, 5:56 AM
c.koehne_beckhoff.com requested review of D35113: bsdinstall: stop messing with file descriptors.
Tue, May 3, 5:55 AM

Apr 14 2022

c.koehne_beckhoff.com updated the diff for D33010: bhyve: use handlers for cfg reads/writes of passthru devices.
Apr 14 2022, 7:37 AM · bhyve

Apr 13 2022

c.koehne_beckhoff.com updated the summary of D33767: bhyve: add helper struct for ACPI device handling.
Apr 13 2022, 1:41 PM · bhyve
c.koehne_beckhoff.com requested review of D34897: bhyve: add support for qemu's ACPI table loader.
Apr 13 2022, 9:55 AM · bhyve
c.koehne_beckhoff.com updated the summary of D31578: bhyve: add support for QEMU's fwcfg.
Apr 13 2022, 9:28 AM · bhyve
c.koehne_beckhoff.com updated the diff for D31578: bhyve: add support for QEMU's fwcfg.
  • Rebase on 14.0-CURRENT
  • Add new cmdline option to add fwcfg files specified by the user
Apr 13 2022, 9:27 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33767: bhyve: add helper struct for ACPI device handling.
  • Rebase on 14.0-CURRENT
Apr 13 2022, 7:57 AM · bhyve

Apr 7 2022

c.koehne_beckhoff.com added a comment to D26209: GVT-d support for bhyve.

I got a intel Xe DG1 dedicated graphics adapter. I will try it later.

Apr 7 2022, 5:36 AM · bhyve

Apr 1 2022

c.koehne_beckhoff.com added inline comments to D34688: bhyve: avoid uninitialized variable.
Apr 1 2022, 5:14 AM · bhyve
c.koehne_beckhoff.com updated the diff for D34688: bhyve: avoid uninitialized variable.
  • don't set addr = 0 in case block
Apr 1 2022, 5:14 AM · bhyve

Mar 28 2022

c.koehne_beckhoff.com added a comment to D34465: bhyve: use bhyve_config for SMBIOS strings.

In illumos, it is split up into two phases, one that parses and one that does the smbios build. This means that the keys and values show up with -o config.dump=1, which I think is useful as it provides a template for editing.
Have you considered doing something like that here?

Mar 28 2022, 9:35 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33129: bhyve: add ROM emulation.
Mar 28 2022, 9:09 AM · bhyve
c.koehne_beckhoff.com requested review of D34689: bhyve: avoid overflow of BAR index.
Mar 28 2022, 9:08 AM · bhyve
c.koehne_beckhoff.com requested review of D34688: bhyve: avoid uninitialized variable.
Mar 28 2022, 9:03 AM · bhyve

Mar 18 2022

c.koehne_beckhoff.com requested review of D34600: bhyve: avoid an empty passthru config value.
Mar 18 2022, 9:28 AM · bhyve

Mar 14 2022

c.koehne_beckhoff.com updated the diff for D28280: bhyve: set lpc IDs to physical values.
  • Rebase on 14.0-CURRENT
Mar 14 2022, 2:15 PM · bhyve
c.koehne_beckhoff.com updated the diff for D34465: bhyve: use bhyve_config for SMBIOS strings.
  • make processor and memdevice strings unconfigurable
Mar 14 2022, 9:32 AM · bhyve

Mar 11 2022

c.koehne_beckhoff.com added a comment to D34465: bhyve: use bhyve_config for SMBIOS strings.

I've mainly decided to make all values configurable to avoid a special handling for single values. Additionally, I don't know if just serial_number makes sense. There's system.serial_number, board.serial_number, chassis.serial_number, ... What about using " " for unmodifiable nodes? e.g.

struct smbios_string smbios_type1_strings[] = {
	{ " ", "FreeBSD" },			/* manufacturer string */
	{ " ", "BHYVE" },			/* product string */
	{ " ", "1.0" },				/* version string */
	{ "system.serial_number", "None" },	/* serial number string */
	{ " ", "None" },			/* sku string */
	{ " ", "Virtual Machine" },		/* family string */
	{ 0 }
};
Mar 11 2022, 11:56 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33129: bhyve: add ROM emulation.
Mar 11 2022, 11:38 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33129: bhyve: add ROM emulation.
Mar 11 2022, 11:33 AM · bhyve

Mar 9 2022

c.koehne_beckhoff.com updated the diff for D34465: bhyve: use bhyve_config for SMBIOS strings.
  • keep old variable names to make the diff smaller
Mar 9 2022, 9:58 AM · bhyve
c.koehne_beckhoff.com requested review of D34506: bhyve/usage: memory size is not in MB.
Mar 9 2022, 7:31 AM · bhyve

Mar 7 2022

c.koehne_beckhoff.com requested review of D34465: bhyve: use bhyve_config for SMBIOS strings.
Mar 7 2022, 8:52 AM · bhyve

Mar 4 2022

c.koehne_beckhoff.com added a comment to D33766: OVMF: add support for QemuFwCfg.

I'm going to send this patch to EDKII next week if no one complains.

Mar 4 2022, 12:59 PM · bhyve
c.koehne_beckhoff.com updated the summary of D31578: bhyve: add support for QEMU's fwcfg.
Mar 4 2022, 12:56 PM · bhyve
c.koehne_beckhoff.com updated the diff for D31578: bhyve: add support for QEMU's fwcfg.
  • Rebase on 14.0-CURRENT
Mar 4 2022, 12:54 PM · bhyve
c.koehne_beckhoff.com updated the diff for D33767: bhyve: add helper struct for ACPI device handling.
  • Rebase on 14.0-CURRENT
Mar 4 2022, 12:49 PM · bhyve
c.koehne_beckhoff.com abandoned D27456: bhyve: GPU Passthrough for dedicated AMD GPUs.

GPU passthrough for deciated AMD GPUs will be enabled by D33129.

Mar 4 2022, 11:54 AM · bhyve
c.koehne_beckhoff.com added a comment to D33129: bhyve: add ROM emulation.

This patch is ready to be merged. Any comments on it?

Mar 4 2022, 11:52 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33129: bhyve: add ROM emulation.
  • Rebase on 14.0-CURRENT
Mar 4 2022, 11:51 AM · bhyve
c.koehne_beckhoff.com added a comment to D33769: bhyve: export funcs for read/write pci config.

Can this be merged?

Mar 4 2022, 7:38 AM · bhyve

Feb 16 2022

c.koehne_beckhoff.com added inline comments to D34301: bhyve: memory leak in topology_parse().
Feb 16 2022, 3:28 PM

Jan 28 2022

c.koehne_beckhoff.com added inline comments to D33433: bhyve: add varfile option to nvlist of lpc device.
Jan 28 2022, 6:38 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33433: bhyve: add varfile option to nvlist of lpc device.
  • do not leak varfd in bootrom_loadrom
Jan 28 2022, 6:37 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33433: bhyve: add varfile option to nvlist of lpc device.
  • check if lpc.bootrom exists before calling bootrom_loadrom
Jan 28 2022, 6:29 AM · bhyve

Jan 27 2022

c.koehne_beckhoff.com added inline comments to D33433: bhyve: add varfile option to nvlist of lpc device.
Jan 27 2022, 10:11 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33433: bhyve: add varfile option to nvlist of lpc device.
  • rebase on main
  • check for romfile/varfile == NULL
Jan 27 2022, 10:10 AM · bhyve
c.koehne_beckhoff.com added inline comments to D28280: bhyve: set lpc IDs to physical values.
Jan 27 2022, 9:37 AM · bhyve
c.koehne_beckhoff.com updated the diff for D28280: bhyve: set lpc IDs to physical values.
  • rebase on main
  • start sentences on new line in bhyve_config
  • check lpc class and subclass
Jan 27 2022, 9:32 AM · bhyve

Jan 14 2022

c.koehne_beckhoff.com added a reviewer for D33770: bhyve: add nvlist functions for setting unset nodes: manu.
Jan 14 2022, 7:55 AM · bhyve

Jan 12 2022

c.koehne_beckhoff.com added inline comments to D33433: bhyve: add varfile option to nvlist of lpc device.
Jan 12 2022, 11:41 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33433: bhyve: add varfile option to nvlist of lpc device.
  • check if lpc.bootrom is NULL before strdup it
Jan 12 2022, 11:41 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33433: bhyve: add varfile option to nvlist of lpc device.
  • do not strdup varfile
  • remove const from romfile
Jan 12 2022, 7:41 AM · bhyve

Jan 11 2022

c.koehne_beckhoff.com added inline comments to D33129: bhyve: add ROM emulation.
Jan 11 2022, 4:14 PM · bhyve
c.koehne_beckhoff.com updated the diff for D33129: bhyve: add ROM emulation.
  • rebase on 14.0-CURRENT
  • add bhyve_config entry
  • fail hard if mapping the ROM fails
Jan 11 2022, 4:12 PM · bhyve

Jan 7 2022

c.koehne_beckhoff.com added inline comments to D33129: bhyve: add ROM emulation.
Jan 7 2022, 8:44 AM · bhyve
c.koehne_beckhoff.com added a comment to D33433: bhyve: add varfile option to nvlist of lpc device.

@jhb @markj Any suggestions on which config nodes to use for romfile and varsfile? D31578 depends on that decision.

Jan 7 2022, 6:37 AM · bhyve

Jan 6 2022

c.koehne_beckhoff.com updated the diff for D33770: bhyve: add nvlist functions for setting unset nodes.
  • fix style
Jan 6 2022, 2:22 PM · bhyve
c.koehne_beckhoff.com updated the summary of D33770: bhyve: add nvlist functions for setting unset nodes.
Jan 6 2022, 2:18 PM · bhyve
c.koehne_beckhoff.com requested review of D33770: bhyve: add nvlist functions for setting unset nodes.
Jan 6 2022, 2:18 PM · bhyve
c.koehne_beckhoff.com requested review of D33769: bhyve: export funcs for read/write pci config.
Jan 6 2022, 2:15 PM · bhyve
c.koehne_beckhoff.com added reviewers for D31578: bhyve: add support for QEMU's fwcfg: jhb, markj.
Jan 6 2022, 10:22 AM · bhyve
c.koehne_beckhoff.com updated the summary of D33767: bhyve: add helper struct for ACPI device handling.
Jan 6 2022, 10:04 AM · bhyve
c.koehne_beckhoff.com requested review of D33767: bhyve: add helper struct for ACPI device handling.
Jan 6 2022, 10:03 AM · bhyve
c.koehne_beckhoff.com updated the diff for D31578: bhyve: add support for QEMU's fwcfg.
Jan 6 2022, 10:01 AM · bhyve
c.koehne_beckhoff.com requested review of D33766: OVMF: add support for QemuFwCfg.
Jan 6 2022, 9:56 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33333: bhyve: add support for MTRR.
Jan 6 2022, 7:12 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33333: bhyve: add support for MTRR.
  • fix type of MTRR offset
  • handle writes to reserved fields
Jan 6 2022, 7:10 AM · bhyve

Jan 5 2022

c.koehne_beckhoff.com updated the summary of D26209: GVT-d support for bhyve.
Jan 5 2022, 10:27 AM · bhyve
c.koehne_beckhoff.com updated the diff for D26209: GVT-d support for bhyve.
  • rebase on CURRENT
Jan 5 2022, 10:19 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33333: bhyve: add support for MTRR.
Jan 5 2022, 9:52 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33333: bhyve: add support for MTRR.
  • add base and mask register for variable ranges
Jan 5 2022, 9:51 AM · bhyve

Jan 3 2022

c.koehne_beckhoff.com added a comment to D33728: bhyve: only init MSI-X table if passthru device supports it.
In D33728#762550, @bz wrote:

Sorry for that breakage and thanks for the fix; do you mind if I commit it straight away so I can MFC the proper version?

Jan 3 2022, 2:14 PM · bhyve
c.koehne_beckhoff.com added a comment to D33628: bhyve: passthru: enable BARs before possibly mmap(2)ing them.

This patch unconditionally calls init_msix_table. This breaks passthru for devices which only support MSI. I created a patch for it D33728

Jan 3 2022, 12:27 PM
c.koehne_beckhoff.com requested review of D33728: bhyve: only init MSI-X table if passthru device supports it.
Jan 3 2022, 12:26 PM · bhyve

Dec 17 2021

c.koehne_beckhoff.com added a comment to D33460: pci: add missing PCI id of Coffee Lake GPU.

I have to detect intel_graphics_stolen_base and intel_graphics_stolen_size for GPU passthrough to work properly (see D26209). Instead of duplicating the code of pci_early_quirks.c, I'm reusing these variables. Since one of my devices has this missing device id, GPU passthrough doesn't work on that device.

Dec 17 2021, 12:53 PM
c.koehne_beckhoff.com added a comment to D33460: pci: add missing PCI id of Coffee Lake GPU.

@kib @bwidawsk @imp I added you as reviewer because I saw you've added the original file.

Dec 17 2021, 9:04 AM
c.koehne_beckhoff.com added reviewers for D33460: pci: add missing PCI id of Coffee Lake GPU: bwidawsk, imp.
Dec 17 2021, 9:02 AM
c.koehne_beckhoff.com added a reviewer for D33460: pci: add missing PCI id of Coffee Lake GPU: kib.
Dec 17 2021, 8:59 AM
c.koehne_beckhoff.com added inline comments to D33496: bhyve: dynamically register FwCtl ports.
Dec 17 2021, 7:51 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33496: bhyve: dynamically register FwCtl ports.
  • use asserts for checking the return code of register_inout
Dec 17 2021, 7:51 AM · bhyve

Dec 16 2021

c.koehne_beckhoff.com added a comment to D33496: bhyve: dynamically register FwCtl ports.

Sorry if I missed it, but is there another diff to add alternate handlers for these I/O ports?

Dec 16 2021, 4:59 PM · bhyve
c.koehne_beckhoff.com requested review of D33496: bhyve: dynamically register FwCtl ports.
Dec 16 2021, 8:26 AM · bhyve
c.koehne_beckhoff.com added a comment to D33433: bhyve: add varfile option to nvlist of lpc device.
In D33433#756746, @jhb wrote:

I would perhaps avoid converting "lpc.bootrom" to a new node and instead leave it as-is for the path to the boot ROM and just add a new "lpc.bootvars" or "lpc.nvram" or some such that holds the path to the vars file.

Dec 16 2021, 7:58 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33433: bhyve: add varfile option to nvlist of lpc device.
  • start every sentence on a new line in manpages
  • do not convert "lpc.bootrom" into a node
  • only query one nvlist variable at the same time
Dec 16 2021, 7:48 AM · bhyve

Dec 15 2021

c.koehne_beckhoff.com updated the summary of D33460: pci: add missing PCI id of Coffee Lake GPU.
Dec 15 2021, 12:37 PM
c.koehne_beckhoff.com updated the summary of D33460: pci: add missing PCI id of Coffee Lake GPU.
Dec 15 2021, 12:26 PM
c.koehne_beckhoff.com requested review of D33460: pci: add missing PCI id of Coffee Lake GPU.
Dec 15 2021, 12:22 PM

Dec 14 2021

c.koehne_beckhoff.com requested review of D33433: bhyve: add varfile option to nvlist of lpc device.
Dec 14 2021, 11:17 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33428: loader: move all gfx_fb.c stubs to common/gfx_fb_stub.c.
Dec 14 2021, 6:21 AM

Dec 8 2021

c.koehne_beckhoff.com updated the summary of D33333: bhyve: add support for MTRR.
Dec 8 2021, 12:06 PM · bhyve
c.koehne_beckhoff.com requested review of D33333: bhyve: add support for MTRR.
Dec 8 2021, 12:01 PM · bhyve
c.koehne_beckhoff.com added inline comments to D33331: bsdinstall: zfsboot: Prompt user for zpool name if the pool already exists.
Dec 8 2021, 11:39 AM

Dec 6 2021

c.koehne_beckhoff.com added inline comments to D19976: bhyve: Support a _VARS.fd file for bootrom.
Dec 6 2021, 7:42 AM

Dec 3 2021

c.koehne_beckhoff.com added inline comments to D19976: bhyve: Support a _VARS.fd file for bootrom.
Dec 3 2021, 1:20 PM
c.koehne_beckhoff.com added a comment to D20623: Deterministically initialize the PCI command register for passthru devices..

This patch should be updated. @jhb I could do it for you if you like to.

Dec 3 2021, 6:46 AM

Dec 2 2021

c.koehne_beckhoff.com updated the diff for D26209: GVT-d support for bhyve.
  • rebase on 14.0-CURRENT
Dec 2 2021, 11:20 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33129: bhyve: add ROM emulation.
  • fix formatting
Dec 2 2021, 10:31 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33129: bhyve: add ROM emulation.

Address feedback

Dec 2 2021, 8:42 AM · bhyve
c.koehne_beckhoff.com added inline comments to D33129: bhyve: add ROM emulation.
Dec 2 2021, 7:39 AM · bhyve

Dec 1 2021

c.koehne_beckhoff.com added inline comments to D32831: bhyve: implement SELF-TEST feature for NVMe controller.
Dec 1 2021, 2:26 PM
c.koehne_beckhoff.com added a comment to D32903: bhyve: implement Timestamp get/set feature for NVMe controller.

Thank you!

The standard about timestamp is very hard to understand. I am not sure I am doing the right thing...

Dec 1 2021, 12:51 PM
c.koehne_beckhoff.com added inline comments to D32903: bhyve: implement Timestamp get/set feature for NVMe controller.
Dec 1 2021, 9:31 AM

Nov 30 2021

c.koehne_beckhoff.com requested review of D33188: bhyve: add ioctl to get acpi resources of an acpi device.
Nov 30 2021, 1:07 PM · bhyve
c.koehne_beckhoff.com added inline comments to D33161: bhyve: add ioctl to modify the second level address translation.
Nov 30 2021, 8:54 AM · bhyve
c.koehne_beckhoff.com updated the diff for D33129: bhyve: add ROM emulation.
  • fix style
  • use fstat to detect romfile size
  • use mmap to read romfile
  • add error checking for passthru_addr_rom
Nov 30 2021, 8:50 AM · bhyve
c.koehne_beckhoff.com added a comment to D33011: bhyve: add ioctl to query infos about special memory regions.

I don't really like this interface. The name is too general and the interface is kind of simplistic, for example because it can only describe a single contiguous memory region and can't refer to different instances of a device. I'm not what a better interface would look like, I haven't yet read more of the patch series. But I think this deserves some more thought.

Nov 30 2021, 7:33 AM · bhyve
c.koehne_beckhoff.com updated the diff for D31981: bhyve: allow reading of fwctl signature multiple times.
Nov 30 2021, 7:13 AM · bhyve
c.koehne_beckhoff.com updated the diff for D28278: bhyve: enumerate BARs by size.

prettify code style

Nov 30 2021, 7:06 AM · bhyve