Page MenuHomeFreeBSD

brett_gutste.in (Brett Gutstein)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 13 2017, 7:35 PM (172 w, 1 d)

Recent Activity

Oct 15 2018

brett_gutste.in added a comment to D17483: Don't import 0 into the quantum cache..

Right, I'll drop that check.

Oct 15 2018, 10:42 AM

Oct 12 2018

brett_gutste.in added a comment to D17483: Don't import 0 into the quantum cache..

Regarding the fallback solution, I believe it is okay to fall back on vmem_xalloc() regardless of whether vmem_alloc() is called with M_WAITOK or M_NOWAIT (i.e. the if statement on line 1299 is not necessary). If vmem_alloc() is called with M_NOWAIT, then the fallback vmem_xalloc() call will also have M_NOWAIT and could also allocate the range starting at 0.

Oct 12 2018, 4:21 PM

Oct 11 2018

brett_gutste.in added a comment to D17483: Don't import 0 into the quantum cache..

As I understand it, there are now two qualitatively different vmem_xalloc() calls that could be made when a user calls vmem_alloc(). The first is the vmem_xalloc() call used in qc_import() to fill the quantum caches when needed, and the change to this call's parameters means that a quantum cache will never contain the range from 0 to QUANTUM_SIZE - 1. The second is called directly by vmem_alloc() if the allocation size exceeds those supported by the quantum caches, and this call could still allocate the range from 0 to QUANTUM_SIZE - 1.

Oct 11 2018, 1:47 PM

Oct 9 2018

brett_gutste.in added a comment to D17483: Don't import 0 into the quantum cache..

I believe this change means that the range from 0 to QUANTUM_SIZE - 1 cannot be allocated by vmem_alloc() when quantum caching is enabled (except as part of an allocation request that is too large to be satisfied by a quantum cache). Should the qc_import comment state this explicitly?

Oct 9 2018, 6:26 PM