User Details
- User Since
- Jan 29 2022, 5:50 PM (97 w, 1 d)
Thu, Nov 30
Address @jhb 's comments.
Wed, Nov 29
Address @markj 's comments:
- multiline comment style fixes
- use old mapping scheme on 32-bit systems
Mon, Nov 27
Address @alc 's comments.
Mon, Nov 13
Upload diff with full context.
Nov 8 2023
Nov 7 2023
Rebased the patch.
Oct 30 2023
Address @corvink 's comments.
Address @corvink 's comments.
Oct 26 2023
Oct 19 2023
Oct 12 2023
LGTM.
Oct 11 2023
Fix formatting for multiline comment in teken_utf8_bytes_to_codepoint.
Address @christos 's comments.
- Add more detailed explanation of the use of __builtin_clz
Other fixes:
- Codepoint calculation for two-byte sequences was missing one bit in the mask used for the leading character, fixed now
- ttydisc_rubchar now falls back to non-UTF8 behaviour if teken_wcwidth returns an error
Oct 10 2023
Oct 7 2023
I've updated the manpages for stty and termios and moved IUTF8 behind __BSD_VISIBLE.
Oct 6 2023
Quick update: I've tested the patch with different numbers of kstack guard pages (1-4) and encountered no issues.
Each run consisted of running the test suite and a rebuild of the whole kernel.
I have, there are no duplicates for 1-4 guard pages.
I also think that duplicates are mathematically impossible in this case, since this function is bijective for each value in its domain.
Its domain, however is not contiguous.
I've whipped up a quick graph for the first few kvas {F68913014}.
Oct 5 2023
Address @christos 's comments - properly handle zero width characters.
Oct 3 2023
Oct 1 2023
@markj I tried the new mlock superpage test case, the patch didn't cause a panic.
I've updated the diff to work with an arbitrary number of guard pages but I didn't have time to test this with different guard page configurations - I'll do this in the coming days and report back.
The formula has been slightly reworked to account for the direction of stack growth (+ 1 to the result of lin_pindex(kva) / kstack_size and different condition for detecting guard pages).
Sep 27 2023
Address @alc 's comments.
Sep 22 2023
Sep 20 2023
Address @alc 's comments.
Address @markj 's comments.
Sep 17 2023
Address @markj 's comments.
Sep 16 2023
Aug 29 2023
Aug 15 2023
Address @alc 's comments.
Aug 8 2023
Address @alc 's comments:
- Defer PTE initialization until demotion
- Rearrange code to simplify error handling
Jul 26 2023
Address @kib 's comments - remove pde pv entry upon leaf ptpage insertion or allocation failure, defer setting PGA_WRITEABLE for constituent pages.
Jul 24 2023
Jul 21 2023
Address @kib 's comment, free pagetable page when insertion fails.
Address @kib 's comments.
Address @markj 's comments/
Jun 27 2023
Jun 21 2023
Handle possible divide-by-zero exception when info.free_blocks is 0.
Jun 16 2023
Jun 14 2023
I've changed the way the db_ctf subsystem registers kernel CTF data - it will now use preload_search_by_type during ddb initialization check if the loader loaded the file containing raw kernel CTF data. I've also added an extra code to copy kernel CTF data info from ddb into linker_kernel_file upon KLD initialization.
I've changed to use the loader for registering kernel CTF data instead of the previous double-linking approach. The idea is that the user can opt-in to loading raw kernel CTF data using loader.conf as follows:
ddb_kctf_load="YES" ddb_kctf_name="/boot/kernel/kctf.raw" ddb_kctf_type="ddb_kctf"
The data gets picked up by ddb during early boot.
The changes to the build files make sure that the merged CTF data is uncompressed and dumped into the kctf.raw file. I am not sure if these changes follow proper procedure for installing non-module files, but I would be glad to rework them if necessary.
May 8 2023
Remove stray whitespace, change commit message to reflect new changes.
May 5 2023
Address @corvink 's comments.
May 3 2023
Mar 16 2023
Address @markj 's comments - per-domain kstack arenas + KVA import size adjustment
Mar 11 2023
Address @markj 's comments, additional kstack object for non-standard kstack sizes.
Mar 3 2023
Move changes to vm_glue.c.