Page MenuHomeFreeBSD

alfix86_gmail.com (Alfonso Siciliano)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2018, 3:44 AM (134 w, 4 d)

Recent Activity

Sun, Nov 1

alfix86_gmail.com added inline comments to D27035: Add versioning support for kernel<>userland sysctl interface.
Sun, Nov 1, 1:48 PM
alfix86_gmail.com updated the test plan for D21700: sysctlinfo interface.
Sun, Nov 1, 3:25 AM
alfix86_gmail.com added a comment to D27035: Add versioning support for kernel<>userland sysctl interface.

A question about feature change

Sun, Nov 1, 2:43 AM
alfix86_gmail.com added inline comments to D27035: Add versioning support for kernel<>userland sysctl interface.
Sun, Nov 1, 2:20 AM
alfix86_gmail.com added a comment to D27035: Add versioning support for kernel<>userland sysctl interface.
Sun, Nov 1, 2:06 AM

Jun 28 2020

alfix86_gmail.com abandoned D20205: sysctl.name false positive.

This review is obsoleted by the <sysutils/sysctlinfo-kmod> port, so 'Abandon Revision'.

Jun 28 2020, 11:33 AM

Jun 7 2020

alfix86_gmail.com added a reviewer for D21700: sysctlinfo interface: imp.
Jun 7 2020, 12:36 PM

Feb 20 2020

alfix86_gmail.com created D23769: Fix broken links sound manuals.
Feb 20 2020, 3:20 AM

Jan 16 2020

alfix86_gmail.com added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

D23110#506589, @mjg wrote:
Also interested people can run dtrace to see what is taking giant at runtime on their boxes:

dtrace -n 'fbt::sysctl_root_handler_locked:entry /(args[0]->oid_kind & 0x00040000) == 0/ { @[stringof(args[0]->oid_name), args[0]->oid_descr[0] != 0 ? stringof(args[0]->oid_descr) : "NULL", sym((uintptr_t)args[0]->oid_handler)] = count(); }' -o out

sysctl -a > /dev/null

Jan 16 2020, 10:08 PM

Jan 10 2020

alfix86_gmail.com added a comment to D23110: Introduce CTLFLAG_NEEDGIANT.

A question because I should update my tools.
If a node has not the CLT_MFSAFE flags then it has to have the CTL_NEEDGIANT, is it right?
(So I should add a new "flag column" to deskutils/sysctlview and handle/show the new flag with "nsysctl -aNG" sysutils/nsysctl)

Jan 10 2020, 7:18 PM

Nov 21 2019

alfix86_gmail.com updated the summary of D21700: sysctlinfo interface.
Nov 21 2019, 8:49 PM

Nov 20 2019

alfix86_gmail.com updated the summary of D21700: sysctlinfo interface.
Nov 20 2019, 7:57 PM

Sep 28 2019

alfix86_gmail.com updated the diff for D21700: sysctlinfo interface.

Update sysctlinfo.h: CTL_SYSCTL is in sysctl.h
Improve lock (use a shared lock updating sysctl.h/kern_sysctl.c)
Move the implementation to kern_mib.c (sysctlinfo uses nothing from kern_sysctl.c)
Update man/man[3|4]/Makefile

Sep 28 2019, 5:11 AM
alfix86_gmail.com updated the summary of D21700: sysctlinfo interface.
Sep 28 2019, 5:02 AM

Sep 18 2019

alfix86_gmail.com updated the diff for D21700: sysctlinfo interface.

update the manual page to address revision feedback

Sep 18 2019, 6:29 PM
alfix86_gmail.com added a comment to D21700: sysctlinfo interface.
Sep 18 2019, 4:35 PM
alfix86_gmail.com updated the summary of D21700: sysctlinfo interface.
Sep 18 2019, 4:07 AM
alfix86_gmail.com created D21700: sysctlinfo interface.
Sep 18 2019, 3:55 AM

Sep 17 2019

alfix86_gmail.com added a comment to D21688: make truss decode sysctl names.

I apologize, I wrote some off-topic remark not important in this review (please don't consider them),
thanks to add the sysctl name support to truss.

Sep 17 2019, 5:25 PM
alfix86_gmail.com added inline comments to D21688: make truss decode sysctl names.
Sep 17 2019, 4:12 PM

May 13 2019

alfix86_gmail.com added a comment to D20205: sysctl.name false positive.
In D20205#435565, @cem wrote:

So, I think this was an intentional feature and there are automatically generated numerical nodes which are not actually present in the tree structure.

May 13 2019, 8:51 PM

May 9 2019

alfix86_gmail.com created D20205: sysctl.name false positive.
May 9 2019, 12:06 AM

Jan 30 2019

alfix86_gmail.com added a comment to D18696: sysctlmibinfo(3).

Question: why "sysctlmif", as opposed to "sysctlmib"? Since this is about walking the MIB tree?

Jan 30 2019, 8:08 PM
alfix86_gmail.com added a comment to D19012: sysctl has not -R option.

Thank you all for the comments,
Could you commit the diff? Thanks.

Jan 30 2019, 7:55 PM

Jan 29 2019

alfix86_gmail.com updated the summary of D19012: sysctl has not -R option.
Jan 29 2019, 1:27 AM
alfix86_gmail.com created D19012: sysctl has not -R option.
Jan 29 2019, 1:18 AM
alfix86_gmail.com added a comment to D18696: sysctlmibinfo(3).

Thank you for comments, I updated the manual page

Jan 29 2019, 1:00 AM
alfix86_gmail.com updated the diff for D18696: sysctlmibinfo(3).
  • add: __FBSDID("$FreeBSD$").
  • indent: sysctlmif_internal_subtree().
  • change: SYSCTLMIF_IDMAXLEVEL -> SYSCTLMIF_MAXIDLEVEL ( = CTL_MAXNAME).
  • change: mib-size for magic nodes to mib[CTL_MAXNAME + 2] (like in sbin/sysctl.c).
  • add free(object->fmt) in sysctlmif_freeobject() to avoid memory leak.
  • manual page: fix comments and update API.
Jan 29 2019, 12:59 AM

Jan 18 2019

alfix86_gmail.com updated the diff for D18696: sysctlmibinfo(3).
  • Change prefix: libsysctl_ -> sysctlmif_
  • manual page: update API
  • rename files: libsysctl.h/c/3 -> sysctlmibinfo.h/c/3
  • update lib/libutil/Makefile
  • fix style(9): delete 'double newlines'
Jan 18 2019, 4:18 PM

Jan 17 2019

alfix86_gmail.com added a comment to D18696: sysctlmibinfo(3).

Thank you for your comment,

Jan 17 2019, 7:21 PM

Jan 11 2019

alfix86_gmail.com updated the diff for D18696: sysctlmibinfo(3).

libsysctl moved to libutil,
thin wrappers deleted ( GETVALUE() and SETVALUE() ),
manual updated and
fixed style(9).

Jan 11 2019, 2:55 PM

Jan 10 2019

alfix86_gmail.com added inline comments to D18696: sysctlmibinfo(3).
Jan 10 2019, 9:13 PM
alfix86_gmail.com updated the diff for D18696: sysctlmibinfo(3).

Complete manual, checked by "mandoc -Tlint" and "igor -Dd".

Jan 10 2019, 3:44 PM
alfix86_gmail.com added a comment to D18696: sysctlmibinfo(3).

Thanks you all for the comments,
I updated to fix, soon the "update diff".

Jan 10 2019, 1:34 PM

Jan 7 2019

alfix86_gmail.com added a comment to D18696: sysctlmibinfo(3).
Jan 7 2019, 5:21 PM

Jan 1 2019

alfix86_gmail.com added inline comments to D18696: sysctlmibinfo(3).
Jan 1 2019, 11:53 AM

Dec 31 2018

alfix86_gmail.com created D18696: sysctlmibinfo(3).
Dec 31 2018, 12:10 AM