- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 28 2022
Manual page English LGTM. Can't attest to correctness.
May 27 2022
In D35337#801197, @pauamma_gundo.com wrote:Does that text get copied into a manual page? I'm confused why the mdoc(7) markup otherwise. (And if it does, do the .Xr's get added to a SEE ALSO section?)
Does that text get copied into a manual page? I'm confused why the mdoc(7) markup otherwise. (And if it does, do the .Xr's get added to a SEE ALSO section?)
In D35339#801187, @glebius wrote:Why is it called "leaf"? Wouldn't "physical" or "original" be a better description?
English LGTM. Waiting to hear from SMEs.
Upstream updated https://github.com/sethmlarson/rfc6555/pull/8 and prefer not to add test to sdist.
Manual page change LGTM.
The problem of rcvif being rewritten as a packet travels up the stack has been affecting not only offloading. I subscribed more people to gather more opinions. That's definitely is a useful feature. Let's get it right from the very beginning.
Why is it called "leaf"? Wouldn't "physical" or "original" be a better description?
- Correct year on copyright
Fix a memory leak introduced by previous commit.
Update copyright:
This is not what I wanted. The second diff (that I prematurely accepted) that you committed omits the f_isset call
Add namespacing to libnv, don't export msgio funcs
The patch is too old and does not not work as expected (or as I remember).
I have added a few more reviewers: the patch is a bit complex and my mentors are a bit busy, so if some other developer is able to take a look into this it would be helpful.
A month has passed without further discussion of the topic, so I accept dbaio's suggestion and leave the text as it is.
I tested this on a Netflix https serving workload, and I do not see any performance regressions from increasing the pkthdr size. That surprised me.
@salvadore Thanks for the corrections, all clear from me!
A few notes about spurious checks for NULL. In cases where APIs guarantee non-NULL values (or existing program logic) I don't find these checks helpful (especially since other drivers do not include such checks) as it makes a reader have to pause and wonder what cases could result in these values being NULL.
In D35328#800878, @chuck wrote:What you posted is very close to the original change I made. My hope was the intent of this version was clearer and compiled down to roughly the same assembly code.