Peter, could you, please, test this change ?

I'm writing a few test cases for mlock as part of the user wiring work. I added one which does the following:

Reported by: emaste using syzcaller

LGTM

Forgot to update distinfo, corrected.

So mat and tcberner were correct, brotli sources are only needed if not
building against source. Since we are building with --with-libbrotli
we are using the system libraries and don't need the source.

You must have changed the tab width or made some other change in your configuration. Something is clearly up, since you changed the indentation on most lines in this revision. Here is what I see in /usr/bin/vi in a pristine jail.

As for editing - well, they have been separate up until now, at https://github.com/freebsd/freebsd-quarterly/tree/master/2018q4. But yeah, we do have a bit of a problem with the review part of the process; plan for next quarter is to do a "call for edits" in addition to the usual call for reports.

I'm not sure about the PORTREVSION bump. The package would not change and it wouldn't have fetched in the past. Proceed as you think appropriate.

Fixes from bcr@.

Unconditionally copy src_m to dst_m (ignore valid bits).
Update comment.

*cough* PORTREVISION

I'm confused how a RST could have tripped this assert. In that case, len should have been 0 and ((th_flags) & (TH_SYN | TH_FIN)) == 0 should have been true (i.e. neither SYN nor FIN was set). In other words, it looks to me as if a RST should already pass the assert without tripping it. Can you explain further what I'm missing?

address first review round remarks
(where are the docs for @dir params?)

In D19615#420152, @markj wrote:

Dmitry noted that you shouldn't need the dash, i.e., "Reported by: syzbot+514d40ce757a3f8b15bc@syzkaller.appspotmail.com" is fine.