nr_seg is int, but it can not get to negative, can it?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 2 2023
Feb 2 2023
Maybe it should be moved to common?
Jan 24 2023
Jan 24 2023
Jan 18 2023
Jan 18 2023
In D36052#857841, @emaste wrote:Getting rid of default 9600 baud serial console is a good thing, we'll need to make sure this is widely documented in release notes etc.
See also D36295
Jan 13 2023
Jan 13 2023
Nice, thanks!:)
Jan 4 2023
Jan 4 2023
Dec 16 2022
Dec 16 2022
small nits still, but good otherwise, I assume, this code does work as expected now?
Dec 15 2022
Dec 15 2022
In D36052#857682, @schakrabarti_microsoft.com wrote:Setting other values than default values cause hang during comc_setup. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266248
Nov 18 2022
Nov 18 2022
Seems reasonable.
Oct 13 2022
Oct 13 2022
Oct 11 2022
Oct 11 2022
Oct 10 2022
Oct 10 2022
LGTM, thanks!
Sep 20 2022
Sep 20 2022
tsoome added a comment to D34479: Add support for custom keyboard layout when GELI asks for a passphrase.
In D34479#831843, @imp wrote:Some general comments...
The style of indented #if isn't what we do in FreeBSD. Code should be indented as if the #if isn't present, and the # directives should be in column 1.
We don't add extra spaces around the ('s, as I've highlighted
We don't do if (foo) bar; on one line.
logical operators are at the end of the line, not the start of the continuation.It's an interesting notion... You'll likely want to do something similar to the EFI boot loader as well.
Sep 14 2022
Sep 14 2022
Sep 13 2022
Sep 13 2022
Sep 8 2022
Sep 8 2022
Thanks!
Sep 5 2022
Sep 5 2022
tsoome committed rG1f5679569dd4: libpmc: pmc_init() should avoid overflowing pmc_class_table (authored by tsoome).
libpmc: pmc_init() should avoid overflowing pmc_class_table
Aug 31 2022
Aug 31 2022
tsoome added inline comments to D36401: libpmc: pmc_init() should avoid overflowing pmc_class_table.
review feedback.
50 enumeration values not handled in switch
commit message update
Aug 15 2022
Aug 15 2022
tsoome committed rGd98de7440507: loader: zfs reader should only store devdesc in f_devdata (authored by tsoome).
loader: zfs reader should only store devdesc in f_devdata
Aug 14 2022
Aug 14 2022
Aug 13 2022
Aug 13 2022
BSS would not had saved us as we do have code, data, bss, stack in low memory.
Aug 12 2022
Aug 12 2022
Jul 28 2022
Jul 28 2022
Jul 27 2022
Jul 27 2022
Jul 26 2022
Jul 26 2022
Add pmc.dmc-620(3) man page.
Jul 25 2022
Jul 25 2022
tsoome added inline comments to D35915: stand: Add dv_devfmt to return a string represenation of the device.
Jul 24 2022
Jul 24 2022
I am wondering, if we should use #ifndef ASSERT etc instead.
Jul 22 2022
Jul 22 2022
update date and nuke $FreeBSD$
suggestions from review.
Jul 20 2022
Jul 20 2022
In D33302#814333, @avg wrote:@tsoome , could you please clarify the nature of our objection to this change?
Jul 14 2022
Jul 14 2022
tsoome committed rGf4ca0fdbe69d: loader.efi: faults could try to print out call trace (authored by tsoome).
loader.efi: faults could try to print out call trace
Jul 10 2022
Jul 10 2022
Do not split authors on new lines.
Implemented by https://reviews.freebsd.org/D35750
tsoome committed rGda4e1e319c6c: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man… (authored by ray).
Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man…
Jul 9 2022
Jul 9 2022
tsoome added a comment to D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
most done
tsoome updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
and more feedback
tsoome updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
some more feedback.
tsoome updated the diff for D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
review feedback
Jul 8 2022
Jul 8 2022
It does look good, thanks! (waiting for update as noted in chat).
Jul 4 2022
Jul 4 2022
Seems to be good. and on this arm64 machine, it does work:
tsoome committed rG67f8b6d985db: loader: GELI encrypted disk should still use device name disk (authored by tsoome).
loader: GELI encrypted disk should still use device name disk
Jun 26 2022
Jun 26 2022
tsoome committed rG59191f3573f6: Add support of ARM CMN-600 controller, PMU access functions only. Add support… (authored by ray).
Add support of ARM CMN-600 controller, PMU access functions only. Add support…
tsoome committed rG1459a22787ea: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver (authored by ray).
The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver
tsoome committed rGe3572eb65473: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by… (authored by ray).
Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by…
Support of optional PMC classes.
tsoome committed rGb6e28991bf3a: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620… (authored by ray).
System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620…
test_diskread(): detect end of the disk
loader.efi: fix panic() after BS off
tsoome committed rG95e283e4d00f: loader: abstract boot services exiting to libefi function (authored by imp).
loader: abstract boot services exiting to libefi function
Herald added a reviewer for D32226: loader: abstract boot services exiting to libefi function: manu.
tsoome committed rGc8e7050f8a6a: efi: switch boot_services_gone to boot_services_active (authored by imp).
efi: switch boot_services_gone to boot_services_active
userboot is missing vdisk_dev
Jun 25 2022
Jun 25 2022
tsoome added a comment to D35342: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
In D35342#807371, @mhorne wrote:Seems to be the same as the original review with my two suggested tweaks? LGTM
tsoome updated the diff for D35342: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
Updates to pmc.3 as suggested by pauamma_gundo.com.