Great, thanks @gerald! And sorry for letting this gather dust!

@kib, could RTLD_LO_EARLY help here?

In D19277#413005, @kib wrote:

At very least, all constructors are executed there.

In D19277#412997, @kib wrote:

You do understand that with your patch, parts of the image code is executed un-jailed, and part of it is executed jailed, all sudden for it.

• finalized patch

• full context
• initialize jid variable

@rgrimes, sure, go ahead, as you see fit.

removed go libraries

updated GH_TUPLE to include commit hashes instead of master

removed DIST_SUBDIR

moved GNU_CONFIGURE variable

added tab

addressed @mat's comment

nice, thanks!

good catch, @tobik!

@lwhsu: sorry for not answering sooner. That sounds like a good idea. What would need to be done to move this?

committed in rP469642

adressed @tobik's comments

updated to 0.9.0 and addressed @0mp's comments:

• added LICENSE_FILE
• included documentation

committed in rP468278

awesome, thanks!

do not build x86_64 EFI image on i386

Adressed some comments.

chown pidfile and logfile

chown pidfile owner

In D14473#306827, @grehan wrote:

So a comment on this: in general, api's are not added to FreeBSD that don't have base-system clients that use them, or for a good reason. I think this falls into the latter but I'd like to cut it down a bit.

• can the get_unrestricted_guest() routine be removed ? There is an error return on the set, which seems like it can be used to determine if unrestricted mode is not available (e.g. that's how bhyve uses the ioctl).

Yes, it can.

ping? Anything else I can do to improve this patch?

use prometheus user and group.

addressed some of @mat's comments

addressed @mat's comments

@lwhsu while you're here, any chance you could take a look at D14537?

Fixed that, using ${PREFIX} now.

Would these changes be welcome in base? If yes, what would still need to be done to this review in order to get it into a committable state?

addressed some comments

I'm sorry, I seem to have created the previous patch without full context, so here it is again, this time with full context.

pass USERBOOT_VERSION_5 to loader_main.

I hope I got them all now

addressed @grehan's comments regarding style(9)

• updated the comment at the version identifier to correctly list the changes introduced by this version
• added a callback to vcpu_reset

I may also add a vcpu_reset callback still, would be nice to have that in as well.

@mat, thanks for catching that! I updated the patch, and also bumped PORTREVISION.

Thanks a lot! Feel free to close PR #225117 when comitted.

Sure, I don't know why it didn't work for you though. I recreated it with full context.

Usse g prefix on DISTVERSION

Merge .pre.mk .post.mk

Reworked in D7029 and committed in rS319487.

Yes this does fix the problem for me.

In D7223#207883, @gerald wrote:

Heads up, my top priority is to get lang/gcc / USE_GCC=yes updated
to GCC 5 in the coming days (which finally appears good to go, then
a small infrastructure improvement that has queued up) and then hope
to get to this finally, hopefully this coming weekend.

Remove TEST_DEPENDS stuff.

• Added error handling
• Rebased onto r436066
• Added full context

Yes, that works. It's a bit unnecessary however, I always used make BHYVE_SYSDIR=/usr/src/ -m /usr/src/share/mk -C /path/to/local/bhyve_graphics/checkout.