Oct 3 2020
Sep 11 2020
Jul 16 2020
I think this is fine now at least for the lib9p bits as next commit (i.e. everything except usr.sbin/bhyve which I still think should be a 3rd commit).
Once it's committed it would be good to refresh with the latest version of the bhyve bits.
Clean up makefile.
Jun 15 2020
Revert back to previous concept (sort of).
Jun 8 2020
May 15 2020
Can you refresh this with the updating lib9p/Makefile you plan to use?
May 14 2020
Apr 29 2020
Apr 20 2020
Well, do we think the GH will still be used once this is imported? If we think only FreeBSD will use this and that it will be fine to just live as a FreeBSD library then importing into lib/lib9p is fine and there's no need for the other bits that would get dropped. The argument for not doing vendor was that we didn't have a real upstream. If we have a real upstream, then it needs to be in contrib/.
BTW, even in upstream I think the issue of which files contain bits from libipx is probably still relevant and it would be good to update the per-file copyright statements to ACK that library in the relevant files.
So assuming a non-contrib model, the library needs to look like it is a normal base system library. This means no separate COPYRIGHT file, no README.md file, no GNUmakefile or apple_endian.h. Each file needs an accurate copyright statement. I think all the files do, but none of them mention libipx mentioned in COPYRIGHT, so if libipx bits are used, then the files using those need to have a proper attribution in their license statement.
Apr 14 2020
Removed contrib/lib9p/ and moved all lib9p sources under lib/. Consolidated two Makefiles (upstream contrib/lib9p/Makefile and local lib/lib9p/Makefile) into one.
Feb 5 2020
So this looks good to me, but the latest upload lost all the lib9p sources. I finally found the lib9p upstream, though the only version I see is in your GitHub space? I would be fine with still using that as an upstream though and putting the sources into contrib/lib9p (despite the last call where I said it could move). I think it would be good to first import lib9p into the vendor/ space and then contrib/, then a commit to hook it up to the build (being able to hook the tests up to run as part of the kyua test suite runs would be a bonus), and finally the commit to add it to bhyve 3rd.
Jan 31 2020
- Sort lib9p SRCS in the Makefile
- virtio-9p: error out on invalid options.
Jan 7 2020
Updated missing lib/Makefile changes
Added bsd.libnames.mk and src.libnames.mk changes left out in previous update.
Dec 24 2019
Proposed changeset passes make tinderbox run:
Dec 20 2019
Fixed issues pointed out in the review. Added full read-only sharing support.
Dec 27 2018
This update adds the Capsicum/Casper support to lib9p. It definitely needs more polishing, though.
Apr 11 2017
Is there another upstream repo where you'll maintain lib9p? I'm slightly surprised to see bespoke code landing in contrib/
Apr 9 2017
Any thoughts on the interaction with capsicum ? Seems like you just need blanket access underneath a particular directory.
Mar 26 2017
still missing: man page changes. working on them...
Fixed issued pointed out by mav@, added new switches to usage() in ctladm.c
Feb 23 2017
I can't really comment on style, but from technical accuracy standpoint it's all good.
Feb 22 2017
Added -d switch to ctladm port command to specify frontend driver type (default is ioctl). Fixed resource leaks in cfi_shutdown(). Fixed minor gratuitous typecasts. Added seatbelts preventing default ioctl port to be destroyed.
I decided to not allow to destroy default ioctl port
Feb 1 2017
Jan 31 2017
Fixed various things pointed out by reviewer.
Jan 27 2017
Jan 24 2017
Adapted to new ramdisk backend features, added fragments missing in previous diffs
Jan 23 2017
Fixed several HEAD mismerges
Jan 22 2017
Jan 3 2017
I'd be glad to hear what else needs to be changed - I applied that patch in freenas/os tree about a month ago and heard from several users that it fixed virtio-blk on Windows for them, but maybe they didn't push it hard enough.
Nov 30 2016
There might be some merit in implementing guest side of emergency write feature - virtio spec says that emergency writes are possible even before device is initialized or even reset, and emergency write port resides inside PCI config space, making it easy to write to it from loader(8) or during kernel early initialization.
Nov 24 2016
Nov 12 2016
Sep 17 2016
Port names are not null-terminated - putting '\0' at the last byte was wrong.
Cast basename() argument to char *.
Jul 11 2016
Mar 13 2016
Feb 3 2016
Jan 26 2016
Style fixes; moved check_perms() after parse_conf()/uclparse_conf().
Dec 12 2015
Initialize "tag" variable to NULL explicitly at uclparse.c:134.