Page MenuHomeFreeBSD
Feed Advanced Search

Nov 17 2023

jceel accepted D42644: dpaa2: fdt improve detection.

Looks good to me. pcs-handle is not used on non-SerDes (i.e. RGMII) MACs.

Nov 17 2023, 1:11 AM

Jul 15 2021

jceel updated the diff for D31191: build: Rewrite arm_kernel_boothdr in Lua and add RISC-V support..

Fix kernel_boothdr.lua file mode.

Jul 15 2021, 3:15 PM
jceel updated the diff for D31191: build: Rewrite arm_kernel_boothdr in Lua and add RISC-V support..

Added riscv linker script change missing in previous revision.

Jul 15 2021, 3:14 PM
jceel added inline comments to D31191: build: Rewrite arm_kernel_boothdr in Lua and add RISC-V support..
Jul 15 2021, 3:10 PM
jceel added reviewers for D31191: build: Rewrite arm_kernel_boothdr in Lua and add RISC-V support.: imp, manu, ian, ARM.
Jul 15 2021, 2:06 PM
jceel requested review of D31191: build: Rewrite arm_kernel_boothdr in Lua and add RISC-V support..
Jul 15 2021, 2:04 PM

Oct 3 2020

jceel closed D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Oct 3 2020, 7:05 PM
jceel committed rS366413: Add virtio-9p (aka VirtFS) filesystem sharing to bhyve..
Add virtio-9p (aka VirtFS) filesystem sharing to bhyve.
Oct 3 2020, 7:05 PM
jceel committed rS366412: Import lib9p 9d5aee77bcc1bf0e79b0a3bfefff5fdf2146283c..
Import lib9p 9d5aee77bcc1bf0e79b0a3bfefff5fdf2146283c.
Oct 3 2020, 6:53 PM

Sep 11 2020

jceel committed rS365622: Tag import of lib9p 9d5aee77bcc1bf0e79b0a3bfefff5fdf2146283c..
Tag import of lib9p 9d5aee77bcc1bf0e79b0a3bfefff5fdf2146283c.
Sep 11 2020, 12:12 AM
jceel committed rS365621: Import lib9p 9d5aee77bcc1bf0e79b0a3bfefff5fdf2146283c..
Import lib9p 9d5aee77bcc1bf0e79b0a3bfefff5fdf2146283c.
Sep 11 2020, 12:10 AM

Jul 16 2020

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
In D10335#568530, @jhb wrote:

I think this is fine now at least for the lib9p bits as next commit (i.e. everything except usr.sbin/bhyve which I still think should be a 3rd commit).

Once it's committed it would be good to refresh with the latest version of the bhyve bits.

Jul 16 2020, 6:33 PM
jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Clean up makefile.

Jul 16 2020, 4:13 PM

Jun 15 2020

jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Revert back to previous concept (sort of).

Jun 15 2020, 12:21 AM

Jun 8 2020

0mp awarded D10335: VirtFS/9p filesystem passthrough support (virtio-9p) a Love token.
Jun 8 2020, 10:48 AM

May 15 2020

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
In D10335#547251, @jhb wrote:

Can you refresh this with the updating lib9p/Makefile you plan to use?

May 15 2020, 5:39 PM
jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
May 15 2020, 5:38 PM

May 14 2020

jceel committed rS361054: Import lib9p 7ddb1164407da19b9b1afb83df83ae65a71a9a66..
Import lib9p 7ddb1164407da19b9b1afb83df83ae65a71a9a66.
May 14 2020, 7:58 PM

Apr 29 2020

jceel committed rS360471: Tag import of lib9p 7ddb1164407da19b9b1afb83df83ae65a71a9a66.
Tag import of lib9p 7ddb1164407da19b9b1afb83df83ae65a71a9a66
Apr 29 2020, 4:29 PM
jceel committed rS360470: Import lib9p 7ddb1164407da19b9b1afb83df83ae65a71a9a66..
Import lib9p 7ddb1164407da19b9b1afb83df83ae65a71a9a66.
Apr 29 2020, 4:24 PM

Apr 20 2020

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
In D10335#539242, @jhb wrote:

Well, do we think the GH will still be used once this is imported? If we think only FreeBSD will use this and that it will be fine to just live as a FreeBSD library then importing into lib/lib9p is fine and there's no need for the other bits that would get dropped. The argument for not doing vendor was that we didn't have a real upstream. If we have a real upstream, then it needs to be in contrib/.

BTW, even in upstream I think the issue of which files contain bits from libipx is probably still relevant and it would be good to update the per-file copyright statements to ACK that library in the relevant files.

Apr 20 2020, 11:23 PM
jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
In D10335#539175, @jhb wrote:

So assuming a non-contrib model, the library needs to look like it is a normal base system library. This means no separate COPYRIGHT file, no README.md file, no GNUmakefile or apple_endian.h. Each file needs an accurate copyright statement. I think all the files do, but none of them mention libipx mentioned in COPYRIGHT, so if libipx bits are used, then the files using those need to have a proper attribution in their license statement.

Apr 20 2020, 10:59 PM

Apr 14 2020

jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Removed contrib/lib9p/ and moved all lib9p sources under lib/. Consolidated two Makefiles (upstream contrib/lib9p/Makefile and local lib/lib9p/Makefile) into one.

Apr 14 2020, 10:38 PM

Feb 5 2020

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
In D10335#516241, @jhb wrote:

So this looks good to me, but the latest upload lost all the lib9p sources. I finally found the lib9p upstream, though the only version I see is in your GitHub space? I would be fine with still using that as an upstream though and putting the sources into contrib/lib9p (despite the last call where I said it could move). I think it would be good to first import lib9p into the vendor/ space and then contrib/, then a commit to hook it up to the build (being able to hook the tests up to run as part of the kyua test suite runs would be a bonus), and finally the commit to add it to bhyve 3rd.

Feb 5 2020, 8:45 PM

Jan 31 2020

jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
  • Sort lib9p SRCS in the Makefile
  • virtio-9p: error out on invalid options.
Jan 31 2020, 10:21 PM

Jan 7 2020

jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Updated missing lib/Makefile changes

Jan 7 2020, 2:19 PM
jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Added bsd.libnames.mk and src.libnames.mk changes left out in previous update.

Jan 7 2020, 12:28 PM

Dec 24 2019

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Proposed changeset passes make tinderbox run:

Dec 24 2019, 3:40 PM

Dec 20 2019

jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Fixed issues pointed out in the review. Added full read-only sharing support.

Dec 20 2019, 12:25 PM
jceel added inline comments to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Dec 20 2019, 12:18 PM

Dec 27 2018

jceel updated the diff for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

This update adds the Capsicum/Casper support to lib9p. It definitely needs more polishing, though.

Dec 27 2018, 1:33 AM

Apr 11 2017

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Is there another upstream repo where you'll maintain lib9p? I'm slightly surprised to see bespoke code landing in contrib/

Apr 11 2017, 12:23 AM

Apr 9 2017

jceel added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Any thoughts on the interaction with capsicum ? Seems like you just need blanket access underneath a particular directory.

Apr 9 2017, 10:21 PM
jceel retitled D10335: VirtFS/9p filesystem passthrough support (virtio-9p) from 9p filesystem passthrough support (virtio-9p) to VirtFS/9p filesystem passthrough support (virtio-9p).
Apr 9 2017, 10:13 PM
jceel updated the test plan for D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Apr 9 2017, 9:52 PM
jceel updated the summary of D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Apr 9 2017, 9:50 PM
jceel updated the summary of D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Apr 9 2017, 9:48 PM
jceel created D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Apr 9 2017, 9:45 PM

Mar 26 2017

jceel added a comment to D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

still missing: man page changes. working on them...

Mar 26 2017, 10:08 PM
jceel updated the diff for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Fixed issued pointed out by mav@, added new switches to usage() in ctladm.c

Mar 26 2017, 10:06 PM

Feb 23 2017

jceel accepted D9564: bhyve: document virtio-console in the manpage.

I can't really comment on style, but from technical accuracy standpoint it's all good.

Feb 23 2017, 12:50 PM

Feb 22 2017

jceel updated the diff for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Added -d switch to ctladm port command to specify frontend driver type (default is ioctl). Fixed resource leaks in cfi_shutdown(). Fixed minor gratuitous typecasts. Added seatbelts preventing default ioctl port to be destroyed.

Feb 22 2017, 7:21 PM
jceel added a comment to D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

I decided to not allow to destroy default ioctl port

Feb 22 2017, 1:49 AM

Feb 1 2017

jceel updated the diff for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.
Feb 1 2017, 6:06 PM

Jan 31 2017

jceel updated the diff for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Fixed various things pointed out by reviewer.

Jan 31 2017, 9:26 PM

Jan 27 2017

jceel added inline comments to D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.
Jan 27 2017, 4:36 PM

Jan 24 2017

jceel updated the diff for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Adapted to new ramdisk backend features, added fragments missing in previous diffs

Jan 24 2017, 11:09 PM

Jan 23 2017

jceel added inline comments to D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.
Jan 23 2017, 5:00 PM
jceel set the repository for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports to rS FreeBSD src repository - subversion.
Jan 23 2017, 10:22 AM
jceel updated the diff for D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

Fixed several HEAD mismerges

Jan 23 2017, 10:22 AM

Jan 22 2017

jceel updated D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.
Jan 22 2017, 10:51 PM
jceel updated D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.
Jan 22 2017, 10:49 PM
jceel retitled D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports from to Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.
Jan 22 2017, 10:47 PM

Jan 3 2017

jceel added a comment to D9033: Raise BLOCKIF_IOV_MAX to 128. .

I'd be glad to hear what else needs to be changed - I applied that patch in freenas/os tree about a month ago and heard from several users that it fixed virtio-blk on Windows for them, but maybe they didn't push it hard enough.

Jan 3 2017, 7:47 PM
jceel retitled D9033: Raise BLOCKIF_IOV_MAX to 128. from to Raise BLOCKIF_IOV_MAX to 128. .
Jan 3 2017, 7:41 PM

Nov 30 2016

jceel added a comment to D8680: add low level console support to virtio_console driver.

There might be some merit in implementing guest side of emergency write feature - virtio spec says that emergency writes are possible even before device is initialized or even reset, and emergency write port resides inside PCI config space, making it easy to write to it from loader(8) or during kernel early initialization.

Nov 30 2016, 4:10 PM

Nov 24 2016

jceel committed rS309121: virtio_console: handle short writes to an Unix domain socket gracefully..
virtio_console: handle short writes to an Unix domain socket gracefully.
Nov 24 2016, 10:16 PM
jceel committed rS309120: Allow opening virtio-console ports from the host side before guest.
Allow opening virtio-console ports from the host side before guest
Nov 24 2016, 9:53 PM

Nov 12 2016

jceel committed rS308566: Reserve space for control message payload (currently a port name)..
Reserve space for control message payload (currently a port name).
Nov 12 2016, 1:42 AM

Sep 17 2016

jceel committed rS305900: Create aliases for named virtio-console ports..
Create aliases for named virtio-console ports.
Sep 17 2016, 4:03 PM
jceel closed D7182: Add support for named virtio console ports by committing rS305900: Create aliases for named virtio-console ports..
Sep 17 2016, 4:03 PM
jceel updated the diff for D7182: Add support for named virtio console ports.

Port names are not null-terminated - putting '\0' at the last byte was wrong.

Sep 17 2016, 3:57 PM
jceel committed rS305898: Add virtio-console support to bhyve..
Add virtio-console support to bhyve.
Sep 17 2016, 1:48 PM
jceel closed D7185: Add virtio-console support to bhyve by committing rS305898: Add virtio-console support to bhyve..
Sep 17 2016, 1:48 PM
jceel updated the diff for D7185: Add virtio-console support to bhyve.

Cast basename() argument to char *.

Sep 17 2016, 1:31 PM

Jul 11 2016

jceel retitled D7185: Add virtio-console support to bhyve from to Add virtio-console support to bhyve.
Jul 11 2016, 1:19 PM
jceel retitled D7182: Add support for named virtio console ports from to Add support for named virtio console ports.
Jul 11 2016, 12:09 PM

Mar 13 2016

jceel committed rS296808: Check value returned from ucl_parser_add_file()..
Check value returned from ucl_parser_add_file().
Mar 13 2016, 7:50 PM

Feb 3 2016

jceel committed rS295212: Add an additional, libucl-based configuration file parser to ctld..
Add an additional, libucl-based configuration file parser to ctld.
Feb 3 2016, 4:04 PM
jceel closed D4534: libucl-based configuration file parser for ctld by committing rS295212: Add an additional, libucl-based configuration file parser to ctld..
Feb 3 2016, 4:03 PM

Jan 26 2016

jceel set the repository for D4534: libucl-based configuration file parser for ctld to rS FreeBSD src repository - subversion.
Jan 26 2016, 12:45 PM
jceel updated the diff for D4534: libucl-based configuration file parser for ctld.

Style fixes; moved check_perms() after parse_conf()/uclparse_conf().

Jan 26 2016, 12:44 PM

Dec 12 2015

jceel updated the diff for D4534: libucl-based configuration file parser for ctld.

Initialize "tag" variable to NULL explicitly at uclparse.c:134.

Dec 12 2015, 9:14 PM
jceel added a reviewer for D4534: libucl-based configuration file parser for ctld: mav.
Dec 12 2015, 4:22 PM
jceel retitled D4534: libucl-based configuration file parser for ctld from to libucl-based configuration file parser for ctld.
Dec 12 2015, 3:33 PM

Oct 11 2015

jceel committed rS289143: Sync key definitions with Linux..
Sync key definitions with Linux.
Oct 11 2015, 5:37 PM

Jul 5 2015

jceel committed rS285167: Correctly handle data arguments in EV_SET_* ioctls..
Correctly handle data arguments in EV_SET_* ioctls.
Jul 5 2015, 2:24 PM

Aug 12 2014

jceel added inline comments to D587: Add interrupt controller interface on ARM & allow to use stacked ICs.
Aug 12 2014, 8:06 AM

Aug 11 2014

jceel updated D587: Add interrupt controller interface on ARM & allow to use stacked ICs.
Aug 11 2014, 4:57 PM
jceel retitled D587: Add interrupt controller interface on ARM & allow to use stacked ICs from to Add interrupt controller interface on ARM & allow to use stacked ICs.
Aug 11 2014, 4:56 PM