In D16868#415222, @bdrewery wrote:In D16868#415167, @bdrewery wrote:In D16868#415150, @bdrewery wrote:Has this turned up any bad pipelines in Makefiles?
Ah right there is that dd one from a while back.
Now that pipefail is in we could do this a lot simpler like tools/install.sh works.
I don't think it needs to be a MK_ option.
It doesn't need to install.
Maybe something like this could work in tools/sh.sh that we just set with __MAKE_SHELL=?#! /bin/sh set -o pipefail 2>/dev/null || : exec "$@"Hmm set -o pipefail || : doesn't actually ignore the error.
# sh -ec 'set -o pipefail || :; echo test' set: Illegal option -o pipefail:(
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 28 2019
Feb 28 2019
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.
In D16868#415167, @bdrewery wrote:In D16868#415150, @bdrewery wrote:Has this turned up any bad pipelines in Makefiles?
Ah right there is that dd one from a while back.
Now that pipefail is in we could do this a lot simpler like tools/install.sh works.
I don't think it needs to be a MK_ option.
It doesn't need to install.
Maybe something like this could work in tools/sh.sh that we just set with __MAKE_SHELL=?#! /bin/sh set -o pipefail 2>/dev/null || : exec "$@"
Feb 27 2019
Feb 27 2019
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.
In D16868#415150, @bdrewery wrote:Has this turned up any bad pipelines in Makefiles?
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.
Has this turned up any bad pipelines in Makefiles?
bdrewery added a comment to D16762: Don't delete the source file when installing links on case-insensitive file systems.
This seems incomplete. It's just fixing the specific cases having problems today?
Why shouldn't we mandate enabling case-sensitivity on the filesystem first?
Feb 26 2019
Feb 26 2019
Update to 3.3.30 release.
Feb 25 2019
Feb 25 2019
- Update to 3.2.8-438-ga95f2cbfe
Feb 12 2019
Feb 12 2019
- Update to 3.2.8-432-g070fc33be
Feb 8 2019
Feb 8 2019
bdrewery added inline comments to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Feb 7 2019
Feb 7 2019
ipfw table list: Fix showing header outside of 'all'.
Jan 31 2019
Jan 31 2019
Shar files may be seen as binary by grep.
Jan 23 2019
Jan 23 2019
bdrewery added inline comments to D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.
Jan 15 2019
Jan 15 2019
Fix build of ccache-memcached-static sasl2 update in r485191
Looks ok. I didn't dive in very deep.
Dec 5 2018
Dec 5 2018
In D14244#388189, @emaste wrote:I don't really like this, but given that any failure should be fairly straightforward to track down OK.
(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)
Dec 4 2018
Dec 4 2018
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
bdrewery requested changes to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Nov 19 2018
Nov 19 2018
Nov 14 2018
Nov 14 2018
~/git/poudriere3 # cat /usr/local/bin/clang70 #!/bin/sh # $FreeBSD: head/devel/llvm70/files/llvm-wrapper.sh.in 466018 2018-03-31 03:28:42Z tobik $
Use exec in wrapper to avoid an extra shell process sticking around.
Nov 12 2018
Nov 12 2018
- Fix X509 build after r484765 openssl fix
MFH: r484765 r484823 r484824
- Update KERB_GSSAPI for 7.9p1
Nov 11 2018
Nov 11 2018
Nov 9 2018
Nov 9 2018
Nov 8 2018
Nov 8 2018
Thanks!
In D17899#382351, @bdrewery wrote:I don't think this _must_ be in Makefile.inc1 but it's simpler to put it there to ensure the right bmake and share/mk is used, so fine to be there.
I don't think this _must_ be in Makefile.inc1 but it's simpler to put it there to ensure the right bmake and share/mk is used, so fine to be there.
Nov 7 2018
Nov 7 2018
reviewed and approved
Nov 5 2018
Nov 5 2018
In D16842#359095, @jhb wrote:Agreed that as a followup we should define a single variable in src/Makefile.inc1 to hold 'freebsd12.0'. Will be useful since we are about to bump it to 13 in a few weeks.
I don't get emails for phabricator emails.
I do get and respond to IRC usually instantly.
Please get my feedback for further build changes.
Oct 26 2018
Oct 26 2018
Update my key after bumping the expiry some time ago
Oct 24 2018
Oct 24 2018
- Update to 3.2.8-402-g73eefa2e6
Oct 16 2018
Oct 16 2018
Oct 11 2018
Oct 11 2018
bdrewery committed rP481847: Need to define PORTVERSION later due to depending on MEMCACHED option..
Need to define PORTVERSION later due to depending on MEMCACHED option.
Oct 3 2018
Oct 3 2018
Please also don't checkin generated files in the initial commit. As-is it makes it hard to review.
bdrewery committed rP481187: - MEMCACHED with no DOCS: Remove dependency on asciidoc which is required.
- MEMCACHED with no DOCS: Remove dependency on asciidoc which is required
Oct 1 2018
Oct 1 2018
Sep 27 2018
Sep 27 2018
Sep 26 2018
Sep 26 2018
bdrewery added inline comments to D17331: Remove -m (update) from ldconfig -32 invocation on startup..
Handle overflow of uid or gid in arguments for chown
Sep 17 2018
Sep 17 2018
DIRS: Rework how duplicated dirs are installed.
installdirs can be a recursive/standalone target.
PROGS: Don't redundantly process DIRS.
DIRS: installdirs should also be .PHONY
Sep 13 2018
Sep 13 2018
Sep 6 2018
Sep 6 2018
Can't evaluate lib/Makefile changes without the rest of the changes. I.e., does it require dependency changes in Makefile.inc1's make libraries handling? Can't tell from this.
Aug 16 2018
Aug 16 2018
bdrewery committed rS337928: Fix build after r337852: Don't rebuild moduli based on unrelated moduli.c.
Fix build after r337852: Don't rebuild moduli based on unrelated moduli.c
Aug 9 2018
Aug 9 2018
Remove my blocker - I think it's fine in general if off-by-default
Aug 8 2018
Aug 8 2018
bdrewery committed rS337499: MFC r320280,r320281,r320282,r320283,r320284,r320285,r320692,r322362,r322401….
MFC r320280,r320281,r320282,r320283,r320284,r320285,r320692,r322362,r322401…
Revert r325808 (MFC r322401) to re-MFC with larger set
DIRS: Fix duplicate target warnings.
DIRS: Ensure existing directory still has permissions set.