Page MenuHomeFreeBSD
Feed Advanced Search

Jul 21 2019

dougm added a comment to D20863: prototype for trimming.

Stop updating blk before it might be freed.

Jul 21 2019, 7:44 PM
dougm added a comment to D20863: prototype for trimming.

Back out the changes that would launch more that one trim request from a single call to swp_pager_trimswapspace.

Jul 21 2019, 7:38 PM
dougm updated the summary of D20814: Make entry simplification one-way.
Jul 21 2019, 4:32 PM
dougm added a comment to D20863: prototype for trimming.

If trimming fails after blocks are allocated, free the blocks and reset the trimming cursor.

Jul 21 2019, 3:45 PM
dougm added a comment to D20863: prototype for trimming.

Don't let the trimmer sleep waiting for a resources. Don't invoke the trimmer while holding an object lock. Do let the trimmer launch as many delete ops as it wants, subject to resource constraints. Don't worry about trimming too little.

Jul 21 2019, 4:56 AM

Jul 20 2019

dougm committed rS350183: In trimming on startup, invoke swapon before closing the fd used for.
In trimming on startup, invoke swapon before closing the fd used for
Jul 20 2019, 8:47 PM
dougm closed D21006: swapon before closing trimming fd.
Jul 20 2019, 8:47 PM
dougm added a comment to D21006: swapon before closing trimming fd.

Add explanatory comment.

Jul 20 2019, 6:12 PM
dougm retitled D21006: swapon before closing trimming fd from trim after swapon to swapon before closing trimming fd.
Jul 20 2019, 6:12 PM
dougm added a comment to D21006: swapon before closing trimming fd.

Fix Eflags typo.

Jul 20 2019, 7:31 AM
dougm added a comment to D21006: swapon before closing trimming fd.

Call swapon(2) after trimming, but before closing the trimming fd.

Jul 20 2019, 7:14 AM
dougm created D21006: swapon before closing trimming fd.
Jul 20 2019, 4:27 AM

Jul 19 2019

dougm added a comment to D20814: Make entry simplification one-way.

Code formatting and comment changes.

Jul 19 2019, 9:19 PM
dougm committed rS350155: Define vm_map_entry_in_transition to handle an in-transition map.
Define vm_map_entry_in_transition to handle an in-transition map
Jul 19 2019, 8:47 PM
dougm closed D20833: factor out common wiring code.
Jul 19 2019, 8:47 PM
dougm added a comment to D20833: factor out common wiring code.

Edit comments.

Jul 19 2019, 7:00 PM
dougm added a comment to D20833: factor out common wiring code.

Improve a comment.

Jul 19 2019, 4:23 PM

Jul 15 2019

dougm added inline comments to D20833: factor out common wiring code.
Jul 15 2019, 9:37 PM
dougm added a comment to D20833: factor out common wiring code.

Act on reviewer feedback.

Jul 15 2019, 9:37 PM
dougm added 1 blocking reviewer(s) for D20833: factor out common wiring code: alc.
Jul 15 2019, 6:10 AM

Jul 14 2019

D20833: factor out common wiring code now requires review to proceed.

Rename a variable. Restore a comment.

Jul 14 2019, 11:21 PM
dougm added a comment to D20863: prototype for trimming.

Make swapgeom_strategy() handle a BIO_DELETE just like a BIO_WRITE.

Jul 14 2019, 10:27 PM
dougm added inline comments to D20863: prototype for trimming.
Jul 14 2019, 8:58 PM
dougm added a comment to D20863: prototype for trimming.

Bypass swp_pager_strategy for the BIO_DELETE case and just go to sp->sw_strategy(bp, sp);

Jul 14 2019, 5:37 PM
dougm added a comment to D20814: Make entry simplification one-way.

Drop all the changes related to wiring and unwiring.

Jul 14 2019, 5:00 PM
dougm added a comment to D20863: prototype for trimming.

It would be unfair to Peter to keep guessing solutions for this problem and letting him try them out. Does anyone listening know what I've got wrong here?

Jul 14 2019, 8:23 AM

Jul 13 2019

dougm added a comment to D20625: clarify reserv_test_config.

Add an assertion. Use vm_paddr_t variable to manage bounds checking at function start.

Jul 13 2019, 6:33 PM
dougm added a comment to D20863: prototype for trimming.

g_io_request requires that b_data be NULL before BIO_DELETE. Make it so.

Jul 13 2019, 6:02 PM

Jul 12 2019

dougm committed rS349930: MFC r349286, r349293.
MFC r349286, r349293
Jul 12 2019, 2:04 AM

Jul 11 2019

dougm added a comment to D20863: prototype for trimming.

Don't try to trim exactly the swap device we just allocated from; just look for one that needs trimming.
Tweak the parameters to make the max trim size bigger, and make the trim zone smaller.

Jul 11 2019, 9:51 PM
dougm committed rS349923: Address problems in blist_alloc introduced in r349777. The swap block….
Address problems in blist_alloc introduced in r349777. The swap block…
Jul 11 2019, 8:52 PM
dougm closed D20893: Fix a next_leaf bug.
Jul 11 2019, 8:52 PM
dougm added inline comments to D20893: Fix a next_leaf bug.
Jul 11 2019, 7:49 PM
dougm updated the summary of D20833: factor out common wiring code.
Jul 11 2019, 1:35 PM

Jul 10 2019

dougm added a comment to D20893: Fix a next_leaf bug.

If we can allocation nothing from the next leaf, be sure to return immediately.

Jul 10 2019, 5:54 PM
D20893: Fix a next_leaf bug now requires review to proceed.

In the case that we have to back-up 'scan' because we've found that there's no next leaf with free blocks, we also have to back-up 'blk'.

Jul 10 2019, 4:05 PM
dougm added a comment to D20893: Fix a next_leaf bug.

Do I understand correctly that the "panic: freeing free block" condition is happening only with the patch from D20863 in place? Or does it happen with an unmodified kernel?

Jul 10 2019, 2:56 PM

Jul 9 2019

dougm created D20893: Fix a next_leaf bug.
Jul 9 2019, 3:53 PM
dougm added a comment to D20863: prototype for trimming.

Correct the last log field.

Jul 9 2019, 6:59 AM
dougm added a comment to D20863: prototype for trimming.

Add logging. Don't really try to trim anything.

Jul 9 2019, 3:06 AM
dougm updated the test plan for D20863: prototype for trimming.
Jul 9 2019, 3:06 AM

Jul 8 2019

dougm added a comment to D20833: factor out common wiring code.

The obvious questions are:
Does this happen without the patch in place?
Does this happen before r349777?

Jul 8 2019, 8:23 AM

Jul 7 2019

dougm added a comment to D20863: prototype for trimming.

In swap_pager_reserve, release the write lock when not modifying the object.

Jul 7 2019, 8:28 PM
dougm added a comment to D20863: prototype for trimming.

In swap_pager_reserve, do all the allocation before acquiring the object lock. If all the allocation can't be done, leave the object alone.

Jul 7 2019, 6:40 PM
dougm added a comment to D20833: factor out common wiring code.

Change a misleading variable name. Drop a contentious comment.

Jul 7 2019, 7:20 AM
dougm committed rS349799: A style-related change, r349791, made unclear the meaning of a.
A style-related change, r349791, made unclear the meaning of a
Jul 7 2019, 6:57 AM
dougm closed D20871: Fix comment after r349791.
Jul 7 2019, 6:57 AM
dougm added a comment to D20863: prototype for trimming.

Fix some obvious deadlocks.

Jul 7 2019, 3:43 AM

Jul 6 2019

dougm created D20871: Fix comment after r349791.
Jul 6 2019, 11:19 PM
dougm added a comment to D20863: prototype for trimming.

Something less obviously blocking, though I'm sure some flags are set wrong and the wait for an available write resource (nsw_wcount_async) is unacceptible. There must a queue somewhere I could stick that task in, waiting for writing to be okay again.

Jul 6 2019, 8:55 PM
dougm removed a reviewer for D20814: Make entry simplification one-way: alc.
Jul 6 2019, 6:30 PM
dougm added a comment to D20833: factor out common wiring code.

The motivation for this change is that I was working on another change that would do something to every function that simplified entries, and when I got to the wiring/unwiring functions, I found that it was hard to do and that I'd have to do it twice. So I concocted this patch so that I'd only have to do it once. I'm sorry that it seems I just mess with your code for no real purpose other than to annoy you.

Jul 6 2019, 6:23 PM
dougm updated the diff for D20863: prototype for trimming.
Jul 6 2019, 6:18 PM
dougm retitled D20863: prototype for trimming from move cursor from blist to swdev to prototype for trimming.
Jul 6 2019, 6:17 PM
dougm added inline comments to D20833: factor out common wiring code.
Jul 6 2019, 5:34 PM
dougm added inline comments to D20833: factor out common wiring code.
Jul 6 2019, 5:02 PM
dougm committed rS349791: Fix style(9) violations involving division by PAGE_SIZE..
Fix style(9) violations involving division by PAGE_SIZE.
Jul 6 2019, 3:55 PM
dougm closed D20847: fix style(9) violations involving division by PAGE_SIZE.
Jul 6 2019, 3:55 PM
dougm created D20863: prototype for trimming.
Jul 6 2019, 8:17 AM
dougm committed rS349777: Change blist_next_leaf_alloc so that it can examine more than one leaf.
Change blist_next_leaf_alloc so that it can examine more than one leaf
Jul 6 2019, 6:15 AM
dougm closed D20579: Remove limit on blist_alloc maxsize, allow bigger getswapspace allocations.
Jul 6 2019, 6:15 AM
D20833: factor out common wiring code now requires review to proceed.

Change '.' to '?' in a comment.

Jul 6 2019, 3:25 AM

Jul 5 2019

dougm added inline comments to D20833: factor out common wiring code.
Jul 5 2019, 8:38 PM
dougm added a comment to D20833: factor out common wiring code.

Add a locked-assertion.

Jul 5 2019, 8:38 PM
dougm accepted D20858: Add per-freepool page caches..
Jul 5 2019, 8:09 PM
dougm resigned from D13484: swapoff to release multiple swap blocks at a time.
Jul 5 2019, 4:50 PM
dougm committed rS349767: Based on work posted at https://reviews.freebsd.org/D13484, change.
Based on work posted at https://reviews.freebsd.org/D13484, change
Jul 5 2019, 4:49 PM
dougm closed D20635: release multiple swap blocks at a time in swp_pager_force_pagein.
Jul 5 2019, 4:49 PM
dougm added a comment to D20833: factor out common wiring code.

Apply reviewer suggestions.

Jul 5 2019, 3:25 PM
D20635: release multiple swap blocks at a time in swp_pager_force_pagein now requires review to proceed.

Add braces around one-line do-while body.

Jul 5 2019, 3:16 PM
dougm added a comment to D20579: Remove limit on blist_alloc maxsize, allow bigger getswapspace allocations.

Fix typo.

Jul 5 2019, 3:09 PM
dougm retitled D20635: release multiple swap blocks at a time in swp_pager_force_pagein from release multiple swap blocks at a time to release multiple swap blocks at a time in swp_pager_force_pagein.
Jul 5 2019, 5:15 AM
dougm added inline comments to D20858: Add per-freepool page caches..
Jul 5 2019, 4:26 AM
dougm added a comment to D20833: factor out common wiring code.

Apply reviewer suggestion, unhappily.

Jul 5 2019, 3:10 AM

Jul 4 2019

dougm added inline comments to D20858: Add per-freepool page caches..
Jul 4 2019, 8:40 PM
dougm added inline comments to D20858: Add per-freepool page caches..
Jul 4 2019, 8:23 PM
dougm added a comment to D20833: factor out common wiring code.

Address reviewer comments.

Jul 4 2019, 8:03 PM
dougm added a comment to D20850: remove gotos from vm_map_unwire.

Mentors, what do you want me to do here?

Jul 4 2019, 7:49 PM
dougm added a reviewer for D20850: remove gotos from vm_map_unwire: kib.
Jul 4 2019, 7:49 PM
dougm updated the diff for D20833: factor out common wiring code.
Jul 4 2019, 7:43 PM
dougm added a comment to D20833: factor out common wiring code.

Resolve conflicts with parts already checked in. Drop some goto-elimination in vm_map_wire_locked.

Jul 4 2019, 7:40 PM
dougm committed rS349745: Move an assignment, drop a label, and change gotos to break statements.
Move an assignment, drop a label, and change gotos to break statements
Jul 4 2019, 7:25 PM
dougm closed D20850: remove gotos from vm_map_unwire.
Jul 4 2019, 7:25 PM
dougm updated the diff for D20850: remove gotos from vm_map_unwire.
Jul 4 2019, 7:21 PM
dougm added a reviewer for D20850: remove gotos from vm_map_unwire: markj.
Jul 4 2019, 7:21 PM
dougm closed D20855: replace 'goto' with 'else' in vm_map_wire_locked..
Jul 4 2019, 7:18 PM
dougm committed rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked..
Replace a 'goto' with an 'else' in vm_map_wire_locked.
Jul 4 2019, 7:18 PM
D20855: replace 'goto' with 'else' in vm_map_wire_locked. now requires review to proceed.

No semicolon.

Jul 4 2019, 7:15 PM
dougm committed rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to.
Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to
Jul 4 2019, 7:12 PM
dougm closed D20846: boolean_t to bool in wire/unwire fucntions.
Jul 4 2019, 7:12 PM
dougm added a reviewer for D20855: replace 'goto' with 'else' in vm_map_wire_locked.: markj.
Jul 4 2019, 7:08 PM
dougm added a comment to D20846: boolean_t to bool in wire/unwire fucntions.

Resolve merge conflicts. Don't confuse true with false.

Jul 4 2019, 7:06 PM
dougm added a comment to D20579: Remove limit on blist_alloc maxsize, allow bigger getswapspace allocations.

Add/alter comments and slightly restructure a computation in response to reviewer comments.

Jul 4 2019, 6:56 PM
dougm updated the summary of D20846: boolean_t to bool in wire/unwire fucntions.
Jul 4 2019, 6:48 PM
dougm closed D20849: drop a temp variable from vm_map_insert.
Jul 4 2019, 6:29 PM
dougm committed rS349741: Drop a temp variable from vm_map_insert, with no effect on the.
Drop a temp variable from vm_map_insert, with no effect on the
Jul 4 2019, 6:29 PM
dougm created D20855: replace 'goto' with 'else' in vm_map_wire_locked..
Jul 4 2019, 4:28 PM
dougm created D20850: remove gotos from vm_map_unwire.
Jul 4 2019, 6:15 AM
dougm created D20849: drop a temp variable from vm_map_insert.
Jul 4 2019, 4:53 AM
dougm added a comment to D20847: fix style(9) violations involving division by PAGE_SIZE.

Include other files.

Jul 4 2019, 2:26 AM