In D20251#483238, @james.wright_digital-chaos.com wrote:

In D20251#483236, @lwhsu wrote:

This patch build failed in poudriere: https://gist.github.com/5919089c2e8d247342cf9a8749df7ca7

I added these files in include/ to pkg-plist and it pass the poudriere test. Is that the right fix? (these files need to be installed and installed to the right place)

The orphaned files mentioned in that poudriere log were header files I deliberately excluded from the pkg-plist, as I think they are for internal libs and headers only required during the build process, so didn't need to be included in the final package.

Updated pkg-plist: https://gist.github.com/cc17d08532e48039d9c5c30fc2a145f9

This patch build failed in poudriere: https://gist.github.com/5919089c2e8d247342cf9a8749df7ca7

It looks good to me, but I haven't had time to test and commit this. Add more (possible reviewers) to try to get more hands on this before I can get back to this.

@freebsd_sysctl.cz : hello, could you update this differential to the full patch, including the content in D21787? Thanks!

Thanks for the patch. I've tested the result with qemu and changed to use .xz distfile.

pkg-plist seems to need updating: https://gist.github.com/1009408f7a1427f6543b5174acb4ba7b

maintainer approved at https://bugs.freebsd.org/238228

In D21815#476631, @wjw_digiware.nl wrote:

I've ran my poudriere on 11.3.
Got to find a 12.0 system and see what brings there.
My original 12.0 system has moved onto 12.1 so check what that brings.

It seems not passing poudriere cleanly: https://gist.github.com/6a204afe88fc4531bc9f1b0614bdbb10

Just be curious, we already have net/ceph12 and net/ceph13 in the ports tree. Will we retire the old versions?

@scottph: do you want me to commit this? Or you can commit this with Approved by: lwhsu

I'll commit with minor fixes.

I would be good to also modify https://svnweb.freebsd.org/ports/head/devel/subversion/files/extra-patch-fbsd-template

In D20251#473528, @james.wright_digital-chaos.com wrote:

In D20251#472897, @lwhsu wrote:

Because python is used for those bin/* files, the quickest way is moving python:run to USE=, however, I tried this and poudriere gives many Error: Orphaned: include/*.
Can you check this part?

I think the previous errors (regarding python and shebangfix) were caused by a typo in CLI_USES=, I have since updated the diff and they seem to have been resolved.

Please could you run a build through poudriere and let me know if there are any outstanding issues?

In D14590#473177, @wjw_digiware.nl wrote:

Nope, I'm not sure why this was not closed when it got commited.

Fixed in rP440218

net/ceph is 12.2.7 now. Do we still need have this open?

Do you have a PR to inform the maintainer?

Is there a PR to inform the maintainer?

Sorry, one last thing to confirm, is tstruk@gmail.com also your email address?

Please let me know if you need me to commit this (and D21650, D21651, D21650).

In D20251#472520, @james.wright_digital-chaos.com wrote:

====> Running Q/A tests (stage-qa)
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat'
Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp'
*** Error code 1

I think this is because USE=python:run is only defined when CLI option enabled.

Tried moving shebangfix from USES= to CLI_USES= but still get the same error when running make stage-qa.

Please could you provide a suggestion how to fix this issue as I'm stumped as to what is the actual problem here.

Thanks for fixing!

In D21650#472763, @tadeusz.struk_intel.com wrote:

Still not sure if that's the best solution, but following examples from other ports I marked tools as broken when OSVERSION <= 1200086 and OpenSSL < 1.1.0

I can build this port in poudriere fine. I think previous error was because of patching issue.

has this test done?

This is committed as rP511993 and can be closed.