In D20894#452944, @ngie wrote:

This should actually be obtained via ctypes.

• Change string mapping of SUPERIO_DEV_NONE (to distinguish from SUPERIO_DEV_MAX)
• Drop unnecessary comment

Update per @avg's suggestion.

Agreed, I also think this may be a problem of the old GCC, haven't tried with newer one (which should have been using) yet.

I'll take care of this and also bump the .Dd field.

devmatch info has been added in rS339020

Add explicit braces to avoid dangling else (-Werror,-Wdangling-else of clang)

In D20344#440836, @ngie wrote:

A change related to this broke CI (example):

...
Fail: incorrect exit status: 1, expected: 0
stdout:

stderr:
geli: The 3DES-CBC encryption algorithm is deprecated.

I'm looking through to figure out what exactly caused this.

CC: @lwhsu

In D19298#440809, @cem wrote:

In D19298#440806, @ngie wrote:

1. This broke the build with gcc:

I just noticed the same thing :-). Should be fixed in r348293.

Tested this in Waterloo Hackathon 2019, this fixes bug230857 and bug238012.

@phil do you want me to commit this first (if you haven't had fix yet) to stop the failure warnings?

In D20188#434993, @lwhsu wrote:

In D20188#434976, @phil wrote:

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

Thanks!

In D20188#434976, @phil wrote:

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

@phil or do you want me to have a PR in github?