Page MenuHomeFreeBSD
Feed Advanced Search

Feb 11 2017

rstone closed D9519: Don't zero out srtt after excess retransmits by committing rS313646: Don't zero out srtt after excess retransmits.
Feb 11 2017, 5:05 PM
rstone updated the diff for D9519: Don't zero out srtt after excess retransmits.
  • fixup! Don't zero out srtt after excess retransmits
Feb 11 2017, 4:50 PM

Feb 9 2017

rstone retitled D9519: Don't zero out srtt after excess retransmits from to Don't zero out srtt after excess retransmits.
Feb 9 2017, 6:18 PM
rstone added a comment to D9518: Check for preemption after lowering a thread's priority.
Feb 9 2017, 5:57 PM
rstone added a comment to D9518: Check for preemption after lowering a thread's priority.

See this ML post for a detailed description of the problem:
https://lists.freebsd.org/pipermail/freebsd-current/2013-January/039261.html

Feb 9 2017, 5:55 PM
rstone retitled D9518: Check for preemption after lowering a thread's priority from to Check for preemption after lowering a thread's priority.
Feb 9 2017, 5:53 PM

Feb 7 2017

rstone committed rS313388: MFC r312544.
MFC r312544
Feb 7 2017, 3:13 PM
rstone committed rS313387: MFC r312544.
MFC r312544
Feb 7 2017, 3:12 PM

Feb 6 2017

rstone retitled D9465: Remove unnecessary ifdef soup from struct tcpcb from to Remove unnecessary ifdef soup from struct tcpcb.
Feb 6 2017, 11:36 PM

Jan 20 2017

rstone closed D9164: Set ifm_cur to NULL in ifmedia_removeall. by committing rS312544: Fix reference to free memory in ixgbe/if_media.c.
Jan 20 2017, 5:17 PM
rstone committed rS312544: Fix reference to free memory in ixgbe/if_media.c.
Fix reference to free memory in ixgbe/if_media.c
Jan 20 2017, 5:17 PM

Dec 9 2016

rstone added inline comments to D8736: Add COMPAT_FREEBSD11 and use it vm_meter.c..
Dec 9 2016, 3:30 AM

Dec 2 2016

rstone committed rS309414: Revert r309372.
Revert r309372
Dec 2 2016, 3:39 PM

Dec 1 2016

rstone committed rS309372: Fix a false positive in a buf_ring assert.
Fix a false positive in a buf_ring assert
Dec 1 2016, 9:08 PM
rstone closed D8685: Fix a false positive in a buf_ring assert by committing rS309372: Fix a false positive in a buf_ring assert.
Dec 1 2016, 9:08 PM

Nov 30 2016

rstone added inline comments to D8685: Fix a false positive in a buf_ring assert.
Nov 30 2016, 11:42 PM
rstone updated the diff for D8685: Fix a false positive in a buf_ring assert.

Ensure we don't walk off the end of the ring

Nov 30 2016, 11:41 PM
rstone updated subscribers of D8685: Fix a false positive in a buf_ring assert.
Nov 30 2016, 9:59 PM
rstone retitled D8685: Fix a false positive in a buf_ring assert from to Fix a false positive in a buf_ring assert.
Nov 30 2016, 9:43 PM

Nov 26 2016

rstone committed rS309177: MFC r308580:.
MFC r308580:
Nov 26 2016, 1:16 AM

Nov 23 2016

rstone accepted D8624: Add tunable to disable destructive dtrace Security.
Nov 23 2016, 4:50 PM
rstone added inline comments to D8624: Add tunable to disable destructive dtrace Security.
Nov 23 2016, 4:50 PM

Nov 18 2016

rstone committed rS308790: Add a dtrace script for collecting schedgraph data.
Add a dtrace script for collecting schedgraph data
Nov 18 2016, 2:29 AM

Nov 17 2016

rstone accepted D8515: loader: beri_sdcard_disk_print() needs to return int..
Nov 17 2016, 6:19 PM

Nov 12 2016

rstone committed rS308580: Don't read if_counters with if_addr_lock held.
Don't read if_counters with if_addr_lock held
Nov 12 2016, 7:03 PM
rstone closed D8498: Don't read if_counters with if_addr_lock held by committing rS308580: Don't read if_counters with if_addr_lock held.
Nov 12 2016, 7:03 PM

Nov 11 2016

rstone committed rS308562: Fix git tools when run against a worktree.
Fix git tools when run against a worktree
Nov 11 2016, 11:07 PM
rstone closed D8501: Fix arcgit when run from a worktree by committing rS308562: Fix git tools when run against a worktree.
Nov 11 2016, 11:07 PM
rstone updated the diff for D8501: Fix arcgit when run from a worktree.

--git-dir is unreliable, so use -C $git_repo instead

Nov 11 2016, 9:06 PM
rstone added inline comments to D8501: Fix arcgit when run from a worktree.
Nov 11 2016, 8:57 PM
rstone added inline comments to D8501: Fix arcgit when run from a worktree.
Nov 11 2016, 8:51 PM
rstone updated the diff for D8501: Fix arcgit when run from a worktree.

Similar fix is needed in importgit

Nov 11 2016, 8:29 PM
rstone retitled D8501: Fix arcgit when run from a worktree from to Fix arcgit when run from a worktree.
Nov 11 2016, 7:26 PM
rstone abandoned D8500: Fix arcgit when run from a worktree.
Nov 11 2016, 7:26 PM
rstone retitled D8500: Fix arcgit when run from a worktree from to Fix arcgit when run from a worktree.
Nov 11 2016, 7:26 PM
rstone added reviewers for D8498: Don't read if_counters with if_addr_lock held: sbruno, asomers.
Nov 11 2016, 5:42 PM
rstone retitled D8498: Don't read if_counters with if_addr_lock held from to Don't read if_counters with if_addr_lock held.
Nov 11 2016, 5:41 PM
rstone added a comment to D8306: Fix lock order reversal in lagg_get_counter.

This is not the correct fix. The bug lies in a higher layer; the stack must never call into the ifnet layer with the if_addr_lock already held. I see how to fix the upper layer, so I'll take that.

Nov 11 2016, 3:34 PM

Oct 24 2016

rstone closed D8303: Fix ip_output() on point-to-point links by committing rS307887: Fix ip_output() on point-to-point links.
Oct 24 2016, 10:11 PM
rstone committed rS307887: Fix ip_output() on point-to-point links.
Fix ip_output() on point-to-point links
Oct 24 2016, 10:11 PM

Oct 20 2016

rstone updated subscribers of D8303: Fix ip_output() on point-to-point links.
Oct 20 2016, 6:30 PM
rstone retitled D8303: Fix ip_output() on point-to-point links from to Fix ip_output() on point-to-point links.
Oct 20 2016, 6:29 PM
rstone committed rS307681: Set the executable bit on arcgit and importgit.
Set the executable bit on arcgit and importgit
Oct 20 2016, 6:28 PM
rstone closed D2071: Add some tools to simplify the use of git by committing rS307680: Add some tools to simplify the use of git.
Oct 20 2016, 6:24 PM
rstone committed rS307680: Add some tools to simplify the use of git.
Add some tools to simplify the use of git
Oct 20 2016, 6:24 PM

Oct 5 2016

rstone accepted D8157: Corrected non-portable reuse of va_list in dt_printf().
Oct 5 2016, 9:34 PM

Sep 8 2016

rstone updated the test plan for D7821: Preserve ECN bits when merging frames in LRO.
Sep 8 2016, 2:18 AM
rstone retitled D7821: Preserve ECN bits when merging frames in LRO from to Preserve ECN bits when merging frames in LRO.
Sep 8 2016, 2:16 AM

Aug 22 2016

rstone committed rS304606: Temporarily disable the optimization from r304436.
Temporarily disable the optimization from r304436
Aug 22 2016, 3:28 PM

Aug 18 2016

rstone committed rS304437: Fix unlocked access to ifnet address list.
Fix unlocked access to ifnet address list
Aug 18 2016, 10:59 PM
rstone committed rS304436: Don't check for broadcast IPs on non-bcast pkts.
Don't check for broadcast IPs on non-bcast pkts
Aug 18 2016, 10:59 PM
rstone closed D7227: Fix unlocked access to ifnet address list by committing rS304437: Fix unlocked access to ifnet address list.
Aug 18 2016, 10:59 PM
rstone closed D7309: Don't check for broadcast IPs on non-bcast pkts by committing rS304436: Don't check for broadcast IPs on non-bcast pkts.
Aug 18 2016, 10:59 PM
rstone committed rS304435: Don't iterate over the ifnet addr list in ip_output().
Don't iterate over the ifnet addr list in ip_output()
Aug 18 2016, 10:59 PM
rstone closed D7266: Don't iterate over the ifnet addr list in ip_output() by committing rS304435: Don't iterate over the ifnet addr list in ip_output().
Aug 18 2016, 10:59 PM

Aug 15 2016

rstone committed rS304179: MFC r304163.
MFC r304163
Aug 15 2016, 7:18 PM
rstone committed rS304163: MFC r303836.
MFC r303836
Aug 15 2016, 3:24 PM

Aug 8 2016

rstone closed D7041: Fix invalid enqueue of NULL in bxe tx path by committing rS303836: Don't enqueue NULL on a drbr.
Aug 8 2016, 4:19 PM
rstone committed rS303836: Don't enqueue NULL on a drbr.
Don't enqueue NULL on a drbr
Aug 8 2016, 4:19 PM
rstone updated the diff for D2071: Add some tools to simplify the use of git.

Add -n option to arcgit to perform a dry run, and fix some typos.

Aug 8 2016, 3:25 PM
rstone updated the diff for D7309: Don't check for broadcast IPs on non-bcast pkts.

Add sysctl to control new UDP receive behaviour, and document it
in UPDATING.

Aug 8 2016, 2:57 PM

Aug 3 2016

rstone accepted D7400: Permit the name of the /dev/iov entry to be set by the driver..
Aug 3 2016, 5:03 PM
rstone accepted D7402: Use the port device name for the iov device for Chelsio T4/T5 cards..
Aug 3 2016, 3:27 PM
rstone requested changes to D7400: Permit the name of the /dev/iov entry to be set by the driver..
Aug 3 2016, 3:24 PM

Jul 30 2016

rstone requested changes to D5157: Patch for bug 100219.
Jul 30 2016, 2:33 AM
rstone added a comment to D7366: Acquire if_addr_lock before traversing if_addrhead in in_broadcast()..

I already have this one in review. I'm trying to address some concerns that have been raised outside of phabricator, and once that's taken care of I'll commit my version.

Jul 30 2016, 2:32 AM

Jul 25 2016

rstone retitled D7309: Don't check for broadcast IPs on non-bcast pkts from to Don't check for broadcast IPs on non-bcast pkts.
Jul 25 2016, 6:06 PM

Jul 20 2016

rstone updated the test plan for D7266: Don't iterate over the ifnet addr list in ip_output().
Jul 20 2016, 11:51 PM
rstone updated subscribers of D7266: Don't iterate over the ifnet addr list in ip_output().
Jul 20 2016, 11:45 PM
rstone retitled D7266: Don't iterate over the ifnet addr list in ip_output() from to Don't iterate over the ifnet addr list in ip_output().
Jul 20 2016, 11:45 PM
rstone added a comment to D7227: Fix unlocked access to ifnet address list.

so apparently this is called on nearly every packet that passes through ip_output() (according to a comparison of dtrace and netstat output). Adding an additional lock/unlock to the transmit path concerns me, but this is obviously the right fix. Does in_broadcast() really need to be called so much?

Jul 20 2016, 5:25 PM
rstone updated the diff for D7227: Fix unlocked access to ifnet address list.

Use macros for code compiled in kernel

Jul 20 2016, 5:23 PM

Jul 17 2016

rstone updated subscribers of D7227: Fix unlocked access to ifnet address list.
Jul 17 2016, 6:23 PM
rstone retitled D7227: Fix unlocked access to ifnet address list from to Fix unlocked access to ifnet address list.
Jul 17 2016, 6:22 PM

Jun 30 2016

rstone retitled D7041: Fix invalid enqueue of NULL in bxe tx path from to Fix invalid enqueue of NULL in bxe tx path.
Jun 30 2016, 4:44 PM

May 11 2016

rstone accepted D6239: Create a get_id pci and pcib interface..
May 11 2016, 3:32 PM

May 10 2016

rstone added inline comments to D6239: Create a get_id pci and pcib interface..
May 10 2016, 10:16 PM

May 3 2016

rstone accepted D6192: Make VF creation more robust..
May 3 2016, 7:32 PM

Apr 9 2016

rstone added inline comments to D5891: Add a new PCI bus interface method to alloc the ivars (dinfo) for a device..
Apr 9 2016, 11:31 PM

Apr 4 2016

rstone added a reviewer for D5825: if_vlan locking fixes: rstone.
Apr 4 2016, 5:39 PM

Mar 14 2016

rstone committed rS296865: Clean up repeated "All rights reserved".
Clean up repeated "All rights reserved"
Mar 14 2016, 5:41 PM

Feb 5 2016

rstone added a comment to D4994: Make quicksort or mergesort configurable for the LRO code..

Have we tested the case where there is only a single flow, so all of the flowids are equal? That tends to be a very bad case for qsort.

Feb 5 2016, 2:01 PM

Jan 9 2016

rstone added a reviewer for D4809: TCP signature output-path cleanup: rstone.
Jan 9 2016, 1:14 AM

Jan 5 2016

rstone committed rS293208: MFC r287920:.
MFC r287920:
Jan 5 2016, 4:58 PM

Jan 2 2016

rstone added a comment to D4232: MFC SR-IOV to 10-STABLE.

Changing pm_reg to uint16_t was done because the SR-IOV BARs are located outside of the 256-byte PCI configuration space (they are in the extended config space).

Jan 2 2016, 3:18 PM

Nov 20 2015

rstone added a comment to D4232: MFC SR-IOV to 10-STABLE.

nvlist not being backmerged yet was why I haven't yet MFC'ed SR-IOV. That's long overdue, though. It was originally promised to me that would happen for 10.1-RELEASE.

Nov 20 2015, 9:26 PM

Sep 23 2015

rstone accepted D3718: ixl(4): Remove compile warning for unused function..
Sep 23 2015, 3:16 PM

Sep 17 2015

rstone committed rS287945: MFC r280957.
MFC r280957
Sep 17 2015, 11:31 PM
rstone committed rS287929: MFC r279410:.
MFC r279410:
Sep 17 2015, 6:22 PM
rstone committed rS287928: MFC r279413:.
MFC r279413:
Sep 17 2015, 6:20 PM
rstone committed rS287926: MFC r263109.
MFC r263109
Sep 17 2015, 5:56 PM
rstone committed rS287922: MFC r286970:.
MFC r286970:
Sep 17 2015, 5:09 PM
rstone committed rS287920: Fix /sbin/route to never look up (invalid) interface names through DNS.
Fix /sbin/route to never look up (invalid) interface names through DNS
Sep 17 2015, 4:57 PM

Aug 20 2015

rstone committed rS286970: Prevent ticks rollover from preventing vm_lowmem event.
Prevent ticks rollover from preventing vm_lowmem event
Aug 20 2015, 8:29 PM
rstone closed D3439: Prevent ticks rollover from preventing vm_lowmem event by committing rS286970: Prevent ticks rollover from preventing vm_lowmem event.
Aug 20 2015, 8:29 PM
rstone retitled D3439: Prevent ticks rollover from preventing vm_lowmem event from to Prevent ticks rollover from preventing vm_lowmem event.
Aug 20 2015, 3:07 PM

Jul 16 2015

rstone added inline comments to D3111: ixl: Add MAC+VLAN filter for LAA MAC assignment.
Jul 16 2015, 11:57 PM ยท network

Jul 3 2015

rstone accepted D2988: Fix range descriptions in iovctl.conf(5) man page.
Jul 3 2015, 10:26 PM

Jun 27 2015

rstone accepted D2921: iovctl rc script uses invalid option.
Jun 27 2015, 1:17 PM
rstone added a comment to D2921: iovctl rc script uses invalid option.

Thanks for fixing this

Jun 27 2015, 1:17 PM