In D44456#1272317, @minsoochoo0122_proton.me wrote:

Can we enable/disable the whole module when one or both of HMP and SMP aren't enabled? I don't see why we need to build this driver when HMP and SMP don't exist.

• Remove the unnecessary inclusion of opt_sched.h.
• Modify the code to output an error (#error) if a required SMP kernel configuration option is not defined.

• Restore the NULL check for the handler function pointer in the lapic_handle_thermal(), which was mistakenly deleted.
• Fix an issue with the registration order of instance ptr. and handler function ptr. within the lapic_enable_thermal().

Modify to load and store handler function pointers using atomic(9) functions.

• Fix missing deletion of conditional decision by SCHED_ULE constant. (Sorry, that was my mistake)

• Delete the conditional branching part using the EARLY_AP_STARTUP macro constant. (because the EARLY_AP_STARTUP constant definition is now mandatory.)
• Add a comment to the x2apic_mode check block in the lapic_enable_thermal function.
• Modify the lapic_handle_thermal function so that the handle function and its argument pointers are saved to the stack before being used. (improving safety in the event that the pointers are cleared between the NULL check and the handle function call).

• Fix the old style of comments at the beginning of the file (removed hyphens).
• Change the HISTORY section from "under development" to "released from FreeBSD 16.0."

• Squash the previous review fixes and re-create the patch commit.
• Correct the driver name insertion line to be in alphabetical order

• Squash the previous review fixes and re-create the patch commit.
• The driver description was mistakenly placed in the VM OPTIONS section, so it has been moved to the SMP OPTIONS section.

Squash the previous review fixes and re-create the patch commit.

I checked the latest version of the Intel Software Developer's manual (SDM) again, and it appears that the Intel Hardware Feedback Interface / Thread Director does not provide a table with performance index values ​​for each P core/E core/LP-E core, but rather a table with two values ​​for each core group: a performance index value (computation speed) and a power saving index value (power efficiency).
It does not appear that the table or columns have been expanded for LP-E cores.

• Correct the driver name insertion line to be in alphabetical order (My mistake. Sorry)

The driver description was mistakenly placed in the VM OPTIONS section, so it has been moved to the SMP OPTIONS section.
(Sorry for not noticing my carelessness. Thank you for pointing that out.)

• Correct the driver name insertion line to be in alphabetical order (My mistake. Sorry)

• Fix the driver name (coredirector -> intelhfi)
• Fix file name with changed the driver name.
• Fix review findings. (Copyright style, etc)

• Fix the driver name (coredirector -> intelhfi)
• Fix review findings. (__builtin_popcount, device_printf, etc)

• Fix macro define name (CPUGRP_SCORE -> HMP)
• Rebase for freebsd current source tree.

• Fix the driver name (coredirector -> intelhfi)
• Fix file name with changed the driver name.

Fix the driver name (coredirector -> intelhfi) and macro definition name (CPUGRP_SCORE -> HMP).

Thank you for your suggestion.
I understood that the driver name "coredirector" is vague.

Attach the patch file created with the git format-patch command.

Attach the patch file created with the git format-patch command.

Attach the patch file created with the git format-patch command.

Attach the patch file created with the git format-patch command.

Attach the patch file created with the git format-patch command.

Attach the patch file created with the git format-patch command.

In D44453#1016452, @kib wrote:

Please mail me (kib@f.o) the updated patch in the format of git-format-patch, with the correct metadata. Most important, put your author's email and name as you want them to appear in the git commit log.

Attach the patch file created with the git format-patch command. I also fixed the constant names.

In D44453#1017213, @karels wrote:

Is this project derived from Intel's code (see https://github.com/intel/intel_hfi)? It was originally GPL, but is now dual-licensed.

In D44453#1016452, @kib wrote:

Please mail me (kib@f.o) the updated patch in the format of git-format-patch, with the correct metadata. Most important, put your author's email and name as you want them to appear in the git commit log.

Fix CPUID Leaf6 define strings.

Upload a full-context patch that corrects the name of the CPUID Leaf6 constant.

Attach the full context patch file.

Attach the full context patch file.

Attach the full context patch file.
{F79836034}

Attach the full context patch file.

Attach the full context patch file.

Also, if you have a public git repo (on GitHub or elsewhere) with this work please share the link - it makes it convenient to cherry-pick changes.

I'm sorry.
I tried uploading a full-context patch file from "Update Diff" in the upper right menu, but when I download it afterwards, only the modified parts are shown.
Since I don't know how to use this site, I will attach the full context file here.
If I'm wrong, please let me know how to upload it.