/var/run/motd doesn't work for update_motd="NO" whether /var/run is tmpfs or not.
when /var/run is not tmpfs cleanvar rc script will remove any motd placed there.

Updated changes:
When update_motd="NO", don't overwrite /var/run/motd, only copy if missing.
Don't remove rcvar line to allow "service motd disable",
check rcvar before run_rc_command instead.

I was not aware of "service X disable" usage and I thought
when rcvar is set to "NO" it prevented the run of the rc script.
I see that it only prevents run_rc_command from running.
motd_start won't run but motd is loaded and can do stuff before run_rc_command.

Update changes to mask destination address before calling rib_handle_ifaddr_info

update after rtinit split/removal changes

Do you have a suggestion for a different way to fix it?

The problem with reverting the login(1) portion and leaving /etc/rc.d/motd as-is is that then the default of update_motd=YES will not work.
The motd script only generates /etc/motd symlink if motd.template does not exist when the script runs.
motd.template will exist on new installations so login will look for /etc/motd but script will only generate /var/run/motd.

Previous changes were confusing with /etc/motd being either symlink or file.
As suggested, use simpler design.
motd script will always run and generate /var/run/motd.
update_motd variable will decide if motd script prepends version info or not.

Sounds good to me.
Do you want me to prepare a new patch with your suggestion?

changes from last diff:
libexec/rc/rc.d/motd

1. overwrite /etc/motd.template with /etc/motd if /etc/motd is a regular file
2. always create /etc/motd symbolic link

Abandon in favor of D23695

Abandon in favor of D23695

rebase the changes against D23695, dropping the use of RTF_CONNECTED

replace TAILQ_FOREACH with CK_STAILQ_FOREACH in in6_ifremprefix

Update for D13029 changes

moved increment of tx.segs to correct location

changed to only increase opackets/oerrors on last segment

Mark request for tx interrupt notification only on last segment.
Return ENOBUFS from awg_encap only if buffer is full so don't unset IFF_DRV_OACTIVE if m_collapse or dma loading failed.