- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 9 2021
Apr 8 2021
Apr 5 2021
LGTM for the man page parts.
LGTM for the man page parts.
LGTM
LGTM, thanks for contributing this.
Mar 20 2021
Mar 13 2021
I missed the differential revision tag in the commit, so manually close this differential.
In D29114#652131, @imp wrote:There is a find.1 man page in the V1 man pages we have. We lack sources, though, to know for sure.
It is indeed absent from V3, though no mention of its absence is included in the intro.
It appears to be present in the V2 manual that's available online (but not from TUHS),
FWIW, find is not present in the PDP-7 version of unix either (though that's ambiguous given the fragmentary nature of the surviving artifacts).PWB post-dates V5 though. That troubles me. PWB 1.0 was for V6.
The sources in v5 are dated 1974:
12 -rw-r--r-- 1 imp loshes 9217 Nov 26 1974 ./Research/Dennis_v5/v5/usr/source/s1/find.c
and then the pwb version we have is
-rw-r--r-- 1 imp loshes 9660 Jul 6 1977 USDL/bostic/pwb/pwb.1/tape1/s1/find.cA diff between these shows they are the same, but with some stuff added in PWB 1.0 as well as cleanups. main was rewritten and EQ was used instead of compstr in places. More compile time constants are used in PWB as well. Large sections are otherwise the same. My belief is that this is a strong indication that PWB 1.0 find was derived from V5 find, not the other way around. V6 shows some minor edits to the V5 one (all these edits are in the PWB 1.0 one too, which was released after V6). Finally, the date in the PWB one is also from 1977, and the V5 and V6 ones were from 1974 and 1975 respectively. v7 has many of the PWB changes, and on top of that a number of portability fixes or other trivial style differences.
Absent some contemporary commentary, I'd suggest that it was rewritten for v5, enhanced in PWB and then V7 brought that in and added portability fixes.
- find(1): Update the HISTORY section
In generell no objections from manpages, but the updated text has no references to be IPv6 specific. Is that intentional?
Mar 11 2021
LGTM from manpages. Thanks for working on this PR.
Should be fine. I haven't checked the rendered output, but I am sure you did.
Mar 7 2021
Mar 6 2021
Mar 4 2021
LGTM from manpages
Mar 3 2021
No objections from manpages.
Two small nits from manpages.
LGTM from manpages. @rwatson thanks for spotting this, I had overlooked this in the initial review.
LGTM for the manpage kind of things.
LGTM from my side. @adrian, would you be fine with this change?
Mar 2 2021
Feb 28 2021
Feb 24 2021
In D28914#647311, @khng300_gmail.com wrote:In D28914#647282, @gbe wrote:LGTM from manpages . Did you run igor and 'mandoc -Tlint' against the man page?
I just checked it against mandoc -Tlint, and did some fixes.
The output from mandoc -Tlint in the current form is:
mandoc: share/man/man9/zero_region.9:80:28: STYLE: consider using OS macro: FxThe output of igor is:
$ igor -R share/man/man9/zero_region.9 zero_region.9:28:date not today, February 25, 2021:.Dd February 24, 2021
LGTM from manpages . Did you run igor and 'mandoc -Tlint' against the man page?
Feb 22 2021
Feb 19 2021
Also LGTM from manpages.
Feb 18 2021
@fernape please forward this diff to christos@netbsd.org if you have some time.
Feb 17 2021
In D28593#643325, @fernape wrote:Link manpage to the Makefile
spotted by gbe@
Sorry, was the wrong differential. The Makefile.Inc part is still missing.
There is still the Makefile change missing.
@imp would you approve this as direct commit to contrib?
Feb 13 2021
Anyone up for a review?
Feb 12 2021
Good work. Some inline comments and you have to update Makefile.inc to actual install the man page.
Feb 8 2021
Feb 7 2021
Feb 6 2021
- Add missing dot
@jhb I updated the differential according to your comments.
- Reference src.conf
- Update the wording
Feb 4 2021
Could some one review this? I would like to get it into releng/13.
LGTM
Feb 3 2021
Feb 2 2021
@brueffer Thanks for the fast review. I incorporated the change in the updated differential.
- Add suggestions from @brueffer