Page MenuHomeFreeBSD
Feed Advanced Search

Sep 26 2019

araujo accepted D21802: security/vuxml: Add entry for lang/go and lang/go-devel CVE-2019-16276.

Ok, please open reviews for both of go and go-devel, we should commit the vuxml and both ports together, not mandatory, but nice to do.

Sep 26 2019, 3:52 PM
araujo updated subscribers of D21802: security/vuxml: Add entry for lang/go and lang/go-devel CVE-2019-16276.

Will we update go and go-devel ports? Do you need to sync anything with @jlaffaye?

Sep 26 2019, 3:29 PM
araujo accepted D21799: databases/pspg: Update to 2.1.2.
Sep 26 2019, 12:26 PM

Sep 25 2019

araujo accepted D21793: dns/knot-resolver: Remove redundant lang/go build dependency.
Sep 25 2019, 10:23 PM

Sep 24 2019

araujo accepted D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.

Is it worth do an exp-run on this one too?

Sep 24 2019, 2:02 AM
araujo accepted D21743: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc-shells).

LGTM, same thing as the other reviews, wait for the exp-run and also for the portmgr approval.

Sep 24 2019, 1:58 AM
araujo accepted D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

LGTM, same thing, wait for the exp-run and portmgr approval.

Sep 24 2019, 1:50 AM
araujo accepted D21741: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. audio-mail).

It looks good to me, but you need to wait for the exp-run and also portmgr approval.
Thanks to work on this.

Sep 24 2019, 1:44 AM

Sep 23 2019

araujo accepted D21771: www/gitea: Use linker flags to set version instead of patching the source..

This is cool, I didn't know it would be possible set version via ldflags.

Sep 23 2019, 10:52 PM
araujo added a comment to D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.
In D21730#475087, @dmgk wrote:

IIUC this potentially changes all Go binaries, so all USES=go ports that do not set ldflags themselves probably need a PORTREVISION bump afterwards to relink them?

A quick search

for f in $(find /usr/ports -name Makefile | xargs grep -l 'USES=.*\bgo\b'); do grep -q '\bldflags\b' $f || echo $f; done | wc -l

shows that it would require bumping PORTREVISION of 198 ports. Recompiling will make binaries about 25% smaller on average but there are no other functional changes. I can prepare a separate review if we're OK with this.

Sep 23 2019, 10:49 PM
araujo accepted D21735: www/gohugo: Update for D21730.
Sep 23 2019, 7:59 PM

Sep 22 2019

araujo accepted D21751: editors/dte: Update to 1.9.
Sep 22 2019, 1:38 PM
araujo accepted D21748: databases/pspg: Update to 2.0.4.
Sep 22 2019, 1:37 PM

Sep 20 2019

araujo added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#474028, @dmgk wrote:

As you are working on this already for a while, how about ports that you are not a maintainer? Maybe an exp-run following with a portmgr@ approval would be interesting to clean up the rest of the ports.

That was my plan actually, I was just not sure what would be the best way to get something like that reviewed/committed. The complete diff is about 250KB, I was thinking about maybe breaking it to 3-4 parts for easier review. Would that make sense or it would be better to post it in a single review?

Sep 20 2019, 12:23 PM
araujo accepted D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#473887, @dmgk wrote:
In D21721#473870, @tz wrote:

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

r505321 converted all ports to USES=go which already provides do-build and do-install targets. During that conversion, ports that were defining their own build/install targets were left alone to be cleaned up later. This commit does this cleanup for the ports that I maintain.

Sep 20 2019, 2:05 AM

Sep 19 2019

araujo accepted D21716: security/botan2: Update to 2.11.0.

You should do two commits for this review, first commit security/botan2 and then commit the BUMP for the other ports that depends of security/botan2.

Sep 19 2019, 2:39 PM

Sep 18 2019

araujo committed rP512255: This is a multi tabbed terminal that uses embedded windows and a gtk.
This is a multi tabbed terminal that uses embedded windows and a gtk
Sep 18 2019, 7:23 AM
araujo committed rP512254: - Update to 2019.09.12.1..
- Update to 2019.09.12.1.
Sep 18 2019, 6:49 AM

Sep 17 2019

araujo accepted D21691: x11-fonts/font-awesome: Update to 5.10.2.
Sep 17 2019, 5:27 PM
araujo accepted D21687: security/sops: Update to 3.4.0.
Sep 17 2019, 12:43 PM
araujo accepted D21679: Amend r352422, add missing 'n'.
Sep 17 2019, 12:16 AM

Sep 16 2019

araujo committed rP512140: Welcome Dmitri Goutnik (dmgk) to the rank of ports committer..
Welcome Dmitri Goutnik (dmgk) to the rank of ports committer.
Sep 16 2019, 3:42 AM

Sep 11 2019

araujo accepted D21601: Depend on the gcc${GCC_DEFAULT} binary, since only lang/gcc installs gcc..

It builds fine at my side with poudriere: build of sysutils/uefi-edk2-qemu | uefi-edk2-qemu-x86_64-g20190307_1 ended at Wed Sep 11 09:26:10 CST 2019

Sep 11 2019, 1:32 AM

Sep 10 2019

araujo added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

You have my approve to commit it! Thank you!

Committed. But I just realized, should I also bump PORTREVISION?

Sep 10 2019, 2:03 AM
araujo added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Thanks! Since I'm not a ports committer, could you commit the change please?

Sep 10 2019, 1:49 AM
araujo committed rP511726: Update to 2019.09.01.
Update to 2019.09.01
Sep 10 2019, 1:48 AM
araujo accepted D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Sep 10 2019, 1:44 AM

Sep 9 2019

araujo committed rP511604: - Use vendored deps.
- Use vendored deps
Sep 9 2019, 2:05 AM

Sep 2 2019

araujo committed rP510766: - Update to 0.21.0.
- Update to 0.21.0
Sep 2 2019, 7:12 AM

Aug 28 2019

araujo committed rP510038: - Simplify the port moving out unneeded post-extract, do-build and.
- Simplify the port moving out unneeded post-extract, do-build and
Aug 28 2019, 3:06 AM

Aug 27 2019

araujo committed rS351541: MFC r350433: Fix sound on headset jack for ALC255 and ALC256 codec..
MFC r350433: Fix sound on headset jack for ALC255 and ALC256 codec.
Aug 27 2019, 7:17 AM
araujo committed rP509991: Update to 2019.08.13..
Update to 2019.08.13.
Aug 27 2019, 6:44 AM
araujo committed rP509990: A personal terminal-based dashboard utility, designed for displaying.
A personal terminal-based dashboard utility, designed for displaying
Aug 27 2019, 6:21 AM

Aug 2 2019

araujo committed rP507862: Assign back to the pool.
Assign back to the pool
Aug 2 2019, 8:44 AM
araujo committed rP507860: Update to 2.04.
Update to 2.04
Aug 2 2019, 8:40 AM
araujo added a comment to D21053: Simplify capsicumization of bhyve (cont'd).
In D21053#458959, @jhb wrote:

I worry this might be a bit premature. New features for bhyve are often developed without capsicum because capsicum is a pain to work with. The debug server didn't use it at first, save/restore currently disables it as does the 9p patch. Removing WITHOUT_CAPSICUM makes coordinating that existing work harder. It also adds a pretty good barrier to entry when trying to add new things that add new ioctls, etc.

It's not much more work to add a new right in a driver that already works under capsicum than it is to add -DWITHOUT_CAPSICUM to the build flags.

Aug 2 2019, 3:30 AM

Aug 1 2019

araujo committed rP507757: Update to 2019.07.30.
Update to 2019.07.30
Aug 1 2019, 8:09 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
In D19400#458961, @rob.fx907_gmail.com wrote:

@araujo, sounds like you are taking over this review?

Aug 1 2019, 12:13 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
In D19400#458949, @jhb wrote:

I wonder if it makes more sense to do this in vmrun.sh? OTOH, it's probably fine to do this. We should also probably do it in bhyverun.c since bhyveload isn't used in the UEFI case. Another option would be to do this in the vm_create() wrapper in libvmmapi in which case that would fix bhyveload, grub2-bhyve, and bhyve all in one place.

Aug 1 2019, 12:02 AM

Jul 30 2019

araujo added a comment to D7840: HD Audio Emulation For Bhyve.

Committed already at r349335

Jul 30 2019, 8:16 AM
araujo added a reviewer for D7840: HD Audio Emulation For Bhyve: iateaca.

I'm commandeer this revision because this patch were committed already by @scottl: https://svnweb.freebsd.org/base?view=revision&sortby=date&revision=349335

Jul 30 2019, 8:16 AM
araujo added a member for bhyve: araujo.
Jul 30 2019, 7:52 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@jhb Perhaps do the same with bhyverun.c?

Jul 30 2019, 7:06 AM
araujo committed rS350433: Fix sound on headset jack for ALC255 and ALC256 codec..
Fix sound on headset jack for ALC255 and ALC256 codec.
Jul 30 2019, 2:02 AM
araujo closed D19017: - Fix Headset sound for DELL laptops.
Jul 30 2019, 2:02 AM

Jul 28 2019

araujo added a comment to D19017: - Fix Headset sound for DELL laptops.

Ok, I'm gonna do it tomorrow!!!

Jul 28 2019, 12:10 PM

Jul 25 2019

araujo added inline comments to D21053: Simplify capsicumization of bhyve (cont'd).
Jul 25 2019, 4:29 AM
araujo committed rP507309: - Update GH_TAGNAME to reflect the right tag on github for version 1.1.0..
- Update GH_TAGNAME to reflect the right tag on github for version 1.1.0.
Jul 25 2019, 2:34 AM

Jul 24 2019

araujo committed rP507267: Update to 2.22.
Update to 2.22
Jul 24 2019, 9:00 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@jhb Any objection if I proceed to commit this patch? I just hit the same situation "forgot to load vmm" and this patch does fix it.

Jul 24 2019, 8:22 AM
araujo added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

ping!!!

Jul 24 2019, 8:18 AM
araujo added a comment to D21053: Simplify capsicumization of bhyve (cont'd).

The problem here is that you will not be able to build this code on other platforms like Solaris.
I'm not sure if this is applicaple for bhyve, if not then the change looks good to me.

Jul 24 2019, 8:05 AM
araujo added a comment to D21053: Simplify capsicumization of bhyve (cont'd).

Remove CASPER from Makefile as we don't use any service.

Jul 24 2019, 8:00 AM
araujo added inline comments to D21053: Simplify capsicumization of bhyve (cont'd).
Jul 24 2019, 8:00 AM
araujo added reviewers for D21053: Simplify capsicumization of bhyve (cont'd): oshogbo, jhb.
Jul 24 2019, 7:47 AM
araujo created D21053: Simplify capsicumization of bhyve (cont'd).
Jul 24 2019, 7:45 AM
araujo committed rP507264: Update to 2019.07.16.
Update to 2019.07.16
Jul 24 2019, 6:15 AM
araujo committed rP507263: - Enable ZMQ by default.
- Enable ZMQ by default
Jul 24 2019, 5:35 AM
araujo committed rP507261: Update to 1.1.0.
Update to 1.1.0
Jul 24 2019, 2:29 AM

Jul 16 2019

araujo added a comment to D20945: bhyve: update the NVMe CQ based on the status.

Lgtm!

Jul 16 2019, 12:30 AM

Jul 3 2019

araujo committed rP505734: Release egypcio from mentorship, he is ready to fly solo..
Release egypcio from mentorship, he is ready to fly solo.
Jul 3 2019, 8:15 AM
araujo committed rP505733: elease jhixson from mentorship, it's been long overdue.
elease jhixson from mentorship, it's been long overdue
Jul 3 2019, 8:10 AM

Jun 25 2019

araujo closed D20750: Add SPDX tags to HD Audio device bhyve(8).
Jun 25 2019, 6:25 AM
araujo committed rS349361: Add SPDX tags to bhyve(8) HD Audio device..
Add SPDX tags to bhyve(8) HD Audio device.
Jun 25 2019, 6:25 AM
araujo added a reviewer for D20750: Add SPDX tags to HD Audio device bhyve(8): scottl.
Jun 25 2019, 2:04 AM
araujo created D20750: Add SPDX tags to HD Audio device bhyve(8).
Jun 25 2019, 2:03 AM

Jun 22 2019

araujo committed rP504858: Update to 2019.06.21..
Update to 2019.06.21.
Jun 22 2019, 9:57 AM

Jun 17 2019

araujo committed rP504424: Update to 2019.06.08..
Update to 2019.06.08.
Jun 17 2019, 1:38 PM

May 23 2019

araujo accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
May 23 2019, 4:52 PM
araujo accepted D19905: bhyve: Add EUI64 to NVMe device.

Lgtm

May 23 2019, 4:51 PM

Apr 28 2019

araujo accepted D19042: [New port] audio/pianod2: A free, multi-source, network-controlled music player daemon.
Apr 28 2019, 1:14 AM
araujo accepted D20084: sysutils/nomad: Update to v0.9.0.
Apr 28 2019, 1:13 AM

Apr 24 2019

araujo committed rP499854: - Update to 2019.04.24.
- Update to 2019.04.24
Apr 24 2019, 3:14 PM
araujo committed rP499851: - Add a devel version of edk2-bhyve based on the newest stable201903 branch..
- Add a devel version of edk2-bhyve based on the newest stable201903 branch.
Apr 24 2019, 2:49 PM
araujo closed D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 24 2019, 2:49 PM
araujo accepted D19976: bhyve: Support a _VARS.fd file for bootrom.

LGTM! Thank you!

Apr 24 2019, 2:40 PM

Apr 19 2019

araujo accepted D19869: Add a new uefi-edk2-qemu port..

double accept this revision!

Apr 19 2019, 7:46 AM

Apr 15 2019

araujo added a reviewer for D15405: Match IPv6 neighbor routes when they are marked with RTF_CONNECTED.: network.
Apr 15 2019, 9:06 AM
araujo added a comment to D15404: Add and use new RTF_CONNECTED flag to mark connected routes.

Any news about this patch?

Apr 15 2019, 9:05 AM
araujo accepted D19869: Add a new uefi-edk2-qemu port..

I'm fine with that too! We can have it as it is and later evolve it.

Apr 15 2019, 2:26 AM

Apr 14 2019

araujo committed rP498890: - Update to 2019.04.07..
- Update to 2019.04.07.
Apr 14 2019, 11:49 AM
araujo updated the diff for D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
  • Also remove SHEBANGFIX not needed.
Apr 14 2019, 11:37 AM
araujo updated the diff for D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
  • Update ONLY_FOR_ARCHS that was replaced wrong.
Apr 14 2019, 11:34 AM
araujo added inline comments to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 14 2019, 11:24 AM
araujo updated the diff for D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.

Address @bcran suggestions!

Apr 14 2019, 11:21 AM

Apr 10 2019

araujo accepted D19869: Add a new uefi-edk2-qemu port..

LGTM!

Apr 10 2019, 5:03 PM
araujo added a comment to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.

I did only smoke tests!! Do you mind do additional tests with different guests?

Apr 10 2019, 4:48 PM
araujo updated the summary of D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 10 2019, 4:48 PM
araujo created D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 10 2019, 4:42 PM
araujo added a comment to D19869: Add a new uefi-edk2-qemu port..
  • Rename the port and files to include a -x86_64 suffix
Apr 10 2019, 3:15 PM
araujo added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 2:37 PM
araujo added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 2:22 PM
araujo added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 2:02 PM
araujo added inline comments to D19869: Add a new uefi-edk2-qemu port..
Apr 10 2019, 1:53 PM

Apr 3 2019

araujo accepted D19695: bhyve(8): Fix NVMe data structure copy to guest.

It looks good! Thanks again @chuck

Apr 3 2019, 3:29 AM

Mar 26 2019

araujo added a comment to D19042: [New port] audio/pianod2: A free, multi-source, network-controlled music player daemon.

Sooooooooo. Is anybody going to help me fix this or approve this? ;-) I am still waiting.

Mar 26 2019, 7:12 AM

Mar 23 2019

araujo accepted D19676: bhyve: Fix NVMe BAR size calculation.
Mar 23 2019, 3:09 AM

Mar 15 2019

araujo accepted D19579: Fix bhyve's NVMe Identify Namespace data.

LGTM!

Mar 15 2019, 12:12 AM
araujo accepted D19580: Fix bhyve PCIe capability emulation.

LGTM!

Mar 15 2019, 12:11 AM

Feb 22 2019

araujo abandoned D2838: Add on bhyvectl the capability to list the running vms..
Feb 22 2019, 5:07 AM