Backported D14709. The Lua 5.3 and 5.4 ports are now identical except version difference and the patch-src__Makefile is slightly different (to be reviewed).

In D14709#345220, @andrew_tao173.riddles.org.uk wrote:

In D14709#345216, @russ.haley_gmail.com wrote:

In D14709#345215, @andrew_tao173.riddles.org.uk wrote:

Note that work2 is not ready for prime time yet (garbage collector bugs, at least)

I didn't see anything on the mailing list that would preclude adding it to the ports collection, or at the very least performing an expeditionary run (if that's possible). @mat, @dbn, I'm keen to get 5.3.5 or preferably 5.4 "build tested" against other packages because I've got a week off work right now with no kids.

The "uservalue has an incorrect value" thread is the GC bug I know about. Won't affect pure-lua code, but anything that uses uservalues can explode (even just doing require "re" collectgarbage() triggers an invalid access, though it won't crash immediately unless you built with assertions on).

Corrected so name variables. Thanks @andrew_tao173.riddles.org.uk

In D14709#345215, @andrew_tao173.riddles.org.uk wrote:

Note that work2 is not ready for prime time yet (garbage collector bugs, at least)

It ... doesn't seem to be common style as far as I can see. I'm not keen on the idea.

In D13690#345167, @andrew_tao173.riddles.org.uk wrote:

In D13690#345147, @russ.haley_gmail.com wrote:

@andrew_tao173.riddles.org.uk, I am very grateful for your tutelage and contributions. Do you want to see the readline options from D14709 left in? I had two thoughts: 1) anyone who doesn't want readline support is probably building Lua themselves and 2) with the freebsd target working, we could create an option for the generic target, that does not include readline.

I personally don't feel the extra complexity of the options adds value since the source Makefile is patched to use editline.

I have been working on a new version of the 5.4 port (since the need for NILINTABLE went away, and I wanted to experiment with other options).

Probably not worth adding options just for readline, but what about installing the HTML docs? I think that would be a good option (or indeed a default).

• Removed hand created credits. I would like to see @andrew_tao173.riddles.org.uk get credited?
• Reset port revision number

@andrew_tao173.riddles.org.uk, I am very grateful for your tutelage and contributions. Do you want to see the readline options from D14709 left in? I had two thoughts: 1) anyone who doesn't want readline support is probably building Lua themselves and 2) with the freebsd target working, we could create an option for the generic target, that does not include readline.

Update to 5.3.5. See updated summary.

Hi David,

Corrected src/Makefile patch to remove -DLUA_USE_READLINE as per AG. Compiles with and without interactive mode.

Updated with improvements from @andrew_tao173.riddles.org.uk :

• Removed hard coded options
• Added options for editline/readline library source
• Added option for experimental NILINTABLE
• Andrew commented that command names should come from lua.mk. I added a timestamp for tracking. (Updating lua.mk is on my todo list. See D13691)

Hi Andrew,

• Updated to build shared object.
• Removed LUA_NILINTABLE. Will turn it into an option. Any other useful options?
• Fixed to use MYLIBS not MYLDFLAGS for -ledit

In D14709#309100, @andrew_tao173.riddles.org.uk wrote:

The so isn't working because there is nothing here to build it; the makefile distributed with Lua does not try to build one and never did, the ports for earlier Lua versions patch the makefile to add it.

Thank you, I didn't remember that I had stripped that out to revise it. I get a few hours here and there for these things.

Minor update to make section 3.2.2 a little more readable. I'll push the changes here as well http://envirobotics.ca/portershb/tools-introduction.html

I've posted the output here: http://envirobotics.ca/portershb/ph-introduction.html

• Updated formatting to make it more readable. Still requires a great deal of work.
• Some revision of the text, no change to the technical content.

In D13870#299128, @dbn wrote:

In D13870#297392, @russ.haley_gmail.com wrote:

russellh@g1 /u/l/lib> pwd
/usr/local/lib
russellh@g1 /u/l/lib> ll libunwind.so*
lrwxr-xr-x 1 root wheel 18B Jul 26 2017 libunwind.so -> libunwind.so.8.0.1
lrwxr-xr-x 1 root wheel 18B Jul 26 2017 libunwind.so.8 -> libunwind.so.8.0.1
-rwxr-xr-x 1 root wheel 43K Jul 26 2017 libunwind.so.8.0.1

I think your Ports directory was out-of-date. There is a bug with USES=linux in that it ignores missing Linux packages (i.e. if your Ports tree was out-of-date). See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225768 for the patch to check for this case.

Also, note that this is a Linux port, and you need the Linux version of libunwind:

# cd /compat/linux/usr/lib
# ls -l libunwind.so*
lrwxr-xr-x  1 root  wheel     18 Aug  2  2017 libunwind.so.8 -> libunwind.so.8.0.1
-rwxr-xr-x  1 root  wheel  43764 Aug  2  2017 libunwind.so.8.0.1

You can manually install it with pkg install linux-c7-libunwind, however you are likely missing other Linux packages.

I hope this helps?

In D13869#299136, @dbn wrote:

I've double checked and the issue does not appear to be with this revision. We'll work on the issue in https://reviews.freebsd.org/D13870 and if there is an issue relating to these Linux ports we'll report back.

I'm cross posting an issue with the dotnet runtime, which was the reason this patch was created. Not sure where the source of the issue is yet.

Hi David, I'm trying to create a test application from instructions here: https://medium.com/wolox-driving-innovation/how-to-create-your-first-net-e2223dedb74f

In D13752#293261, @dbn wrote:

We have failing ports. Another github distinfo issue, and other isses with ports.

Hi,
Ran make test.

Thanks for separating this out from that monster work you did. There was one issue that I noted in a comment (on distinfo). Much of the delay was me not knowing how to use patch (-E). I regenerated the entire patch here:

Well to my surprise it "compiled". Chapter three is all mashed up and this version doesn't have the changes requested by mat. I'll have to get that revision off a different computer.

In D12921#287341, @julian wrote:

is there a formatted version of this available somewhere so it can be read in final form?

Hi David,

Hi, I've looked over the failures and I think I'd rather just close this review and comment on the original bugzilla ticket. Not sure how to close a review?

Removed changes to lua.mk. Review is tracking questions on exp-run failures. Alternatively we can close this and I can use bugzilla.

In D13691#286204, @antoine wrote:

The last exp-run was: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220281

In D13691#286171, @antoine wrote:

There was an exp-run a few months ago and the results were bad.
Maybe lua ports could be flavored...

Nice job adding msbuild. That's going to come in handy for dotnet core 2. I'll try building this again asap.

Thanks so much for the review @mat!