Now wondering why portscout didn't pick up on this. I'll look at this later tonight. Thanks, Matthew

pbr no longer in use by py-molecule.

In D16716#434707, @koobs wrote:

I have a WIP for pbr 5.2.0 pending (reverse dependents) QA

Is 5.x ok for the port you have that uses it? Which port/python package is it btw?

still lgtm

Seems fine at first glance. I won't be able to test this until this evening though.

In D19762#424774, @D.Sieborger_ru.ac.za wrote:

Thanks very much for creating the port.

This extension normally requires running "make initdb" to create a custom field called Original Ticket. The port currently doesn't provide an easy way to do that, and I'm really not sure how it could do so elegantly. I managed to do so by running "make -n initdb" in the port wrkdir, then doing likewise on our production server where we'd installed the package:

Address @mat's comments

python3 is only a symlink, not an actual executable. You need one of the actual python3.x packages. Also the python3 port does not follow eg. a custom DEFAULT_VERSIONS=python=3.7 -- for that you need DEFAULT_VERSIONS=python3=3.7 -- which puzzled me for some time after I switched all my systems to the latest python-3.7, and yet pkg kept insisting that python-3.6 needed to be installed...

Revive this review after far too long. Address all of @mat's points.

• Fix longstanding error USES+=perl5 -> USES=perl5

• No need to test for undefinedness as we always set ${FLAVOR} a few

• Import D17285 changes
• Don't use flavours where there's only one choice. These modules are
• No PORTREVISION bump if all we're doing is dropping support for the
• Set FLAVOR so flavourization actually happens...
• rtXX_PKGNAMEPREFIX should always end in a -

Also covered by implict mentor approval. This justs needs an ACK from the maintainer.

You've got implicit mentor approval for commiting this sort of simple update -- no need to put it to a review.

LGTM

In D19064#409396, @leres wrote:

Just some thoughts, which I'm not insisting you implement (but you can if you want):

In D19064#409287, @leres wrote:

LGTM

Ooops. I was too quick to accept there. Needs pkg-plist updating as @tobik has shown

Good to commit so long as you have maintainer approval too.