• rewrite (actually copy and modify utf8-rollup.pl) mkwidths in perl, making it 300x faster compared to sh version
• add to README
• use pkgconf to get utf8proc cflags/libs

context

Thank you.

In D25640#567601, @pfg wrote:

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

In D25398#560911, @pstef wrote:

It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.

remove debugging cruft

I think this looks good.

In D22160#555029, @phil wrote:

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

In D22160#555029, @phil wrote:

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

In D25165#554658, @trasz wrote:

And yeah, I think it’s a good idea to fix all of them. Still, this is fine too.

In D25166#554560, @bjk wrote:

I expect I should be the one committing this?
But I will hold off for a bit in case someone wants to respond to the 'kldstat' remark.

Actually, there are more timeout(9) references, wonder if it would make sense to gather all of those in one review?

In D25013#550908, @phil wrote:

Just knowing that the "--libxo" was used is not sufficient, since there are options that should not affect output (e.g. color, no-humanize, warn).

Can you describe more exactly when you want to avoid truncation? I'm guessing you want this for the "encoding" output styles (XML, JSON) and not text, but do you want to truncate HTML output?

Maybe the test you are needing is just "if (xo_get_style(NULL) == XO_STYLE_TEXT)"?

Thanks,
Phil

In D24919#548530, @yuripv wrote:

In D24919#548529, @bapt wrote:

Have you contacted the upstream? https://github.com/lichray/nvi2

Will do, forgot about it! Thanks.

In D24919#548529, @bapt wrote:

Have you contacted the upstream? https://github.com/lichray/nvi2

Correct sysctl description.

In D23109#506462, @yuripv wrote:

I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:

if (table->__collate_load_error == 0 && table->header != NULL && strcmp(table->header.locale, encoding) == 0)
    return (_LDP_LOADED);

Not completely sure about the table->header check here as we already checked that the table was loaded, but it's just an idea.

(P.S. I think encoding is really a wrong argument name here, as it's full locale name.)

I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:

Warner, does this make sense to you/won't interfere with other changes you might be working on?

actually split the synopsis into separate options that can't be used together

As noted by @imp, there are better ways to do this.

Correct the .Fo field (remove *). Ingo did agree that .Fo (f) shouldn't trigger the warning and it will be supressed in the future. For the moment, we'll just have a non-fatal warning.

• use sbuf functions
• also handle am_pm
• mark all keywords not specified by POSIX (e.g. abmon_1 through abmon_12, am_str, pm_str, ...) as local additions as other systems (at least Linux and Solaris) do not handle them
• add tests

In D21569#469935, @0mp wrote:

Seems fine to me.