In D21452#466886, @ian wrote:IMO, the much easier fix is to change the call to bus_generic_attach() at the end of the ichsmb_attach() routine to:
config_intrhook_oneshot((ich_func_t)bus_generic_attach, dev); return (0);We really need to do it to all i2c/smb controller drivers. I've done most of the arm ones already.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 28 2019
Aug 28 2019
yuripv retitled D21452: ichsmb: defer smbus attach until interrupts are available from ichsmb: poll for cmd completion status instead of sleeping if cold booted to ichsmb: defer smbus attach until interrupts are available.
In D21452#466863, @hselasky wrote:If this driver doesn't need to started early have a look at this:
We could modify SI_SUB_DRIVERS in the macro below to load the driver at a later point in time!
#define EARLY_DRIVER_MODULE_ORDERED(name, busname, driver, devclass, \ evh, arg, order, pass) \ \ static struct driver_module_data name##_##busname##_driver_mod = { \ evh, arg, \ #busname, \ (kobj_class_t) &driver, \ &devclass, \ pass \ }; \ \ static moduledata_t name##_##busname##_mod = { \ #busname "/" #name, \ driver_module_handler, \ &name##_##busname##_driver_mod \ }; \ DECLARE_MODULE(name##_##busname, name##_##busname##_mod, \ SI_SUB_DRIVERS, order) /sys/sys/bus.h:#define DRIVER_MODULE_ORDERED(name, busname, driver, devclass, evh, arg,\
In D21452#466857, @hselasky wrote:Can you upload full context?
Feb 6 2019
Feb 6 2019
In D18705#401939, @imp wrote:This is fine, but there's a chance we'll rework the arg parsing in this program in the near future... Better to get this in now though.
yuripv added a comment to D18658: top: fix PID sorting after r340742; add process birth time sorting.
@eadler any comments on this as you requested pre-commit review for top?
pwm.8: fix markup in synopsis, add -f description
pwm.9: fix markup in interfaces description
Jan 12 2019
Jan 12 2019
@kevans any thoughts here? I'm still hesitant to add the symbol, so are you ok with the change only being in libc and libregex using the old behavior (strict character comparison instead of equivalence class)?
In D18408#400188, @evfbsd_yandex.ru wrote:Hi @yuripv, are there plans to commit this?
@imp anything else I need to change here?
Jan 2 2019
Jan 2 2019
Are we *guaranteed* to have the floppy drives coming only at the start of the list?
Address comments from @imp.
In D18705#399280, @bcran wrote:-N (delete BootNext) doesn’t require -b since it doesn’t operate on a bootnum.
-N doesn't need the -b bootnum.
yuripv edited reviewers for D18705: efibootmgr: make generic usage message more readable, added: bcran; removed: db.
Jan 1 2019
Jan 1 2019
Drop the xlocale_private.h change, it's not really needed.
Dec 27 2018
Dec 27 2018
yuripv added inline comments to D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 25 2018
Dec 25 2018
yuripv added inline comments to D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
yuripv added inline comments to D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 23 2018
Dec 23 2018
Dec 22 2018
Dec 22 2018
Dec 19 2018
Dec 19 2018
In D18611#396895, @pfg wrote:For the record: while it is good practice to request reviews before committing, IMHO they dont make much sense, and are not required at all, for reverts. After all they stand for things all the initial reviewers missed in the first place ;).
regcomp: revert part of r341838 which turned out to be unrelated
Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)
Dec 12 2018
Dec 12 2018
regcomp: reduce size of bitmap for multibyte locales
yuripv added a comment to D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
@kevans are you OK with the test case added to libc/regex instead and using sed? :)
Dec 8 2018
Dec 8 2018
Oops, I didn't mean to add Ed back to this review :-)
Reading through the discussion, I do agree with @ed -- we should have just one version in UTF-8, and convert to current encoding on the fly, though I do agree with @AMDmi3 as well -- making sure we use only the characters that can be converted to the related single-byte locale shouldn't be that hard, we don't need to use the fancy unicode chars in messages.
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Sorry for the delay. I have spent quite a bit more time on this, including testing. Summary and the change updated accordingly.
Dec 6 2018
Dec 6 2018
syslog(3): stdarg.h is needed only for vsyslog()
In D18334#393097, @asomers wrote:LGTM. Do you you need someone to commit this for you?
termcap: add italics and tmux entries
Dec 5 2018
Dec 5 2018
Actually mark r341596 as MFC.
Dec 3 2018
Dec 3 2018
mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
Add the comment for msi_tupelo (and cleanup whitespace issues introduced by the patch).
yuripv updated the test plan for D18408: PR209468: aacraid fixes to work with newer controller firmware.
yuripv updated the test plan for D18408: PR209468: aacraid fixes to work with newer controller firmware.
Dec 2 2018
Dec 2 2018
yuripv added inline comments to rS334805: - Once we have shifted arguments up to thrice, base-bits-dir is $1 rather.
Now with full context...
Use UnicodeData.txt to create UTF-8 ctype map.
Nov 29 2018
Nov 29 2018
Nov 28 2018
Nov 28 2018
diff with full context
Nov 26 2018
Nov 26 2018
Upstream PR: https://github.com/lichray/nvi2/pull/61
bectl: sync usage with man page, removing stray multibyte characters
In D17950#389310, @bapt wrote:as this been upstreamed? (https://github.com/lichray/nvi2)
Nov 23 2018
Nov 23 2018
regexec: fix processing multibyte strings.
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
drop unrelated changes
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
After providing the quick fix, I have started wondering how GNU grep (or libgnuregex, more precisely) does the matching without providing any locale specific data; the answer is pretty simple, not sure why I didn't think about it from the start -- fold the case of *both* sides of comparison, and compare both-upper and/or both-lower.
Please submit diffs with full context.
yuripv retitled D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range from regcomp() recuses infinitely on a case-insensitive pattern with unidirectional case-mappings to regcomp() recurses infinitely on a case-insensitive pattern with unidirectional case-mappings.