Link to Git repository

For more info on this bug, it occurs because all iflib drivers atm have iflib_get_media in IFDI_ATTACH_PRE. I don't think any of them actually use the media until later so you can either move the calls down into IFDI_ATTACH_POST or initialize the pointer and media before IFDI_ATTACH_PRE.

I like the changes.

nvm, that makes sense.

In D19946#428690, @mmacy wrote:

In D19946#428687, @aryeeteygerald_rogers.com wrote:

As is, the patch works.

I would still suggest exposing the iflib_media_* because init_locked is unavailable in the case of reset and I think the locks in the wrapper are useful?

Call iflib_init. You don't need the iflib lock held across your PHY routines - the wrapper you see here is so that normal drivers don't have to maintain their own locks. Any dedicated PHY driver is going to already be using its own locks. Exposing these would only further complicate the API with no benefit.

In D19946#428672, @mmacy wrote:

can you test with this patch and let me know? It should be a no-op for current drivers so can probably go in quickly.

As is, the patch works.

the custom media would have to call the wrappers, especially if restart is necessary

I think a check/assert for that (and maybe a comment on isc_media) would be good idea

Should probably note that this would require miibus users (and other consumers of this) to correctly init the status and change callbacks to iflib_media_change and iflib_media_status.

Remove diff junk ...

• Update comments to reflect rS345550

Rebase changes to reflect upstream update to libarchive

• Support old DTBs which still use phy_id

• Remove extra phy-handlei check and add 'no children' check

Also I perform a diff against the old version first so they must have added a line that looks like the diff marker during conflict resolution. This seems very unlikely.

• Change unresolved conflict warning into an error

An error or forcing them to resolve it manually again may be better.

• Clarify 'mirror failure' message

In D18859#404006, @delphij wrote:

In D18859#403540, @aryeeteygerald_rogers.com wrote:

Note that most IDS_run output shouldn't be considered as "informational", especially checksum differences: these should not be suppressed because they suggest there are real issues.

Where are the checksum diffs? I don't think they are currently suppressed but maybe I missed it.

Sorry it was my typo. It's IDS_compare's output (called by IDS_run).

• Fix style issues

Remove unnecessary diff junk.

• Use HEREDOC/cat instead of multiple echos

• Fix style/syntax issues

Note that most IDS_run output shouldn't be considered as "informational", especially checksum differences: these should not be suppressed because they suggest there are real issues.

• Improve code for printing to stderr

Need to add export UNAME_r to config_SourceRelease. Will create new review with fix.

• Fix ordering of system checks

• Update permissions check and chflag check

• Fix spacing issues

• Include support for upgrading from alpha releases

• Simplify src component check

It may be because it is hard to follow but warnings/errors are redirected to the stderr
And then the stdout fetch_run/IDS_run is intended to be piped to INFOREDIR. This is normally stdout but can be /dev/null in order to hide informational messages ...
is this a bad idea?

• Fix typo in comment

• Update outdated comment

• Ensure install flags can be removed